- 30 Nov, 2018 40 commits
-
-
Pavel Feldman authored
Change-Id: I76a8edbc45bd6e2d775b48c8f93e288d82bed817 Reviewed-on: https://chromium-review.googlesource.com/c/1357513Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612830}
-
Esmael El-Moslimany authored
Bug: 909653 Change-Id: I3aeb33600e6cf01b2cccfd54d860830b04bff97b Reviewed-on: https://chromium-review.googlesource.com/c/1355527Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612829}
-
Erik Jensen authored
The IPC_MESSAGE_CONTROL[0-5] macros have been deprecated in favor of a new variadic IPC_MESSAGE_CONTROL macro. Change-Id: I64a0e8c7ec3c51b387de615950f93b6d5798d3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1354102 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612828}
-
Avi Drissman authored
BUG=556939 Change-Id: I66fe86602ab965622b1db26e5468f8d596c851e9 Reviewed-on: https://chromium-review.googlesource.com/c/1356867 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612827}
-
oysteine authored
This reverts commit 8aa669ef. Reason for revert: crbug.com/910759 Original change's description: > [protoc] Use protoc's lite java plugin and runtime > > protoc the protobuf compiler now requires using a separate plugin for > compiling protos for the java lite runtime. The lite java runtime is now > also separate from the main java runtime and is distributed separately. > > This cl switches java proto compilation for lite protos to this new > mode. > > TBR=android_webview/BUILD.gn > > Bug: 782237, 800281 > Change-Id: I31c2d073bed51109dffeea133495679deef3186b > Reviewed-on: https://chromium-review.googlesource.com/c/1340522 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612720} TBR=pkasting@chromium.org,michaelbai@chromium.org,wnwen@chromium.org,pavely@chromium.org,agrieve@chromium.org,mheikal@chromium.org Change-Id: Ie2dce6e8c5ad03e6a75607a02e234c813f3072a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782237, 800281 Reviewed-on: https://chromium-review.googlesource.com/c/1357571Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612826}
-
Daniel Rubery authored
This CL only includes the changes that made no functional changes to unrar. If diffs from this patch file don't apply to new versions, it shouldn't be very concerning. Bug: 910302 Change-Id: I871307b441a73ba6ee55601ac2944df3eeff7705 Reviewed-on: https://chromium-review.googlesource.com/c/1357383Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#612825}
-
oysteine authored
This reverts commit d66855ad. Reason for revert: crbug.com/902064, reverting to see if this decreases test failures. Original change's description: > Perfetto: Reduce max trace buffer size to 300mb to avoid Android browser OOMs > > Specifically memory.long_running_idle_gmail_background_tbmv2 will OOM > on Nexus5 devices with this buffer size. > > R=eseckler@chromium.org > > Bug: 902064 > Change-Id: If8e5529f3000b9a2f3b86abaecb1f219df356575 > Reviewed-on: https://chromium-review.googlesource.com/c/1338889 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608698} TBR=oysteine@chromium.org,eseckler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902064 Change-Id: I0528cc367fb44cc7814fc3b72b5727a25c04450b Reviewed-on: https://chromium-review.googlesource.com/c/1357403Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612824}
-
Becca Hughes authored
Add a collapsed mode where the notification will show fewer action buttons and also place the buttons to the right of the title/artist information. BUG=893296 Change-Id: I5a05f074ddda0d000a26db76b26ccc97fd732cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1327613 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612823}
-
dpapad authored
Conversions performed with a tool ./node_modules/lebab/bin/index.js \ --replace ui/webui/resources/cr_components --transform let A .eslintrc.js file already exists, so probably these violations had not been fixed at the time it was added. Bug: 792774 Change-Id: I647bbf9a08c816fe810acf6582a5d9a0a45a96a0 Reviewed-on: https://chromium-review.googlesource.com/c/1354575Reviewed-by:Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612822}
-
Sam Maier authored
Fixes the issues that broke the previous 1.4 roll: https://issuetracker.google.com/issues/120130435 Bug: 908988 Change-Id: Ibe4f16e2b12ed569762ace16b1d573e9328b1cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1357511 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612821}
-
Becca Hughes authored
Audio focus is currently grouped for media sessions in the browser. Apps that are displayed in their own window (e.g. PWAs, platform apps) should have their own group id shared across all media sessions for that app. BUG=906285 Change-Id: I11004301f0e8c3118b62e4b25bcbfe15ecd351e4 Reviewed-on: https://chromium-review.googlesource.com/c/1344821 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612820}
-
Miguel Casas authored
This CL addresses two issues: - Extends "Vaapi frames at client" to show used vs available, where ToT only shows the currently used ones, without any reference to its max. - TRACE_COUNTER1/2 is global per-process, which means that when there are multiple Vaapi decoders working, each will update the counter as if in isolation, rendering the measurement meaningless. This CL uses TRACE_COUNTER_ID2 to add an id to each counter, allowing for counter separation [1]. [1] https://i.imgur.com/qq60Xqw.png (https://imgur.com/a/AOcwh78) Bug: 909926, 721674 Change-Id: If7089d8e9ca614912b3965eb46dc552b8c63928f Reviewed-on: https://chromium-review.googlesource.com/c/1356884 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#612819}
-
Devlin Cronin authored
When granting and removing optional permissions from an extension in PermissionsUpdater::GrantOptionalPermissions() and PermissionsUpdater::RevokeOptionalPermissions(), CHECK() that the permissions we're adding or removing are contained within the optional permissions specified in the extension's manifest. This required updating three unit tests that were exercising improper behavior (trying to add or remove permissions that weren't listed in the manifest). Bug: None Change-Id: I325ef2fb8c053b4ae7463aca36e6b4aba0ff4838 Reviewed-on: https://chromium-review.googlesource.com/c/1354651Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612818}
-
khmel@chromium.org authored
App search provider already has optimization that runs update result deferred in certain cases. This also includes cases when new app registered or existing app updated. However in last case we always do refresh apps inline. This CL also defers Refresh app when it possible. Additionally that has protection not to list not yet registered ARC default apps. TEST=Manually, using 2 step fix. On first step verified that ArcAppListPrefs did not return not yet registered default app. At second step verified that app data search provider refreshes apps deferred and functionality is not broken BUG=907590 Change-Id: I12b015c02e0c59d19e49926f11d5632adf25ad9a Reviewed-on: https://chromium-review.googlesource.com/c/1356012Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612817}
-
Aaron Tagliaboschi authored
Unit test for encoding advertisement on range requests. Simple logic to change accepted encoding to identity in a range request Bug: 849952 Change-Id: I436ac5e4db118faa4f362a0b8c1943b5fe7020ea Reviewed-on: https://chromium-review.googlesource.com/c/1352672Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#612816}
-
Joe Mason authored
Change-Id: I8ef824ce088327dd1afe8ebdca5dbea845cf0642 Reviewed-on: https://chromium-review.googlesource.com/c/1357521Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#612815}
-
Dan Harrington authored
Article thumbnails are now fetched for suggestions from feed. We fetch with the cached image fetcher, which is shared with feed. Bug: 841522 Change-Id: I283fa2ea145341fb28dd337026a57abbd36aec77 Reviewed-on: https://chromium-review.googlesource.com/c/1344549 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#612814}
-
Devlin Cronin authored
Currently, if an extension is affected by runtime host permissions but doesn't want to run on the current site, we still show the context menu submenu entry for page access. The only item is the "Learn more" link. Instead, remove the context menu submenu for these sites, and replace it with a (disabled) menu item "Can't read or change site's data". Bug: 909790 Change-Id: Id77efca23a96e8d5d8f683954946970b652612d4 Reviewed-on: https://chromium-review.googlesource.com/c/1351302 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612813}
-
Kevin Marshall authored
* Fixes issue with an on-receive callback not being unbound, causing the incoming message buffer to be drained immediately. * Add browser tests to verify buffering behavior. * Add browser tests to verify proper origin enforcement for Frame::PostMessage. * Make the AsyncValueReceiver interface a bit nicer to use. * Minor cleanups for other FrameImpl browser tests. Bug: 893236 Change-Id: I521e9316ccf9195133a940be670556a882cb1044 Reviewed-on: https://chromium-review.googlesource.com/c/1351777 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612812}
-
Jamie Madill authored
The dEQP test suites need to be run on specific dEQP buidlers and testers. Trying to build dEQP on these configs was breaking the ANGLE CQ when the testers were enabled. After this change the configs can be re-added to the tools/build repo. Bug: 822310 Change-Id: I7dae7799948819004640f14379839c425f8a8280 Reviewed-on: https://chromium-review.googlesource.com/c/1357002Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#612811}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/010497f89102..b26f97ac1d28 Created with: gclient setdep -r src-internal@b26f97ac1d28 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: I42411d33fb47167aae0ece852d5f2ba26a5a94ca Reviewed-on: https://chromium-review.googlesource.com/c/1357422Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612810}
-
Francois Doray authored
Hang reports show that there can be contention on the pool lock when a thread is created in a scope where it is held. To avoid this contention, this CL ensures that no lock is held when SchedulerWorker::Start() is called. Bug: 905288 Change-Id: I4158fb061e6c0ec0de820bd061c1cc5b2d309e6b Reviewed-on: https://chromium-review.googlesource.com/c/1355427Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612809}
-
bsheedy authored
Removes use of testharness.js's async_test from all XR instrumentation test files. testharness.js supports single-page tests, where not calling test() or async_test() will allow asserts to work without having to be wrapped in a step. This new approach is both cleaner and less confusing, as it was not obvious to new users that asserts needed to be wrapped. Bug: 909948 Change-Id: If945571ef414953c538596da08976483ab39b3f9 Reviewed-on: https://chromium-review.googlesource.com/c/1356021Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612808}
-
Xing Liu authored
Most DownloadManager::DownloadUrl use cases don't use cache because cache can result in download with a partial file, and it can block video thumbnail generation when the partial file is too small. Bug: 909605 Change-Id: I40c8dae00da677d969f1a3c398b758d4e1d230a4 Reviewed-on: https://chromium-review.googlesource.com/c/1357501Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612807}
-
Sam Maier authored
This reverts commit 33264a73. Reason for revert: Since dexdump version has been fixed, this should now be okay. Original change's description: > Android: removing min-api from R8 > > Bug: 910319 > Change-Id: I5fa81395b39d877e68eb8a49a3d4d1ffab016a39 > Reviewed-on: https://chromium-review.googlesource.com/c/1355855 > Commit-Queue: Sam Maier <smaier@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612398} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: Ie31442be0997e04bfcc65a852446e8935d6e2702 Bug: 910319 Reviewed-on: https://chromium-review.googlesource.com/c/1357379 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612806}
-
Kyle Milka authored
Create service that fetches middle-slot promo data from /async/newtab_promos (created in cl/222286677) on NTP load if kPromosOnLocalNtp is enabled. Bug: 906278 Change-Id: I1ee859951acc06f8fae9354b80e41bf2a2ae2521 Reviewed-on: https://chromium-review.googlesource.com/c/1352321Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612805}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7b5740a89e63..390ce238ca28 git log 7b5740a89e63..390ce238ca28 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 tsepez@chromium.org Use single-byte strings in more places in pdfium. Created with: gclient setdep -r src/third_party/pdfium@390ce238ca28 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I804b05eccdefe3fec8ad7f24402a965909036595 Reviewed-on: https://chromium-review.googlesource.com/c/1357419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612804}
-
Suman Nelson Kancherla authored
Bug: 907247 Change-Id: I6c6fd2c2c8fcc86f0b70a5e87640fc98ae530f63 Reviewed-on: https://chromium-review.googlesource.com/c/1354357 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612803}
-
Xing Liu authored
This CL implements the retry functionality used in download home. Currently interrupted download that can't resume can retry. Cancelled download potentially can also be retried. TBR=dtrainor@chromium.org Bug: 883387 Change-Id: I13e9ad9511d8e15c1b3432184f1376cf3dcf9319 Reviewed-on: https://chromium-review.googlesource.com/c/1278267 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612802}
-
Lei Zhang authored
PDFium started exporting them in its public config, so these are now redundant. Change-Id: I2f7a476059a0aefd1e46b59463dbe9e90a64af32 Reviewed-on: https://chromium-review.googlesource.com/c/1357210Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#612801}
-
Caleb Rouleau authored
I am not part or this team anymore and neither is John. Replacing ourselves with the team TL. Change-Id: I6ec7c488def2403806894a5dad462774ac2281c0 Reviewed-on: https://chromium-review.googlesource.com/c/1356227Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#612800}
-
Daniel Rubery authored
This CL breaks out the code that inspects an individual file within a ZIP archive. This will be shared between the ZIP and RAR inspection, when RAR files begin doing content inspection. Bug: 909778 Change-Id: I7acf1cabd472f112f2ed7c31735688cae7a6d122 Reviewed-on: https://chromium-review.googlesource.com/c/1354103 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612799}
-
Martin Kreichgauer authored
Windows generally doesn't seem to echo the HmacSecret extension in their response to AuthenticatorMakeCredential. However, AuthenticatorImpl already parses the hmacSecret response value out of the authenticator data, so we should not fail the request over this. Bug: 898718 Change-Id: I1e732ab189f240df2be09ec89135af143634238f Reviewed-on: https://chromium-review.googlesource.com/c/1357460 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612798}
-
Greg Kerr authored
This is a reland of 1d979043 Original change's description: > macOS Sandbox: Port fontloading test to V2 sandbox. > > This removes all of the obsolete unit testing code from the V1 sandbox. > > Bug: 902597 > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 > Reviewed-on: https://chromium-review.googlesource.com/c/1327527 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612416} Bug: 902597 Change-Id: I2088dd954956be6d704add7ee8e07bc629df8eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1357217Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612797}
-
Robin Raymond authored
It will use static method globals which originally froze when protobuf tool was run after compiling with CL.EXE. This allows MSVC based builds to be re-enabled. The next official release of protobuf should no longer need this patch as the code around singletons has been rewritten to no longer have this issue present in this release of protobuf. https://bugs.chromium.org/p/webrtc/issues/detail?id=9695 Change-Id: I729bd66429774cf9845a7ae754173722f31a208a Reviewed-on: https://chromium-review.googlesource.com/c/1297536Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#612796}
-
Peter Kotwicz authored
This CL: - Makes SplashActivity singleTask - Introduces InitialSplashActivity to launch SplashActivity. Otherwise, whenever the user taps the WebAPK's app icon the WebAPK is relaunched and the ChromeActivity which is on top of SplashActivity is killed BUG=907951 TEST=LaunchTest.* Change-Id: Ibc06b1b3fc2aea49ad26bf1043aebec595fb68cf Reviewed-on: https://chromium-review.googlesource.com/c/1340516 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612795}
-
Becca Hughes authored
Add labels for artist and title that are shown if we have the metadata from the session. BUG=893296 Change-Id: I9bab7dd6c31c711c3552dbac975477808ec9311a Reviewed-on: https://chromium-review.googlesource.com/c/1321258 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612794}
-
Roger McFarlane authored
The value of the autofill::prefs::kAutofillProfileValidity pref name does not match the actual value being used to populate the priority pref from the server. Thie CL changes this constant from autofill.profile_validity to autofill_profile_validity to match what's actually being synced. Change-Id: I151874de8dde861dff280e1fc0e53e2ee1b60d84 Bug: 910596 Reviewed-on: https://chromium-review.googlesource.com/c/1356863 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612793}
-
Egor Pasko authored
The test legitimately fails when "prerender" value gets removed from visibilityState as it is done in http://crrev.com/c/1356120 Unblock this change by removing the test. Traditional prerenders should no longer happen, while nostate-prefetch should not ever look at visibility state. TBR=mattcary@chromium.org Bug: 908582, 755921 Change-Id: I44da809f924b2730ac2b00fd85a1d1e484a3aacb Reviewed-on: https://chromium-review.googlesource.com/c/1356939Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612792}
-
Andrew Grieve authored
Except for sample_apk, which looks like it's a valid app on its own. Motivation: * Trying to add a new JNI generator, and these targets were being difficult due to the tests having (unused) native methods that the under_test apk did not have. * The under_test apks didn't really make sense on their own anyways, so it's more efficent to just combine them. Bug: 898261 Change-Id: I23571ea61230daefccb8e0e14689d3f872080136 Reviewed-on: https://chromium-review.googlesource.com/c/1352853Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612791}
-