- 09 Jun, 2020 40 commits
-
-
Jorge Lucangeli Obes authored
The histogram was added in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2230224 BUG=1091286 TEST=validate_format, pretty_print. Change-Id: Ibd651812a608c7154eb997157b6c3465bc20f91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237707 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#776548}
-
Charlie Hu authored
Previously, oversized-images is migrated from feature policy to document policy in https://chromium-review.googlesource.com/c/chromium/src/+/2058702, but there are still expectation files and links to feature-policy-oversized-images-*. This CL cleans up those obsolete files and links. Change-Id: Ifd80e5ad59fa787164062a941f306c5149db3f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228360Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#776547}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a48dd43fe185..dffa944e0725 2020-06-09 tommi@webrtc.org Reland "Remove dead code from ModuleRtpRtcpImpl2" 2020-06-09 tommi@webrtc.org Deprecate a few unused methods in RtpRtcpInterface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2668c89f08ba5c1e6c89d2721842dfb393e05f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776546}
-
Aaron Krajeski authored
Bug: 1091267 Change-Id: Ibe58b5778860d91d3181ded85024f27271d4a0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236040Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#776545}
-
Jeff Yoon authored
Migrate base::Bind calls in ios/components to base::BindOnce or base::BindRepeating as part of code health improvements Bug: 1007793 Change-Id: Ib25fed1c909c8d72628214a55bbd2d6213d42d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236281Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#776544}
-
Miguel Casas authored
This CL is a refry of crrev.com/c/2072621, where only the HDR DisplayColorSpaces are filled in and the SDR ones are skipped and left for a later CL. The original landed-and-reverted CL is kept in PS0 to ease review. Bug: 958166, b:158126931 Original CL description ----------------------------------------------- This CL adds code for populating the necessary gfx::DisplayColorSpaces in CreateManagedDisplayInfo for supporting SDR and HDR target color spaces (depending on the monitor capabilities and the big hdr flag). It needs a sibling CL to allow AR/B30 FBs on CrOs crrev.com/c/2078655, Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 958166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072621Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#745461} Change-Id: I2700d4d22a6b7e3a91433e6ca5bd042760cf165b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235977 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#776543}
-
Matt Menke authored
SpdySession::CanPool() checks CertificateTransparency state, so in order to double-key the Expect-CT database, we need to pass the NetworkIsolationKey through CanPool() down to TransportSecurityState::CheckCTRequirements(). BUG: 969893 Change-Id: I612be66f8a530d01edd14b6286617e20a6b28f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212702Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776542}
-
Marc Treib authored
They're all very flaky. TBR=dschuff@chromium.org Bug: 1003259 Change-Id: Ibf8bd420fd9948ff1a0872df1778958c39759361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236143Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#776541}
-
Charlie Hu authored
Change-Id: Id82847e8f54f740cbc4cdbd9bf34000262882f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229208Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#776540}
-
Xida Chen authored
TBR=treib@chromium.org NOTRY=true Bug: 1092924 Change-Id: Iea95759a9cb37b9a11c76f5bfb2fb1763c6a7507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238008Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776539}
-
Koji Ishii authored
This patch fixes: ObjectPaintInvalidatorTest.TraverseFloatUnderCompositedInline ObjectPaintInvalidatorTest.TraverseStackedFloatUnderCompositedInline when FragmentItem is enabled. Bug: 982194 Change-Id: I7857d063711669ac3f3a5b66ba1e114cc3db8f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237430 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776538}
-
Alexander Timin authored
Now DedicatedWorkerHost interface doesn't have any methods and this patch removes it. This patch can be easily reverted if the need for DedicatedWorkerHost interface appears again. TBR=haraken@chromium.org R=nasko@chromium.org BUG=1018601 Change-Id: Ia572e086aab3445cd96f5bac5b0cb89186b06ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203207Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776537}
-
Chris Fredrickson authored
This reverts commit 5bf5f652. Reason for revert: This cl caused a perf regression in the rendering.mobile and blink_perf.canvas benchmarks. Bug: 1092434,1087234,973801 Original change's description: > Include image data when reporting UKM from canvas readbacks. > > This is a reland of https://crrev.com/c/2207979, but which takes extra steps to avoid performance regressions. In particular: > * No additional overhead is incurred if the user is not in the identifiability study. > * The overhead of constructing the pixmap is posted to another thread, rather than holding up the current thread. > > Bug: 973801,1087234 > Change-Id: I7701c622e4d146504b1ea57d0f2047aa2a98ed9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224820 > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Cr-Commit-Position: refs/heads/master@{#775558} TBR=fserb@chromium.org,asanka@chromium.org,cfredric@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973801, 1087234 Change-Id: I5bc8452692562f8b82af0c3b0903327b86744cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236336Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#776536}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. Note that an explicit conversion to WebMediaStreamTrack is added because the call crosses the Blink API boundary. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I342bd8d36dafeda513d339a3380c7076c2e406a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236276Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#776535}
-
Mason Freed authored
Prior to this CL, these errors were just logged to stdout; now they are proper console errors. Needed to add a non-WPT layout test here because there is no way to test console messages in WPT. Fixed: 1067488 Change-Id: I4c46c64dbc80449338c699490e1ab0dda32cd833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231918 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#776534}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. CL also, moves the file from renderer/platform/exported/mediastream/ to renderer/platform/mediastream/. BUG=704136 R=guidou@chromium.org Change-Id: I3626117d3945f043049aa8a3bc8dc36c8d8f9519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236014Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#776533}
-
adamta authored
Adds the Discover feed coming from the Discover provider to the NTP ContentSuggestions collection view. The feed is shown based on the feature flag, as well as the "Article Suggestions" setting in the settings menu. Will replace the Zine feed if the flag is active. Bug: 1085419 Change-Id: Iad9e94af68ad74e2d9028152cf696c7cb69d733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230765Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#776532}
-
Bartek Nowierski authored
The hint points to a bit in the bitmap before which we know for sure all bits are 1s, so no need to scan those. Bug: 1086388 Change-Id: If1ff5dfb7a8faa2fd47937e44bb811af67bda7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230149 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#776531}
-
Gavin Williams authored
This test was originally named ReasonFromPrinterStatus because the first version of this was testing the actual printer status enum codes, not the colors. Bug: 1059607 Change-Id: I953fa6ece3ad5bba8c6f515ebd05d0bc56d2df34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234547Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#776530}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5fef85222ed..2a9754b30e90 2020-06-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b37ea9126ea20d6551bfa08a08f911b4eabe3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776529}
-
Shengfa Lin authored
This reverts commit 68c28c5c. Reason for revert: Test flakiness Original change's description: > [chromium] Re-enable testGetSessions > > Retried locally on Mac and Linux, the test seems fine. > > Bug: chromium:899919 > Change-Id: I48d50f2f25a7111d4713b1b826eca36893e03289 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236886 > Auto-Submit: Shengfa Lin <shengfa@google.com> > Commit-Queue: Shengfa Lin <shengfa@google.com> > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776318} TBR=johnchen@chromium.org,shengfa@google.com Change-Id: Idcfbd0cbf2f46210e4c81752c693fccab5dbdecc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:899919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237648 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776528}
-
Tobias Sargeant authored
* Add comment to C++ enum indicating persitence in UMA * kCount -> kMaxValue, per UMA guidelines. * Remove lock and DCHECK that RecordMetrics is called on the UI thread. * Fix enums.xml, which listed enum values in the wrong order. Bug: 1083005 Change-Id: I4faf67d5614358d19e93df69128bba0fa68b561b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236136Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#776527}
-
Alex Rudenko authored
Disabling CL: https://chromium-review.googlesource.com/c/chromium/src/+/2235718 DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2236400 Bug: 946975 Change-Id: Ib0b84bda186ed009b36f587ecfd540f2310e61bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236138 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#776526}
-
Xiaocheng Hu authored
The histogram is not under active monitoring, and we didn't receive any related alerts in ~20 milestones. Hence, this CL deprecates it. Bug: 1089650 Change-Id: If86e90c52095ab27ed419e6c618888733560d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236230Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#776525}
-
Ella Ge authored
This CL adds the java part of InstalledWebappGeolocationBridge that pass start/stop location updates to the TWAClient, and also pass the location data that received from TrustedWebActivityCallback, to the native part. This also adds the InstalledWebappGeolocationBridge::SetOverride, which is the same as GeolocationImpl::SetOverride. Bug: 1069506 Change-Id: I4d561227a0ecadb52a41c19341044fe8488ab4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212455 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776524}
-
Xida Chen authored
This CL disables the test on Cast Audio Linux. TBR=treib@chromium.org NOTRY=true Bug: 810690 Change-Id: I76214c00dd73a0874abf0afa5fff6a3a8d039fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237710Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776523}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. This CL also updates the call sites in ApplyConstraintsProcessor class, and also removes some uses of WebMediaStreamSource::Type, in favor of MediaStreamSource::Type. BUG=704136 R=guidou@chromium.org Change-Id: I8507cea20ef0a1171809444ec74f1163f30d5d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236233 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#776522}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc23d95f5f85..7910a8f76121 2020-06-09 michaelludwig@google.com Account for surface origin in Dawn scissor rect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091734 Tbr: bungeman@google.com Change-Id: I92518d29446488f9c28d35e2fee199dcdba05c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776521}
-
Mugdha Lakhani authored
Bug: 1091795 Change-Id: Iabf8e6d3dc83c071e1427c965c95ca4320d74fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235838 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776520}
-
Marc Treib authored
https://crrev.com/c/2235075 disabled these tests on all platforms, when in fact they were only failing on ChromeOS. So this CL re-enables them on other platforms. TBR=rdevlin.cronin@chromium.org Bug: 1092345 Change-Id: I7c00e74ed21bf1db18ac7c346e7d02513aa15f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236140Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#776519}
-
Asanka Herath authored
Move the privacy_budget related source definitions into separate BUILD.gn files in the respective source directories. Doing so eases the logistical burden of the fairly heavy code churn in these directories. R=haraken@chromium.org Bug: 973801 Change-Id: I2d6520d8453ea4f48bf9717315436d90a8c293e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231507Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#776518}
-
Adam Langley authored
This change implements the getPublicKey(), getPublicKeyAlgorithm(), and getAuthenticatorData() functions described in the editor's draft of WebAuthn level two[1]. [1] https://w3c.github.io/webauthn/#sctn-public-key-easy BUG=1083301 Change-Id: I3a03279d5239a9f8df50a78f2166f30d01d38d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204087Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#776517}
-
Andrew Grieve authored
This runs our existing espresso .jars through jetify so that they no longer need enable_jetify = true. Mechanically updates all source references to the new package name. Bug: 896775 Change-Id: I1fb688421d3703c211279ba9ae0d29edef77d718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233692 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776516}
-
Eric Seckler authored
Moves the stop-gap implementation of typed trace events from //services/tracing/public/cpp/perfetto into //base/trace_event and extends //base's stub implementation to cover typed event macros, too. This adds a dependency on //third_party/perfetto to //base in the case when the enable_base_tracing gn flag is set to true. Base embedders can set this arg to false to disable tracing support and avoid the dependency on //third_party/perfetto. Design doc: https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/edit Test: add a new typed event to //base (not submitted), run services_unittests, base_unittests (the latter also with enable_base_tracing = false). Change-Id: I1f54b9e6b4b9f26aff5b85d2e3d18aaceb752936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203380Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#776515}
-
sandromaggi authored
This test has been disabled for failing on tablet. Looking at other sources testing the new tab button, they set a restriction to only enable it for phones. This CL does the same to that test. Bug: 1070272 Change-Id: I1c108391f0f4b5b31e2b8271392a998ed5266109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236440 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#776514}
-
Marc Treib authored
According to webkit_lint, "virtual/*/"-prefixed test expectations are implied by the non-prefixed ones, so no need to list both of them. This CL removes two such cases (for external/wpt/webrtc/RTCPeerConnection-getStats.https.html). TBR=hta@chromium.org No-Try: true Bug: 1092835 Change-Id: Ia5e841194e3ca673245fd6956369d23c67b4774f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235848Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#776513}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f19675c75eab..a7e60fe18677 2020-06-09 ddrone@google.com Update a comment in proto_library.gni If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4eacd81c0997eacc66654b2c1134621e82237625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237201Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776512}
-
Ewann authored
This is a reland of 62ef43a9 Broken tests have been fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/2230496 Original change's description: > Adds ChangeTabSwitcherPosition to Field Trial Testing Configuration > > > Bug: 1073826 > Change-Id: I378c67f926df54bd4bd75d0a64f7b241534238a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208971 > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775055} Bug: 1073826 Change-Id: I2b4e824f024b3d1994eb6bbe9f8081e5b5a1e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232343Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776511}
-
Chris Blume authored
The Renderer4.ImageDecodeTaskDurationUs* histograms will be expiring soon. These track the cache hit rate for the software decode cache. This CL changes the expiry to 1 year from now, as suggested in [1] for a histogram which will be useful indefinitely. It also adds me as an owner of the histogram since I plan to be doing a lot of image decoder work. [1] https://chromium.googlesource.com/chromium/src/+/master/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms Bug: 1089796 Change-Id: I66aea8522635ecf2f86f07e6254e95136c9a213e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236733Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#776510}
-
Aya ElAttar authored
Added another PolicyMap::Entry::set_value to override the old one to switch from passing value as unique_ptr to base::Value. Bug: 1092471 Change-Id: Ibe38a8cbb022d951495c2b2d03a3b40d70e54f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237251Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Auto-Submit: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#776509}
-