- 21 Nov, 2018 40 commits
-
-
Antonio Gomes authored
... to observing IdentityManager CL also gets rid of the AccountTrackerService usage, driven-by. BUG=906579 Change-Id: I1ec47f5817a665995a5c1e4c2a6ed21a49756f3e Reviewed-on: https://chromium-review.googlesource.com/c/1340890Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610032}
-
Alessio Bazzica authored
The default APM configuration will change disabling the adaptive digital mode of AGC2. Bug: webrtc:7494 Change-Id: I272153142dcd49b267feeb2620a651d42db62e01 Reviewed-on: https://chromium-review.googlesource.com/c/1345437Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#610031}
-
Kent Tamura authored
- Add comments based on DOM-Parsing specification. - Introduce |candidate_prefix| variable to follow the specification. This CL has no behavior changes. Bug: 906807 Change-Id: I51e7fd9f22fd4f43baac2a85a521af049b5e588c Reviewed-on: https://chromium-review.googlesource.com/c/1345375Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#610030}
-
Sylvain Defresne authored
Add a new method OnPrimaryAccountSetWithPassword to IdentityManager::Observer (with comments indicating it only works for legacy sign-in workflow) and port PasswordStoreSigninNotifierImpl to it. Bug: 903870, 887438, 887441 Change-Id: Ic79cff4ffdd341aedb22ee2c8abd40d309ee6fa4 Reviewed-on: https://chromium-review.googlesource.com/c/1344089Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#610029}
-
David Jean authored
Bug: 907087 Change-Id: I3ae8056fcc7ca33eff2a813abf030a2ffeaf8198 Reviewed-on: https://chromium-review.googlesource.com/c/1346149Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#610028}
-
Alex Clarke authored
This will help https://crrev.com/c/1340317. TBR=mbarbella@chromium.org Bug: 906125, 907410 Change-Id: Id6d666a0e8dc18d8646a81dd16fadec16fe44abe Reviewed-on: https://chromium-review.googlesource.com/c/1344105 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#610027}
-
Boris Sazonov authored
This CL changes AccountManagerFacade.getGoogleAccounts() return type from Account[] to List<Account>. This is done to ensure immutability of this list and for consistency with getGoogleAccountNames(). Bug: None Change-Id: If703947028dd4ed0c9fdaf18856d97d6b6a52aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1338088 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610026}
-
Noel Gordon authored
- remove metrics.ImportEvents - remove metrics.timing.Variables.HISTORY_LOAD No change in behavior, no new tests. Bug: 905934, 847729 Change-Id: I2f5ab9659dc5e134bdb47d8c770a1f918b4a0126 Reviewed-on: https://chromium-review.googlesource.com/c/1345381Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610025}
-
Benoît Lizé authored
When a ParkableString is unparked, keep the compressed data around, allowing to drop the uncompressed data at no cost later. As decompression is much (>10x) cheaper than compression and compressed data smaller, this is usually a good tradeoff. This also allows to recover memory when a string is unparked once, and its content is not touched again soon. Concretely, we introduce: - "synchronous parking" when parking is merely dropping the decompressed representation. - "synchronous only" string parking in ParkableStringManager - Drop all parkable strings when receiving a OnPurgeMemory() notification. Also, improve and simplify testing, with fewer "friend" function and tighter compression test. Bug: 877044 Change-Id: I4b66ca5ddc67b2a6e49bfd1790e1788870642b04 Reviewed-on: https://chromium-review.googlesource.com/c/1329975Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610024}
-
Peter Boström authored
This effectively aligns the tab-icon animation with page commits as the navigation request only exists while the tab is navigating. This code is also easier to understand since we don't need to keep track of when a first response could have been received (and which navigation the response is related to). Bug: chromium:903817 Change-Id: I3629792f1a122a2445edc9a2cab02e38b0eeca7b Reviewed-on: https://chromium-review.googlesource.com/c/1341992Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610023}
-
Marc Treib authored
If IsSyncFeatureEnabled is false, then GetPreferredDataTypes doesn't really mean anything. In practice, this wasn't an actual issue: If Sync isn't enabled, then the whole UserEventService can't upload anything anyway. But still best to be precise here. Bug: 907027, 856081 Change-Id: I2e3ee7200118175ed9397b5a1b7d9fedd0eb7692 Reviewed-on: https://chromium-review.googlesource.com/c/1344104Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610022}
-
Clemens Arbesser authored
To this end, the billing profile of the credit card is retrieved and stored in client memory. Bug: 806868 Change-Id: Ic29020f70f4c00f06ee4014ca7322ff2c8039c92 Reviewed-on: https://chromium-review.googlesource.com/c/1344143 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610021}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a63cf8e80aa5..ef3f9bef8660 git log a63cf8e80aa5..ef3f9bef8660 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 rmistry@google.com Revert "Reland "Temporarily remove Android compile bot from CQ"" 2018-11-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0e604f9f1107..836674c28b1e (4 commits) 2018-11-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-20 rmistry@google.com Reland "Temporarily remove Android compile bot from CQ" 2018-11-20 kjlubick@google.com [canvaskit] Add debug-mode only logs 2018-11-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-20 michaelludwig@google.com Convert aa edge distances into attribute 2018-11-20 michaelludwig@google.com Add aa/non-aa, local coord, and perspective modes to rect benchmarks 2018-11-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-20 kjlubick@google.com Add software backend to gpu build 2018-11-20 kjlubick@google.com [canvaskit] Expand canvas2d API 2018-11-20 mtklein@google.com disable platform (matrix) procs 2018-11-20 michaelludwig@google.com Update drawimage composite benchmark to force aa 2018-11-20 reed@google.com hide (unused) intercepts methods -- for staging migration to SkFont 2018-11-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-20 brianosman@google.com Use GrVertexWriter for GrAAStrokeRectOp 2018-11-20 reed@google.com guard flag, so we can remove it and force clients to opt-in 2018-11-20 jvanverth@google.com Add SkImage::MakeFromYUVAPixmaps 2018-11-20 brianosman@google.com Use a smaller tolerance when chopping conics to quads 2018-11-20 bsalomon@google.com Add docs about building with clang-cl on Windows. 2018-11-20 mtklein@google.com SkBitmapProcState_matrixProcs.cpp refactoring 2018-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b81ff9e6c518..0e604f9f1107 (1 commits) 2018-11-20 bsalomon@google.com Experimentally disable GrTextureOp chaining on Intel GPUs on Mac. 2018-11-20 michaelludwig@google.com Add writePoint3() to SkWriteBuffer interface. 2018-11-20 bsalomon@google.com Pass alpha rather than full colors to TextureOps made from image sets. 2018-11-20 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8a0fb48a56d6..b81ff9e6c518 (2 commits) Created with: gclient setdep -r src/third_party/skia@ef3f9bef8660 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:888453,chromium:906453 TBR=csmartdalton@chromium.org Change-Id: I7cc3a2bb87f5fd53a7b05756b08e468d99aa26ff Reviewed-on: https://chromium-review.googlesource.com/c/1345769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610020}
-
Sam McNally authored
Previously, when the selected item is removed, the selection is changed to the index after where the old lead index was. When multiple items are removed, the logical next item may move multiple positions. Avoid this by moving to the item that hasn't been removed from prior to the permutation - using its position after the permutation. Bug: 708299 Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 Reviewed-on: https://chromium-review.googlesource.com/c/1345709Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610019}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96e14159c92b..b33ab55f3140 git log 96e14159c92b..b33ab55f3140 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 treehugger-gerrit@google.com Merge "perfetto: fix build on gcc" 2018-11-20 lalitm@google.com trace_processor: relax DCHECK on retrieving process with upid == 0 2018-11-20 lalitm@google.com trace_processor: lazy lookup mem counter and rss stat events upids 2018-11-20 lalitm@google.com Merge "trace_processor: properly handle how to bound filter int and float types" 2018-11-20 treehugger-gerrit@google.com Merge "profiling: interner: do not construct temporary objects." 2018-11-20 lalitm@google.com Merge "perfetto: bump sqlite version" 2018-11-20 primiano@google.com Merge "Make flush async in probes producer" 2018-11-20 lalitm@google.com Merge "traced_probes: add atrace timeout and print error message on unexpected exit" 2018-11-20 treehugger-gerrit@google.com Merge "Fix trace_to_text for WASM" 2018-11-20 lalitm@google.com Merge "perfetto: handle mock traces setting data about tid and tgid == 0" 2018-11-20 lalitm@google.com Merge "perfetto: introduce base::optional" Created with: gclient setdep -r src/third_party/perfetto@b33ab55f3140 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:119118907 TBR=perfetto-bugs@google.com Change-Id: I744c1d7ea4ce39b4fa067e727198dfd44510e637 Reviewed-on: https://chromium-review.googlesource.com/c/1344898Reviewed-by:
-
Jonas Olsson authored
Bug: chromium:904764 Change-Id: I3ad24d066a2c60328921867b559fdd5e1a2dad00 Reviewed-on: https://chromium-review.googlesource.com/c/1346092Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#610017}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/44bef83f2be0..9ace67b95f5c git log 44bef83f2be0..9ace67b95f5c --date=short --no-merges --format='%ad %ae %s' 2018-11-21 dburger@chromium.org remove unused GetSlaveBuildMessages call 2018-11-21 lamontjones@chromium.org signing: Add KeyPair.ParsePrivateKeyFilename 2018-11-20 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-20 gmeinke@chromium.org lakitu-gpu: mark as experimental 2018-11-20 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-20 jemele@google.com Remove deprecated loonix boards Created with: gclient setdep -r src/third_party/chromite@9ace67b95f5c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I945a20b864e9e25b77e8236c853e0bed8ab7a4fb Reviewed-on: https://chromium-review.googlesource.com/c/1345929Reviewed-by:
-
Guido Urdaneta authored
The old algorithm computed fitness for width, height and aspect ratio using the best possible width, height and aspect ratio supported by a constrained format. However, the actual selected resolution does not necessarily have the width, height and aspect ratio that are simultaneously closest to the ideal values. In practice, this results in differences only in marginal cases such as: * Extreme ideal aspect ratios, where rounding a selected resolution in floating-point format might lead to a significant variation in aspect ratio. For example (1000x1.25 has aspect ratio 800 before rounding but aspect ratio 1000 after rounding to 1000x1). This is not an issue for resolutions that are used in practice and the spec allows some deviation in the optimization of the fitness distance anyway. * The ideal aspect ratio significantly contradicts the ratio between the ideal width and the ideal height. In this case, the selected point will be close to ideal width and ideal height, but might be far from the ideal aspect ratio (which is ignored), thus it might have a higher fitness distance than the one computed by the old algorithm. This minor fix has more importance when extra complexity is added to the computation of fitness distance to support the new resizeMode constraint in a follow-up CL. Bug: 854980 Change-Id: I0cadb28553816357ce84bbf38b5686cc48b427e7 Reviewed-on: https://chromium-review.googlesource.com/c/1329788Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#610015}
-
Stephen Chenney authored
We were recording main frame time metrics even when doing lifecycle updates for other reasons, which is pointless and skews the numbers. This plumbs information on the source of the update through necessary layers. R=pdr@chromium.org BUG=896356 Change-Id: I94ec6ec14a6629ec2295b4575e9af7a8fd5b7ead Reviewed-on: https://chromium-review.googlesource.com/c/1303874Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#610014}
-
Johannes Kron authored
Bug: webrtc:8651 Change-Id: Ic819f9264083b2ab99e7796b932f82e28af8c23b Reviewed-on: https://chromium-review.googlesource.com/c/1344432Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#610013}
-
David Roger authored
Going forward the default API for interacting with authentication error should be the token service rather than the SigninErrorController. This CL updates tests to use the token service instead of AuthErrorProvider to set authentication errors. Note: this is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1016904 Relanding notes: The CL was reverted because OAuth2Test.SetInvalidTokenStatus was flaky. This was happening because the error was set through UpdateAuthError, which does not cancel requests that are in flight, and thus requests could randomly succeed later on and remove the error. To fix this, the test now uses UpdateCredentials() which cancels all in-flight requests, and prevent the error from disappearing later. TBR=msarda, stevenjb Bug: 836212 Change-Id: I2d9cde22e6fc1933de0b47f39aebdd495ab2dd95 Reviewed-on: https://chromium-review.googlesource.com/c/1075088 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610012}
-
Hiroki Nakagawa authored
Before this CL, when a failure on importScripts() happens, WorkerOrWorkletScriptController::RethrowExceptionFromImportedScript() creates a new Error and throws it instead of an original Error. This fails web platform tests: https://wpt.fyi/results/workers/interfaces/WorkerUtils/importScripts/004.html?label=stable&aligned https://wpt.fyi/results/workers/interfaces/WorkerUtils/importScripts/006.html?label=stable&aligned This CL makes the function throw the original Error. In addition, this CL changes ErrorEvent::CreateSanitizedError() to create a sanitized error with a null error object instead of an empty error object. This is because the HTML spec requires the error object for scripts whose errors are muted must be null, and ExceptionState::RethrowV8Exception() called from RethrowExceptionFromImportedScript() doesn't throw an exception when its error object is empty. Bug: 651778, 655458 Change-Id: I67a91879b4a9fa3fd521797394fe35de89634b7a Reviewed-on: https://chromium-review.googlesource.com/c/1343465 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#610011}
-
Harald Alvestrand authored
This prevents a failure in RTCP messsaging from masking other failures. It's up to other tests to actually verify that RTCP stats have been delivered. Bug: 904574 Change-Id: Ie641d5275372b4c10ad5fa3a39ae38c36f974482 Reviewed-on: https://chromium-review.googlesource.com/c/1341510Reviewed-by:
-
Pavel Shmakov authored
Android Apps can choose an Activity that Android Settings will link to when the user presses "Manage Data" for that app. This CL, plus the corresponding one to Custom Tabs library, https://crrev.com/c/1331527, gives TWA developers the option to link to Chrome's site-settings for the origin their app is verified with. Bug: 888958 Change-Id: Ie003feb42c8fe82e75574ff0da6ac01ce577a72e Reviewed-on: https://chromium-review.googlesource.com/c/1329978 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#610009}
-
Anders Hartvoll Ruud authored
This CL makes it possible to parse custom properties though the CSSProperty API (like other properties). We need different parsing behavior, depending on the situation: * kTyped: Parsed according to registered syntax. This is needed by e.g. CSS Typed OM. * kUntyped: Parsed as if unregistered. This is needed by the CSS parser, where registrations should just be ignored. * kUntypedValidated: Parsed as if unregistered, but tokens must also match the registered syntax. This is needed by CSS OM, where values should be validated against the registered syntax when arriving through setProperty, yet still behave as unregistered once the value has been accepted. Change-Id: I656cbd63b14b2516ad6bf014e433c34b5c6a72a8 Reviewed-on: https://chromium-review.googlesource.com/c/1343103 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610008}
-
Hajime Hoshi authored
V8 must not be executed on the default task runner. This CL replaces that with a per-frame task runner. Bug: 870606 Change-Id: I9c3844692235baad411a83ed50a7c6402e0a3b8f Reviewed-on: https://chromium-review.googlesource.com/c/1312444Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610007}
-
Anna Malova authored
This CL is reupload of CL:1329797 which was reverted in CL:1343260 due to test flakiness. The test flakiness comes from waiting of "https://www.google.com/..." URLs to be loaded. Replacing these URLs with local URLs generated by EmbeddedTestServer fixed the problem. Bug: 906834 Bug: 889916 Change-Id: I3e9981b4a4ca5a0bd64dff217e44bfd89ca10b9c Reviewed-on: https://chromium-review.googlesource.com/c/1344132Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
David Turner authored
This reverts commit cf14fec1. Reason for revert: Unexpected 3.5 MiB increase of private RAM usage BUG=907092 TBR=agrieve@chromium.org, pasko@chromium.org Original change's description: > android: build: Enable RELR packed relocations for libchrome.so > > NOTE: This is a reland of [1], but this one does not touch > libchromefortest.so which is used on Android N+ during testing, > and could not be loaded by the system linker when using RELR > relocations. > > This optimization cannot be applied to libmonochrome.so, unfortunately, > because only Android P and above support these at the system linker > level. > > [1] https://chromium-review.googlesource.com/c/1304487 > > BUG=895194 > R=agrieve@chromium.org,torne@chromium.org,pasko@chromium.org,pcc@chromium.org > > Change-Id: If50f607d2e9abbff5ae0c140da342af7b8c78858 > Reviewed-on: https://chromium-review.googlesource.com/c/1317630 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: David Turner <digit@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609142} TBR=pasko@chromium.org,digit@chromium.org,torne@chromium.org,pcc@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895194 Change-Id: Ib796a90aca376042d8b91f2a388060c3738bb096 Reviewed-on: https://chromium-review.googlesource.com/c/1346090Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#610005}
-
Lukasz Suder authored
When details are empty and no UI update is needed we should return. Bug: 806868 Change-Id: Ibc644b11f135d9fab082b942f8939257b9933b1e Reviewed-on: https://chromium-review.googlesource.com/c/1345078Reviewed-by:
-
Noel Gordon authored
CL:1345374 removed metrics / analytics use from ImportHistory and with those gone, we can now 1) remove them from import_history_unittest and 2) remove metrics from the import history js_library BUILD deps. No change in test behavior, no new tests. Bug: 905934 Change-Id: I706beb0fa5c61fdb55b46a8d2072a9de1016fa40 Reviewed-on: https://chromium-review.googlesource.com/c/1346189Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610003}
-
David Jean authored
Bug: 845472 Change-Id: Id077ed820ad559e00da61d96bf82f890333d9c86 Reviewed-on: https://chromium-review.googlesource.com/c/1341523 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Darwin Huang authored
drag state Only allow frames who are ancestors of the drag_src_ to reset a drag_src_ Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging Created layout test to verify lack of regression when frames containing drag source are moved/detached Fix memory leak from reverted CL https://crrev.com/c/1265818 Bug: 737691, 903705, 903933 Change-Id: I308680446662d6548587ae2d7dd2c139b09ee581 Reviewed-on: https://chromium-review.googlesource.com/c/1336440 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610001}
-
Sami Kyostila authored
If a delayed task is posted from a non-main thread and task queue time recording is enabled, we attempt to grab the "any thread" lock twice, leading to a deadlock. This patch reduces the scope of the lock to avoid the problem. Original fix from Alexander Timin <altimin@chromium.org>. Bug: 891670 Change-Id: I5af0c2016a12b061c523b8b51c16ff23a8f3a41f Reviewed-on: https://chromium-review.googlesource.com/c/1344144Reviewed-by:
-
Harald Alvestrand authored
This is a minimal fix - move the generation of the track (which causes onnegotiationneeded) to before we set the expectation that no event will be fired. Bug: chromium:905563 Change-Id: I879f6eb6130d719d7eaad71fed85044b690f0cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1346030Reviewed-by:
-
Mario Sanchez Prada authored
This is the first step of those that will allow us remove the dependency from SigninManager::IsAllowedUsername() in the long run, as part of our effort to migrate parts of the code base to the Identity service. Note that this free function will be in the |identity| namespace even if it's actually declared & defined in signin_manager.[h|cc] for now, which should be ok since this is just a temporary situation until we get to a state where SigninManager is not used by any consumers outside //services/identity, at which point we'd simply move it to the public C++ API in there. We can't do it now, though, because doing so would create a dependency cycle as //components/signin would have to depend on //services/identity (which in turn depends on //components/signin). Bug: 906081 Change-Id: I0ec5817661c0cfd27c7a08ef67eae389beff1230 Reviewed-on: https://chromium-review.googlesource.com/c/1344145Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#609998}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/38332cdcb107..66eedce30a82 git log 38332cdcb107..66eedce30a82 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7d53bc24..16e6b253 (609559:609893) 2018-11-20 ssilkin@webrtc.org Increase buffer level threshold in VP8/9 tests. 2018-11-20 nisse@webrtc.org Delete unneeded includes of common_types.h and gn deps on webrtc_common. Created with: gclient setdep -r src/third_party/webrtc@66eedce30a82 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I02cbbfbd8c6c62a834cd93d5e70504b8777e40b1 Reviewed-on: https://chromium-review.googlesource.com/c/1345730Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 871f84f2. With Chromium commits locally applied on WPT: 3629f6dc "Refine wpt/service-workers/service-worker/clients-get.https.html" 02c7f5d5 "Revert "Add referrer-policy module worker tests"" 396a0004 "[BlinkGenPropertyTrees] Filter effects should be clipped" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I7bc81554c3ce6e05f6939858d10c97b4f01075b3 Reviewed-on: https://chromium-review.googlesource.com/c/1344833 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609996}
-
Jan Krcal authored
This CL allow propagating is_from_expiration bool to TypedURLSyncBridge. It is important for keeping sync data (in history DB) with sync metadata consistent. This bool will be used in a follow-up CL. Bug: 851869 Change-Id: I96bec4ecc86f9357a82b7abf4ca7ee8320ef998d Reviewed-on: https://chromium-review.googlesource.com/c/1343005 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609995}
-
Finnur Thorarinsson authored
This provides support for the Contacts Picker API, https://github.com/beverloo/contact-api https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/brKChSa9_d0 allowing contact details to be shared with a web page. A skeleton select() function is implemented (returns a DOMException). BUG: 860467 Change-Id: I7cf4c147271179c0f59a7cd455d88b1b570c9891 Reviewed-on: https://chromium-review.googlesource.com/c/1326501 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609994}
-
Guido Urdaneta authored
This is intended to make it easier to detect if an RTCPeerConnection is used together with getUserMedia() or getDisplayMedia() for real-time audio/video. Bug: 906029 Change-Id: I440fc93567bd9a490047c2bcf3bf5641a4ff3dfa Reviewed-on: https://chromium-review.googlesource.com/c/1344101Reviewed-by:
-
