GitLab

Instead, DownloadFileManager puts the DownloadFile in a new map when it has the final name.

This is a step towards moving the 'final rename' determination happen in the UI thread.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6480079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75400 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75371 - Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6538058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75399 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6469055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72579
TEST=manual testing, trybots

Review URL: http://codereview.chromium.org/6487001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72486
TEST=added new unit_tests and browser_tests
Manual Test: With preendering enabled, do a search for "yahoo mail". Prerendering should be canceled
due to https.

Review URL: http://codereview.chromium.org/6523062

TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/6543010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75395 0039d316-1c4b-4281-b951-d872f2087c98

Show doesn't necessarily get called when a window is opened directly to a
url (as opposed to a new tab page).

BUG=70657
TEST=manual testing

Review URL: http://codereview.chromium.org/6538038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72486
TEST=added new unit_tests and browser_tests
Manual Test: With preendering enabled, do a search for "yahoo mail". Prerendering should be canceled
due to https.

Review URL: http://codereview.chromium.org/6523062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75393 0039d316-1c4b-4281-b951-d872f2087c98

- use ScopedTempDir in work items that need backup space for rollback
- all work items that need backup space take a parent dir in which they create temp dirs
- use ScopedTempDir in a few other places
- renamed some parameters in certain functions so that the same name is used everywhere

While I was at it, I couldn't help but replace Append(UTF8ToWide(version.GetString())) with the more pleasing AppendASCII(version.GetString())

BUG=70368
TEST=existing tests in installer_util_unittests cover the changes

Review URL: http://codereview.chromium.org/6538025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73415
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/6538056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75391 0039d316-1c4b-4281-b951-d872f2087c98

Check and invalidate cached credentials if they were used for preemptive authentication and were rejected by the server.

BUG=72589
TEST=net_unittests --gtest_filter=HttpAuthHandler*.HandleAnotherChallenge

Review URL: http://codereview.chromium.org/6525035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75390 0039d316-1c4b-4281-b951-d872f2087c98

Revert 75347 - Revert 75306 - Force native frames to repaint when OnNCActivate is called. With a profile menu button added to the GlassBrowserFrameView, failure to trigger the frame repaint means that the button will remain in the active state even when the frame has been deactivated.

DesktopNotification tests failing on win full - speculative revert since this is the only CL in the range that seems possibly related.

BUG=none
TEST=frames behave normally in Aero mode, when activated and deactivated.

Review URL: http://codereview.chromium.org/6507044

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6546006

TBR=mattm@chromium.org
Review URL: http://codereview.chromium.org/6541023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75389 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6541022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75388 0039d316-1c4b-4281-b951-d872f2087c98

Rather than have a couple of nasty #if defined blocks, push the code down into the platform specific RenderWidgetHostView layer.  Added support for releasing surfaces:

- if renderer crashes, RenderWidgetHostView releases the surfaces (no change from previous code)

- if gpu process crashes, the GpuProcessHostUIShim releases the surfaces (introduced in this patch)

- if the channel between the renderer and gpu process falls, the gpu process asks the GpuProcessHostUIShim to release the surface

BUG=none
TEST=by hand 3D css and WebGL on win, max, linux, and linux views

Review URL: http://codereview.chromium.org/6462034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75387 0039d316-1c4b-4281-b951-d872f2087c98

After opening a new tab, the tab may not be ready to read the title. The method CheckTitle checks title within the certain timeout.
It may not a good solution but workable and existing code already uses it, so I think we use it to fix this bug.


BUG=46781
TEST=UnloadTest.BrowserCloseBeforeUnloadOK.

Review URL: http://codereview.chromium.org/6544015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75386 0039d316-1c4b-4281-b951-d872f2087c98

Initialize INPUT struct. The dwFlags member of INPUT struct is not properly
initialized so sometimes the key event is interpreted as a key up and thus
keys are missed.

BUG=70167
TEST=keyboard input is fine on windows

Review URL: http://codereview.chromium.org/6542015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=72633
TEST=none
Review URL: http://codereview.chromium.org/6538022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75384 0039d316-1c4b-4281-b951-d872f2087c98

When set this policy overrides the user settings for that pref.

No UI changes have been made to ContentSettings.xib only wired the enabled flag to the managed property of the underlaying pref.

BUG=59775
TEST=Manually set the policy and check if the corresponding UI element is disabled and correspond to the policy state.

Review URL: http://codereview.chromium.org/6534021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73358
TEST=waterfall.sh match no longer shows stack

Review URL: http://codereview.chromium.org/6469051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75382 0039d316-1c4b-4281-b951-d872f2087c98

When Chromoting is enabled via Chrome, the service process is started
if necessary and notified that the Chromoting service has become enabled.
When the service process is later auto-started (or run manually) it will
initialize Chromoting, which detects that it is enabled and starts up, but
fails to inform the service process that it's enabled, so the process waits
a while and then exits.

BUG=73168
TEST=Enable Chromoting in Chrome.  Kill the existing service process and start a new one manually.  Ensure that the new one runs for at least two minutes without quitting.

Review URL: http://codereview.chromium.org/6532023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6532045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73166
TEST=Enable Chromoting Host in Chrome, and try to connect to it.  The service process should not crash trying to retrieve the VP8 codec.

Review URL: http://codereview.chromium.org/6539017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75379 0039d316-1c4b-4281-b951-d872f2087c98

GeolocationDispatcher::render_view_ is never used or assigned to, so remove
unnecessary field.

BUG=None
TEST=Compile

Review URL: http://codereview.chromium.org/6507045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75376 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75375 0039d316-1c4b-4281-b951-d872f2087c98

The bug is that the changes in an onChangesApplied() event is set to
n copies of the first change.

Fix similar bug in test code (which is why this bug wasn't caught).

BUG=69500
TEST=

Review URL: http://codereview.chromium.org/6546009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75373 0039d316-1c4b-4281-b951-d872f2087c98

75361 seems to introduce new crashes caught by reliability:

"anonymous namespace'::purecall____invalid_parameter_noinfo___ots::parselookuplisttable"

BUG=none
TEST=ran try

Review URL: http://codereview.chromium.org/6539010

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/6542010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75372 0039d316-1c4b-4281-b951-d872f2087c98

Try to fix the Win Builder (dbg)(shared) build break by adding a dependency from content_browser to WebKit.gyp (TabContents uses WebView's zoom constants and helper functions).

TBR=avi
Review URL: http://codereview.chromium.org/6546013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75371 0039d316-1c4b-4281-b951-d872f2087c98

Start moving core pieces of Chrome multi-process code to src\content.  I'm starting with tab_contents directory.In future changes the headers that include these files will be updated.  Once all the files are moved (i.e. renderer_host, rest of browser, renderer etc), then refactoring can begin so that content\DEPS doesn't have chrome in it.
Review URL: http://codereview.chromium.org/6537015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75369 0039d316-1c4b-4281-b951-d872f2087c98

Changed parsing code for the phonenumbers fields to incorporate different combinations of the phone fields in the forms.
Should fix a lot of the phone parsing bugs and make changes to parsing code much easier.
BUG=71893,71897
TEST=unit-tested, please also check that any web-form that includes a phone number fields gets that fields parsed correctly
Review URL: http://codereview.chromium.org/6480083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75368 0039d316-1c4b-4281-b951-d872f2087c98

(by https://bugs.webkit.org/show_bug.cgi?id=54632).

Otherwise, landing the WebKit patch results in Chromium build breakage.
Example:
.\glue\media\buffered_resource_loader_unittest.cc(87) : error C2259: 'testing::NiceMock<MockClass>' : cannot instantiate abstract class
    with
    [
      MockClass=webkit_glue::MockWebFrame
    ]
    due to following members:
    'void WebKit::WebFrame::setScrollOffset(const WebKit::WebSize &)' : is abstract
    c:\b\build\slave\webkit-win-latest-rel\build\src\third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h(146) : see declaration of 'WebKit::WebFrame::setScrollOffset'

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6538049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:12188
TEST=manually on netbook

Review URL: http://codereview.chromium.org/6532050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/6538051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75365 0039d316-1c4b-4281-b951-d872f2087c98

the benchmark lab.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6519042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ran try

Review URL: http://codereview.chromium.org/6539010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75361 0039d316-1c4b-4281-b951-d872f2087c98

Since Callback<> is essentially a smartpointer, some introspective APIs are
required for sensible usage.

BUG=35223
TEST=new unittests

Review URL: http://codereview.chromium.org/6507029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75360 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73252
TEST=see bug

Review URL: http://codereview.chromium.org/6543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75352 0039d316-1c4b-4281-b951-d872f2087c98

Detect this case and automatically switch to showing the menu above the button in this case.
BUG=69996
TEST=NONE
Review URL: http://codereview.chromium.org/6531019

TBR=maf@chromium.org
Review URL: http://codereview.chromium.org/6544010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73558
TEST=None

Review URL: http://codereview.chromium.org/6469040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73358
TEST=None

Review URL: http://codereview.chromium.org/6532046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73558
TEST=None

Review URL: http://codereview.chromium.org/6538040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75348 0039d316-1c4b-4281-b951-d872f2087c98