GitLab

Rulers, grid and media queries are now rendered in CSS pixels.
Additionally, a content size rectangle is drawn for visual feedback.

BUG=none

Review URL: https://codereview.chromium.org/351303003

git-svn-id: svn://svn.chromium.org/blink/trunk@177098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/356033002

git-svn-id: svn://svn.chromium.org/blink/trunk@177097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/352953002

git-svn-id: svn://svn.chromium.org/blink/trunk@177096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an array or a dictionary is ended we check that there are no other open containers on top of it.

BUG=None

Review URL: https://codereview.chromium.org/356013002

git-svn-id: svn://svn.chromium.org/blink/trunk@177095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With [TypeChecking=Interface], two type-checks would be emitted for
variadic arguments; one as if the argument wasn't variadic, checking only
the first actual argument, and then another one checking each actual
argument.

Review URL: https://codereview.chromium.org/359763002

git-svn-id: svn://svn.chromium.org/blink/trunk@177094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys

Review URL: https://codereview.chromium.org/359743003

git-svn-id: svn://svn.chromium.org/blink/trunk@177093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Popover is a modal element, and should be hidden on resize,
toggling fullscreen, zoom change akin to TextPrompt.

BUG=388659

Review URL: https://codereview.chromium.org/353833003

git-svn-id: svn://svn.chromium.org/blink/trunk@177092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The goal is to eventually have an empty HTTP origin header added if needed in
content rather than in FrameFetchContext::addAdditionalRequestHeaders.

BUG=376025

Review URL: https://codereview.chromium.org/352313003

git-svn-id: svn://svn.chromium.org/blink/trunk@177091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

|cpp_type| can be non-*Ptr type so it seems that we can't always use
local variables if we want to merge local variable assignment.
Following Jens' suggestion[1] to merge local variable assignment.

[1] https://codereview.chromium.org/359703002/diff/1/Source/bindings/templates/attributes.cpp#newcode51

BUG=345503

Review URL: https://codereview.chromium.org/351403003

git-svn-id: svn://svn.chromium.org/blink/trunk@177090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method needs to iterate the glyphs within a fragment and check if the
queried point is contained within any of them.
Currently a fragment offset is converted to a offset that's suitable for
passing to mapStartEndPositionsIntoFragmentCoordinates - which then in
turn maps it into a text box-relative offset and then runs (the costly)
modifyStartEndPositionsRespectingLigatures to check if the current range
happen to fall within a "multicharacter glyph" (ligatures etc.), and then
expand the range appropriately.
This is a lot of work, that is better performed by finding the index within
the text metrics list for the corresponding RenderSVGInlineText object,
and then step through the fragment using the lengths of the individual
glyphs.
The impact on performance will vary with the length of fragments and the
length of the text content.
For a case like:

  <text ...>(AAAAAAAAAA ){99}AAAAAAAAAA</text>

  (100 groups of ten A's separated by a single whitespace)

with a negative query, the speed-up is ~1.2x. With 'word-spacing' added
(to get more fragments) the speed-up becomes ~8.7x.

Review URL: https://codereview.chromium.org/353003002

git-svn-id: svn://svn.chromium.org/blink/trunk@177089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I will replace HeaderMap class with this in another change.

http://fetch.spec.whatwg.org/#headers-class

BUG=373120

Review URL: https://codereview.chromium.org/358573002

git-svn-id: svn://svn.chromium.org/blink/trunk@177088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current MediaQueryEvaluator takes the media type on top of the LocalFrame upon its creation.
That means that media type changes are not taken into account, and users such as
MediaQueryMatcher have to create a new instance whenever the media type may have changed.
This CL fixes that.

BUG=389462

Review URL: https://codereview.chromium.org/335313003

git-svn-id: svn://svn.chromium.org/blink/trunk@177087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The builders provide interface for constructing JSON-like structure. Current implementation uses JSONValue as backing store but it may be replaced later with something more efficient without requiring to update client code.

Current implementation ensures that we create isolated copies of all strings as they may be destroyed on a different thread.

JSCallStack in InspectorTraceEvents.cpp now serializes call stack to string in the constructor instead of doing it later during tracing events serialization. Alternatively we could clone ScriptCallStack so that it contained isolated copies of all strings and do the serialization later but that seemed equally costly.

BUG=375242,361045

Review URL: https://codereview.chromium.org/357703002

git-svn-id: svn://svn.chromium.org/blink/trunk@177086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allocate oilpan heap pages in chunks of 10 pages at a random address.
Allocating all individual pages at random addresses blows out the TLB
and leads to poor performance so we group the allocations slightly.

Using a random aligned address for our allocations has the additional
advantage that we usually do not have to unmap surrounding unaligned
bits on all page allocations which turns out to be surprisingly
expensive on Linux.

The address space randomization code has been extracted from
PartitionAlloc. No need to reinvent the wheel. :-)

R=cevans@chromium.org, erik.corry@gmail.com, oilpan-reviews@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/343753004

git-svn-id: svn://svn.chromium.org/blink/trunk@177085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When changing the list type (from ordered to unordered or vice-versa) of a list item,
a new list containing that list item is created.
Now, if that same list item (contained within the new list) is selected in its entirety and then
its list type reversed again, it merges itself back into the original list.
However, post this merge, the selection over that list item is lost.

The selection is lost because we lose the 'start' of the selection. We thus ought to maintain
the start index of the selection in the same way we maintain the end index of the selection before
merging the two lists.(Done in InsertListCommand::doApply())

The reason why this behavior is observed only when a list item is selected in its entirety is
because we do preserve the start of the selection in case the original selection spans across
multiple paragraphs, but skip this (the if check in doApply()) if the start and the end of the
selection lie on the same line.

So now, we simply need to maintain the indices for the start and the end of the selection before
we insert or merge new lists. Afterwards, we can reset the ending selection using these start
and end indices.

The selection range for the existing test, insert-list-nested-with-orphaned.html changes with
this fix. It now sets the selection over the entire list, as expected.
The test initially sets the selection over the entire list which was later lost after
performing the insertOrderedList command.

BUG=328030

Review URL: https://codereview.chromium.org/114043002

git-svn-id: svn://svn.chromium.org/blink/trunk@177084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388348

Review URL: https://codereview.chromium.org/352373003

git-svn-id: svn://svn.chromium.org/blink/trunk@177083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The center of a radial-gradient can be determined four
different ways. It can be defined with lengths, percentages,
keywords or by combining keywords with lengths or percentages.
This patch makes the usage of the latter combinations
possible.

R=fmalita@chromium.org
BUG=389205

Review URL: https://codereview.chromium.org/356683005

git-svn-id: svn://svn.chromium.org/blink/trunk@177082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts r175364. The test has been fixed and is confirmed to
not flake anymore.

BUG=380151
NOTRY=true

Review URL: https://codereview.chromium.org/353003003

git-svn-id: svn://svn.chromium.org/blink/trunk@177081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I'm not sure since when, anyway |newSelectedSentence| is no longer used.

BUG=

Review URL: https://codereview.chromium.org/350993002

git-svn-id: svn://svn.chromium.org/blink/trunk@177080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add missing & now-needed V8ValueTraits<> specialization for HeapVector.

R=haraken@chromium.org
BUG=369451

Review URL: https://codereview.chromium.org/350293004

git-svn-id: svn://svn.chromium.org/blink/trunk@177079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, caseq

Review URL: https://codereview.chromium.org/354993003

git-svn-id: svn://svn.chromium.org/blink/trunk@177078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using local variable for isolate in attribute_getter will add
complexity and won't pay for it.

BUG=345503

Review URL: https://codereview.chromium.org/359703002

git-svn-id: svn://svn.chromium.org/blink/trunk@177077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388185

Review URL: https://codereview.chromium.org/342683008

git-svn-id: svn://svn.chromium.org/blink/trunk@177076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/352983004

git-svn-id: svn://svn.chromium.org/blink/trunk@177075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVG{Length,Point,Number} have very similar implementations of adjustFromToListValues.
This CL dedupes it by moving it to SVGListPropertyHelper.

BUG=378670

Review URL: https://codereview.chromium.org/358083002

git-svn-id: svn://svn.chromium.org/blink/trunk@177074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes redundant functions Editor::indent() and outdent(), which were used for special handling of WebFrame::executeCommand.

Editor::indent/outdent are identical to executeIndent/executeOutend.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/356173002

git-svn-id: svn://svn.chromium.org/blink/trunk@177073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to haraken's comment on [1], we can always use info.Holder()
instead of calling findInstanceInPrototypeChain().
Removing one FIXME.

[1] https://codereview.chromium.org/140663012

BUG=345503

Review URL: https://codereview.chromium.org/347773003

git-svn-id: svn://svn.chromium.org/blink/trunk@177072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ensure that animations started by element.animate function the same way
as regular CSS Animations -- they will wait for notification of a start
time from the compositor.

BUG=389396

Review URL: https://codereview.chromium.org/354123002

git-svn-id: svn://svn.chromium.org/blink/trunk@177071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch ensures that we check both the current context and the
top-level browsing context when evaluating whether or not an insecure
websocket connection should be blocked as mixed content.

BUG=389040

Review URL: https://codereview.chromium.org/351163002

git-svn-id: svn://svn.chromium.org/blink/trunk@177070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch uses text shadow for label text instead of black half-opaque
background color.

BUG=382996

Review URL: https://codereview.chromium.org/351263002

git-svn-id: svn://svn.chromium.org/blink/trunk@177069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=328814

Review URL: https://codereview.chromium.org/349123002

git-svn-id: svn://svn.chromium.org/blink/trunk@177068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=389042
TBR=kouhei@chromium.org

Review URL: https://codereview.chromium.org/356993003

git-svn-id: svn://svn.chromium.org/blink/trunk@177067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add move constructor and assignment operator to RefPtr class. As a result, we
can now use the implicitly defined move constructor and assignment operator for
Atomic String. Also, other classes with RefPtr data members like CString now
get a better default move constructor and assignment operator.

The release binary is ~21Kb smaller, there is no diff on the generated asm
for CString and AtomicString. However, there is a small diff for WTFString.o:
http://pastebin.com/RTzX23JV

The generated assembly for "CString WTF::String::latin1() const" and
"CString WTF::String::ascii() const" is slightly smaller, likely due to
CString's improved move copy constructor as these methods return CStrings.

Review URL: https://codereview.chromium.org/354023003

git-svn-id: svn://svn.chromium.org/blink/trunk@177066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I was very confused by the ScriptLoader code which called
CSP::allowScriptNonce and the corresponding variable
which was called isValidScriptNonce.  I searched around
for nonce functions and found that they only checked
the nonce (not all policies) and I originally thought
this was an error!  However after further investigation
I found that allowScriptNonce actually checks all active
CSPs and returns true only if they all pass, thus making
the following line (which disables further CSP checks
on the load) OK.

I renamed these allowScriptNonce and allowStyleNonce
functions to have a 'With' in their name and added
a comment in the header explaining their behavior.

While making this change, I also reduced the verbosity
of several repeated uses of the string ContentSecurityPolicy.
I think most blink hackers would be able to look up that CSP
refers to ContentSecurityPolicy.

I removed several redundant calls to Document::contentSecurityPolicy
(again just caused the lines to be needlessly verbose).

Finally I made ScriptLoader::executeScript use the preferred
early-return pattern instead of a long indented block
for the !frame case.  I suspect that the !frame check
can actually be moved much earlier in the function
or even turned into an ASSERT.

This is still my long yack-shave to actually make the
preloader correct so I can fix the bugs which my
patch to make the HTML parser yield more agressively
(and thus not starve the preloader) possible to land:
https://codereview.chromium.org/258013009/

BUG=356292

Review URL: https://codereview.chromium.org/353873003

git-svn-id: svn://svn.chromium.org/blink/trunk@177065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently CSSValueList::item does a bounds check and will return null if
the given index is out of range. This patch makes the interface slightly
more sane by removing the check, which is currently otherwise skipped by
calling itemWithoutBoundsCheck. Note that the vector access will perform
a bounds check (with release assert) anyway. The only caller where the
bounds check behaviour is useful is for the IDL binding so a separate
function itemWithBoundsCheck is created for this (already tested by
value-list-out-of-bounds-crash.html).

Review URL: https://codereview.chromium.org/333163004

git-svn-id: svn://svn.chromium.org/blink/trunk@177064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/359473008

git-svn-id: svn://svn.chromium.org/blink/trunk@177063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Custom bindings for modules are moved into bindings/modules/v8/custom, and
- Custom bindings for core are moved into bindings/core/v8/custom.
- Update gn and gypi files.

BUG=358074

Review URL: https://codereview.chromium.org/331373002

git-svn-id: svn://svn.chromium.org/blink/trunk@177062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This replaces flags + FullScreenCheckType, for a few reasons:

 1. An UnprefixedRequest will be added, for which neither
    ALLOW_KEYBOARD_INPUT nor FullScreenCheckType is possible. Not all
    previously possible combinations are possible, either.

 2. An enum is clearer than flags at the call site. In particular,
    0 was passed to HTMLMediaElement::enterFullscreen() which would
    disallow keyboard input, which was not obivous and possibly not
    even the original intention. The behavior was preserved but should
    probably be changed to allow keyboard input in a future patch.

 3. LEGACY_MOZILLA_REQUEST as a public part of Element.h is weird.

BUG=383813

Review URL: https://codereview.chromium.org/356933002

git-svn-id: svn://svn.chromium.org/blink/trunk@177061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451
TEST=no new tests because of just refactoring.

Review URL: https://codereview.chromium.org/350863002

git-svn-id: svn://svn.chromium.org/blink/trunk@177060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add another test for empty (but rendered) paths.

BUG=388676

Review URL: https://codereview.chromium.org/357943002

git-svn-id: svn://svn.chromium.org/blink/trunk@177059 bbb929c8-8fbe-4397-9dbb-9b2b20218538