- 18 Jun, 2018 40 commits
-
-
Ryan Sturm authored
This behavior will now match UKMPageLoadMetricsObserver, which is key to keeping the metrics in sync. Change-Id: Ic92efc53e8c68d8f298ebdb8c9059c4e0604afb0 Reviewed-on: https://chromium-review.googlesource.com/1101700 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#568204}
-
Ryan Landay authored
In the Android horizontal tab switcher, we determine which tab thumbnails to render based on the index of the currently-centered tab, as determined by NonOverlappingStack#computeReferenceIndex() (this is a virtual method called by Stack since the logic for updating visibility is shared between the overlapping and non-overlapping tab switchers). We currently have a bug where the tab thumbnails are becoming blank during quick scrolling. This is because the current implementation of this method uses mScrollTarget instead of mScrollOffset to determine the centered tab (basically, mScrollTarget is where we're going and mScrollOffset is where we are, and is actually used for rendering). This CL fixes this bug by updating this method's implementation to use the value returned from getCenteredTabIndex(), which uses mScrollOffset instead of mScrollTarget. Bug: 853879,831359 Change-Id: I129c03ca80297c15b670d223bfc6630b6d8de68c Reviewed-on: https://chromium-review.googlesource.com/1105021Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#568203}
-
Paul Miller authored
BUG=628650 Change-Id: Ia78bfe6ad2d12362cb85bcc4580d907fe1ed6b47 Reviewed-on: https://chromium-review.googlesource.com/1105181Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568202}
-
Bill Orr authored
This is a reland of edb91802 Original change's description: > Add an interface to communicate between the fake openvr and tests > > This change creates a way for tests to control the behavior of > the fake OpenVR, and allows devices to send information up to > tests. > > BUG=801034 > > Change-Id: Ie0fe035ada9553114c054717f52788d375d5c62f > Reviewed-on: https://chromium-review.googlesource.com/1100157 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567725} Bug: 801034 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4c1b4891df8ba1de9d7bf07863d4b696ec81de0 Reviewed-on: https://chromium-review.googlesource.com/1104761 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568201}
-
Jiaquan He authored
This commit reenables ClickingContextMenuDoesNotDismiss but moves it into Ash. Bug: 733662 Change-Id: If176458fd07d949c8d21082b40ed06f4f571b3d5 Reviewed-on: https://chromium-review.googlesource.com/1100675 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568200}
-
Xiaocheng Hu authored
The layout test's baseline somehow got one "PASS" line missing, making it incorrectly marked as failure. This patch corrects it. Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia0281dd694b72103b97858bfc3104766c5f4ef4c Reviewed-on: https://chromium-review.googlesource.com/1104720 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#568199}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I9ecc53ebb303b1c08ca4f21f9b948fdbfa02598c Reviewed-on: https://chromium-review.googlesource.com/1104387Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#568198}
-
Hongchan Choi authored
This CL adds EventListenerBreakPoints for the AudioContext constructor, AudioContext.close(), AudioContext.resume() and AudioContext.suspend(). Bug: 848473 Change-Id: Ifbbccfd1e21dc8b5b444993c7143e869a56d7e6c Reviewed-on: https://chromium-review.googlesource.com/1089200 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568197}
-
Morten Stenshorne authored
Floats and out-of-flow objects need to be true layout siblings of the inlines, or rendering will be wrong. This means that such objects should never be siblings of anonymous blocks, but rather inside them. This already works correctly for initial layout tree building, and also for many DOM manipulations. However, code was missing to satisfy this requirement if we removed a regular block that was a sibling of an anonymous block and either a float or out-of-flow positioned object. This even caused a crash triggered by ruby code, which ended up mixing inline and block children within the same container. That is not allowed. This happened in the MoveAllChildrenIncludingFloatsTo() call inside LayoutRubyBase::MoveBlockChildren(). Added a DCHECK to MoveAllChildrenIncludingFloatsTo() (which could fail prior to this fix); When moving children from one container to another, either both or none of the containers must have inline children. This is a reland of https://chromium-review.googlesource.com/1102690 with some modifications to avoid bug 853552. Bug: 852640 Change-Id: I0f8a0aa5523e8fe60c841164d25aad088f4b728f Reviewed-on: https://chromium-review.googlesource.com/1104900 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Splits code that loops over accessibility events from the code that loops over dirty nodes that need to be serialized. Keeps track of duplicate ids and avoids serializing the same node twice. This is a different approach than crrev.com/c/1063007 "Avoid serializing the same accessibility node twice in the same message" which tried to put all of the nodes in the same AXTreeUpdate. That approach could fail in rare cases when multiple updates both tried to set node_id_to_clear. Now we've refactored the event message so that it can contain multiple AXTreeUpdates, so it's safe to just skip an entire update if it's a node we've already serialized in this event bundle. Bug: 651614, 845778 Change-Id: I3cc859e7a63d9c8b8beeb930d96aa53898940485 Reviewed-on: https://chromium-review.googlesource.com/1097423 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#568195}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d994c8643744..f13bae2df0b8 git log d994c8643744..f13bae2df0b8 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 dtu@chromium.org [pinpoint] Update Swarming server API path. Created with: gclient setdep -r src/third_party/catapult@f13bae2df0b8 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852184 TBR=sullivan@chromium.org Change-Id: I47ed58f73a0c6e4072c160ec9810def812ec17b6 Reviewed-on: https://chromium-review.googlesource.com/1104920Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568194}
-
Peter Boström authored
Prevents DCHECK failure when turning on MD Refresh by default in tests ToolbarActionsBarUnitTest.TestHighlightMode/{0,1}. This was due to an inconsistent MD mode in the test as the browser window gets constructed and initialized with the default mode before it's overridden with ToolbarActionsBarUnitTest::GetParam(). Bug: chromium:846410 Change-Id: Id1fc1a0137d27cb4be7c5ddc32f2a2c9c203e117 Reviewed-on: https://chromium-review.googlesource.com/1102992 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568193}
-
Qiang Xu authored
This CL supports manually scale of ImageSkia for different representations, which could deliver good visual effect for reps other than 1x and 2x. Bug: 840641 Test: manual Change-Id: I7c131a76297dd565065ff67213b90349ff00206d Reviewed-on: https://chromium-review.googlesource.com/1081408Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Andrew Luo authored
Bug: 852617 Change-Id: I3d0e485ac5660e485bc23ffbf7b9069a9187ca72 Reviewed-on: https://chromium-review.googlesource.com/1100195 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#568191}
-
Sammie Quon authored
Using the approach suggested in [1]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1100235 Test: manual Bug: 845686 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I66a8cb687463c30ba2414c29245797338a49d60f Reviewed-on: https://chromium-review.googlesource.com/1103280 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568190}
-
Egor Pasko authored
For a little while we have been recording startup metrics based on main entry point time using two techniques: * (old way) by converting process creation wall time using StartupTimeToTimeTicks() * (new way) by calling base::TimeTicks::Now() The new way is theoretically cleaner and removes a few possible skews (see details in the bug). During a few months of overlap we have been computing these two histograms for the identical time interval: * (old way) Startup.BrowserMessageLoopStartTimeFromMainEntry2 * (new way) Startup.BrowserMessageLoopStartTimeFromMainEntry3 On Windows the skew between the two is super tiny (2-3 UMA samples with difference during the day). On Android the difference is between 0.5% and 0.7% for the same day for various quantiles. The overflow bucket (1 hour and more) for the new histogram is 3.5x smaller - nice. Also the new histogram looks a tiny bit smoother on Android. Overall the shape of the distribution does not change our subjective perception of the startup metrics on Android. Based on these observations this change proposes to: * Switch the remaining calculations based on the main entry point to the new way - calling base::TimeTicks::Now() (no conversion to ticks, not using the wallclock) * Avoid renaming the histograms because the expected difference is likely not worth worrying * Celebrate cleanup :) Bug: 797762 Change-Id: I5c32541280c359d6571cbcc5c6e7500b79002011 Reviewed-on: https://chromium-review.googlesource.com/1104696Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568189}
-
Geoff Lang authored
BUG=angleproject:1618 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id680ec102ea40bb2117b276e0ffa002956a750d2 Reviewed-on: https://chromium-review.googlesource.com/1101514Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568188}
-
Steven Holte authored
Bug:853907,853915 TBR=reillyg NOTRY=true Change-Id: Ib8e489de591b014a3f33da233bd55cddb56abb59 Reviewed-on: https://chromium-review.googlesource.com/1105302Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568187}
-
Zhongyi Shi authored
These test verifies that a session will migrate immediately to the alternate network when the default network disconnects. Bug: 818259, 843299 Change-Id: Id8be7a79db09cf6ec5e706e8bf6442351bdd11cc Reviewed-on: https://chromium-review.googlesource.com/1103608 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568186}
-
Jeremy Roman authored
It is a per-process Mojo interface, since the browser side never did anything per-frame, and the renderer actually caches this data process-wide anyhow. Bug: 846722 Change-Id: I8e0300749b0d1c2b055b512f0d8906c1fcd3e403 Reviewed-on: https://chromium-review.googlesource.com/1073648Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568185}
-
Istiaque Ahmed authored
Once Signal()ed, OneShotEvent should drop all the references to the tasks, otherwise OneShotEvent::tasks_ would continue to hold references to users of OneShotEvent::Post(), for the lifetime of OneShotEvent. This CL clears |tasks_| once Signal() is called, dropping those references correctly. In future, OneShotEvent::Post() will take OnceClosure instead of (repeating) Closure. This CL also adds a regression test for the same. Bug: 853649 Change-Id: I10270318ff8393a9af0b8da299a1866df936b273 Reviewed-on: https://chromium-review.googlesource.com/1103606 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Chris Harrelson authored
All of these conditions must be true for the current PaintLayer: 1. The layer is not under a non-root composited scroller, or there are no fixed/sticky descendants. 2. There are no non-contained absolute position descendants (i.e. ones whose containing block skips the current layer). 3. The current layer has overflow clip. 4. There are no direct compositing reasons on any descendant. 5. There is no currently-composited descendant. Bug:814439 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74c1ad25ec1c5c20ec3629140b6555c89676a3ac Reviewed-on: https://chromium-review.googlesource.com/1099972Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568183}
-
Findit authored
This reverts commit 7f596585. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 568084 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdmNTk2NTg1YTM4MmI3ZDIzNDQ3NDAxOTY4OTU4OGUxOTE5ZDU2OWYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27973 Sample Failed Step: unit_tests Original change's description: > cros: Make LoginDisplayHost own LoginDisplay > > Instead of this ownership model > > LoginDisplayHost owns ExistingUserController owns LoginDisplay > LoginDisplayHost owns WebUIScreenLocker owns LoginDisplay > > switch to > > LoginDisplayHost owns ExistingUserController, LoginDisplay > > This makes it clear that the LoginDisplay instance has one owner, and > that it shares the same lifetime as LoginDisplayHost. > > Bug: 851012 > Change-Id: I80cb56d8fc244ce5331046ba31defba4cd77c45f > Reviewed-on: https://chromium-review.googlesource.com/1093741 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568084} Change-Id: I144f702fc39267db2ef830b276ca3c77c2c3c262 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851012 Reviewed-on: https://chromium-review.googlesource.com/1105240 Cr-Commit-Position: refs/heads/master@{#568182}
-
Kyle Horimoto authored
Now, ConnectionAttempt uses a single ConnectToDeviceOperation throughout its lifetime, which drastically cleans up the code and removes the ConnectToDeviceOperationFactory, which is not really needed. This CL removes ConnectToDeviceOperationFactory entirely. Bug: 824568, 752273 Change-Id: Iaf8182da258e864b1377aa94cefa1ed9440e8bd1 Reviewed-on: https://chromium-review.googlesource.com/1103337 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568181}
-
Jun Choi authored
Response to CTAP AuthenticatorGetInfo command contains supported versions. Previously, the CTAP spec did not specify exactly which strings to expect for versions, but with the new spec, only 2 -- "FIDO_2_0" and "U2F_V_2" are expected to be present as versions. Bug: 851057 Change-Id: Iac1b3c45205a956e927aa2be3e6064c479b84481 Reviewed-on: https://chromium-review.googlesource.com/1093542 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568180}
-
Tim Brown authored
It turns out that openSuse decided to call the version "15.0", not "15", so we aren't currently detecting it. Also, there are two guaranteed point releases, so support for detecting those has been added already. I've also added thomasanderson@ as a co-owner of the histogram. Bug: 853354 Change-Id: I6867e13833744f4fa0013b1f505c318cc3893051 Reviewed-on: https://chromium-review.googlesource.com/1103279Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is a reland of 27f8891c The main difference from the original CL is that instead of passing raw network::mojom::URLLoaderFactory pointers, this CL takes a more conservative approach where a thread-agnostic network::mojom::URLLoaderFactoryPtrInfo instance is passed through ContentHash::FetchParams, which allows us to "bind" the network::URLLoaderFactoryPtr instance only when it is actually going to be used (in ContentHashFetcher::Start). Also, differently than the original/reverted CL, this CL does not change the threads ContentHash methods run on. Last, in order to adapt ContentVerifierHashTest, we: 1) Replace the use of net::TestURLRequestInterceptor by content::URLLoaderInterceptor. 2) Install the interceptor at the beginning of each test execution flow, so that it is able to intercept all relevant URLLoaderFactory creation requests. Some other minor differences, were because of some preparation CLs already landed, eg https://crrev.com/c/1089273. Original change's description: > Migrate ContentHashFetcher to SimpleURLLoader > > This CL migrates ContentHashFetcher away from URLRequestFetcher to > SimpleURLLoader. > > In order to accomplish this, a few other related changes are also performed: > > 1) The regular flow of the code is ContentVerifier -> ContentHash -> > ContentHashFetcher. In ContentVerifier, for instance, UI, IO and > "File tasks" threads take place. > Previously, the URLRequestFetcher logic residing in ContentHashFetcher > executed in the "file tasks" thread. > > As part of the migration from URLRequestFetcher to SimpleURLLoader > machinery, this CL also changes the ContentHashFetcher logic to > execute to the IO thread. > Note that it could be possible to keep the new SimpleURLLoader logic > in the "file tasks" thread. However, this would impose a way bigger change, > and require unittests to be considerably rewritten as well (see for > patchsets 7, 8 and 9. > The issue is that mojo objects are not thread safe. We could create a new > URLLoaderFactory for the extensions thread, but then we'd need to create a > new one when the network service crashes (Something this SharedURLLoaderFactory > one, already bound to the IOThread, magically handles), but that would be > significantly more complicated. > > 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed > to support running with the network service feature both enabled > and disabled. This is a pattern that is also present in various other > unittests. > > In summary, the migration to use SimpleURLLoader performed here includes > also a change in the thread that ContentHashFetcher runs on, but no > functionality change is expected from this CL. > > BUG=773295,844926 > > Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf > Reviewed-on: https://chromium-review.googlesource.com/1056587 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561480} Bug: 773295, 844926 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie2f3665bcca5378ff67bf78bec38bdc225ff6c26 Reviewed-on: https://chromium-review.googlesource.com/1076947 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568178}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6fd48fd329f..f5557accff71 git log f6fd48fd329f..f5557accff71 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 jmadill@chromium.org translator: Store symbol type in TField. 2018-06-18 lucferron@chromium.org SampleApps: Refactor to use cli args the same way 2018-06-18 lucferron@chromium.org Vulkan: Implement conversion to uint16 for drawElements with ubytes 2018-06-18 lucferron@chromium.org Vulkan: Fill in glslang resources with our caps Created with: gclient setdep -r src/third_party/angle@f5557accff71 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib446737a17b3795a59c61841cc3fdb7e3dffa870 Reviewed-on: https://chromium-review.googlesource.com/1104919Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568177}
-
Pedro Amaral authored
Bug: 852116 Change-Id: I558bbb8cbb2cfc614d6953ec2778e9802de26430 Reviewed-on: https://chromium-review.googlesource.com/1094325 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Nico Weber authored
Simplifies the config, and fixes an oversight were the tests were running on the regular cros bots, but not on the cros memory bots. Bug: 843511 Change-Id: I751ead56fca4adec28b991243a03cc516417ca3f Reviewed-on: https://chromium-review.googlesource.com/1104799 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568175}
-
Christopher Grant authored
At some point, the floor regressed to be non-hittable. Mark it as explicitly hit-testable. BUG=853822 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8ceda269a3e403c4fbf3eeb46709344d1faa90f Reviewed-on: https://chromium-review.googlesource.com/1104980Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#568174}
-
Nick Harper authored
Bug: 849201, b/109944165 Change-Id: I051b1af77f9434b40c9f5ca9e9357d46e3072f82 Reviewed-on: https://chromium-review.googlesource.com/1104962Reviewed-by:
-
Matt Menke authored
The causes the parameter to work when the network service is enabled. This CL disables referrers for Safe Browsing requests when the network service is enabled - none of the requests use referrers, so it seems like hooking up the kEnableReferrers pref to that NetworkContext is more effort than it's worth. Never send it rather than always send it just to make sure we respect the user's preference, when referrers are disabled. Bug: 838906 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8c9d8350bfce99e1140900f5dbcbda9eb0cc9718 Reviewed-on: https://chromium-review.googlesource.com/1087570 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#568172}
-
Becky Zhou authored
TBR=boliu@chromium.org Bug: 853816 Change-Id: Icda147b5735a5bda3abf67e296d870a120b55918 Reviewed-on: https://chromium-review.googlesource.com/1105061Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568171}
-
Ovidio Henriquez authored
This change adds Feature Policy tests for Dedicated Workers. Bug: 841510 Change-Id: I117f8a5bb61d5783b6867e7edcc9d99aff41a497 Reviewed-on: https://chromium-review.googlesource.com/1093379 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568170}
-
Reilly Grant authored
A sensor's initial reading is checked to see if an event should be fired immediately after it is activated. Unfortunately this initial reading was not actually read from shared memory. Depending on timing the reading might be refreshed by the polling timer or upon receiving a SensorReadingChanged message. This patch updates the code to take this initial reading on initialization so that we can reliably decide whether to send an initial reading event. Bug: 789515,809537 Change-Id: I96f441aad3ec474ef94fd634aa34bf9b29b9edf9 Reviewed-on: https://chromium-review.googlesource.com/1103178Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568169}
-
Andres Medina authored
Change-Id: I806de57477f1acd310bcdb7e0e7121f8d98ceeca Reviewed-on: https://chromium-review.googlesource.com/1103217Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568168}
-
Rintaro Kuroiwa authored
- The new action is for correctly ref counting the COM object. - The AddRef is required for Rules 1c and 1d defined in "Reference-Counting Rules" https://msdn.microsoft.com/en-us/library/ms810016.aspx?f=255&MSPPError=-2147217396 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ieb0e38f077b3786a77a0c415be3a703dc7f9ecca Reviewed-on: https://chromium-review.googlesource.com/1103236 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568167}
-
Bret Sepulveda authored
When Harmony is enabled textfields have an additional child in the form of the focus ring, so the expectation needed to be updated. Bug: 846410 Change-Id: I0b807d7f69c97eed7bc56e9520f51d3a845fba76 Reviewed-on: https://chromium-review.googlesource.com/1103586Reviewed-by:
-
Emircan Uysaler authored
This CL cleans up this class in preparation for future types to be added. Bug: 853843 Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 Reviewed-on: https://chromium-review.googlesource.com/1104965Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568165}
-
