- 29 Nov, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3cc809294788..935a35bce4ca $ git log 3cc809294..935a35bce --date=short --no-merges --format='%ad %ae %s' 2017-11-28 benjaminwagner Remove temporary image Swarming dimension. 2017-11-29 robertphillips Revert "Make PathGeoBuilder use consistent iterators." 2017-11-29 bsalomon Revert "Make PathGeoBuilder use consistent iterators." 2017-11-28 bsalomon Make PathGeoBuilder use consistent iterators. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I5aa9de0fa6139dae7d815a472cd16a44ee6ffd6c Reviewed-on: https://chromium-review.googlesource.com/797070Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520148}
-
Matthew Jones authored
This reverts commit 70baccad. Reason for revert: Missing import causes compile failure. Original change's description: > Disabled flaky testCallCanMakePayment() > > In PaymentRequestServiceWorkerPaymentAppTest.java. > It's flaky, see bug. > > TBR=rouslan@chromium.org,mathp@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789532 > Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac > Reviewed-on: https://chromium-review.googlesource.com/796417 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520097} TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org Change-Id: I496a3e9099f1a89a2356b035f9fc24873f963295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Reviewed-on: https://chromium-review.googlesource.com/797170Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520147}
-
Xiangjun Zhang authored
This CL added the control logic to stop/disable Media Remoting when user indicates always do traditional mirroring through the MR dialog. Bug: 788855 Change-Id: I16a81b25af3815bc89e5480db775f745a86153a3 Reviewed-on: https://chromium-review.googlesource.com/791631Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#520146}
-
Mihai Sardarescu authored
This CL also enables the feature to remove the programmatic auth endpoint from Chrome. The plan is to continue to use the finch experiment as a kill switch in case we discover any issues with the server-side signin pages. For more info, please relate to https://bugs.chromium.org/p/chromium/issues/detail?id=780808#c20 Bug: 780808 Change-Id: I786b21fcbb041fb9266e5fdfe8a42e98f3942e7f Reviewed-on: https://chromium-review.googlesource.com/793690 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520145}
-
Eric Lawrence authored
The comment suggested that "must-revalidate" might be a reason not to reuse a response. This is misleading because must-revalidate is a poorly named directive which simply means that the cache freshness lifetime should not be ignored. It does not forbid caching or require revalidation of resources within their freshness lifetime. Change-Id: Ib8e9f9c9f588fb018fc256445dc1f88bd2961a9c Reviewed-on: https://chromium-review.googlesource.com/794049Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#520144}
-
Tobias Sargeant authored
Change-Id: Ib41d0b741d76a2dc5dfc70f2369263e16980974b Reviewed-on: https://chromium-review.googlesource.com/796410Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#520143}
-
Xiaocheng Hu authored
This patch refactors ComputeInlineBoxPosition() by breaking it into: - ComputeInlineAdjustedPosition for adjusting a position into text or atomic inline anchored - ComputeInlineBoxPositionForInlineAdjustedPosition, which takes a position returned by the previous function and computes an InlineBoxPosition from it This is the first patch to convert callers of ComputeInlineBoxPosition into NG versions. The full plan is at: https://goo.gl/6WtiUm Bug: 771398 Change-Id: Ifb324939e940afb3f2afa490af4b9c5ae5bd1731 Reviewed-on: https://chromium-review.googlesource.com/786784 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520142}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/f13cadd8bd5f..54a29ffd82e7 $ git log f13cadd8b..54a29ffd8 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 oetuaho Refactor TSymbol to follow naming conventions 2017-11-27 oetuaho Fix scalarizing vec and mat constructor args Created with: roll-dep src/third_party/angle BUG=772653 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I06e2ac5b82354070505d5314e67eef11790a37ff Reviewed-on: https://chromium-review.googlesource.com/796714Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520141}
-
Bence Béky authored
Do not send HTTP/2 PING if there is a CheckPingStatus() posted on the message loop, because it might get confused about which PING to expect a response to. Imagine the following scenario: * SpdySession sends out a preface PING then a request. * A CheckPingStatus() is posted on the message loop with delay. * SpdySession receives PING ACK right away. * Later, SpdySession sends out another preface PING then another request. * CheckPingStatus() gets executed shortly after. |last_activity_time_| is when the first ACK was received. CheckPingStatus() sees that there is an outstanding PING, and thinks that it timed out (even though it was just sent), so it tears down the connection. One could make the argument that this is impossible with the current values of kDefaultConnectionAtRiskOfLossSeconds and kHungIntervalSeconds (or at least very unlikely, depending on how much one trusts PostDelayedTask() timing), but that is not very transparent. This CL introduces two functional changes. The first one is that it returns early from SendPrefacePingIfNoneInFlight() (freshly renamed to MaybeSendPrefacePing) if |check_ping_status_pending_|. There is little harm in not sending another preface PING within kHungIntervalSeconds (10 seconds) since the last preface PING was sent. The other functional change is only increment PING opaque data by one with each PING frame. "Receivers of a PING frame that does not include an ACK flag MUST send a PING frame with the ACK flag set in response, with an identical payload." according to RFC7540 Section 6.7, so this is acceptable. This CL also does some cleanup: rename SendPrefacePingIfNoneInFlight() to MaybeSendPrefacePing(), shuffle around some base::Time and base::TimeDelta in inequalities for easier readability, improve comments, inline SendPrefacePing(), and sharpen some expectations in unit tests. Bug: 784975 Change-Id: Ic278ea87041120443fc73304d266b2f7a4eb54a2 Reviewed-on: https://chromium-review.googlesource.com/779670Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520140}
-
Daniel Bratell authored
Change-Id: Idf7504a625141e1177b4fe2457608847e7120fc4 Reviewed-on: https://chromium-review.googlesource.com/797031 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520139}
-
Andrew Grieve authored
Example output for: pak_util.py print locales/zh-CN.pak version: 5 encoding: utf-8 num_resources: 3120 num_aliases: 413 size_header: 12 size_id_table: 16248 size_alias_table: 1652 size_data: 99490 total_size: 117402 Entry(id=423, canonical_id=423, size=271, sha1=bd30bee710): ... ... Bug: 749521 Change-Id: Id0c3e788c83d9e97d67b7eb6a4090ca68cb97431 Reviewed-on: https://chromium-review.googlesource.com/794340 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520138}
-
Mike West authored
Very flaky. TBR=ojan@chromium.org Bug: 789567 Change-Id: Ie457f0b626d3fe12af6f21b07fed9852c5902f13 Reviewed-on: https://chromium-review.googlesource.com/796890 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#520137}
-
Henrik Boström authored
This ships a significant portion of the RTP Media API https://w3c.github.io/webrtc-pc/#rtp-media-api This exposes: - RTCPeerConnection (existing interface) - getSenders() - addTrack() - removeTrack() - ontrack - RTCRtpSender (new interface) - track - (not shipping: replaceTrack, transport, rtcpTransport, get/setParameters) - RTCTrackEvent (new interface) - receiver - track - streams - (not shipping: transceiver) Intent to Implement & Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GnlJt54O_EY Bug: 760107 Change-Id: I281463ced5716fc305cc119c7da1e34a7be07b96 Reviewed-on: https://chromium-review.googlesource.com/790911 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#520136}
-
danakj authored
This sets up the VizProcessTransportFactory to respond to the notice that it should use software compositing. In that case it will call OnLostMainThreadSharedContext() and release all the FrameSinks from ui::Compositors. These compositors then make a new LayerTreeFrameSink coming back to the VizProcessTransportFactory. Also eliminate the call to EstablishGpuChannel if software compositing is being used, and jump right to OnEstablishedGpuChannel() with a null GpuChannelHost. R=kylechar@chromium.org Bug: 730660 Change-Id: I54feb3be3b27993c8b87a3ee30a210e540b2b1c8 Reviewed-on: https://chromium-review.googlesource.com/789553 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520135}
-
Yoav Weiss authored
The Symantec cert warning message has a typo causing the link not to work. This CL fixes that by adding a white space between the word "See" and the link itself. Bug: Change-Id: I9ff62a634ab303feea4d74a89101525e78d97bc3 Reviewed-on: https://chromium-review.googlesource.com/795728Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#520134}
-
Jérôme Lebel authored
This method should have been removed with crrev.com/735722. It was called by BookmarkHomeViewController. This code is now done by SigninPromoViewMediator. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1a1a44bec51f2bc29763354b9b382e63c5c7489a Reviewed-on: https://chromium-review.googlesource.com/796411 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#520133}
-
Abhishek Arya authored
R=mmoroz@chromium.org,ochang@chromium.org Bug: Change-Id: I2f1d8ecbdceb8583b4b387773a46966e52a21007 Reviewed-on: https://chromium-review.googlesource.com/796715Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#520132}
-
danakj authored
When using --enable-viz, the display compositor and thus compositing mode decisions are in the viz process (gpu process). This adds a CompositingModeReporter to the viz process, that is connected to the browser process when it sets up its connection to the FrameSinkManager. Then the browser process owns a ForwardingCompositingModeReporterImpl which watches the gpu process' authoritative reporter, and acts as a CompositingModeReporter for other compositor clients (eg renderers) in the same way that the authoritative one would from the browser when not running viz. The BrowserMainLoop makes one or the other type of reporter, and connects clients to it. The VizProcessTransportFactory connects the forwarding one to the authoritative one, and reconnects it on gpu process restart. R=kylechar@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9d9995fabf192c5ca470551f73322b5215628bc2 Reviewed-on: https://chromium-review.googlesource.com/788139Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#520131}
-
clamy authored
This CL ensures that the upgrade-insecure-request header is properly set on navigations when PlzNavigate is on and that it is before the user-agent one as some websites (e.g. hertz.com) seem to expect this. BUG=776164 Change-Id: Ib388dcd640c8042c458b21c5edfb6768e145e278 Reviewed-on: https://chromium-review.googlesource.com/793712 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#520130}
-
Antonio Gomes authored
Today, X11WindowBase::SetBounds bails out earlier when it is called on a hidden window (i.e. when X11WindowBase::Show has not been called yet). Although this is Ok for ChromeOS/Ozone, where a native window corresponds to a physical display, and accurate bounds provided at its creation time, this breaks several cases in "external window mode" (Linux/Ozone). For instance, tooltips (which chrome/x11 has its on native window for) are created with arbitrary temporary bounds - see DesktopWindowTreeHostX11::Init, where 100x100 is used. When bounds are available, DesktopWindowTreeHostX11::SetBoundsInPixels is called, and only then DesktopWindowTreeHostX11::ShowImpl. In 'external window mode', this behavior is also mimic'ed: arbitrary (and temporary) bounds are also set so that an Ozone window is properly created, but prior to showing it, Aura/Mus is expected to set proper bounds to it. As is, Ozone's X11WindowBase, breaks this flow, since ::SetBounds conditions its execution to 'X11WindowBase::window_mapped_' being true, an attribution done in X11WindowBase::Show. CL changes ozone/x11 so that it mimics chrome/x11 behavior, allowing tooltips to be supported in external window mode, without changes in on client side. BUG=666958 Change-Id: Icc0490fe011ce3e19f08f161c7c0ff6cef9ef8f5 Reviewed-on: https://chromium-review.googlesource.com/791290 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520129}
-
Jose Dapena Paz authored
Build was broken in GCC for Linux, with ATK enabled. There were two methods with same name ax_platform_node_auralinux_get_attributes. One for AtkDocument, and the other for AtkObject. Rename AtkDocument interfaces to avoid the problem. Bug: 789525 Change-Id: I05560a98befccb913c5ea6b2bcd403360662464e Reviewed-on: https://chromium-review.googlesource.com/796471 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520128}
-
Alex Clarke authored
Bug: Change-Id: Iac5361077c24160af5a73a42f5bdd4e74309cf16 Reviewed-on: https://chromium-review.googlesource.com/796671Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#520127}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5d27a6a..c1a3627c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia0b807e733a0ff3e544311e89624d7bd88615f51 Reviewed-on: https://chromium-review.googlesource.com/796590Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#520126}
-
Bo Liu authored
Two independent signals cause a binding to be added to the moderate binding pool. * view becomes invisible, ie when it drops strong binding * view no longer has pending views, ie when it drops the initial binding. (Previously, this was the onDeterminedVisibility signal) So the assert that a connection is only added once does not actually hold. The assert was added to make sure the moderate pool only adds a single refcount on the moderate binding. So turn the assert into a runtime check instead. Also add back the old comment explaining why the second signal exists. Bug: 689758 Change-Id: I50471eee598dbf57108b91fc478d34b0bbee0e6b Reviewed-on: https://chromium-review.googlesource.com/795094Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520125}
-
Erik Chen authored
Updated the list of on-going projects. Updated the metrics section. Bug: Change-Id: Ic981596ce74aca0afdcdc7ceea95dcccab123ad0 Reviewed-on: https://chromium-review.googlesource.com/795430Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520124}
-
Henrik Boström authored
TBR=bsazonov@chromium.org,bauerb@chromium.org,iuliah@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789531 Change-Id: Iffeb007f1c4181cb72553298d98c9f332ce19ea3 Reviewed-on: https://chromium-review.googlesource.com/797030Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520123}
-
Henrik Boström authored
This reverts commit 85afef48. Reason for revert: Forgot to import DisabledTest Original change's description: > Disable flaky testAutoDismissPromo() > > TBR=bsazonov@chromium.org,bauerb@chromium.org,iuliah@google.com > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789531 > Change-Id: I9ffa24762c4bd4f3b4d700acc827af8e5aca6eaf > Reviewed-on: https://chromium-review.googlesource.com/796610 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520098} TBR=bauerb@chromium.org,hbos@chromium.org,bsazonov@chromium.org,iuliah@google.com Change-Id: I61722964a5ef5298d08cca37a6b188d0bc6a62c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789531 Reviewed-on: https://chromium-review.googlesource.com/796893Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520122}
-
Ian Vollick authored
With this change, you can simulate accepting voice search permissions and issuing a query. TBR=cjgrant@chromium.org Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1e1ae183c02255632d67cd8c051f09577255952e Reviewed-on: https://chromium-review.googlesource.com/796453Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#520121}
-
Maksim Sisov authored
This is change doesn't bring any functionality change, but takes X11WindowOzone as an event_grabber instead. X11WindowOzone will be passed back to X11WindowOzone on request once events come and the events will be rerouted to that window once explicit grab is set. Bug: 707406 Change-Id: If35e5de10701e5eb71453ec19d007bcd2b699531 Reviewed-on: https://chromium-review.googlesource.com/790772 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#520120}
-
Leon Scroggins III authored
We had a bug where GIFs with opaque first frames but transparent later frames failed to decode. Add a test that confirms it is fixed. crbug779261.gif is a modified version of gif-loop-count.gif which triggers the bug by having no transparent index in frame 0 and a valid (though unused) transparent index in its independent frame 1. Bug: 779261 Bug: 780878 Change-Id: I0c07b7105cdf1c17a148e074279b0e3df7235df8 Reviewed-on: https://chromium-review.googlesource.com/753841 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#520119}
-
Peter Beverloo authored
Not everybody uses Eclipse or Android Studio, so refer to the Android AOSP code style that both configuration files follow. Bug: Change-Id: Id436a59173c43135e6d3b419b1592b5a1552c5c3 Reviewed-on: https://chromium-review.googlesource.com/794134Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#520118}
-
Henrik Boström authored
Despite the [ Linux ] flake, Linux Tests still report this an unexpected failure. Speculatively making it unconditional in case there is some magic going on with "virtual/gpu" paths. TBR=junov@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789533 Change-Id: Ib45fe81d6327874c259249f8863e938f5d4791bd Reviewed-on: https://chromium-review.googlesource.com/796853Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520117}
-
Miguel Casas authored
Change-Id: I094f62917131e4c20557aa7edc1ab7b0de65eebe Reviewed-on: https://chromium-review.googlesource.com/794534Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#520116}
-
Robert Ma authored
This is a reland of cd0c516c Compared with the original CL, this one instantiates self.wpt_git after local_wpt.fetch() to ensure local_wpt.path exists so that Git.__init__ does not throw. Original change's description: > Refactor wpt-import to use common.checkout.git > > Some methods are not currently supported by common.checkout.git, and > Git.run is used in such cases for now. Later we would like to port some > of them (the reusable ones) to common.checkout.git. > > Bug: 676399 > Change-Id: I42459221c684f8ffeabb9991a64dea3489663d19 > Reviewed-on: https://chromium-review.googlesource.com/793984 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519777} Bug: 676399 Change-Id: I919064f5599a1b503a9ce5db927cc6713d9f428f Reviewed-on: https://chromium-review.googlesource.com/794610Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#520115}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1ba5bfe59056..3cc809294788 $ git log 1ba5bfe59..3cc809294 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 angle-deps-roller Roll skia/third_party/externals/angle2/ 57ea533f7..f13cadd8b (1 commit) Created with: roll-dep src/third_party/skia BUG=789029 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Iedf55657af2a5f6a50ab047e36cb823abf7783c9 Reviewed-on: https://chromium-review.googlesource.com/795791Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520114}
-
Henrik Boström authored
Failures have been detected on multiple platforms, removing the conditional to only disable on Linux. TBR=dtapuska@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789096 Change-Id: I725cf5059b19cf7eaba1e09a0f45097c1e74b223 Reviewed-on: https://chromium-review.googlesource.com/796831Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#520113}
-
stkhapugin@chromium.org authored
Separates LocationBarView into its own file and adds necessary includes. Bug: 788636 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1999c8b4ab7798d5d7c1c4b5352b1c22679a733d Reviewed-on: https://chromium-review.googlesource.com/759783 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#520112}
-
Fredrik Söderquist authored
Basic tests for 'fill-box' and 'view-box' with various viewport configurations. Bug: 595829 Change-Id: I81ec92e958c5ec240c7932219371b6c5369f5ac5 Reviewed-on: https://chromium-review.googlesource.com/796211Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#520111}
-
Yaron Friedman authored
We stopped building these builds 1.5 years ago: https://chrome-internal-review.googlesource.com/256541 Change-Id: Iabe92b32e5cc16cb9b34749efcd9dff2fe6496ea Reviewed-on: https://chromium-review.googlesource.com/794094Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520110}
-
Gauthier Ambard authored
When the language of the device is changed, the suggestions should be displayed in the new language. This CL clears the cached suggestions when the language is changed. Bug: 765164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I12894c18531c8d1771d6c7e0d2b6c558ba9ce110 Reviewed-on: https://chromium-review.googlesource.com/737631 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#520109}
-