GitLab

BUG=

Review-Url: https://codereview.chromium.org/2948623003
Cr-Commit-Position: refs/heads/master@{#480960}

Now that core/imagebitmap/ exists, it's surprising for its namesake to be in
core/frame/ instead. This CL is pure code movement.

TBR=haraken@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibbd256b6e40c85fedb47ed644595c2ec202156a4
Reviewed-on: https://chromium-review.googlesource.com/541019
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480959}

Follow-up to crrev.com/2911573002. There was a regression with a later
refactor of the ink drop code, and this fixes that.

BUG=652510

Review-Url: https://codereview.chromium.org/2939043005
Cr-Commit-Position: refs/heads/master@{#480958}

https://skia.googlesource.com/skia.git/+log/ffa8484eb061..49b7b6f38fc9

$ git log ffa8484eb..49b7b6f38 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 brianosman Handle too many (or too large) paths in GrDefaultPathRenderer
2017-06-20 csmartdalton Add makeBuffer and caps to GrOnFlushResourceProvider

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I245f9f94d35e7122e19005d4036f38d5d1d58039
Reviewed-on: https://chromium-review.googlesource.com/541618Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480957}

This reverts commit ce6be2e5.

Reason for revert: This CL along with https://chromium-review.googlesource.com/c/536915/ broke a variety of external
url tests on ipad 32-bit configs.

Original change's description:
> Add the header section to ContentSuggestions
> 
> ContentSuggestions is supposed to replace the current NTP and display the logo
> and the fake omnibox.
> This CL adds the section which will contain the header to the content suggestions.
> 
> Bug: 700375
> Change-Id: I4b9eac70b0464b3e289daf036323398b7704ba9f
> Reviewed-on: https://chromium-review.googlesource.com/538693
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480763}

TBR=lpromero@chromium.org,gambard@chromium.org

Change-Id: I4b6d25b4852428d73f077168cba57d302dd5ca8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 700375
Reviewed-on: https://chromium-review.googlesource.com/541760Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480956}

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #5 id:80001 of https://codereview.chromium.org/2941293003/ )

Reason for revert:
Caused build failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/19709

Original issue's description:
> mac: Roll hermetic toolchain to Xcode 8.3.2.
>
> Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
> 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.
>
> BUG=624049
>
> Review-Url: https://codereview.chromium.org/2941293003
> Cr-Original-Commit-Position: refs/heads/master@{#480685}
> Committed: https://chromium.googlesource.com/chromium/src/+/abd9ba0ebfca0ce7a37c14593d55ebee56c4a55c
> Review-Url: https://codereview.chromium.org/2941293003
> Cr-Commit-Position: refs/heads/master@{#480918}
> Committed: https://chromium.googlesource.com/chromium/src/+/7f8f750fffcee0e256c228655e9d331f2dcb6f58

TBR=dpranke@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624049

Review-Url: https://codereview.chromium.org/2946133002
Cr-Commit-Position: refs/heads/master@{#480955}

R=rdevlin.cronin@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2948443003
Cr-Commit-Position: refs/heads/master@{#480954}

Revert of clang/win: Temporarily slow down renderer startup by 0.1s (patchset #1 id:1 of https://codereview.chromium.org/2944033004/ )

Reason for revert:
Dev channel was cut.

Original issue's description:
> clang/win: Temporarily slow down renderer startup by 0.1s
>
> We're trying to understand why a certain metric is a bit higher with clang
> than with MSVC.  We think this might be due to slower renderer startup, but
> we're not sure.  Slow down renderer startup so we can measure if this is the
> reason.
>
> BUG=728324
>
> Review-Url: https://codereview.chromium.org/2944033004
> Cr-Commit-Position: refs/heads/master@{#480707}
> Committed: https://chromium.googlesource.com/chromium/src/+/51a2f1e6d3a9edc207bbc096a827153b1a23d316

TBR=avi@chromium.org,kinuko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=728324

Review-Url: https://codereview.chromium.org/2949913002
Cr-Commit-Position: refs/heads/master@{#480953}

Bug: 733526
Test: browser_tests
Change-Id: Ia098210f38039221c1b4fcc7ee25c83f93cfb55c
Reviewed-on: https://chromium-review.googlesource.com/541679
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480952}

crbug.com/733024 is actually a CSS style issue. This CL also fixes other
obvious style issues for right-to-left languages. We may need to further
polish the UI for rtl languages and those changes will be included in
a specific polish CL.

BUG=733024

Review-Url: https://codereview.chromium.org/2947933002
Cr-Commit-Position: refs/heads/master@{#480951}

Removes DataUse as a friend of DataUseAscriber.
Improves ChromeDataUseAscriber by making repeated code to a private
function.

BUG=733417

Review-Url: https://codereview.chromium.org/2950603003
Cr-Commit-Position: refs/heads/master@{#480950}

This keeps the property of compiling the code on all platforms,
while removing the need to have a ton of individual per-test ifdefs.

For tests that are later disabled for other reasons, this can result
in DISABLED_ prefix appearing two times, but that doesn't seem too
problematic and the code cleanup benefits outweigh that.

BUG=none

Review-Url: https://codereview.chromium.org/2947023002
Cr-Commit-Position: refs/heads/master@{#480949}

Break the dependency on LayoutObject for NinePieceImage painting and for
border painting by updating NinePieceImagePainter to instead take a Node
and a ImageResourceObserver reference. Also moves border painting to the
BoxPainterBase class as border painting can now be shared with LayoutNG.

R=pdr@chromium.org
BUG=714962
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2942123002
Cr-Commit-Position: refs/heads/master@{#480948}

Crash reports for https://crbug.com/723414 show a crash in a CHECK()
of profile type being used to create a new browser window via
Browser::Browser(), specifically:

  CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
      << "Only off the record browser may be opened in guest mode";

This cl forces SessionStartupPref::GetStartupPref() to return default
startup prefs for guest profiles.

R=sky@chromium.org
BUG=723414

Review-Url: https://codereview.chromium.org/2927853002
Cr-Commit-Position: refs/heads/master@{#480947}

The refactor https://chromium-review.googlesource.com/536475 lost a pair of
parentheses, so the division by epsilon_seconds was just dividing one of the
matrix elements instead of the difference. This broke angular velocity
calculation.

BUG=735155

Review-Url: https://codereview.chromium.org/2947843003
Cr-Commit-Position: refs/heads/master@{#480946}

BrowserThread::FILE is deprecated in favor of the post_task API.

BUG=689520

Change-Id: Ib93ffbf44c692f7effdcc717c20ddca6ceed0e74
Reviewed-on: https://chromium-review.googlesource.com/540668Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480945}

BUG=733722
TEST=manually with flag --force-device-scale-factor=2

Review-Url: https://codereview.chromium.org/2947003002
Cr-Commit-Position: refs/heads/master@{#480944}

Review-Url: https://codereview.chromium.org/2944253002
Cr-Commit-Position: refs/heads/master@{#480943}

Modifies the ARC account provisioning for Active Directory users.
Does not show a ToS page since for AD users both arc-enabled and
metrics-enabled policies are always managed and the backup-and-
restore and location-services prefs are unused as DM server creates
LaForge accounts for AD users.
Instead, shows a page informing the user that they have to
authenticate with Active Directory. This is necessary to prove the
user's identity to DM server for creating the LaForge account. The
prove of identity works through a SAML flow.
ArcActiveDirectoryEnrollmentTokenFetcher pops up a browser window
connecting to AD Federation Services. Without the shown page, it
would be weird to pop up a browser window that might ask for
credentials.
The backup-and-restore and location-services prefs are left untouched
at their defaults, which is off.

BUG=chromium:728188
TEST=out/Release/unit_tests --gtest_filter=Arc*

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f6a63038705e71d29a92557a2b62325eae23d0b
Reviewed-on: https://chromium-review.googlesource.com/521502Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480942}

Revert of Change memory dumps to not use periodic dumps by default. (patchset #3 id:40001 of https://codereview.chromium.org/2912483002/ )

Reason for revert:
This breaks periodic dumping on Android. Reverting.

Original issue's description:
> Change memory dumps to not use periodic dumps by default.
>
> The only consumer that requires periodic dumps [and doesn't specify an explicit
> dump config] is Chrome tracing, so explicitly specify a periodic dump config
> there. Remove by default the periodic dump config.
>
> BUG=726393
>
> Review-Url: https://codereview.chromium.org/2912483002
> Cr-Commit-Position: refs/heads/master@{#475608}
> Committed: https://chromium.googlesource.com/chromium/src/+/0529413d84c06f3720bf4a56b28bb2c7358cefd1

TBR=primiano@chromium.org,ssid@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=726393

Review-Url: https://codereview.chromium.org/2952693002
Cr-Commit-Position: refs/heads/master@{#480941}

Chromoting host no longer needs API Key, so the key can be removed.

Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d
Reviewed-on: https://chromium-review.googlesource.com/540035Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480940}

We now have enabled external/wpt/2dcontext in our layout tests, and that
covers everything that is in the LayoutTests/canvas/philip dir.

This CL will be the first step to remove redundant canvas layout tests.
Basically I removed everything under canvas/philip/. There are 7 tests
under LayoutTests/canvas dir, and I moved them to fast/canvas/. With that,
some of the expectation files are updated. To sum up, this CL removes
more than 800 layout tests without loss of test coverage, and it should
not cause behavior change at all.

Bug: 725651
Change-Id: I3d187a2f283d8ad5615eea3ae18fe77a5b3da28e
Reviewed-on: https://chromium-review.googlesource.com/538597
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480939}

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2945513003
Cr-Commit-Position: refs/heads/master@{#480938}

This reverts commit 1d629632.

Reason for revert: Failures on Win7 Debug (NVIDIA). See crbug.com/735175.

Original change's description:
> gpu: Add message filter destructor stack traces to crash keys.
> 
> base::debug::Alias values don't show up in minidumps. Using crash keys
> is recommended for use-after-free bugs in the following doc:
> http://dev.chromium.org/developers/debugging-with-crash-keys
> 
> R=​jbauman,rsesek,sandersd
> BUG=729483
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I8fd129daf66dc9235307a28fe5cd7a6c23b85a94
> Reviewed-on: https://chromium-review.googlesource.com/538056
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: John Bauman <jbauman@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480879}

TBR=jbauman@chromium.org,sandersd@chromium.org,sunnyps@chromium.org,rsesek@chromium.org

Change-Id: Ic7a35e90b386234652835cd463911f6ad9b0d332
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 729483
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/541756Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480937}

Bug: 734102
Change-Id: I626132775aba216400a0c0b536ec4a65797b7430
Reviewed-on: https://chromium-review.googlesource.com/538237
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480936}

BUG=734442

Review-Url: https://codereview.chromium.org/2949883002
Cr-Commit-Position: refs/heads/master@{#480935}

//device/generic_sensors already has all the sensors that can be used
to implement the DeviceOrientation event:
https://w3c.github.io/deviceorientation/spec-source-orientation.html

Currently, //content/renderer/device_sensors uses sensors from
//device/sensors as its backend, and this is one of the CLs that refactor
//content/renderer/device_sensors to use sensors from
//device/generic_sensor as the backend and removes //device/sensors.

This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor.

The issue page contains the design doc link for this change.

BUG=721427

Review-Url: https://codereview.chromium.org/2896583005
Cr-Commit-Position: refs/heads/master@{#480934}

The most important thing that this gives us is the symbolizer data
dependencies in //base (for producing symbolized stack traces on the
swarming bots) but it also allows us to clean up the gn files in a
few places.

R=thakis@chromium.org
BUG=732652

Review-Url: https://codereview.chromium.org/2943863002
Cr-Commit-Position: refs/heads/master@{#480933}

Adds localization for the custom schedule slider legend
marker lebels, as well as the time bubbles.

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2951483003
Cr-Commit-Position: refs/heads/master@{#480932}

TBR=rockot@chromium.org

BUG=NONE

Review-Url: https://codereview.chromium.org/2951743003
Cr-Commit-Position: refs/heads/master@{#480931}

This CL removes some js includes that don't appear to be in use any longer.

BUG=677338

Review-Url: https://codereview.chromium.org/2944743002
Cr-Commit-Position: refs/heads/master@{#480930}

OnSurfaceCreated is not called for pre-existing surfaces. This leads
to the DisplayScheduler ignoring expected surface damage. This patch
removes the use of OnSurfaceCreated and initializes tracking state in
OnSurfaceDamageExpected instead.

Bug: 734942, 697086
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I737293e3b72202aa5fc7fdb4dd6aab4937aabea7
Reviewed-on: https://chromium-review.googlesource.com/541278
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480929}

Running the static_initializers tool on the canary build of
chrome_child.dll showed a few dozen static initializers. It was run like
this:

    > tools\win\static_initializers\static_initializers.exe chrome_child.dll | find "obj/" | find "initializer"

Many of these are trivially avoidable by tagging the objects in question
as constexpr. This saves some startup cost, some code size, and it
avoids creating so many private pages in the data segment. Testing with
a non-official 32-bit release build shows that this change avoids eight
static initializers. Once we switch to VC++ 2017 we will be able to use
constexpr in more places.

The static keyword was removed in a few places because it is redundant
to const/constexpr.

The effect on non-VC++ builds is unknown. It should be strictly
neutral or an improvement.

BUG=341941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2942273002
Cr-Commit-Position: refs/heads/master@{#480928}

After https://codereview.chromium.org/2872343003/ dispatching to input method
has moved to WindowEventDispatcher, which should also work for Cast.

BUG=NONE

Review-Url: https://codereview.chromium.org/2946973002
Cr-Commit-Position: refs/heads/master@{#480927}

BUG=

Review-Url: https://codereview.chromium.org/2948683002
Cr-Commit-Position: refs/heads/master@{#480926}

Cr-Commit-Position: refs/heads/master@{#480925}

TBR=charliea@chromium.org

Bug: 735107,713222
Change-Id: I514c99a7cf93c4f90ba00f6ee9afd7044fb805ff
Reviewed-on: https://chromium-review.googlesource.com/541617Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480924}

This field indicates whether a tab is in a visible window. It will
be used to allow tabs in non-visible windows to be discarded.

This CL does not change any observable behavior.

Bug: 731145
Change-Id: I00206e5213da1cfbefd056fe4f66ac3571334847
Reviewed-on: https://chromium-review.googlesource.com/539855Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480923}

https://codereview.chromium.org/2925073002/ moved this from blink to
base. This doesn't seem to be exposed from musl so filed bugs and
stubbed (as it doesn't compile right now.)

Bug: 706592, 735087
Change-Id: I106eb6875d4ba7b283d831ba33aded5f850c9e1b
Reviewed-on: https://chromium-review.googlesource.com/541655Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480922}

This test is flaky on all platforms:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fblending%2Fbackground-blend-mode-gif-color-2.html&testType=webkit_tests

TBR=schenney@chromium.org

Bug: 734422
Change-Id: Id3a880f6514e7f6b31f43f91d13bf84e21f6f776
Reviewed-on: https://chromium-review.googlesource.com/540787Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480921}