Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 02 Feb, 2018 14 commits
  3. 01 Feb, 2018 26 commits
    • Junliang Yan's avatar
      Fix gn error on gcc compilation · 626ab43e
      Junliang Yan authored 
      Change-Id: Ie6b5fc49076a63b3e4be7a6c4839005d6328f9dc
Reviewed-on: https://chromium-review.googlesource.com/898122Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533856}
      626ab43e
    • Xiaocheng Hu's avatar
      [LayoutNG] Implement LocalCaretRectOfPosition() in LayoutNG · 63dbc4be
      Xiaocheng Hu authored 
      This patch finishes the NG implementation of LocalCaretRectOfPosition()
by filling the gap between NGCaretPosition and LocalCaretRect.

The implementation is a brand new one, not a conversion of the existing
implementations in LayoutText/LayoutBox::LocalCaretRect(), unfortunately,
for two reasons:

1. The existing implementations are too highly coupled to the legacy
InlineBox, such that a conversion with, e.g., templates, results in the
shattered pieces of code, making the code base even more hacky and harder
to understand.

2. The existing implementation contains some computation that seems
unnecessarily complicated (e.g., handling of TextAlign in LayoutText), which
seems replaceable by cleaner logic in the new implementation. However, it
might be risky to remove them from the legacy implementation.

Bug: 771398
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ica7ce378e028dffb47407fc490e431d769b66c6a
Reviewed-on: https://chromium-review.googlesource.com/843148
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533855}
      63dbc4be
    • Jaebaek Seo's avatar
      Type issue in WheelEventsBrowserTest · 511f364b
      Jaebaek Seo authored 
      AsyncWheelEventsBrowserTest.WheelEventTarget fails when enabling
--use-zoom-for-dsf. It assumes that all values related to scroll delta (e.g.,
document.scrollingElement.scrollTop) are integer type values, but some of them
are double values when --use-zoom-for-dsf is enabled (crrev.com/c/878103 has a
similar issue). This CL lets the test get double values instead of integer
values.

TEST=content_browsertests AsyncWheelEventsBrowserTest.WheelEventTarget on
NEXUS 5X

Bug: 737777
Change-Id: If1fc0916d72a06db7999b4d41d9ecd6886412be0
Reviewed-on: https://chromium-review.googlesource.com/897282Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533854}
      511f364b
    • Chris Harrelson's avatar
      [SPv175] Pixel-snap clips in PaintPropertyTreeBuilder. · 4e267b10
      Chris Harrelson authored 
      In SPv175 mode, we know the precise subpixel positions of every object
relative to its composited backing. Therefore we can apply pixel
snapping during pre-paint. This is also necessary because the paint
code can no longer do this pixel-snapping in SPv175 mode, as the
paired display item serialization happens in PaintChunksToCcLayer,
which by design knows nothing about paint offsets or snapping.

To support testing this in SPv1 mode, also add testing of that mode
to PaintPropertyTreeBuilderTest.cpp, and adjust test results accordingly.

Bug: 804010
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f2dbc13237c9aa6919faa6835f59ec465a06508
Reviewed-on: https://chromium-review.googlesource.com/896602
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533853}
      4e267b10
    • Mohammad Refaat's avatar
      Revert "Add UKM SecondaryPassphraseTest" · 9b60ddbd
      Mohammad Refaat authored 
      This reverts commit cb060c31.

Reason for revert: Failing in 
https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fipad11-device-x64%2F3061%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_integration_egtests__iPad_Air_2_iOS_11.2.1__on_iOS-11.2.1%2F0%2Fstdout

Original change's description:
> Add UKM SecondaryPassphraseTest
> 
> Bug: 793082
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I2576f1ae6d40bb20fa641bfaf24089db4dd5e29e
> Reviewed-on: https://chromium-review.googlesource.com/884941
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533520}

TBR=rkaplow@chromium.org,holte@chromium.org,lpromero@chromium.org

Change-Id: Ibab7e13f9e611ad2232c3f3574aeaf1f66737526
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793082
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/898463Reviewed-by: default avatarMohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533852}
      9b60ddbd
    • Tommy Steimel's avatar
      Revert "Let StoragePartition wait for localstorage deletions" · 27682035
      Tommy Steimel authored 
      This reverts commit 9a5b79ce.

Reason for revert: Causing failures on the Linux Chromium OS ASan LSan Tests bot (94% confidence from FindIt):

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25968

Failures:
ExtensionAppModelBuilderTest.Uninstall
ExtensionAppModelBuilderTest.UninstallTerminatedApp
DualBadgeMapTest.ArcAppToExtensionMapTest

Example error message:
==21659==ERROR: LeakSanitizer: detected memory leaks

Original change's description:
> Let StoragePartition wait for localstorage deletions
> 
> This CL changes StoragePartition to wait for localstorage deletions
> to finish before calling its callback.
> 
> Some extension tests can leak memory because they don't wait until
> StorageParitition deletions are finished. This CL adds a method to
> StoragePartition to check if it is done and changes extension tests
> to always wait for StoragePartition.
> 
> Bug: 796151
> Change-Id: Ica6f6ef47457eb34f82923ec6ae144f6b5b67fda
> Reviewed-on: https://chromium-review.googlesource.com/852234
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533707}

TBR=rockot@chromium.org,mek@chromium.org,jochen@chromium.org,dullweber@chromium.org

Change-Id: I2e7dd6dc7d88964b88963278daeb40cc33f6c0b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 796151
Reviewed-on: https://chromium-review.googlesource.com/898462Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533851}
      27682035
    • v8-autoroll's avatar
      Update V8 to version 6.6.136. · 03a3e013
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/595a0288..ad9e8781

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic60b3558f353d967f3e713ccb017449a322d9a53
Reviewed-on: https://chromium-review.googlesource.com/898042Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533850}
      03a3e013
    • Eric Willigers's avatar
      CSS: WPT for basic-shape <position> parsing · 9e38f656
      Eric Willigers authored 
      Test that basic shapes support the <position> grammar
https://drafts.csswg.org/css-shapes/#typedef-basic-shape
https://drafts.csswg.org/css-values-4/#typedef-position

and not the additional forms allowed by the <bg-position> grammar
https://drafts.csswg.org/css-backgrounds-3/#propdef-background-position

Blink has deprecated <bg-position> support in basic shapes
(and other contexts other than background-position), so the expected
failures are while we wait for removal in M68.

BUG=804187

Change-Id: Ifcaa72f42f2b63730ec761bf4fff4d4557f82b75
Reviewed-on: https://chromium-review.googlesource.com/897071Reviewed-by: default avatarnainar <nainar@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533849}
      9e38f656
    • Elliot Glaysher's avatar
      Remove file handling from ScreenshotGrabber. · 685b3cd4
      Elliot Glaysher authored 
      This is the first patch in a series to make screenshots work in
mash. This first step is simplifying ui::ScreenshotGrabber into a
component that can be used without the filesystem. This moves file
writing to the chrome layer, switches to callbacks, and starts
separating ChromeScreenshotGrabber into the part that initiates a
screenshot (will be replaced with an ash side delegate that communicates
over mojo) and the part that accepts the data and writes it to the
filesystem (which will continue to exist and stay in chrome).

Change-Id: Ic2370e0d4426f51ffd09af8920304b98b8ebde0e
Bug: 706246
Reviewed-on: https://chromium-review.googlesource.com/894882Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533848}
      685b3cd4
    • Christopher Cameron's avatar
      viz/mac: Update SetShowPrimarySurface after navigation · e6454017
      Christopher Cameron authored 
      After navigation, the surface id changes, but no call is made to
SetShowPrimarySurface, to tell the ui::Compositor to draw this
surface. Add a call to DelegatedFrameHost::WasResized to cause
this to happen.

Bug: 772576
Change-Id: I33e1fd509e3666f07a4f9a86aa600dc54adac733
Reviewed-on: https://chromium-review.googlesource.com/894197
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarSaman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533847}
      e6454017
    • Dmitry Gozman's avatar
      Rebaseline some stale http/tests/devtools tests · f4cf63ed
      Dmitry Gozman authored 
      Bug: none
Change-Id: Ia2c096b249a6e14a5faabd12895883fda1e38361
Reviewed-on: https://chromium-review.googlesource.com/898100Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Reviewed-by: default avatarAndrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533846}
      f4cf63ed
    • Emily Stark's avatar
      Add HTTP-Bad Phase 3 experiment to field trial testing config · 1b6c18ab
      Emily Stark authored 
      Some browser tests needed to be updated accordingly. I deleted a couple
that were redundant with tests where the field trial is enabled. For a
few others that only made sense in the pre-field trial world, I just
disabled the feature for them, though we'll want to clean them up
eventually after the field trial launches.

Bug: 807062
Change-Id: I480b2527375368d6146c1ddace2551dece9ec596
Reviewed-on: https://chromium-review.googlesource.com/891677Reviewed-by: default avatarEric Lawrence <elawrence@chromium.org>
Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533845}
      1b6c18ab
    • Tommy Steimel's avatar
      Revert "Show Variations info in cmd format in about:version." · 6788e47a
      Tommy Steimel authored 
      This reverts commit 5b240cfb.

Reason for revert: breaking tests on iOS bot:

https://ci.chromium.org/buildbot/chromium.mac/ios-simulator-full-configs/2677

VisibleURLTestCase/testDoubleForwardNavigationToWebUIPage:
[0201/113634.854499:FATAL:template_expressions.cc(97)] Check failed: value != replacements.end(). $i18n replacement key "variations_cmd_name" not found

Original change's description:
> Show Variations info in cmd format in about:version.
> 
> When navigating to about:version/?show-variations-cmd an additional section
> will appear showing complete set of client's variations in the command line
> formatting that can be used to reproduce the same exact state of variations.
> The displayed info contains all the trials including not activated ones
> marked by '*' along with the corresponding group assignment.
> It will also contain enabled and disabled features where the ones that should
> use the default value will be marked with '*'(e.g. expired trials).
> Trials that are unforcable through command line will be shown but warning will
> be shown when processing the command line input with unforcable trial.
> This CL doesn't cover iOS.
> 
> As the displayed text is huge I also changed the width of the text in the
> about:version page (not mobile) to be 60% of the page with a minimum of 800px
> as it used to be.
> 
> Bug: 694675
> TEST=unit test, manual testing
> 1. run chrome with --fake-variations-channel=beta
> 2. copying command line input from about:version/?show-variations-cmd
> 3. run chrome without channel but with command line input copied in step 2.
> 4. confirm about:version/?show-variations-cmd page shows the same info
> 
> Change-Id: Ie73174bd5bd1a02baa75cd3294fd36cf63b3c923
> Reviewed-on: https://chromium-review.googlesource.com/865286
> Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533742}

TBR=asvitkine@chromium.org,gayane@chromium.org,dschuyler@chromium.org

Change-Id: I81dd667cfde45c209eed9889c0785fc0587b123d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 694675
Reviewed-on: https://chromium-review.googlesource.com/898405Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533844}
      6788e47a
    • Weidong Guo's avatar
      Fix focus issue after context menu is shown · fcfb3ecc
      Weidong Guo authored 
      Changes:
Make the source view focused when the context menu for the view is
opened.

BUG=795994
TEST=AppListViewFocusTest.ItemFocusedWhenContextMenuOpened

Change-Id: Ibcc7fd5a054793d1a0abfe40fe0d04c07f00e3d3
Reviewed-on: https://chromium-review.googlesource.com/896633
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: default avatarYury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533843}
      fcfb3ecc
    • Michael Hablich's avatar
      Revert "Revert "Update V8 to version 6.6.133."" · 749c35fe
      Michael Hablich authored 
      This reverts commit 1a753dfc.

Reason for revert: Not the culprit

Original change's description:
> Revert "Update V8 to version 6.6.133."
> 
> This reverts commit e0a03346.
> 
> Reason for revert: compile failed on linux cfi:
> 
> https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604
> 
> [19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64)
> FAILED: v8_context_snapshot.bin 
> python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> ../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000)
> 0x000000000000: note: invalid vtable
> <memory cannot be printed>
> ./v8_context_snapshot_generator failed with exit code 1
> 
> Original change's description:
> > Update V8 to version 6.6.133.
> > 
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/2fc50dd0..595a0288
> > 
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> > 
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> > 
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> > 
> > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
> > 
> > Change-Id: I5634398067826ef46a257e578af8958d333caf57
> > Reviewed-on: https://chromium-review.googlesource.com/897748
> > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#533775}
> 
> TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
> 
> Change-Id: Ie2f24c3d0d5ad77e34b60ec6373ae270ddd6b0e8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/898163
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533823}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org,steimel@chromium.org

Change-Id: I558d2ab3870824849e68a2758838c4d4b2854e9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/898404Reviewed-by: default avatarMichael Hablich <hablich@chromium.org>
Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533842}
      749c35fe
    • Daniel Bratell's avatar
      Rename some history_report functions to have unique names · 693c0e85
      Daniel Bratell authored 
      In jumbo builds many cc files compile in the same translation
unit and then they share the same anonymous namespace. Having
the functions with the same names will then result in compilation
failures.

In preparation for jumbo in chrome/browser, this patch renames
a number of helper functions in chrome/browser/android/history_report
to have unique names.

An alternative would have been to make the functions static private
functions inside the classes.

Bug: 746957
Change-Id: I2df32461d170c5411418cab78abc3020dc0a8109
Reviewed-on: https://chromium-review.googlesource.com/897536Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#533841}
      693c0e85
    • Tommy Steimel's avatar
      Revert "[gin] Implement v8::Platform::GetPageAllocator." · 227b19dc
      Tommy Steimel authored 
      This reverts commit 1cc19640.

Reason for revert: compile failed on linux cfi:

https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604

[19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64)
FAILED: v8_context_snapshot.bin 
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000)
0x000000000000: note: invalid vtable
<memory cannot be printed>
./v8_context_snapshot_generator failed with exit code 1

Original change's description:
> [gin] Implement v8::Platform::GetPageAllocator.
> 
> - Implements a v8::PageAllocator in terms of base page allocator functions.
>   This will cause V8 to use Chromium's page allocator and address space
>   randomization.
> 
> Bug: chromium:756050
> Change-Id: Id076e599e7d5f09eddc78888245fc6bf879b1236
> Reviewed-on: https://chromium-review.googlesource.com/896959
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533782}

TBR=bbudge@chromium.org,jbroman@chromium.org,haraken@chromium.org

Change-Id: I220fe81ce429bf62f29a431187b8407c9740fc93
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:756050
Reviewed-on: https://chromium-review.googlesource.com/898362Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533840}
      227b19dc
    • Daniel Bratell's avatar
      Use the right ref count macros for base::Bind call · 15422458
      Daniel Bratell authored 
      chrome/browser/android/cdm/media_drm_credential_manager.cc sent
a g_browser_process->system_request_context() into a Bind call
without using any ref counting macros. That is prohibited by the
bind system but the code got away with it when the pointer
was just forward declared so that Bind didn't know that it was
a ref counted type.

In jumbo builds the compiler knew more about the return type of
g_browser_process->system_request_context() and failed to compile
because of static_asserts in bind_internal.h.

This patch adds base::Unretained() since that seems to be the
right macro for this type of value.

Bug: 746957
Change-Id: Idfc3ad9bd6708dbc5ef4f295397d05d961595b4a
Reviewed-on: https://chromium-review.googlesource.com/897535Reviewed-by: default avatarChrome Cunningham <chcunningham@chromium.org>
Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#533839}
      15422458
    • Karan Bhatia's avatar
      DNR: Introduce manifest key to specify host permissions. · 10c92aea
      Karan Bhatia authored 
      This CL introduces the "hosts" key within the "declarative_net_request" manifest
key. It is used to specify a list of match patterns. These match patterns will
then be used by DNR to evaluate whether an extension has access to a particular
request for the purpose of DNR.

The parsing of host permissions within PermissionsParser is refactored and a new
static utility method called ParseHostPermissions is introduced on the class to
parse a list of match patterns.

In subsequent CLs, the concept of hosts for DNR will be introduced in the
PermissionsSet class and DNR will start checking these host permissions.

BUG=777714, 696822
Doc=go/dnr-hosts

Change-Id: Iee31b634ce5e45c5685ad4264219cb79b70070aa
Reviewed-on: https://chromium-review.googlesource.com/888321
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533838}
      10c92aea
    • Nate Chapin's avatar
      Always assume ImageResourceConent::Fetch() will return non-null in core/css/ · ffb7e2a2
      Nate Chapin authored 
      This removes the last callers of StyleInvalidImage, so delete it.

Bug: 804409
Change-Id: I0b7cbfd9c764c7255ad7b22212add3c125902b39
Reviewed-on: https://chromium-review.googlesource.com/879409Reviewed-by: default avatarHiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533837}
      ffb7e2a2
    • James Forshaw's avatar
      Enable /DYNAMICBASE for debug builds on Windows. · 74b3d060
      James Forshaw authored 
      This CL changes the build behavior for debug builds to always pass the
/DYNAMICBASE flag which enables ASLR relocation of executables. The
removal of /DYNAMICBASE from debug builds interacts badly with the
sandbox and a new feature to add AppContainer support as the OS
enables an option to force ASLR regardless of whether an executable has
been built with /DYNAMICBASE or not. The rationale for disabling ASLR
was to simplify debugging in the WinDBG debugger due to the name
conflict between chrome.exe and chrome.dll. However due to changes
in the underlying debug engine as well as chrome_elf.dll loading
before chrome.dll this no longer makes it useful.

Bug: 807267
Change-Id: I651d2b1aa2eb970cc02e7063b5467144c69d23be
Reviewed-on: https://chromium-review.googlesource.com/897623Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533836}
      74b3d060
    • David Tseng's avatar
      Audit ChromeVox for active descendant support · 130d110e
      David Tseng authored 
      This adds active descendant to a few output rules that should have it.

Note that explicitly including the active descendant in these rules makes it possible to continue to see the entire output rule as a whole. This makes it possible to provide more intelligent output based on @message_strings, if desired.

Bug: 781840
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia3f8bb0e6613d55e080be7b6eccfbdf0ee35033e
Reviewed-on: https://chromium-review.googlesource.com/898023Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533835}
      130d110e
    • Meredith Lane's avatar
      Implement string accessors for ComputedAccessibleNode. · b0fc027b
      Meredith Lane authored 
      Adds the IDL code and accessor methods into ComputedAccessibleNode for
the intersection of properties between AccessibleNode and
AXStringAttribute. These accessors will return null strings to the
window in a few cases:
   - when the AXNode for a given matching AXID is not in the tree,
   - when the string property has not been set.

Currently, the accessors are rudimentary and require an enum
translation, although this may change in future in favour of an
individual hard coded method on the AomContentAXTree.

BUG=792783

Change-Id: Icd9cac2cb8486d549932f400b0aeeae569a1f712
Reviewed-on: https://chromium-review.googlesource.com/883863
Commit-Queue: Meredith Lane <meredithl@google.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533834}
      b0fc027b
    • angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com's avatar
      Roll src/third_party/angle/ 9dbaeba89..5c5d7deef (1 commit) · ed7de0fe
      angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com authored 
      https://chromium.googlesource.com/angle/angle.git/+log/9dbaeba89424..5c5d7deef28d

$ git log 9dbaeba89..5c5d7deef --date=short --no-merges --format='%ad %ae %s'
2018-02-01 lucferron Remove test restrictions on dEQP gles3 texture.compressedtexsubimage* tests

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ibc4a50753d2891146725eb3c593674974af374fa
Reviewed-on: https://chromium-review.googlesource.com/898098Reviewed-by: default avatarangle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533833}
      ed7de0fe
    • Dmitry Gozman's avatar
      Unflake console-xhr-logging.js · 05b4333d
      Dmitry Gozman authored 
      Bug: none
Change-Id: I2d5b7c11a77d990e9b6c243a9fa335f970f7358f
Reviewed-on: https://chromium-review.googlesource.com/898073Reviewed-by: default avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533832}
      05b4333d
    • Ulan Degenbaev's avatar
      Reland "Capture all DOM nodes reachable from V8 in heap snapshot." · b38855a8
      Ulan Degenbaev authored 
      This reverts commit 0c264842.

The new iframe test is fragile and is not properly waiting for the
iframe onload event. Since the problem is in the test, relanding
without the test for now to unblock other changes.

Original change's description:
> Capture all DOM nodes reachable from V8 in heap snapshot.
>
> This patch uses the new EmbedderGraph API to provide the heap snapshot
> generator with all DOM nodes and references reachable from V8.
>
> Bug: 749490
> Change-Id: I26750a8b80dab4f88508e504b431d976a598c6c3
> Reviewed-on: https://chromium-review.googlesource.com/890260
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>

Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711

TBR=haraken@chromium.org,alph@chromium.org

Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711
Reviewed-on: https://chromium-review.googlesource.com/897644
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533831}
      b38855a8