- 24 Aug, 2020 40 commits
-
-
Andrey Zaytsev authored
Bug: 1120824, 1070620 Change-Id: I6e9ab2cb92801f03afb5bcaba0415d7d8c35636f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372302 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#800969}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/233cb555112c..f7cf133ad5f0 2020-08-24 rohitkrishnan@google.com Fix h264 decoding on iOS Simulator by not using IOSurface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie35c8711a3bf9146d764354b00636537e4d6e5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800968}
-
Titouan Rigoudy authored
As noticed in crrev.com/c/2339972, the feature is not used in services/network anymore, only in content/. This change makes good on my promise in that CL to fix this state of things in a follow-up CL. Bug: chromium:986744 Change-Id: I633011b9eb6f5129dac0a31bdef4f0e9471c64e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366753 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..01f7fadf76bf 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3de852373f7bc1b728fa28cdc53965ad9d15fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372006Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I8a40b9ac4a9cbc3fd0933b94ec24485cf6075048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367868 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800965}
-
Mihai Sardarescu authored
This CL is the first CL that removes the feature flag kUseNSURLSessionForGaiaSigninRequests as the feature is enabled by default. A follow-up CL will also merge GaiaAuthFetcherIOSNSURLSessionBridge in GaiaAuthFetcherIOSBridge. Bug: 1101748 Change-Id: Id8ca73ca198bf3771aefabf157edf8229a84eb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366802Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#800964}
-
Benoit Lize authored
There are a few places where we access a PartitionRoot with the "wrong" thread safety template parameter. This is fragile, but also forces us to remove some DCHECK()s as their layouts don't match. This CL makes sure the layouts do match, which then removes the issue. The only downside is making PartitionRoot<NotThreadSafe> a tiny bit larger, but otherwise this does not add any runtime cost. Bug: 1092288 Change-Id: I7e24eceacd03682eab7693730a4fc7db973d6f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368874 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b3dbd0f5659..ec3fd1e6930e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: drott@google.com Change-Id: Idda835c320df8e7c95becc05cea5b9d8ab6dde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800962}
-
Richard Knoll authored
- Android expects these to be set and rejects payloads otherwise - Fixes access of |share_target| after a std::move() - Fixes transfer metadata process interpretation (0-1 vs 0-100) - Fixes FourDigitString hash from auth token Bug: None Change-Id: I88a2570d3c5b0ee772f28944914a5ae955151511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371624Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#800961}
-
Dominik Röttsches authored
Bug: 1121099 Tbr: kbabbit@microsoft.com, katie@chromium.org Change-Id: Ibb27d5f44a0e009b6b51bed344f1c7e2268ccbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371705Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#800960}
-
Takashi Toyoshima authored
This patch modifies tests that see kOutOfBlinkCors feature flag, so to make them run only with OOR-CORS enabled. BlinkCors has already been deprecated and this is part of the work to remove the kOutOfBlinkCors feature work. Bug: 1053866 Change-Id: I59d3b9c42e61641053cc74aacc99493261ad51fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368642 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#800959}
-
Jonathan Mengedoht authored
Move CreateResourceRequestToWellKnownNonExistingResourceFor to anonymous namespace. Bug: 927473 Change-Id: I9e4c1f095177d27307a67b15bbc13bd342f25e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368597 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
-
Hajime Hoshi authored
Now no samples are emitted for regular VOLT metrics after the page is restored from the back-forward cache. This means that we will miss a lot of metrics for history navigations after we launch back-forward cache. As metrics for history navigations tend to be better figures than other navigations (e.g., due to network cache), the average of such metrics values will become worse and might seem regression if we don't take any actions. To mitigate this issue, we plan to emit 0 samples for such key metrics for back-forward navigations. This is implemented behind the flag so far, and we will enable this by default when we reach the conclusion how to adjust them. Bug: 1014174 Bug: 1121066 Change-Id: I04bf9646167aaf4c7241496a12ad66be3fe92681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354369 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#800957}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a69b6010. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I1d151a884245fb7857913b1be0b01b46a9696c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371569Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800956}
-
Takashi Toyoshima authored
WebUI tests depend on kOutOfBlinkCors feature, and have feature set up code to enable it even on BlinkCORS fyi bots. Now that we turned down the fyi bots, the setup is not needed any more. Bug: 1053866, 1116928 Change-Id: I430946d5adae72f6b5f8b83f1572a27bade08b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367591Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f7edbe1f6f0..8c86f0d91767 2020-08-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f257e0ea6b9a to 983698bb34ec (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If5da03e43d8a1edba7f7115e5f28a7411ba94188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371117Reviewed-by:
-
Marc Treib authored
This extends Sync.CommitLatency.* and Sync.ConfigureFailed, which were about to expire. While we're here, also change the recording of Sync.ConfigureFailed from the macro to the function. It's recorded rarely, so no need for the macro. Bug: 1117117, 1117140 Change-Id: Ic4c793771e495adbdaef3cba17fe514b045139e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361463 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#800953}
-
Tanmoy Mollik authored
This cl creates personalized sync promo for New Tab page. Screenshot: https://crbug.com/1116038#c1 Bug: 1116038 Change-Id: I73153ec34aad74cecd8a0c7bfa9bd5c5d7fada21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353258Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800952}
-
Dominik Röttsches authored
This reverts commit d682b825. Reason for revert: Causes TSAN data race failure in new unit tests, for details see https://crbug.com/1121075 Original change's description: > Production implementation of encryption/decryption. > > Fake-* is removed, as well as virtual interface: we are using openssl and AEAD directly. > Also, decryption is moved out from Chrome, since for now we only use it in test. > Once we add it to the server, it will be placed elsewhere and probably wrapped in Java class. > > Bug: b:153649905 > Change-Id: Ib6383efa8f6b1e993e351e03f2f747043c6cb521 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363868 > Commit-Queue: Leonid Baraz <lbaraz@chromium.org> > Reviewed-by: Zach Trudo <zatrudo@google.com> > Cr-Commit-Position: refs/heads/master@{#800750} TBR=zatrudo@google.com,lbaraz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:153649905 Change-Id: Iddaf0f7dfa145d8620bfd464180537e1cbd2e2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371704Reviewed-by:
-
Christoph Schwering authored
The feature was accidentally enabled in crrev/c/2291070. Bug: 966873, 949094, 1075533 Change-Id: Ie94e25932b3f66286ddc3169a57a37d94011598c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369313 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#800950}
-
Nela Kaczmarek authored
This change modifies the response parsing to support FacetGroups. Bug: 1108279 Change-Id: Iadc6078223110c5f1b890921ba3c84cc5afbd6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362748 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Frédéric Wang authored
Logic to validate custom handlers is required on both the web and browser processes. This CL introduces a new API in third_party/blink/public/common in order to reduce duplication. As a starting point, a new helper function allows to verify whether the following condition is satisfied [1]: > If scheme is neither a safelisted scheme nor a string starting with > "web+" followed by one or more ASCII lower alphas' In order to keep this CL small, more advanced aspects like same-origin condition (currently performed in WebContentsImpl), validation of the schemes of the registered URLs [2] [3] or other tests that are currently only performed on the web process are not considered. This can be refine later if needed. This CL makes the check on the browser process slighty stronger. Previously the only requirement for URLs starting with "web+" was to be sure they are not just equal to "web+". This CL might also make verification on the web process slightly less efficient, if the conversion from WTF::String to base::StringPiece requires a buffer allocation. However, it seems unlikely to be a performance bottleneck for the current use cases. [1] https://html.spec.whatwg.org/multipage/system-state.html#normalize-protocol-handler-parameters [2] https://crbug.com/1112268 [3] https://crbug.com/64100 Bug: 971917, 952974 Change-Id: Iaada22200d7b7d834ad878bbc51cc40ea67d6332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362802 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800948}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5c24d7381a02..5a8fc1fe06a2 2020-08-24 mathias@chromium.org Improve “merges and cherry-picks” docs 2020-08-24 tvanderlippe@chromium.org Fix snippets flaky e2e test 2020-08-24 petermarshall@chromium.org css: Use :focus-visible instead of our custom data-keyboard-focus 2020-08-24 petermarshall@chromium.org components: Create a PieChart component 2020-08-24 petermarshall@chromium.org Always show :focus-visible options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I99357471dd158d620a50b6c5e895fa5c1846daa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372003Reviewed-by:
-
Fredrik Söderqvist authored
This moves DOM interface operations to the tear-off class, similarly to how SVGProperty object lists are structured. Change SVGStringListTearOff to inherit from SVGPropertyTearOffBase rather than SVGPropertyTearOff<T> since since this type is never animated, and thus does not need the ability to re-target to another object. Bug: 1106762 Change-Id: Ic8040339e3a3cdf6a818333dd77bdf15af3829ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302755Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#800946}
-
Yifan Luo authored
Reference: https://github.com/WICG/sanitizer-api/issues/22 Bug: 1116418 Change-Id: Iae2fb7bfea173cc0aad35df5b573b5d2fecfac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367864Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#800945}
-
Nela Kaczmarek authored
This change adds a new feature kChangePasswordAffiliationInfo. Bug: 1108279 Change-Id: If696d7a42002ce8cc73aefe9bdbaf971ba2aff71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367678Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b79773a35d52..4dd122392f3a 2020-08-21 andreperezmaselco.developer@gmail.com spirv-fuzz: Add words instead of logical operands (#3728) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I1c59fb9b002678f5490544397bad2c70b61d0a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371884Reviewed-by:
-
Victor Hugo Vianna Silva authored
When the user must opt in to the account-scoped password storage before saving a password, the ok button in the bubble must display "Next". Fixed: 1113126 Change-Id: Iff6e38359241344ab6ec280685bfd00ac995d4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369194Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#800942}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib4bcefeb82039b4de9809d0f7a04fc12d6f84f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371321Reviewed-by:
-
Aya ElAttar authored
1. Changed ClipboardNonBacked::GetClipboardData and to take destination as a parameter and use to use DLP. 2. Added EndpointType::kClipboardHistory to have privileged access on clipboard data. 3. Changed ash::ClipboardHistoryController to set the data source before writing it. Bug: 1117218 Change-Id: Id8c24bac064140b4123ec7b4d64688a82a791e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362289Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800940}
-
Sylvain Defresne authored
Add compiler wrapper script at build/apple/swiftc.py, define the necessary tool in the toolchain and pass the -target and -sdk through the configuration. Bug: none Change-Id: I177b8a6acf169b5c1d2399b625bdc0a82083b6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341135Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#800939}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0114ee9c6d1..5c24d7381a02 2020-08-24 mathias@chromium.org Correct backmerge doc link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I24c5fec7e97b2cb0ec2a3c8d0bc5cfa3bdd1d464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371882Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I60e3e7479d091d4bb22397233757336597ae445e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371604Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800937}
-
Maksim Sisov authored
Otherwise, it's hard to cover all the possible bots so that they use the filter file. That results in, for example, failures for linux-trusty and other bots. TBR=sky@chromium.org Bug: 1085700, 1121064, 1120811 Change-Id: I110cdebfbc4f595173922538bcb186619cd8ad79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370983 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This updates the comment to avoid the confusing include. Change-Id: Ia573fa869ffedde49901f5ca5b31a819987cd544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209775Reviewed-by:
-
David Jean authored
When Chrome is in first run state, opening a second window in incognito, blocks the UI, and doesn't show an ntp. Fixed by showing ntp on empty tab list (removed out-of-date comment) Fixed by skipping first run ui on incognito. Bug: 1113547 Change-Id: I5281acb44ea3575c157988e86b855a404488a9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362964Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#800934}
-
Eliot Courtney authored
Bug: None Test: compiles Change-Id: I28b4396fc0703451b5c4aa91365db1e5f2e45d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368799 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#800933}
-
Dominik Röttsches authored
This reverts commit a96793a7. Reason for revert: Unittest seems to compare against uninitialized value in Linux MSAN tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871321847226501376/+/steps/unit_tests/0/logs/Deterministic_failure:_VideoTutorialGroupTest.CopyAndCompareOperators__status_CRASH_/0 Original change's description: > [Video Tutorials] Add internal tutorial group. > > Bug: 1115755 > Change-Id: I481a8f6498188681216d13df32ee41436cd1306c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358056 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800642} TBR=dtrainor@chromium.org,shaktisahu@chromium.org,hesen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115755 Change-Id: I5f8b770dc4564fef953f31228c4bda5261dc6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371703Reviewed-by:
-
Roman Sorokin authored
It's been enabled since M84 Bug: 1068314 Change-Id: Id4da966c461c671f704d90ff68f88eaacfa52749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328906 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800931}
-
nancylingwang authored
From M86, we introduce the adaptive icon for all apps. So modify the icon url for FullTaskDescriptor, and use the AppService interface apps::AppIconSource::GetIconURL to fetch the adaptive icons for apps. DD: go/appservice-adaptive-icon BUG=1119545 Change-Id: Id5a67114b80127a23655f4a7087077a2eabb7543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368576 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#800930}
-
