GitLab

Previously we were using va_list for variadic arguments. The downside
for this was that only the first value from the variadic argument was
passed to the original function.

To make it work properly we have to use the __VA_ARGS__ variadic macro
that was introduces in C99 and is available in all major C/C++
compilers.

Change-Id: I50652f7348a16214811aaab8af116d78cdb70444
Reviewed-on: https://chromium-review.googlesource.com/c/1323089Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
Cr-Commit-Position: refs/heads/master@{#606588}

This was a mistake on my part when writing the original file, and it
was just too bothering to see the wrong year on the file and get
confused by it, so I had to update it :-)

Change-Id: Ia59fd264f11bda490448a386528b9b2fc0606473
Reviewed-on: https://chromium-review.googlesource.com/c/1326641Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606587}

The //chrome:chrome group was missing a data_deps declaration
on //chrome:reorder_imports, which meant that chrome would build
fine but if you ran `mb zip //out/Release //chrome` you'd only
get the copy in //out/Release/initialexe/chrome.exe and not
the final version in //out/Release.

Bug: 902010

Change-Id: I0f3b662ced4c34eef974e8bede01fb9c89410dc1
Reviewed-on: https://chromium-review.googlesource.com/c/1325554Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606586}

Changes:
Update the selected page to be the target page of dragged item at the
end of dragging.

Bug: 893832
Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
Reviewed-on: https://chromium-review.googlesource.com/c/1324851
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606585}

Add testing for the ratio metrics and fix bugs that were detected.

Rename the ratio metrics to be specific to MainFrame to prepare for future ratios.

R=pdr@chromium.org
BUG=892861

Change-Id: I01ad5d059d423366e118335ff9288e7eb2cdb339
Reviewed-on: https://chromium-review.googlesource.com/c/1320692Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606584}

Instead use operator== and operator=.

Change-Id: Ia2f694e75f3a5f22338d97ec7c4ce61e1a500996
Reviewed-on: https://chromium-review.googlesource.com/c/1324133
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606583}

The usage docs were in the wrong docstring.

Bug: 747171
Change-Id: Ia08331f8c41f86ce41c795ff1494e258c0d33bf3
Reviewed-on: https://chromium-review.googlesource.com/c/1323807Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606582}

In preparation for a series of patches that change the arguments to
UpdateAllLifecyclePhases, create a local helper in tests that do not
derive from PageTest so that only one call site needs to be changed.

There is no change in functionality at all. Tests writers no need to be
less concerned about the arguments to lifecycle updates.

R=pdr@chromium.org

Bug: 902436
Change-Id: Icee20e327aa5d88ecdc38852d41d1b9bda4e2454
Reviewed-on: https://chromium-review.googlesource.com/c/1324230
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606581}

Bug: 903204
Change-Id: I7d2cbff9184eb9f0fa93bfe14708ca719f145e7a
Reviewed-on: https://chromium-review.googlesource.com/c/1327150Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606580}

BUG=webrtc:9530
TEST=cq
R=sergeyu

Change-Id: I7c007d4dfd12aa86a56fccaef176d614531533c2
Reviewed-on: https://chromium-review.googlesource.com/c/1327151Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606579}

Fixes a bug in the existing Ranker code: the native logger cannot log
64-bit values, so we rename some misleading methods. Also fix some
references to @Nullable.

BUG=872902

Change-Id: I496c8140293200d7f8041fba1a5ede8fac26646a
Reviewed-on: https://chromium-review.googlesource.com/c/1321670Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606578}

Ash will end up maximizing the windows when they are added to the
lock screen container. Creating the widget maximized avoids some
back-and-forth with the window manager under mash. It also simplifies
testing.

Bug: 899055
Test: browser_tests
Change-Id: I168ba67c1cc7c680cd0c9a4b4a1b22c3c40bd500
Reviewed-on: https://chromium-review.googlesource.com/c/1316438
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606577}

Bug: 878390
Change-Id: Ib536680adcbba24e86452ae16502c133eef01ddc
Reviewed-on: https://chromium-review.googlesource.com/c/1256776Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606576}

WebFrameWidgetImpl was missing a call to record metrics, resulting in OOPIF not
recording main frame metrics for their update. And the SingleThreadProxy was
not recording metrics at all, which causes crashes with an upcoming patch.

R=pdr@chromium.org
BUG=902434

Change-Id: I96e4666d098ef22c2b5aec74851470319dd133f5
Reviewed-on: https://chromium-review.googlesource.com/c/1320691Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606575}

There are 15 different test scenario for password manager on each site. We therefore need to have subdirectories for different scenarios. This change adds support for 1 level of subdirectories in the password manager captured sites tests.

Bug: 847905
Change-Id: If3b52088bf857f8fcb0b42a5abcbf33ba9382055
Reviewed-on: https://chromium-review.googlesource.com/c/1325309
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606574}

In crrev.com/588115 introduced capture mouse events to widget during
text selection; and a later change crrev.com/599408 make subframe
widgets capture mouse events on MouseDown, which follows the behavior
without OOPIF.
Since we are captureing mouse events on MouseDown and release the
capture on MouseUp, we don't need to treat the text selection case
special.

Bug: 647378
Change-Id: I207777d16e11e069fb1ab60579d45324cb5b06c4
Reviewed-on: https://chromium-review.googlesource.com/c/1308606Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606573}

BUG=

Change-Id: I621c411f767d2f1442bc45db78f3562101700c27
Reviewed-on: https://chromium-review.googlesource.com/c/1322870Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606572}

Bug: 903289
Change-Id: Ibc84f1083d0cb121435418fcda226b16917d1b87
Reviewed-on: https://chromium-review.googlesource.com/c/1327223
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606571}

This is a reland of 2fc9f6f2

The crashes in flakiness were due to calling destroy() on the wrong
thread, which has been addressed in the new patch set.

Original change's description:
> tracing: Address TracingControllerAndroid test failures.
>
> Fixes the flakiness of buffer usage / known categories tests by
> resolving an accidental race condition. Also restricts disabling
> the other two tests to <= kitkat devices since those seem to be
> the only ones that show (inexplicable) flakiness.
>
> TBR=yfriedman@chromium.org
>
> Bug: 899894
> Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4
> Reviewed-on: https://chromium-review.googlesource.com/c/1307433
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604209}

Bug: 899894
Change-Id: I3cb002950f32bc6b6b4d25892adc3073c2fdb967
Reviewed-on: https://chromium-review.googlesource.com/c/1327407Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606570}

Bug: 883496
Change-Id: Ib611c2d195b401475bb343099c8b12a644e942a7
Reviewed-on: https://chromium-review.googlesource.com/c/1324095
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606569}

Bug: 875053
Change-Id: I3d798801537d6ede56d2f7acd8c26982e7291313
Reviewed-on: https://chromium-review.googlesource.com/c/1325568
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606568}

This test enables tablet mode, but it enables tablet mode in such a way
that MultiUserWindowManager doesn't see (and process) the change. When
the test is updated to correctly notify MultiUserWindowManager the test then
fails. I think this may indicate a regression from recent changes and needs
to be investigated.

I came across this while doing some refactoring to MultiUserWindowManager.

I've updated the test to ensure MultiUserWindowManager is called correctly
and disabled it.

BUG=756085,903427
TEST=none

Change-Id: I7b6ead448ba8d942516e42d9ef5ee745a547cc2c
Reviewed-on: https://chromium-review.googlesource.com/c/1327159Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606567}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b628aaf43bd1..148454cafef1


Created with:
  gclient setdep -r src-internal@148454cafef1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id2747d7d7e285f40149084ae4dc08c5ab2293bda
Reviewed-on: https://chromium-review.googlesource.com/c/1327242Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606566}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f69f7d51..993edbb4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ieba0c084f7f69570e4adf961c5f9e4b55619d424
Reviewed-on: https://chromium-review.googlesource.com/c/1327144Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606565}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I331612216739e82fb46d674aef5853b7777b7a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1325549
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606564}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I08eff200cd6d8eb2eaad989d0abcab7fc1f3d53f
Reviewed-on: https://chromium-review.googlesource.com/c/1321030Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606563}

Make MediaNotificationController a MediaSessionObserver
so it will get updates about playback state which we
can use to toggle the play pause button.

BUG=893296

Change-Id: If23dee44a1d37283a4a3e6249f3ce67553fe1593
Reviewed-on: https://chromium-review.googlesource.com/c/1311255
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606562}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 766678
Change-Id: Id08163a2526a0583da8fee44893b952945b6371d
Reviewed-on: https://chromium-review.googlesource.com/c/1325189Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606561}

This reverts commit 90619203.

Reason for revert: This work-around simply delays the inevitable; test runs still tend to have their SSH connection fail eventually, and so fail.

Original change's description:
> [Fuchsia] Disable capture of system logs via SSH'd 'dlog' on ARM64.
> 
> The 'dlog' SSH channel appears to trigger a bug that causes the package-
> upload step to fail on ARM64 under QEMU.
> 
> Bug: 900790
> Change-Id: Ie5871cef98e94deb936ae591c87a5c90a960b092
> Reviewed-on: https://chromium-review.googlesource.com/c/1325529
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606522}

TBR=wez@chromium.org,sergeyu@chromium.org,jbudorick@chromium.org

Change-Id: I3f9912cb004e64219238c24af95d6084097e768c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900790
Reviewed-on: https://chromium-review.googlesource.com/c/1327412Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606560}

This patch is in preparation for adding a "reason" to lifecycle
update calls. CHanging tests in this way means we can add the reason
with a single change for all PageTests and RendererTests.

R=pdr@chromium.org
BUG=902436

Change-Id: I21d05c13570dc94b7a0743eb5770ab5ca865a1ad
Reviewed-on: https://chromium-review.googlesource.com/c/1321779Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606559}

Also move one of the functions from discards.js into discards_tab.js
as that's the only user.

Bug: 891310
Change-Id: I434dc950029fb5e526a42dbed999a7dddc4ff6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1324101Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606558}

This CL is adding the thread id for each sampled stack event.
This will allow using multiple sampling profiler in the same process.

We are planning to sample the UI and the IO thread in the browser process.


R=ssid@chromium.org

Change-Id: Ia520c7886356fa7bf5d5f069d079125db156995d
Reviewed-on: https://chromium-review.googlesource.com/c/1310500Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606557}

R=etienneb@chromium.org

Change-Id: Ied7a5a0dd3316f105dca5d7a946081b7f08f24b2
Reviewed-on: https://chromium-review.googlesource.com/c/1323704Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606556}

Bug: 806868
Change-Id: I892da7f3a29f4cb0f4500c20e4dad04417087595
Reviewed-on: https://chromium-review.googlesource.com/c/1326505Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#606555}

Bug: 897751
Change-Id: I5e915e20b5c34438786622ce718279d908ee41c8
Reviewed-on: https://chromium-review.googlesource.com/c/1315212
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606554}

Both Canvas2D and SVG expect degenerate radial gradients
(p0 == p1 && r0 == r1) to not draw anything [1].  Canvas2D enforces this
behavior explicitly, but SVG relies on the current Skia semantics.

Skia is about to start handling this case differently [2].  This CL
updates LayoutSVGResourceRadialGradient to also enforce the spec behavior
explicitly:

  * add a DegenerateHandling flag to Gradient (all subtypes) to control
    degenerate behavior
  * when degenerates are not allowed, return an SkEmptyShader to draw nothing
  * in order to support the above, plumb SkEmptyShader in PaintShader
  * update clients to pass this new flag as required by spec
  * clean up degenerate tracking in CanvasGradient/BaseRenderingContext2D
    (no longer needed)
  * also drop the bool return type for BaseRenderingContext2D::Draw (not used)


[1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createradialgradient
[2] https://skia-review.googlesource.com/c/skia/+/168487


Change-Id: I940fcfd87907ebd2df9fae59102770a6031606e5
Reviewed-on: https://chromium-review.googlesource.com/c/1324612Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606553}

1. Tested on Mac and verify everything works as expected.
2. Removed the unnecessary call of GetNativeWindow().
3. The RGB for GPU enabled and GPU disabled test images is slightly different. Additional check is needed.

Bug: 898230
Change-Id: I85bf2450862361572597632159de60db6abf2c22
Reviewed-on: https://chromium-review.googlesource.com/c/1307062Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606552}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib1c2d571dffddf742276c28875275abe790724f1
Reviewed-on: https://chromium-review.googlesource.com/c/1321149
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606551}

base::DictionaryValue is deprecated, and we are transitioning some
internal code to use base::Value instead of base::DictionaryValue, and
it calls GetOverridenFeaturesForStorage. So here we make
GetOverridenFeaturesForStorage accept a base::Value. We do not change
the return value so that we do not break any existing usages.

Bug: Internal 119219865
Test: None
Change-Id: I61a794456b586f0a0b99dc258d13f02d10ae7646
Reviewed-on: https://chromium-review.googlesource.com/c/1321672Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#606550}

This CL removes three similar sections of code that generate histogram
names with a SecurityLevel suffix and replaces them with
a shared implementation in the security_state namespace. This is to
facilitate future growth of that histogram naming pattern.

Bug: 852479
Change-Id: Ic27bc65539108e672e64168c34dd80fa27a34b02
Reviewed-on: https://chromium-review.googlesource.com/c/1318695Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606549}