- 06 Apr, 2011 40 commits
-
-
alexis.menard@openbossa.org authored
Reviewed by Andreas Kling. [Qt] Implement fullscreen playback for the GStreamer backend. https://bugs.webkit.org/show_bug.cgi?id=56826 Implement support for fullscreen playback when building the Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1). The implementation is done in FullScreenVideoQt alongside with the Qt Multimedia support. No new tests because layout tests cover it. They are not yet activated but will be any time soon. * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: (FullScreenVideoWindow::FullScreenVideoWindow): (FullScreenVideoWindow::setVideoElement): (FullScreenVideoWindow::closeEvent): (FullScreenVideoWindow::keyPressEvent): (FullScreenVideoWindow::event): (FullScreenVideoWindow::showFullScreen): (FullScreenVideoWindow::hideCursor): (FullScreenVideoWindow::showCursor): 2011-04-06 Alexis Menard <alexis.menard@openbossa.org> Reviewed by Andreas Kling. [Qt] Implement fullscreen playback for the GStreamer backend. https://bugs.webkit.org/show_bug.cgi?id=56826 Implement support for fullscreen playback when building the Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1). The implementation is done in FullScreenVideoQt alongside with the Qt Multimedia support. No new tests because layout tests cover it. They are not yet activated but will be any time soon. * QtWebKit.pro: * WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode): * WebCoreSupport/ChromeClientQt.h: * WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler): (WebCore::GStreamerFullScreenVideoHandler::setVideoElement): (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen): (WebCore::GStreamerFullScreenVideoHandler::windowClosed): (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen): (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback): (WebCore::FullScreenVideoQt::isValid): * WebCoreSupport/FullScreenVideoQt.h: (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler): git-svn-id: svn://svn.chromium.org/blink/trunk@83078 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. [Gtk] plugins/set-status.html fails https://bugs.webkit.org/show_bug.cgi?id=57844 Unskip a newly-passing test. * platform/gtk/Skipped: 2011-04-06 Zan Dobersek <zandobersek@gmail.com> Reviewed by Eric Seidel. [Gtk] plugins/set-status.html fails https://bugs.webkit.org/show_bug.cgi?id=57844 Allow an empty status text to be dumped. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): git-svn-id: svn://svn.chromium.org/blink/trunk@83077 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Reviewed by Dimitri Glazkov. Bundle lineLeftOffset and lineRightOffset as a class https://bugs.webkit.org/show_bug.cgi?id=57851 Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset. The patch makes clear that lineLeftOffset and lineRightOffset are never read individually and only the difference is used to compute the width. * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers. (WebCore::LineOffsets::LineOffsets): Added. (WebCore::LineOffsets::width): Added. (WebCore::LineOffsets::setLeft): Added. (WebCore::LineOffsets::setRight): Added. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers. git-svn-id: svn://svn.chromium.org/blink/trunk@83076 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Dan Bernstein. Implement an optimization to the line box tree to cull out most of the intermediate line boxes that can occur between the root line box and the leaves of the tree (images and text). Source/WebCore: RenderInlines now have a boolean member, m_alwaysCreateLineBoxes, that starts off as false. Only if it gets flipped to true will there be any line boxes created for that RenderInline. * page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout is up to date. * page/SpatialNavigation.cpp: (WebCore::hasOffscreenRect): (WebCore::nodeRectInAbsoluteCoordinates): Add asserts in spatial navigation code to catch any future bad queries that might be made for rectangles without layout being up to date. * platform/graphics/FloatRect.cpp: (WebCore::FloatRect::uniteIfNonZero): * platform/graphics/FloatRect.h: * platform/graphics/IntRect.cpp: (WebCore::IntRect::uniteIfNonZero): * platform/graphics/IntRect.h: Add a new unite function that is useful for the render tree to FloatRect and IntRect. This version allows rect unites to happen if either width or height is nonzero. * rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult): Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes if content inside those inlines is hit. * rendering/InlineBox.h: (WebCore::InlineBox::logicalFrameRect): Fix a bug in this function for obtaining the logical frame rect of an inline box. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine): addToLine now also checks line gap in the line box tree optimization checks. (WebCore::InlineFlowBox::addTextBoxVisualOverflow): (WebCore::InlineFlowBox::computeOverflow): * rendering/InlineFlowBox.h: Rewritten to add the text box overflow to the text box itself. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::destroy): Destroy has been changed to call a helper function to remove and destroy the line boxes that is now called from one additional spot. (WebCore::InlineTextBox::logicalOverflowRect): (WebCore::InlineTextBox::setLogicalOverflowRect): Text boxes now cache their own overflow in a global hash table. (WebCore::InlineTextBox::baselinePosition): (WebCore::InlineTextBox::lineHeight): Changed to not assume that the parent line box's renderer is the RenderText's immediate parent, since intermediate line boxes may have been culled. (WebCore::InlineTextBox::paint): Paint now properly checks only the text box overflow instead of the parent line box's overflow. * rendering/InlineTextBox.h: (WebCore::InlineTextBox::logicalTopVisualOverflow): (WebCore::InlineTextBox::logicalBottomVisualOverflow): (WebCore::InlineTextBox::logicalLeftVisualOverflow): (WebCore::InlineTextBox::logicalRightVisualOverflow): New accessors to obtain overflow for inline text boxes. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those text boxes may not have anything in between them and the block that contains the inline first letter container. * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxes): The culling optimization is done here. Only if the RenderInline says that boxes are allowed will they be created. (WebCore::RenderBlock::layoutInlineChildren): The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed. This is done before any lines are built. * rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): The new m_alwaysCreateLineBoxes flag has been added to the constructor. (WebCore::RenderInline::styleDidChange): An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately (like having a layer, borders, padding, margins or backgrounds). Some checks that depend on examining the RenderInline's parent (including first line styles) happen later in layoutInlineChildren. (WebCore::RenderInline::updateAlwaysCreateLineBoxes): The function called by layoutInlineChildren to check parent and child style differences (e.g., font, vertical alignment, line height, etc.). (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::culledInlineAbsoluteRects): absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::absoluteQuads): (WebCore::RenderInline::culledInlineAbsoluteQuads): absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::culledInlineBoundingBox): lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::culledInlineFirstLineBox): (WebCore::RenderInline::culledInlineLastLineBox): Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop). (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox): (WebCore::RenderInline::linesVisualOverflowBoundingBox): linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::clippedOverflowRectForRepaint): The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox. (WebCore::RenderInline::dirtyLineBoxes): dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when m_alwaysCreateLineBoxes is false. (WebCore::RenderInline::createAndAppendInlineFlowBox): Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also when line-box-contain is set to an unusual value. (WebCore::RenderInline::addFocusRingRects): Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false. * rendering/RenderInline.h: (WebCore::RenderInline::firstLineBoxIncludingCulling): (WebCore::RenderInline::lastLineBoxIncludingCulling): Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box is all that needs checking. (WebCore::RenderInline::alwaysCreateLineBoxes): (WebCore::RenderInline::setAlwaysCreateLineBoxes): Functions for getting and setting the m_alwaysCreateLineBoxes flag. * rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of lines get dirtied. * rendering/RenderText.cpp: (WebCore::RenderText::removeAndDestroyTextBoxes): New helper invoked by destroy and also from updateFirstLetter. (WebCore::RenderText::destroy): Changed to call removeAndDestroyTextBoxes. (WebCore::RenderText::absoluteRects): Fixed to be properly physical instead of logical. (WebCore::RenderText::linesVisualOverflowBoundingBox): New implementation for RenderText that gives the bounding box of the text boxes including overflow from shadows, glyphs, text-stroke, etc. Used by RenderInline::culledInlineVisualOverflowBoundingBox. * rendering/RenderText.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::RenderSVGInline): RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization. * rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): (WebCore::SVGRootInlineBox::layoutChildBoxes): Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are now InlineTextBoxes (the enclosing InlineFlowBoxes got culled). LayoutTests: RenderInlines now have a boolean member, m_alwaysCreateLineBoxes, that starts off as false. Only if it gets flipped to true will there be any line boxes created for that RenderInline. * platform/mac/fast/blockflow/text-orientation-basic-expected.txt: * platform/mac/fast/text/capitalize-empty-generated-string-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83075 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Unreviewed expectations udpate for gtk port that follows r83065. * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83074 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, modify Chromium test expectations from r83065. They need rebaselines, but in the meantime they should fail more generally so as not to trip the bots. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83073 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alexis.menard@openbossa.org authored
Reviewed by Benjamin Poulain. [Qt] Unskip some media LayoutTests. https://bugs.webkit.org/show_bug.cgi?id=57855 Unskip some media tests for Qt. * platform/qt/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83072 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.pageNumberForElementById https://bugs.webkit.org/show_bug.cgi?id=42329 Unskip passed tests. * platform/mac-wk2/Skipped: * platform/qt-wk2/Skipped: 2011-04-06 Chang Shu <cshu@webkit.org> Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.pageNumberForElementById https://bugs.webkit.org/show_bug.cgi?id=42329 * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundlePageNumberForElementById): * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::pageNumberForElementById): * WebProcess/InjectedBundle/InjectedBundle.h: 2011-04-06 Chang Shu <cshu@webkit.org> Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.pageNumberForElementById https://bugs.webkit.org/show_bug.cgi?id=42329 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::pageNumberForElementById): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83071 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=57909 <rdar://problem/9103220> Reviewed by Darin Adler. Source/WebCore: In WebKit2 we cannot rely on the value returned by platformData() that on Mac returns an NSDraggingInfo object. This is available only in the UI process. Therefore we should use m_pasteboard instead. We cannot change what platformData() returns on Mac, since there are delegate methods that receive a NSDraggingInfo object (only in WebKit). * platform/DragData.h: (WebCore::DragData::pasteboard): Added. * platform/mac/ClipboardMac.mm: (WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData(). * platform/mac/DragDataMac.mm: (WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard. (WebCore::DragData::asURL): Same as above. Source/WebKit2: Added _hitTest method to support drag and drop when the drag types cannot be matched. This is the case for elements that do not place content in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element). * UIProcess/API/mac/WKView.mm: (-[WKView _hitTest:dragTypes:]): Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Eric Carlson. fast/layer/video_layer.html has the same text output for all chromium mac platforms. [chromium] Fix fast/layers/video_layer.html expectations https://bugs.webkit.org/show_bug.cgi?id=57386 * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed. * platform/chromium-mac/fast/layers/video-layer-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergio@webkit.org authored
Reviewed by Martin Robinson. [GTK] DumpRenderTree: do not try to free NULL SoupURIs https://bugs.webkit.org/show_bug.cgi?id=57932 Some Layout tests have invalid URIs that do not generate valid SoupURI instances. Do not try to free those NULL SoupURIs. * DumpRenderTree/gtk/DumpRenderTree.cpp: (willSendRequestCallback): git-svn-id: svn://svn.chromium.org/blink/trunk@83068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
benjamin.poulain@nokia.com authored
Reviewed by Darin Adler. ClipboardWin has unused variables "ExceptionCode ec" https://bugs.webkit.org/show_bug.cgi?id=57952 Remove the unused variable. * platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writePlainText): git-svn-id: svn://svn.chromium.org/blink/trunk@83067 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Reviewed by Dimitri Glazkov. Split getBorderPaddingMargin into two functions https://bugs.webkit.org/show_bug.cgi?id=57947 * rendering/RenderBlockLineLayout.cpp: (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin. (WebCore::borderPaddingMarginEnd): Ditto. (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd. (WebCore::RenderBlock::findNextLineBreak): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@83066 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
morrita@google.com authored
Reviewed by Dimitri Glazkov. [Refactoring] <progress> should not have manual layout code. https://bugs.webkit.org/show_bug.cgi?id=57801 Updated progress-bar-value-pseudo-element.html to have wider coverage and follow pseudo class change. * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: * platform/chromium/test_expectations.txt: * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: 2011-04-06 MORITA Hajime <morrita@google.com> Reviewed by Dimitri Glazkov. [Refactoring] <progress> should not have manual layout code. https://bugs.webkit.org/show_bug.cgi?id=57801 - Simplified RenderProgress, removing its custom layout code - Introducing ProgressValueElement and ProgressBarElement, replacing ProgressBarValueElement. Now the structure is almost identical to <meter>, other than: - RenderProgress has animated painting, thus manages its own timer. - Both ProgressValueElement and ProgressBarElement has pseudo classes which don't changes during its lifetime. * Android.mk: * CMakeLists.txt: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/html.css: (progress): (progress::-webkit-progress-bar): (progress::-webkit-progress-value): * html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::~HTMLProgressElement): (WebCore::HTMLProgressElement::create): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtree): * html/HTMLProgressElement.h: * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressShadowElement::ProgressShadowElement): (WebCore::ProgressShadowElement::progressElement): (WebCore::ProgressShadowElement::rendererIsNeeded): (WebCore::ProgressBarElement::shadowPseudoId): (WebCore::ProgressValueElement::shadowPseudoId): (WebCore::ProgressValueElement::setWidthPercentage): * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h. (WebCore::ProgressBarElement::ProgressBarElement): (WebCore::ProgressBarElement::create): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::ProgressValueElement::create): * rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::animationTimerFired): * rendering/RenderProgress.h: (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation): (WebCore::RenderProgress::canHaveChildren): git-svn-id: svn://svn.chromium.org/blink/trunk@83065 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mario@webkit.org authored
Reviewed by Chris Fleizach. [GTK] Do not reference AccessibilityRenderObject from platform dependent code https://bugs.webkit.org/show_bug.cgi?id=57955 Do not reference AccessibilityRenderObject from platform specific code Added new virtual functions to AccessibilityObject.h and removed explicit references to AccessibilityRenderObject from GTK code. * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::renderer): New virtual method, returning 0 by default. Overriden by AccessibilityRenderObject. (WebCore::AccessibilityObject::correspondingLabelForControlElement): New virtual method, returning 0 by default. It complements the already present method correspondingControlForLabelElement(). * accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::renderer): Made virtual. * accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::emitTextChanged): Reference AccessibilityObject, instead of AccessibilityRenderObject. (WebCore::AXObjectCache::nodeTextChangePlatformNotification): Ditto. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Do not reference AccessibilityRenderObject. (webkit_accessible_get_description): Ditto. (setAtkRelationSetFromCoreObject): Ditto. (optionFromList): Ditto. (optionFromSelection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_select_all_selection): Ditto. (textForObject): Ditto. (webkit_accessible_text_get_text): Ditto. (getPangoLayoutForAtk): Ditto. (webkit_accessible_text_get_caret_offset): Ditto. (baselinePositionForRenderObject): Ditto. (getAttributeSetForAccessibilityObject): Ditto. (accessibilityObjectLength): Ditto. (getSelectionOffsetsForObject): Ditto. (webkit_accessible_text_set_selection): Ditto. (webkit_accessible_text_set_caret_offset): Ditto. (webkit_accessible_table_get_caption): Ditto. (getInterfaceMaskFromObject): Ditto. * accessibility/gtk/WebKitAccessibleHyperlink.cpp: (getRangeLengthForObject): Ditto. Removed unused renderer() method from AccessibilityMenuList. * accessibility/AccessibilityMenuList.h: Removed unused method. * accessibility/AccessibilityMenuList.cpp: Removed unused method. git-svn-id: svn://svn.chromium.org/blink/trunk@83064 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
demarchi@webkit.org authored
cmake: Fix build for ARMv7 * CMakeLists.txt: add missing file. git-svn-id: svn://svn.chromium.org/blink/trunk@83063 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Javascipt warning link expand and overlap with icons in js console https://bugs.webkit.org/show_bug.cgi?id=57939 * inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode): git-svn-id: svn://svn.chromium.org/blink/trunk@83062 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: Beautify parameter names in Inspector.json (CSS domain) https://bugs.webkit.org/show_bug.cgi?id=57931 * inspector/Inspector.json: git-svn-id: svn://svn.chromium.org/blink/trunk@83061 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text. https://bugs.webkit.org/show_bug.cgi?id=57665 <rdar://problem/7350477> We need to track how user modified an autocorrected word. If he changed it back to original text, we want to record AutocorrectionReverted response. And if he changed it to something else, we want to record AutocorrectionEdited response. To achieve this, we need to distringuish between text replacement caused by autocorrection from that due to other causes, such as reversion, text substitution, etc. So we added a new marker type "Autocorrected". We also need to be able to check for correction, even when we don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption value, "CheckForCorrection". We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in specified range, and of specified type. * dom/DocumentMarker.h: * dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::markersInRange): (WebCore::DocumentMarkerController::hasMarkers): * dom/DocumentMarkerController.h: * editing/Editor.cpp: (WebCore::markerTypesForAutocorrection): (WebCore::markersHaveIdenticalDescription): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection): (WebCore::Editor::changeBackToReplacedString): (WebCore::Editor::markMisspellingsAndBadGrammar): (WebCore::Editor::applyCorrectionPanelInfo): (WebCore::Editor::unappliedSpellCorrection): (WebCore::Editor::textCheckingTypeMaskFor): * editing/Editor.h: * editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply): git-svn-id: svn://svn.chromium.org/blink/trunk@83060 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Benjamin Poulain. Correct a include file name. https://bugs.webkit.org/show_bug.cgi?id=57839 * wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix builds on Unix hosts. git-svn-id: svn://svn.chromium.org/blink/trunk@83059 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable. git-svn-id: svn://svn.chromium.org/blink/trunk@83058 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
Unreviewed, add Chromium snow leopard baseline for meter-boundary-values * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83057 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Hopefully this will make it easier to modify this logic in the future. I also made the script much quieter than the old logic, since it didn't seem helpful to see long lists of filenames during the copying phase. If we like this new style, we could copy it for our other projects. Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to modify and noisy Reviewed by Steve Falkenburg. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy files from here... * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.) * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd for convenience. git-svn-id: svn://svn.chromium.org/blink/trunk@83056 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=57846 Reviewed by Andreas Kling. * Scripts/old-run-webkit-tests: git-svn-id: svn://svn.chromium.org/blink/trunk@83055 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=57940 Reviewed by Darin Adler. * WebProcess/ResourceCache/WebResourceCacheManager.cpp: (WebKit::WebResourceCacheManager::clearCacheForOrigin): git-svn-id: svn://svn.chromium.org/blink/trunk@83054 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
podivilov@chromium.org authored
Unreviewed, rolling out r83045. http://trac.webkit.org/changeset/83045 https://bugs.webkit.org/show_bug.cgi?id=57953 Broke win layout tests (Requested by podivilov on #webkit). * inspector/debugger/script-formatter-expected.txt: Removed. * inspector/debugger/script-formatter.html: Removed. * platform/chromium/test_expectations.txt: 2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r83045. http://trac.webkit.org/changeset/83045 https://bugs.webkit.org/show_bug.cgi?id=57953 Broke win layout tests (Requested by podivilov on #webkit). * GNUmakefile.am: * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): git-svn-id: svn://svn.chromium.org/blink/trunk@83053 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042. * rendering/RenderBlock.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83052 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
diegohcg@webkit.org authored
[Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled. https://bugs.webkit.org/show_bug.cgi?id=57007 Reviewed by Kenneth Rohde Christiansen. * CodeGenerators.pri: * css/themeQtMobile.css: Removed. * platform/qt/QtMobileWebStyle.cpp: (drawRectangularControlBackground): (QtMobileWebStyle::drawPrimitive): (QtMobileWebStyle::drawComplexControl): * platform/qt/QtMobileWebStyle.h: * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::paintTextField): git-svn-id: svn://svn.chromium.org/blink/trunk@83051 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=57862 Reviewed by Anders Carlsson. Part 1: Get and set the state. * Shared/API/c/win/WKBaseWin.h: * Shared/APIObject.h: * UIProcess/API/C/win/WKAPICastWin.h: * UIProcess/API/C/win/WKTextChecker.cpp: Added. (WKTextCheckerSetClient): (WKTextCheckerContinuousSpellCheckingEnabledStateChanged): (WKTextCheckerGrammarCheckingEnabledStateChanged): * UIProcess/API/C/win/WKTextChecker.h: Added. * UIProcess/TextChecker.h: * UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::state): Do the initalization for the state only once so that it is not necessary to call the client every time the state is requested. (WebKit::TextChecker::isContinuousSpellCheckingAllowed): Call the client. (WebKit::TextChecker::setContinuousSpellCheckingEnabled): Update the state and tell the client. (WebKit::TextChecker::setGrammarCheckingEnabled): Ditto. (WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged): Update the state. (WebKit::TextChecker::grammarCheckingEnabledStateChanged): Update the state. * UIProcess/win/WebTextChecker.cpp: Added. (WebKit::WebTextChecker::shared): Make the WebTextChecker available globally. (WebKit::WebTextChecker::WebTextChecker): (WebKit::WebTextChecker::setClient): (WebKit::updateStateForAllWebProcesses): (WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged): Tell the TextChecker that the state has changed, and then tell the WebProcessProxies to send the new state to the WebProcesses. (WebKit::WebTextChecker::grammarCheckingEnabledStateChanged): Ditto. * UIProcess/win/WebTextChecker.h: Added. (WebKit::WebTextChecker::client): (WebKit::WebTextChecker::type): * UIProcess/win/WebTextCheckerClient.cpp: Added. (WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed): (WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled): (WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled): (WebKit::WebTextCheckerClient::grammarCheckingEnabled): (WebKit::WebTextCheckerClient::setGrammarCheckingEnabled): * UIProcess/win/WebTextCheckerClient.h: Added. * win/WebKit2.vcproj: Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp. * win/WebKit2Generated.make: Copy over WKTextChecker.h. git-svn-id: svn://svn.chromium.org/blink/trunk@83050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification. https://bugs.webkit.org/show_bug.cgi?id=57800 <rdar://problem/9218223> Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges() now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place. * accessibility/AXObjectCache.h: * accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): * accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postPlatformNotification): * editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): git-svn-id: svn://svn.chromium.org/blink/trunk@83049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Build fix for debug Cairo builds. * platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation. git-svn-id: svn://svn.chromium.org/blink/trunk@83048 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
diegohcg@webkit.org authored
[Qt] Style fix for QtMobileWebStyle.h https://bugs.webkit.org/show_bug.cgi?id=57708 Reviewed by Antonio Gomes. * platform/qt/QtMobileWebStyle.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83047 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abecsi@webkit.org authored
Reviewed by Darin Adler. Invalid color #{predefined colorName} is accepted by the CSS parser. https://bugs.webkit.org/show_bug.cgi?id=15360 * editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid. * fast/css/invalid-predefined-color-expected.txt: Added. * fast/css/invalid-predefined-color.html: Added. * fast/css/script-tests/invalid-predefined-color.js: Added. 2011-04-06 Andras Becsi <abecsi@webkit.org> Reviewed by Darin Adler. Invalid color #{predefined colorName} is accepted by the CSS parser. https://bugs.webkit.org/show_bug.cgi?id=15360 Test: fast/css/invalid-predefined-color.html * css/CSSGrammar.y: Remove superfluous hexcolor production. * css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}). git-svn-id: svn://svn.chromium.org/blink/trunk@83046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: add test for script formatter worker. https://bugs.webkit.org/show_bug.cgi?id=57447 * inspector/debugger/script-formatter-expected.txt: Added. * inspector/debugger/script-formatter.html: Added. * platform/chromium/test_expectations.txt: 2011-03-30 Pavel Podivilov <podivilov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: add test for script formatter worker. https://bugs.webkit.org/show_bug.cgi?id=57447 Test: inspector/debugger/script-formatter.html * GNUmakefile.am: * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): git-svn-id: svn://svn.chromium.org/blink/trunk@83045 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [Cairo] Hide the details of image masking in PlatformContextCairo https://bugs.webkit.org/show_bug.cgi?id=57878 No new tests. This is just a refactor. * platform/graphics/GraphicsContext.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to do the actual cairo_save. Remove information about image masking. (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to do the actual cairo_restore. Remove information about image masking. * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: * platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now. * platform/graphics/cairo/PlatformContextCairo.cpp: (WebCore::PlatformContextCairo::restore): Added. (WebCore::PlatformContextCairo::save): Added. (WebCore::PlatformContextCairo::pushImageMask): Added. * platform/graphics/cairo/PlatformContextCairo.h: (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h. (WebCore::ImageMaskInformation::isValid): Ditto. (WebCore::ImageMaskInformation::maskSurface): Ditto. (WebCore::ImageMaskInformation::maskRect): Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@83044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
diegohcg@webkit.org authored
[Qt] Radio buttons are showing wrong with mobile theme https://bugs.webkit.org/show_bug.cgi?id=57706 Reviewed by Csaba Osztrogonác. * platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawRadio): git-svn-id: svn://svn.chromium.org/blink/trunk@83043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Reviewed by Eric Seidel. Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp https://bugs.webkit.org/show_bug.cgi?id=57943 * rendering/RenderBlock.cpp: Removed positionNewFloatOnLine. * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp git-svn-id: svn://svn.chromium.org/blink/trunk@83042 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
diegohcg@webkit.org authored
Buildfix after r82125. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled https://bugs.webkit.org/show_bug.cgi?id=57087 * platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::findChecker): (QtMobileWebStyle::findRadio): (QtMobileWebStyle::findComboButton): git-svn-id: svn://svn.chromium.org/blink/trunk@83041 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release. https://bugs.webkit.org/show_bug.cgi?id=57641 * WebCore.xcodeproj/project.pbxproj: * gyp/streamline-inspector-source.sh: * inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources. * inspector/inline-javascript-imports.py: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83040 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Reviewed by Eric Seidel. REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words https://bugs.webkit.org/show_bug.cgi?id=57872 r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition. r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without avoiding the tab span. Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy. Test: editing/inserting/insert-paragraph-separator-tab-span.html * editing/EditingStyle.cpp: (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style. * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph separator into a paragraph separator. 2011-04-06 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Eric Seidel. REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words https://bugs.webkit.org/show_bug.cgi?id=57872 Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's style to the paragraph separator or the text. * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added. * editing/inserting/insert-paragraph-separator-tab-span.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83039 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-