- 11 Apr, 2018 40 commits
-
-
Robert Kaplow authored
Bug: 804439 Change-Id: If0c4941a8e9f0deb9205fbb06d33aa82e791a05d Reviewed-on: https://chromium-review.googlesource.com/1000553 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#549727}
-
Xida Chen authored
This CL adds a line of comment in HistogramTest, for the use cases of using it in content browser tests. Bug: None Change-Id: If31592af04382097525ed7e8cfed04054123d145 Reviewed-on: https://chromium-review.googlesource.com/1005802 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#549726}
-
Min Qin authored
DownloadHistory is currently loaded on browser start up. And that will trigger file existence check, which is very costly. File existence check is not needed until user opens chrome://downloads page or loads a download extension. Currently android download home and desktop downloads page already checks for file existence on startup. And download search api will also perform file existence check. So this file existence check on DownloadHistory ctor is not needed. BUG=829044 Change-Id: I3558d2baa6952eda6adde4eec1f3c79efe8e4d11 Reviewed-on: https://chromium-review.googlesource.com/996576 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549725}
-
Wez authored
Fuchsia does not support setrlimit(), which is required for these tests to run under 64-bit systems. Bug: 779645 Change-Id: Ia2c910d641656986c2a88d5d8992e6dcd347a498 Reviewed-on: https://chromium-review.googlesource.com/1006191 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#549724}
-
Sammie Quon authored
Otherwise if you release the window, it will slide underneath the non animating windows. Test: ash_unittests WindowSelectorTest.OverviewWidgetStacking* Bug: 826981 Change-Id: I94c9465faaad744788af38ae8cf97c43f0a6ec66 Reviewed-on: https://chromium-review.googlesource.com/996956 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#549723}
-
Kim Paulhamus authored
InvalidState was added in crrev.com/984725 but not actually returned to the renderer. This CL returns the correct error and adds a corresponding end-to-end layout test using a virtual device. Bug: 819256 Change-Id: Iee07fee5b8de9af59f32399018e1b5ace474abe1 Reviewed-on: https://chromium-review.googlesource.com/1000958 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549722}
-
Amirhossein Simjour authored
Vr supports autofill behind a flag, the comment is updated to reflect this. TBR=mathp@chromium.org Change-Id: Idb5672df4d7fc64c576094ed8132f02d0df931d3 Reviewed-on: https://chromium-review.googlesource.com/997893Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#549721}
-
Becca Hughes authored
If the panel is hidden then we should not update the current time unnecessarily. BUG=821961,821414 Change-Id: I5c3fed448c52edfb14570d5e2e164c56e4747672 Reviewed-on: https://chromium-review.googlesource.com/1006068Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#549720}
-
Joe Downing authored
Per the W3C spec, when navigator.keyboard.lock() is called a second time (or more), any previous, pending promises should be rejected. The old behavior of the API was to reject the newest promise which is not correct. As part of this cleanup, I am also using DomExceptions instead of raw strings for the rejection. This allows us to clean up the test code (which fails if a raw string is returned in the reject call). BUG=680809 Change-Id: Ic4f2563a6ccc22a434f8e6079f1995d9e584f9aa Reviewed-on: https://chromium-review.googlesource.com/1003472 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#549719}
-
Lukasz Anforowicz authored
This is a refactoring that 1) Avoids using the spare RenderProcessHost for Top Document Isolation (TDI) default subframe process. and 2) Because of (1) simplifies SpareRenderProcessHostManager so that it can avoid considering StoragePartition when managing the spare process. Note that after (1) the only caller of RenderProcessHostImpl::CreateOrUseSpareRenderProcessHost (RenderProcessHostImpl::GetProcessHostForSiteInstance) would always pass |nullptr| as the partition argument. Bug: 808114 Change-Id: Ic87b9142b9e27ca1e95233a4e6e42cc1e8e89f97 Reviewed-on: https://chromium-review.googlesource.com/991058Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#549718}
-
Tommy Steimel authored
This CL adds the CSS rules for text tracks from the legacy controls into the modern controls. This also fixes the text track layout calculations which currently avoid the whole controls panel by making them avoid the timeline and media button panel. Bug: 817972 Change-Id: Icbcdfe7db564e49c1164c7b01cd52f5382a7ed53 Reviewed-on: https://chromium-review.googlesource.com/1003761Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Joe Downing authored
The previous KeyboardLockService implementation always returned success even when no KeyboardLock request was registered due to an error. This CL adds errors for two known error conditions which are now communicated back to javascript by rejecting the promise. The messages passed are meant to help developers as they are building their website, they are not something that can/should be used post-development (i.e. they represent unrecoverable errors). BUG=680809 Change-Id: I7748d0f0c7b8688b4e945e6aa349d75b2a9757ca Reviewed-on: https://chromium-review.googlesource.com/1003216Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Xing Liu authored
The flakiness is caused by race between network error and injected error into file thread. This CL posts the injected error callback to UI thread early, also fixed the parameter passed to injected error callback. Bug: 827525 Change-Id: I1ea89f53a764caded6b9ecac806f8229a9dfe9d1 Reviewed-on: https://chromium-review.googlesource.com/999255Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549715}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7bb4395a7fab006b6626150a59574bc42d767a15 Reviewed-on: https://chromium-review.googlesource.com/1000533Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549714}
-
Kent Tamura authored
Bug: 768828 Change-Id: I1a0b5f3542c53db34111a5411beb57b7fbcb189c Reviewed-on: https://chromium-review.googlesource.com/1004877Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549713}
-
Mounir Lamouri authored
This is introducing MediaControlPopupMenuElement as a base class. At the moment, the class handles positioning of the popup and some basic visibility. It's also cleaning up a bit of code around popup menus. This new class will allow the introduction of an event handler to deal with keyboard events on both popup menus. Bug: 821131 Change-Id: I19ad4193b5ccbd6acd3c59c35701e32c91e634c6 Reviewed-on: https://chromium-review.googlesource.com/1005334Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549712}
-
Nathan Parker authored
This fixes the fact that all of the "IPv-mapped to IPv6" addresses, of the form ::ffff:/96, were marked as reserved when in fact they are routable on the Internet. This means some code that thought it was talking to a private IP was actually reachable via a public IP. This switches all callers except those in third_party/blink, which I'll do in in https://crrev.com/c/994276. Bug: 755418 Change-Id: Ic0002efae268a42c86e39541e0bb3808bd0a247c Reviewed-on: https://chromium-review.googlesource.com/994332Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#549711}
-
Ted Meyer authored
SublimeClang doesn't build on rodette without the change from shared_ptr -> std::shared_ptr. I think this has changed with the upgrade of gcc. Regardless, this information should be helpful to new users. Change-Id: Ieb6da09d0ffc5806d5df0378d449a058791fb77a Reviewed-on: https://chromium-review.googlesource.com/988936Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549710}
-
Becca Hughes authored
Adds a "transparent" class to the panel element when we should be transparent. This will allow us to animate it with CSS animations in the future. Also decreases the time to hide to 2.5s for modern media controls as per spec. BUG=780051 Change-Id: I9f69e455f4be822eec00b124da610c768bf8f141 Reviewed-on: https://chromium-review.googlesource.com/1005620 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
https://chromium-review.googlesource.com/c/chromium/src/+/996632 added a MediaStubLocalFrameClient which conflicts with a preexisting class in html_media_element_event_listeners_test.cc in jumbo builds. Let's rename this one. TBR=mlamouri@chromium.org Bug: 827396 Change-Id: If04b1de4a6cea922e5d88707505f1b0d69255f9c Reviewed-on: https://chromium-review.googlesource.com/1005084 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#549708}
-
Elad Alon authored
Occasionally prune pending remote-bound WebRTC event logs. This prevents them from staying on disk for longer than the retention time, in cases where the triggers to non-proactive pruning do not happen (Chrome is not restarted, peer connections are not started/stopped, etc.). Bug: 775415 Change-Id: I1a4e81495b12813776528ed678a445add1fe185f Reviewed-on: https://chromium-review.googlesource.com/1005234Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549707}
-
Yuwei Huang authored
Previously we don't bother to implement a keycode mapping logic and we directly send texts to the host to inject. Hosts usually handle text injection very differently than key injection and may end up texts being directly injected to the host without passing through IME. In other words, host side IME doesn't work with our current key injection implementation. The downside of this change is that non-US keyboard user will now get the wrong keyboard output on the host again, which is what we had on the v1 client. For longer term, we can add a new host setting for changing the keyboard layout. NOTRY=true Bug: 830959 Change-Id: Ia34b6894fd7c0a7a07a5b9657aca19c2a878bd4e Reviewed-on: https://chromium-review.googlesource.com/1006065 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549706}
-
Becca Hughes authored
Since we moved to the image based scrim it looks like image set does not properly provide an image at a high pixel ratio. This provides a quick patch to use media queries instead to provide the high DPI image. A follow up to this CL will be to fix the image set property properly. BUG=830583 Change-Id: I77f3ab695facb23f96dcde9e28c57237034f23d1 Reviewed-on: https://chromium-review.googlesource.com/1003274 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
The goal is to offer a shortcut for cases when tests may either enable or disable a feature based on a condition. Examples that could be simplified if such method exists: - https://cs.chromium.org/chromium/src/components/autofill/core/browser/form_structure_unittest.cc?l=50 - https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_page_view_unittest.cc?l=62 Change-Id: I408cae760aa6a031770498202eb817e3bbd63a6b Reviewed-on: https://chromium-review.googlesource.com/1005421Reviewed-by:
-
P H authored
This will allow tunneling information that account is child to ARC. Bug: 825298 Change-Id: I92d268c8bc13378de04e4eb4c2eeb69b79946a81 Reviewed-on: https://chromium-review.googlesource.com/980952 Commit-Queue: Patricia Hongo <phongo@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549703}
-
rbpotter authored
Add key event handling: - Enter key results in print - Ctrl + shift + P brings up system dialog - Escape key and cmd- to close (on Mac) - Arrow keys/page up and down scroll the preview PDF Mostly copied from the existing UI code in print_preview.js and previewarea/preview_area.js. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I78c99c0ddacc09d598766737a3af4cdcbcca741d Reviewed-on: https://chromium-review.googlesource.com/998345 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#549702}
-
Sahel Sharify authored
This cl changes timer-based wheel scroll latching to start a new scroll sequence when no GSU from the current scroll sequence is consumed and the coming wheel event has different scroll delta direction(s). The reason for this fix is the following scenario: Consider a scrollable div currently at its extent inside an unscrollable viewport. If the user starts scrolling the div downward, the scrolling will latch to the viewport and if there is no rubber-banding or glow effect the user wouldn't notice this. Then if the user decides to scroll the div upward within the same scroll sequence, the viewport will try to scroll upward and again due to lack of overscroll notion the user would see the scroll as ignored. With this change the user would see the upward scrolling since direction change would break the timer based latching and the new scroll sequence will latch to the div. Test: *.TimerBasedLatchingBreaksWithDirectionChange Bug: 828751 Change-Id: I0a709aecc1363759a3b0e0622bac8cad72666014 Reviewed-on: https://chromium-review.googlesource.com/998316 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549701}
-
Koji Ishii authored
This patch is a refactor, no behavior nor logic changes. In the last refactoring, list markers are propagated to list item as NGBlockNode and uses static functions of NGListLayoutAlgorithm. This patch refactors NGListLayoutAlgorithm as NGUnpositionedListMarker, that holds the list marker node and positioning functions as instance functions. Also common code are extracted to private functions. Unfortunately, gerrit/git no longer recognize this as rename and that the diff is large, but the logic does not change. This is to prepare for further fixes that include logic changes. Bug: 725277 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic5c411c0ba977d95695b5feea194a422ea3b5d01 Reviewed-on: https://chromium-review.googlesource.com/1001215Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549700}
-
Tom Anderson authored
BUG=822410 TBR=dpranke Change-Id: I8b9922029b0b1cfbf327ba4de4dec346bb01a2ca Reviewed-on: https://chromium-review.googlesource.com/1006168Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549699}
-
Elly Fong-Jones authored
This is a debugging hack to try to narrow down the root cause of the linked bug. TBR=sky@chromium.org Bug: 828031 Change-Id: Ibdfbd50cdc1bac1ec598f46efba5a63cb0475628 Reviewed-on: https://chromium-review.googlesource.com/1005103 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549698}
-
rbpotter authored
Port the GCP certificate error messages - Learn more links work - UI shows up in preview area - Destination information has correct styling in destination settings. Also - Ensure invalid printer gets set in PrintPreviewApp so that state is changed - Adjust state transition logic, since the system dialog link is available and can be clicked in most states as long as the OS is not Windows. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id644932123ef570f0d304e5fc7739a9f14d6a7d9 Reviewed-on: https://chromium-review.googlesource.com/998843Reviewed-by:
-
Kenneth Russell authored
Already marked flaky on Linux and Android. NOTRY=true TBR=xlai@chromium.org, trchen@chromium.org, ynovikov@chromium.org Bug: 807742 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I883f6f0e21f20aebdff32071de29d4f02c477c72 Reviewed-on: https://chromium-review.googlesource.com/1006357 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549696}
-
Sonny Sasaka authored
Currently passkey is padded with trailing zeros if it's less than 6 digits. It should be padded with leading zeros instead. Bug: 817574 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3a27412c9c053141d28a6e7e7e609de28729ee20 Reviewed-on: https://chromium-review.googlesource.com/1005616Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#549695}
-
Christopher Grant authored
BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iab04434e20a42a346a762cc61c04ade0e3cf1fc5 Reviewed-on: https://chromium-review.googlesource.com/1005905Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#549694}
-
Annie Sullivan authored
This reverts commit 400c1e29. Reason for revert: This CL caused several performance regressions. Bug: 830776,830790,830792,830794,830802,830806 Original change's description: > Enable presentation feedback on Linux > > Bug: 776877 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I6faa89c42bb8a6bf43c4a9c6fe86826dca316e4f > Reviewed-on: https://chromium-review.googlesource.com/998317 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548803} TBR=penghuang@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 776877 Change-Id: I2f4d442305eb6505401e058773338b782c94c3ef Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1005157Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549693}
-
Robert Ma authored
This test has been deleted in the upstream. Remove its expectation line in advance to save the next WPT import from having to run the LayoutNG try job. TBR=kojii No-Try: True Change-Id: I89850c603dd82429911c5534b3bae4a73874e2c6 Reviewed-on: https://chromium-review.googlesource.com/1006271Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549692}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic976db8e6fc7ea7f342a8ad6dbe28a725b4db45f Reviewed-on: https://chromium-review.googlesource.com/1006270Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#549691}
-
Saman Sami authored
I removed a DCHECK by mistake in crrev.com/c/995915. Also add a comment. Bug: 815187 Change-Id: I5bffc2b23358a56ebf3a35621c6c9f2970519b58 Reviewed-on: https://chromium-review.googlesource.com/1005785Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#549690}
-
Andrii Shyshkalov authored
R=jchinlee@chromium.org Bug: 731543 Change-Id: I84441f7d1a4b3b3a1ff620518019b4b93ab88b2b No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1006265Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549689}
-
Peter K. Lee authored
ObjCCastStrict<> returns nil if the object being casted is not of the expected type. This offers a saner behavior when for whatever reasons object is not of the expected type. This is a workaround to avoid a growing crash in iOS 11.3 when an object of UIView type is casted to one of CardView type. A later call to -closeButtonFrame results in an exception (crash). Bug: 393230 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a3f2b66c4ab6a8f268743e1ce8c902ccffaaa05 Reviewed-on: https://chromium-review.googlesource.com/1005562 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#549688}
-
