GitLab

BUG=160207
R=vsevik, yurys@chromium.org

Review URL: https://codereview.chromium.org/547603003

git-svn-id: svn://svn.chromium.org/blink/trunk@181561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, scientific notation (scinot) was only supported for SVG
presentation attributes through a special tokenizer quirk. Since scinot
has now been added to the CSS syntax spec [1][2][3] and is already
supported by Gecko [4] and IE(11).
To harmonize, the call to parseSVGNumber(...) is replaced with a call to
charactersToDouble(...). This results in a small behavioral change, since
the former would reject numbers that were too large. These will now parse
as "Infinity" [5].
Since this removes the last caller of isSVGNumberParsingEnabledForMode()
that function is removed as well.

[1] http://dev.w3.org/csswg/css-syntax/#number-token-diagram
[2] http://lists.w3.org/Archives/Public/www-style/2012Aug/0900.html
[3] http://lists.w3.org/Archives/Public/www-style/2013Apr/0428.html
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=964529
[5] Tested browsers were not entirely consistent in their treatment of
    infinities (Gecko: Infinity, IE: FLT_MAX).

BUG=388161
BUG=344645

Review URL: https://codereview.chromium.org/545173003

git-svn-id: svn://svn.chromium.org/blink/trunk@181560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removes unnecessary code around ElementWrapperFactory.

BUG=235436

Review URL: https://codereview.chromium.org/552733002

git-svn-id: svn://svn.chromium.org/blink/trunk@181558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before we know whether or not we can implement [1], let's find out how
hard it will hit the portions of the web for which we can gather UMA
data.

BUG=378566

Review URL: https://codereview.chromium.org/545923002

git-svn-id: svn://svn.chromium.org/blink/trunk@181557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With the CL, https://codereview.chromium.org/456413002, we are migrating from embedding inline resources
inside blink towards using chromium's grd resource system. As part of this effort, most of the tests
would require to use the 'pak' files packaged as android application assets.

These assets need to be extracted to the application data directory during the startup of the test
application. The native libraries would be able to work with these 'pak' files only after the extraction
from the asset manager. Adding the required 'content_shell.pak' to the target webkit_unit_tests_apk.

BUG=312586

Review URL: https://codereview.chromium.org/549863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(rrev.com/528013002).

Fixes for review comments not handled in the original CL.

BUG=399580
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/549533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [oilpan]: optimize the way we allocate persistent handles in wrappers. (patchset #6 id:100001 of https://codereview.chromium.org/525353002/)

Reason for revert:
Reverting due to browser test failures.

Original issue's description:
> [oilpan]: optimize the way we allocate persistent handles in wrappers.
> 
> The oilpan JS wrappers all have a persistent which is used to keep the wrapped object around while there is a javascript reference to it. Allocation of these wrapper persistents showed up in some of benchmarks. This change creates a new optimized WrapperPersistent which is allocated in blocks. This gives a speedup ranging between a few percent to 20% in some of the more wrapper intensive tests.
> 
> R=ager@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181298

TBR=ager@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,zerny@chromium.org,erik.corry@gmail.com,fdegans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411240

Review URL: https://codereview.chromium.org/553483004

git-svn-id: svn://svn.chromium.org/blink/trunk@181553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch adds long click behavior to the "add new rule" button, which
opens a list of user stylesheets where you can add a new rule.

BUG=402461

Review URL: https://codereview.chromium.org/529553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

30% performance improvement on DOM/textarea-edit on the oilpan build.
2% performance improvement on DOM/textarea-edit on the non-oilpan build.

R=yosin@chromium.org
BUG=388681

Review URL: https://codereview.chromium.org/544083002

git-svn-id: svn://svn.chromium.org/blink/trunk@181551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test do not run, because "return" is not allowed at top level
(syntax error).

BUG=

Review URL: https://codereview.chromium.org/540613004

git-svn-id: svn://svn.chromium.org/blink/trunk@181550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to check this in DocumentThreadableLoader not to send CORS preflight requests to the ServiceWorker.

Chromium side is implemented in https://codereview.chromium.org/553603002/.


BUG=411151

Review URL: https://codereview.chromium.org/546263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

generate_constructor_wrapper macro in bindings/templates/methods.cpp
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/templates/methods.cpp&q=%22macro%20generate_constructor_wrapper%22%20file:methods.cpp&sq=package:chromium&l=611
would like to reuse the existing wrapper object, and in that case,
it needs to associate the impl with the existing wrapper.
(Note that wrap method creates a new wrapper.)

This CL introduces ScriptWrappable::associateWithWrapper to allow it.
This method does not need to be virtual because it must be called from
only a) wrap method, or b) V8T::constructorCallback, where we already
know the right WrapperTypeInfo.

BUG=235436

Review URL: https://codereview.chromium.org/542113003

git-svn-id: svn://svn.chromium.org/blink/trunk@181548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

AXRenderObject assumes that both of the ancestor element and the active
descendant element have their renderers.

BUG=123896

Review URL: https://codereview.chromium.org/550853002

git-svn-id: svn://svn.chromium.org/blink/trunk@181547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per css3-color[1], currentColor is not resolved at computed value
time. This means that we shouldn't fire a transition when a property is
set to currentColor, even if the used value changes. Note we still
transition between currentColor and actual colours, which is likely to
be fine by css4-color, which adds a blending primitive.

[1] http://www.w3.org/Style/2011/REC-css3-color-20110607-errata.html

BUG=394632

Review URL: https://codereview.chromium.org/552683002

git-svn-id: svn://svn.chromium.org/blink/trunk@181546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See:
https://codereview.chromium.org/526423002

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/553753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=367689
NOTRY=true

Review URL: https://codereview.chromium.org/547323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/)

Reason for revert:
calls V8 from a non-V8 context

Original issue's description:
> Mixed Content: Move subframe checks into ResourceFetcher.
> 
> Currently we're checking for mixed content when loading the main
> resource of subframes in two places: DocumentLoader and ResourceFetcher.
> The former properly checks against the frame's parent frame, while the
> latter bypasses the checks entirely by virtue of the request's
> 'Resource::Type' being 'Main'.
> 
> This is both confusing and difficult to replicate when moving to the
> brave new world of request contexts and frame types that Fetch now
> defines.
> 
> This patch drops the DocumentLoader check, and moves the relevant
> logic into ResourceFetcher::canRequest and
> ResourceFetcher::checkInsecureContent.
> 
> BUG=400087
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383

TBR=mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400087

Review URL: https://codereview.chromium.org/550083003

git-svn-id: svn://svn.chromium.org/blink/trunk@181543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit f2e0beaedaeaf15c509a2abd2c4fe598c4094bbd.

TBR=arv@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/546973004

git-svn-id: svn://svn.chromium.org/blink/trunk@181542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Those two files were split apart and redundantly copied
for non-Mac and Mac platforms. This is an attempt an unifying
them, as a preparation for removing the CoreText shaper.
We can merge the implementations in FontPlatformDataHarfBuzz.cpp
and FontPlatformData.cpp as a next step.

This is a reland after the original change 72f392cc147764ec75e4f
got reverted in bcfdb1312a26b0e611. Fix is to
change to the previous operator== implementation and add
m_isHashTableDeletedValue to the hash computation. 

I believe this addresses the observed crash issue as well.

BUG=334269, 411287
R=eae,arv

Review URL: https://codereview.chromium.org/542653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=arv@chromium.org
BUG=411779

Review URL: https://codereview.chromium.org/546633008

git-svn-id: svn://svn.chromium.org/blink/trunk@181540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I would like to add new time complexity test.
Unfortunately, current framework doesn't support async tests.

In this patch I wrap for and while operators, so they could
run asynchronously.

CL I'm going to write test to (fix n^2 HTML parsing):
https://codereview.chromium.org/494993002/

Here is the first async test:
https://codereview.chromium.org/500363002/

BUG=410790

Review URL: https://codereview.chromium.org/544453004

git-svn-id: svn://svn.chromium.org/blink/trunk@181539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While most color properties have an initial value of currentColor,
explicitly specifying currentColor behaves different internally to an
initial value. This patch makes currentColor no longer resolved in style
resolution for properties which are a single color and removes a flag
from RenderStyle indicating that currentColor was explicitly set.

Review URL: https://codereview.chromium.org/547273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Do what the comment says, not what the code does :)

BUG=399775

Review URL: https://codereview.chromium.org/543273002

git-svn-id: svn://svn.chromium.org/blink/trunk@181537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead, it should use synchronous ResourceRequest to obtain imported xsl-stylesheet.

TEST=fast/xsl/transform-xhr-doc.xhtml
BUG=367689

Review URL: https://codereview.chromium.org/507583002

git-svn-id: svn://svn.chromium.org/blink/trunk@181536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently this test is expected to be timed out and should be skipped to reduce
the time to run tests.

BUG=398355
TBR=horo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/546333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These attributes are gone:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container

Chromium: https://codereview.chromium.org/544023002/


BUG=404982
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/541943003

git-svn-id: svn://svn.chromium.org/blink/trunk@181534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFontForTesting
> 
> NOTRY=true
> TBR=arv@chromium.org,tkent@chromium.org
> BUG=None
> 
> Review URL: https://codereview.chromium.org/549013002

TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/554543002

git-svn-id: svn://svn.chromium.org/blink/trunk@181533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: Fix tests failing on Win7(dbg) caused by hitting an assert in FontCache::addSideloadedFontForTesting

NOTRY=true
TBR=arv@chromium.org,tkent@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/549013002

git-svn-id: svn://svn.chromium.org/blink/trunk@181532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I added m_skipServiceWorker to ResourceRequest in https://codereview.chromium.org/527703002/.
But I forgot to add it to CrossThreadResourceRequestData.

BUG=402093
TEST=none

Review URL: https://codereview.chromium.org/547563002

git-svn-id: svn://svn.chromium.org/blink/trunk@181531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In Web applications, the Filesystem API is used to create sandboxed
filesystems. Files in these filesystems should never be shown in a
filepicker. ChromeOS supports a few special filesystems (Downloads,
Gallery) where the files should be shown in filepickers.

This change fixes the userVisibility property for File instances created
from such filesystems.

BUG=398366

Review URL: https://codereview.chromium.org/516763002

git-svn-id: svn://svn.chromium.org/blink/trunk@181530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On non-intel (aka non x86/x64) we can compile the assembly stubs as a
source_set and not use yasm.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/541933003

git-svn-id: svn://svn.chromium.org/blink/trunk@181529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the unused MarginSign enum. I noticed this while
searching how we name enums in Blink as part of another patch.

Since I was in the area, I fixed the comment about margins as well.

R=esprehn

Review URL: https://codereview.chromium.org/548113002

git-svn-id: svn://svn.chromium.org/blink/trunk@181528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added all the plumbing to make Blink aware of the top controls position
and how its viewport has been resized as a result. This CL adds all the
machinery and plumbing but does not yet connect main-thread scrolls to
the top controls. This is needed to support scrolling the top controls
during slow-scrolls as well as correct viewport behavior in the virtual
viewport pinch-to-zoom.

The machinery for top controls now includes two values:

top_controls_layout_height: The amount that the viewport was shrunk to
accommodate the top controls. This is updated only during a layout that
causes a viewport resize (i.e. RenderWidget::OnResize). The compositor
needs this to know how much the viewport layer has already been resized
by Blink.

top_controls_content_offset: The amount that the top controls are showing.
This will be the same as top_controls_layout_height right after a viewport
resize, but will diverge since the top controls will move without
immediately causing a RenderWidget resize.

Blink now keeps track of the top controls "content offset", which is the
distance the content is offset from the top of the screen due to top
controls. It receives updates to this value from the Impl thread during
a commit and echos them back to the compositor.

On the compositor side, the top controls layout height is moved into the
LayerTreeImpl. This is necessary since a commit will change the viewport
layer's size on the pending tree. Keeping it in LayerTreeHostImpl meant
that, until the pending tree was activated, the top controls layout height
corresponded to the viewport bounds in the pending tree. This was causing
flickering as the viewport container was the incorrect size for a short
time. The compositor also keeps track of the top controls content offset
value. The top controls offset uses the same model as page scale, keeping
an offset (the value as known by the main thread), a delta from the main
thread's value, and a sent_delta to keep track of what has been sent to
the main thread.

See: https://codereview.chromium.org/511253003 for Chromium-side patch.

BUG=333143

Review URL: https://codereview.chromium.org/513053003

git-svn-id: svn://svn.chromium.org/blink/trunk@181527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes some deadcode from CompositedLayerMapping:
1) hasContentsLayer - this function name was confusing.
2) isMainFrameRenderViewLayer - state is now all within CLM.

No new tests, no change in behavior.

Review URL: https://codereview.chromium.org/542863007

git-svn-id: svn://svn.chromium.org/blink/trunk@181526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline-o-matic failing to rebaseline these results: some issue with
changing to it's third_party/WebKit directory. Remove baseline requests
for multicol tests on Snowleopard Debug:

fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/client-rects.html

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/553673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline server is not submitting them at thit time, event though it
has been asked to do so. Ran webkit-patch rebaseline-expectations, and
pulled results from the 10.6 Mac bots for submit (old skool).

TBR=wangxianzhu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/554503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/multicol/client-rects.html
fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/548173002

git-svn-id: svn://svn.chromium.org/blink/trunk@181522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181520

TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/551633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rebaseline fast/layers/scroll-descendant-with-cached-cliprects.html on mac
after blink r181475 and r181499

TBR=ccameron@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/547233002

git-svn-id: svn://svn.chromium.org/blink/trunk@181520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181492

BUG=395425
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/551613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181519 bbb929c8-8fbe-4397-9dbb-9b2b20218538