GitLab

R=sky@chromium.org
BUG=121242
TEST=visual test

Review URL: https://codereview.chromium.org/132543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245604 0039d316-1c4b-4281-b951-d872f2087c98

Go back to KeystoneRegistration.framework 1.1.0.3659. The new registration
framework 1.2.0.6782, when using -[KSRegistration
checkForUpdateWasUserInitiated:YES], is not compatible with an older installed
Keystone version such as the current 1.1.0.3973. This results in the About
page showing "Update failed (error: 11)" and this message being printed to
stderr:

ksadmin: unrecognized option `--user-initiated'

In this case, updating is not broken, and Keystone will continue to update
Chrome in the background, but no indication of update availability will be
made in Chrome’s about page.

> Update KeystoneRegistration.framework to 1.2.0.6782.
> 
> The big change in this version is that an installation attempt initiated by
> the application can show up as ondemand on the server. This will allow us to
> provide throttled Mac downloads (such as a "5% push") with correct behavior.
> 
> BUG=35495
> R=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/141193002

BUG=35495
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/141583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245603 0039d316-1c4b-4281-b951-d872f2087c98

Previously this was ignored in the GN build but disabling the plugin is used on some buildbots.

BUG=http://crbug.com/330298
R=thakis@chromium.org, thakis

Review URL: https://codereview.chromium.org/142053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332167

Review URL: https://codereview.chromium.org/133273026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245601 0039d316-1c4b-4281-b951-d872f2087c98

This broke after switching the fetching of plugin stream data to the plugin process because now the data from ResourceDispatcher is passed directly to the plugin and it's read-only.

BUG=308466
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/141333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245600 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/139303018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245599 0039d316-1c4b-4281-b951-d872f2087c98

users.

In Google Chrome-branded builds, show an infobar at startup to users with
32-bit-only systems, and add a message to the about page for those users
advising that automatic updates will soon stop because the system
configuration is about to become unsupported.

A provision is made to change this message to an "end-of-the-line" message for
the final 32-bit-compatible build. When this switch is flipped, the autoupdate
status and promotion button on the about page will be hidden. The
"end-of-the-line" message will appear there, alongside the icon normally used
for failed updates. The startup infobar text will change at that point as
well.

No observable changes for non-branded Chromium builds (since they're not
receiving updates through this mechanism) or for users with 64-bit-capable
systems (because they're not being obsoleted).

R=arv@chromium.org, thakis@chromium.org, thakis
BUG=303280,331810,331830

Review URL: https://codereview.chromium.org/125443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245598 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330709,178409
TBR=glider@chromium.org,eugenis@chromium.org

Review URL: https://codereview.chromium.org/141943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245597 0039d316-1c4b-4281-b951-d872f2087c98

sky@ please look at the files in chrome/browser for owner approval.

Long term, the idea is to unify several updaters in Chrome, so having a specific namespace could help avoiding name conflicts.

Short term, the change reduces some naming verbosity in the implementation but makes the call site names longer, so it is a wash.

Review URL: https://codereview.chromium.org/138553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245596 0039d316-1c4b-4281-b951-d872f2087c98

Without this, GYP will fail if you manually specify gomadir in your GYP_DEFINES.

R=jamesr@chromium.org, jamesr

Review URL: https://codereview.chromium.org/137443024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245595 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org, scottmg

Review URL: https://codereview.chromium.org/138273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245594 0039d316-1c4b-4281-b951-d872f2087c98

Feedback API is in split mode, so without the parameter, the event may
get sent to a wrong profile.

BUG=334590

Review URL: https://codereview.chromium.org/137853016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245591 0039d316-1c4b-4281-b951-d872f2087c98

Using cc frames for now which should fix the bots. Also removing error to fix the perf-bots. I'll enable once I examine manually that all bots are working.

BUG=335610
TBR=ernstm@chromium.org
NOTRY=true

No-try since I've tested locally and this will fix the win perf bots.

Review URL: https://codereview.chromium.org/142033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245590 0039d316-1c4b-4281-b951-d872f2087c98

Rather than using the (now-obsolete) version in platform/android. Once
this lands, we can delete the android stub.

R=jamesr@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/120313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245589 0039d316-1c4b-4281-b951-d872f2087c98

"Get Started" was replaced by the new first-run UI.

BUG=319963

Review URL: https://codereview.chromium.org/139383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245588 0039d316-1c4b-4281-b951-d872f2087c98

This test is not possible with ubercomp, which is always on in aura.
So disable the test. It should just go away entirely once all platforms
are using ubercomp.

R=piman
BUG=272379,270918

Review URL: https://codereview.chromium.org/132963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245587 0039d316-1c4b-4281-b951-d872f2087c98

This was causing linux_aura single-process browser tests to crash since
they don't set up a default X error handler. When the compositor is
shutting down it does a finish and this might try to swap to the X
window.

Also change the windows shutdown ordering to match.

R=ben, enne
BUG=270918

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245028

Review URL: https://codereview.chromium.org/132473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245586 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the Chrome OS SAML login flow was passing the LSID obtained
via /ServiceLogin to /GetUserInfo in order to retrieve the authenticated
user's e-mail address. It turns out that this is wrong because
/ServiceLogin yields a browser LSID and /GetUserInfo expects a
programmatic LSID. In many cases, the two LSID flavors are identical and
the existing code worked. But under some conditions, the browser LSID
could be different, causing /GetUserInfo to fail.

This CL switches to /ListAccounts instead, which handles browser LSIDs.
An additional advantage of /ListAccounts is that it will read the LSID
from cookies, removing the need to extract the LSID from the cookie jar
explicitly.

I could have further simplified the code by doing an XHR to /ListAccounts
from the JS code of the auth extension, avoiding the JS -> C++ -> JS round
trip. However, this would have been a CORS request, requiring the GAIA
URL to be hard-coded in the auth extension's manifest. The implementation
in this CL, which makes the /ListAccounts call from C++, is more flexible
as it preserves the ability to change the GAIA URL via a command-line
flag.

BUG=332132
TEST=Updated browser test and manual

Review URL: https://codereview.chromium.org/134483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/131563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/141973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245583 0039d316-1c4b-4281-b951-d872f2087c98

We should take into account the font scale factor the user has chosen
when drawing text in the WebView.

(Also fixes presubmit warnings in AwSettings.java)

BUG=335343

Review URL: https://codereview.chromium.org/140913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329993
TBR=cpu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/136473012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245580 0039d316-1c4b-4281-b951-d872f2087c98

- Most visited iframe now uses postMessage() to signal the iframing page that the link has been displayed.
- Refactor most_visited_thumbnail.js to eliminate client-side secondary thumbnail fallback.
- Refactor UMA logging of NTP suggestions events.

The new postMessage() signal is sent whenever the iframe has failed loading the thumbnails, or when the thumbnail has been successfully loaded. This way it's impossible for the iframing page to learn whether the user has a given URL in its TopSites. The iframing page can use that signal to know when it's possible to display a fallback visual under the iframe.

The refactor significantly simplifies the iframe javascript by dropping support for multiple thumbnails, which can now be handled by the iframing page. UMA logging of NTP suggestions related statistics have also been both simplified and augmented. The patch also includes better unit tests for the UMA logging.

BUG=None

Review URL: https://codereview.chromium.org/102433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245579 0039d316-1c4b-4281-b951-d872f2087c98

Skip DisplayManagerTest.ScreenAfterShutdown on win8 (which doesn't support multiple dislpays on ash)

BUG=NONE
RDANBEAM

R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/142003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245578 0039d316-1c4b-4281-b951-d872f2087c98

Add a flag to disable GLIBCXX_DEBUG which is used in the GYP build on some bots.

TBR=scottmg

Review URL: https://codereview.chromium.org/141703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245577 0039d316-1c4b-4281-b951-d872f2087c98

Ensure no changes to the JSONSerializer or PrefHashCalculator ever end up producing different hashes for all existing Value::Type.

The current JSON serialization used "appears" to be standard and future-proof (i.e., doesn't use pretty_print or anything silly).

However, the hashing mechanism must be strong in the face of any potential future logic changes to either JSONWriter, JSONStringValueSerializer, PrefHashCalculator. This test protects against that.

As highlighted in code comments these test hashes must never be altered to satisfy a code logic change or PrefHash* breaks.

Kept existing test hashes for list/dict values and expanded the test to all other values.

Review URL: https://codereview.chromium.org/136473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245576 0039d316-1c4b-4281-b951-d872f2087c98

For foolish consistency. I'll never make this mistake again.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/140503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245573 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334796,307841

Review URL: https://codereview.chromium.org/137893023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245571 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245570 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165311:165317&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/140983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245569 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, replace the official key check in DriveAppRegistry::IsUninstallSupported
by the new devoted function. (In fact, the macro is available
only during google_apis/ hence the previous code was not working well...)


BUG=332332

Review URL: https://codereview.chromium.org/140783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288991
R=bradnelson@google.com
Reland of r245254

Review URL: https://codereview.chromium.org/141053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245563 0039d316-1c4b-4281-b951-d872f2087c98

* Split ScreenAsh to ScreenUtil (set of utility functions) and the screen implementation.
* moved screen_ash from Shell to DisplayManager. Ash specific imp is now hidden in DisplayManager.
* Shell now creates a separate screen object which simply keeps the list of displays for shutdown. This allow all screen operation valid during shutdown.

BUG=None
TBR=hongbo.min@intel.com,sky@chromium.org

Review URL: https://codereview.chromium.org/138003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335280
TEST=browser_test --gtest_filter=FirstRunUIBrowserTest.FirstRunFlow

Review URL: https://codereview.chromium.org/141803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245561 0039d316-1c4b-4281-b951-d872f2087c98

This is a prerequisite to adding the incompatible folders check to the
AOSP bot.

BUG=329540
TEST=run tool

Review URL: https://codereview.chromium.org/133073008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245560 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to remove more ExtensionService dependencies, which we need
to do because app_shell doesn't have an ExtensionService.

BUG=334706
TEST=existing unit_tests, browser_tests
TBR=sky@chromium.org for mechanical changes across the non-extensions bits of chrome/browser/

Review URL: https://codereview.chromium.org/139943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245556 0039d316-1c4b-4281-b951-d872f2087c98

ServiceRuntime::InitCommunication is a large method that does several things:
  - Sets up a command channel.
  - Loads a module (nexe).
  - Sets up a reverse channel.
  - Starts a module (nexe).

This change breaks this up into smaller methods. As part of the trusted plugin
refactor, we'll probably move setting up the reverse channel before loading the
module, and join loading and starting the module into one step.

This change should make the changes to use Chromium IPC easier to follow.

BUG=333950

Review URL: https://codereview.chromium.org/133073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245555 0039d316-1c4b-4281-b951-d872f2087c98

In accordance with popular opinion.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/133453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334358

TEST:
On a Pixel, install a downloads extension such as this.
https://chrome.google.com/webstore/detail/download-manager-button/jglgknilkoejnnjngnmoobbhdckpdmem
Either right-click on the browser action button and Inspect Popup, or open the background page console.
If there are no downloads, download a file so that there's a file icon to inspect. One easy way to download a file is to open this data url and click the link:
data:text/html,<a href="data:application/octet-stream," download=test-137043005.txt>download an empty file
Copy this javascript into the Developer Tools console:
chrome.downloads.search({limit:1}, function(items) {matchMedia('screen and (-webkit-min-device-pixel-ratio: 1.5)').addListener(function() {chrome.downloads.getFileIcon(items[0].id, function(icon) {console.log('dpr', devicePixelRatio, icon);});});});
This javascript finds a DownloadItem and listens for the devicePixelRatio to change, then fetches the file icon for the new devicePixelRatio.
Type Ctrl+Shift+- and Ctrl+Shift+= to decrease and increase the screen resolution until the console logs at least one line that begins with 'dpr 1' and another line that begins with 'dpr 2'. You might need to increase and/or decrease the resolution several times. The rest of the 'dpr 1' line should be different from the rest of the 'dpr 2' line. If the rest of those lines are the same, then this fix is broken.

Review URL: https://codereview.chromium.org/137043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245550 0039d316-1c4b-4281-b951-d872f2087c98