- 15 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e970e597b25..8e567c5cf507 2020-10-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: If924d299ff2903cfbecf65418aa35cbcbbb10913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817400}
-
Koji Ishii authored
NOTRY=True Change-Id: Ib088a06a2f6e85ac5cb23c6c8deb0b6b9eeae7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470038Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#817399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c83e15c6b61..40217a30c5c6 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d18ea8bb..914c0473 (817098:817219) 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cc4512db..d18ea8bb (816967:817098) 2020-10-14 danilchap@webrtc.org Refactor ScalableVideoController::OnEncodeDone signature 2020-10-14 danilchap@webrtc.org Distinguish id for GFD and DD rtp header extensions when both are advertised 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 51f6153d..cc4512db (816858:816967) 2020-10-14 alessiob@webrtc.org AGC2 config change detection fixed 2020-10-14 danilchap@webrtc.org Advertise dependency descriptor rtp header extension behind a field trial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e4c2e0d092473e220ecef7acbfd10cdf86ef142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473998Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a58a676ab96a..055495dfbb24 2020-10-15 tsepez@chromium.org Split IPWL_FillerNotify off into its own .h file. 2020-10-14 tsepez@chromium.org Replace class CFWL_List_Notify with a virtual interface. 2020-10-14 tsepez@chromium.org Reverse order of CPWL_ListCtrl and CPWL_List_Notify cleanup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137630 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6e712a2220f4569d1a354a44064a434d35253e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473826Reviewed-by:
-
Alexander Dunaev authored
Bug: 1138740 Change-Id: I444b8d297c920f0b4cf00352bfdb21da6c8ff21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474114 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#817396}
-
Md. Hasanur Rashid authored
This change resets PageScaleConstraints when the printing gets finished. The reason to reset is to avoid unexpected zoom which occurs due to change in page scale during printing phase. We reset the new_page_scale_factor to FinalConstraints().initial_scale by calling the methods SetNeedsReset(true). Bug: 1117391 Change-Id: I08817f1ac575daa5db3612d10d68f1fd40da7be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423673Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#817395}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a0f5452c6e23..324abbd44f95 2020-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cac0442277f7 to 84b70a6e4d93 (4 revisions) 2020-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7cb4c97a to 37c343f0 (470 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I34705a7a8559c9c7bbb26a73fbf7308fe80a29bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473999Reviewed-by:
-
David Tseng authored
R=dmazzoni@chromium.org Test: manually. With js-extension changes, verify chrome.tts.pause() and chrome.tts.resume() do as expected. Change-Id: Ib42e95923d39f3aeaea0d2d6065207a2f52d273a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472581 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817393}
-
Ramin Halavati authored
WebApps are disabled for Guest profiles. This CL updates them to be also disabled for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ic69e7f66a9047d3ac3bd849a6f53d2dfdcd3c9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470078Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#817392}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I4a19d5434de65d96933b0a8c1843702dcd6458eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468301 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#817391}
-
Jesse Schettler authored
Bug: 1059779 Change-Id: Id7c0b8fe77301bc947e6efe4edc53aa9aa6cf92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463555 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817390}
-
Dominic Mazzoni authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: Ia863d02ca500e6ef3a27a015d094252230ff1384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469456Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817389}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602676072-6b1951d9f0e9d329ad053bceb12040099bb1e856.profdata to chrome-win32-master-1602709027-5dd91a5323ea4bffe2a30c2aaff27b21af6d45ea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3c4b9eb6ccb6613b82abbd3092b48adc05aa99c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473219Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: Ibddf85e4e65d2acd63d52262a560d8df6d30f072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454722 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#817387}
-
Shubham Aggarwal authored
sql::Database uses internal state to manage its configuration options like page size, journal mode etc. These options need to be set before Database::Open() is called. Any change to this state has no effect if done after the database has already been opened. There are also some SQLite subtleties around different behaviour of this state depending on whether the database is being opened for the first time or being re-opened. This change encapsulates all such state into a sql::DatabaseOptions struct which is passed to the sql::Database constructor. This ensures that the required options have been configured before calling Open(). We migrate sql/ to use the new constructor instead of the setters for the state. In upcoming changes, we plan to remove the setters for this state. This will make the Database API enforce that the options are set only once and stay the same over the lifetime of the object. Bug: 1126968 Change-Id: Id44b6b3883f7a695f3b5cd96ad071e15cb1dc44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427035 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#817386}
-
Asami Doi authored
This CL tries to re-land the CL (1) which was reverted by the issue (2). (1) https://chromium-review.googlesource.com/c/chromium/src/+/2423698 (2) https://crbug.com/1134552 This CL mainly does the following things: 1) Make the timer start immediately after an event is enqueued, and erases the event from the queue when it has not started to run yet and the timeout happens. 2) Update kUpdateInterval because the minimum possible timeout is 10 seconds for offline events. 3) Set a callback to a hashmap (e.g. fetch_event_callbacks_) before calling EnqueueNormal/Pending/Offline() in SWGlobalScope. The change 3) is needed to fix the issue (2). An abort callback is possibly called before an event is started to run due to the change 1). However, previously, an event_id and a callback were set to a hashmap when a start_callback was called, so if an event was aborted before it starts, a hashmap didn't have a callback yet. Bug: 965802 Change-Id: Ic177e8aaab25527b3fa0b7a07aae51fca484bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460747 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817385}
-
Alexey Baskakov authored
This reverts commit 7bc2776d. Reason for revert: A culprit that breaks WebRtcCaptureFromElementBrowserTest.CaptureFromMediaElement test on Linux TSAN: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/59853 Original change's description: > Enable vaapi decoding on linux x86/64 by default. > > Bug: 1097029 > > Change-Id: Ib3105a11e5ad76f7ef22930246014a702e39d0dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436704 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817228} TBR=dalecurtis@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org Change-Id: I73a5d50738122ef5c81a0c7a92ec9016ac1420eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474233Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817384}
-
Eugene But authored
user_application_state contains information about device orientation, size class, sign in status, number of tabs, etc. Bug: 1103752 Change-Id: If3c3a379c77b7b2076af4ec2200047291de63ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463772 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817383}
-
Shakti Sahu authored
Marking some methods as deprecated, which should be removed soon, after 1 - Native autoresumption is launched. It's launched already to 100%. 2 - The new download backend flag is fully enabled. Change-Id: I769ecdad32a5d2b5607f1198294911f129db8f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463932Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817382}
-
James Vecore authored
This includes fixes to advertisement bytes, a crash bug in bwu_manager and some changes to webrtc. This uprev has been tested on device with CrOS <-> CrOS sharing and CrOS <-> Android sharing. There are still known issues with WebRTC for both initial connection and bandwidth upgrade, but BLE Advertisement and BT classic sharing is working for the most part. Change-Id: I52f07814dd3ec61be1715b2979c840da183e2ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472345 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#817381}
-
Prakhar authored
Reference: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2472980 Bug: 1024915 Change-Id: I484af17dae5aad08eb25a41c32b1abd0dd08fe33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473697 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817380}
-
Jesse Schettler authored
Add a new Polymer element, scan-settings-section, for shared styling of the scan settings. Bug: 1059779 Change-Id: I1cdc9b3857fc97a520f81024c9000d5a4b28414a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462278 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df97f4c2861e..95e0f2a77656 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC loyso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: loyso@google.com Change-Id: I9744d446d7d0b1ff977ddddf52809d512577b3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473823Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817378}
-
Alexey Baskakov authored
This reverts commit d1b3da5a. Reason for revert: Breaks tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20930 Original change's description: > Multipaste: Adjust the clipboard nudge bounds when hotseat is shown > > This change has the clipboard nudge observe the hotseat state and will > animate the bounds of the clipboard nudge so that the nudge is always > placed above the hotseat. > > Bug: 1137019 > Change-Id: If00afa1585e0382d7aa41789eca2a981b1323f1d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469364 > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817235} TBR=newcomer@chromium.org,mmourgos@chromium.org Change-Id: I9ada14cf0e126d129c5e99b28b6405fbf64457c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473782Reviewed-by:
-
Chloe Pelling authored
This is a copy of Crostini.Stability, with the same enum type. Also renamed the enum type to reflect its newly generalized usage. Draft design doc at go/borealis-stability. See https://crrev.com/c/2459490 for usage. BUG=b:166691285 Change-Id: Ic20e0a1885d8b8d88a1cecde89d4768993cb146f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460874 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Chloe Pelling <cpelling@google.com> Cr-Commit-Position: refs/heads/master@{#817376}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9a5e8ce8b873..046d0bf2b6a4 2020-10-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2c041f7edfde22c8569b55c2fb1a255d29ced7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473995Reviewed-by:
-
Hirokazu Honda authored
This is necessary to pass vaapi_unittest on volteer where AV1 capability is detected by VA-API driver. Bug: 1029212 Test: vaapi_unittest on volteer Change-Id: Ib2b7dff8141013e3807de23cfcfe58844258f8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398447 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817374}
-
Glen Robertson authored
Previously we were returning the smallest available icon, which could be larger (or theoretically smaller) than gfx::kFaviconSize. Bug: 1124748 Change-Id: Idf6b54dd455c395cd26a2798e196b5e190460ef6 Fixed: 1124748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474080 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
Now, ThreadController::SetDefaultTaskRunner() became non-deprecated function. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: If37dfc290d2f5d0f0d6c1ca2af7dc1b0dc938ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414328 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Jimmy Gong authored
If we cannot establish a connection within 15 seconds, we time out the connection and cancel Bug: 1106937 Test: chromeos_components_unittests Change-Id: Iad731f6119a900fa411d75a9c53869baabf33498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470321 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#817371}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I7b45430cf884b99776634580b60cdebffe569cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473996Reviewed-by:
-
Alex Newcomer authored
Just add the about flags entry so it shows up in chrome flags. Bug: 1138694 Change-Id: I6275533df40a2d1f46fdd6898f38e638531eec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473798 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817369}
-
Nicholas Verne authored
PermissionBroker is now able to re-attach kernel device drivers to USB device interfaces on detecting the closure of a lifeline pipe from Chrome. CrosUsbDetector and UsbDeviceManager now support this. CrosUsbDetector creates a pipe and stores the local end, sending the remote end to PermissionBroker when opening a device file descriptor. Fixed: 1128752 Change-Id: Ic5069c25183794036ad311f9f705ed8d24db5138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463022Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817368}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/28cb2dd6..58a1323e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd4ce6c9db086f2297d3ceaccd3993521ed991b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473741Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817367}
-
Noel Gordon authored
Our DevtoolsListener sends CDP commands to devtools to control it. And noting StringToSpan() use had grown repetitive in those many calls host->DispatchProtocolMessage // Command devtools to do something then provide a SendCommandMessage helper to do all that and inline the the StringToSpan() code directly (aka we can remove StringToSpan). Collecting the devtool's response to a SendCommandMessage is required, for a subset of the CDP commands sent. Change that helper's name so it clearly states what we are waiting for: AwaitCommandResponse. Tbr: benreich Bug: 1113941 Change-Id: I208f335377d634a07254905460bd9b58c0417d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473621Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817366}
-
Dale Curtis authored
This reverts commit 71020cea. Reason for revert: User reports some crashes. Original change's description: > Don't abort PictureBuffer operations during Invalidate(). > > These operations should continue in all cases since dismissing, > requesting, or waiting on picture buffers should happen regardless > of whatever the decoder is currently doing. > > R=liberato > > Bug: 1111273 > Change-Id: I7dc76ca22cca3f5f16c085a9cd9648275aa3e0c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473342 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817324} TBR=dalecurtis@chromium.org,liberato@chromium.org Change-Id: Ifd18a7e5793f100ea17113689971ec02c68e6492 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473588Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817365}
-
Xiaohan Wang authored
These metrics were added for Widevine CDM and Flash. Widevine CDM doesn't use PPAPI any more and Flash support is being removed in M88. This CL also removes the code that reports these UMAs. Bug: 1064647, 1138309 Change-Id: Ia57a9fd58c0703f51a1f384fb356196235a48929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473339Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817364}
-
David Bienvenu authored
Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550 Original CL didn't account for left and bottom docked dev tools. This CL handles those cases by looking at the incoming strategy.bounds. Bug: 974178 Change-Id: Ic2b7f0b8b642d884f563815b2ccc94a94d423eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472612Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817363}
-
Ramin Halavati authored
Net Error diagnostic dialog is updated to be NOT shown for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I468af46df1095e642d76945929327c0aa9106e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470521Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#817362}
-
Ramin Halavati authored
Announcement notification service is disabled for Guest profiles. This CL updates it to be also disabled for ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I07188559a37470dc3f4dae3ee595a6cbae4cf2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470519Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#817361}
-
