- 09 Sep, 2020 40 commits
-
-
Etienne Bergeron authored
This CL is making const the function that are not modifying the state of the resource bundle. This step is required to make the transition to a Reader/Writer lock. Bug: 1123115 Change-Id: I764a8657fe358ce8cc5097d7ca7140a48682afd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805414}
-
Mark Pearson authored
Largely the change is to make it more acceptable to emit impressions and other events that are not user triggered if it's useful/necessary for analysis. Change-Id: Ic9215981dd71846c3eb3db4ef3af87f40d1ca1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392712 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805413}
-
Ahmed Mehfooz authored
Bug: 1110760 Change-Id: I713b6810aa6d6f21da35e01bf12513df44a3ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398988Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805412}
-
Palak Agarwal authored
Bug: 1117534 Change-Id: I34823045b6e3364edbab94fd3eb74b8b1ef02d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397619Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#805411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8b9262d7426..9b74c18d1728 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: davidvc@google.com,adithyas@google.com Change-Id: I89b86a9d4b1e89bf30305960800f6e8bbaab5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805410}
-
Ryan Hansberry authored
The prior implementation of this function assumed that the provided |size| would match the number of bytes read. In reality, |size| is generally a very large value and number of bytes read may be smaller than it. Manually verified by successfully sending a 7KB file from Chrome OS to Android. Bug: 1124992 Change-Id: I781a2c1f69aee374a18c10641ed14f31eb7348f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393616Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805409}
-
Daniel Rubery authored
This is a reland of a4418459. The original CL was causing crashes due to UaF on the Scorer object. This CL fixes that issue by performing the thread hop within Scorer. Since the returning callback on the PhishingClassifier is guarded by a WeakPtr, this should be more safe. Original change's description: > Move visual feature scoring to helper thread > > This CL calls the GetMatchingVisualTargets in a worker thread, since > the process of scoring visual features takes longer than expected > and was blocking interaction. > > Fixed: 1121375 > Change-Id: I8f3e33d20f812645a72adfc16fe33241b49a6ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372869 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801907} BUG=1121375,1122534 Change-Id: Ifedb94ad8b613a2ba7377bb5bc7795e657a94512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386380Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#805408}
-
David Black authored
New HoldingSpaceClient APIs will be accessed from //ash to: - Copy an item to clipboard (stubbed) - Open an item in its folder (implemented) - Pin an item (stubbed) - Unpin an item (stubbed) Stubbed APIs will be implemented in a follow up CL. Bug: 1126274 Change-Id: Ie6790e935272d90064f278d8d916fd3b33445752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399764Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#805407}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/214971471446..5fc363ed10fc 2020-09-09 chrche@microsoft.com [Loc] Presubmit#3: LocV2 Checking the shape of localization API calls 2020-09-09 aerotwist@chromium.org Migrates theme patching to top-level ThemeSupport 2020-09-09 chrche@microsoft.com [Loc] Presubmit#2: prevent using of LocV1 APIs in migrated files 2020-09-09 jacktfranklin@chromium.org Persist the network filter text input. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I043e8f75d9b1f4e0beece1876c8a8b604adaa3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805406}
-
Joanmarie Diggs authored
This is a follow-up change to http://crrev.com/c/2346329 to address a missed comment. AXPosition::IsValid will check if the positions are valid, so update AXSelection to account for any triggered DOM mutations, and then call AXSelection::IsValid, which will check the validity of the AXPosition instances associated with the selection. Bug: 1113650 AX-Relnotes: N/A Change-Id: Ic7d72111b2172784bbd199b6fe7767b5badefa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396156 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805405}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599630228-06e78b920e92149bcb86488690cdbb2bed08546f.profdata to chrome-win64-master-1599651808-28c874736fb144e9b48a72308f081ee03ad277c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icab2c0aaab9ac3ced0a254eff33e62f3e84284c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401603Reviewed-by:
-
Ian Struiksma authored
Add win-1909 to os enum, update mb config. Bug: 990885,1125612 Change-Id: I419a4ebf018d70841ec62b8bdf2e9dfd26e21cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399721Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#805403}
-
Mark Pearson authored
Change-Id: Ifedf9d66171961cf4435c2714848ba49afc1b263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391512Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805402}
-
Xi Han authored
This is caused by passing a null TabContentManager in Instant Start: LayoutManagerChrome#setTabModelSelector(). As a result, StartSurfaceStackLayout isn't registered as ThumbnailChangeListener of the TabContentManager. Thus, it misses the event of the tab's thumbnails get fetched. Besides, a refactoring is done in this CL: 1) A Supplier of TabContentManager is passed to LayoutManager in the constructor. 2) Add separate API in Layout.java, i.e. setTabContentManager(). Bug: 1116449 Change-Id: Id220248d4ca3cfc832fc1506dfe9e41b32a5efd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355052Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805401}
-
Victor Costan authored
Bug: 1001838 Change-Id: I43735057f98c6041e852318126fbe5f46e4bee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400242 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Ahmed Mehfooz authored
Change in UX requirement to match check mark colors used in menu bubbles to match active pods. Bug: 1115873 Change-Id: I9629a763aae9388442dcb7588532df39d4aeff75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400238Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/447e7a69ecdd..21205c372020 2020-09-09 treehugger-gerrit@google.com Merge "Ensure unique entries in power_profile" 2020-09-09 hjd@google.com ui: Hack minimum screensize to fix heap profiles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:168048193 Tbr: perfetto-bugs@google.com Change-Id: I97cee88669380792a3cda63352b57342d6ef3726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401610Reviewed-by:
-
Gavin Williams authored
Change enum values to camel case to match style guidance for enum class members. Bug: 1059607 Change-Id: Icf5884449d1ad71b761dba7d14a64a7e478b801c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399566Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#805397}
-
Shimi Zhang authored
There is no states shared between tests, so we can easily apply @Batch(Batch.PER_CLASS) to this test file. I also migrated the EmbeddedTestServer to use EmbeddedTestServerRule, so we could reuse the EmbeddedTestServer between tests. Bug: 989569 Change-Id: I1ff0b5dc04a576a41e49c9d0ed9371ac1360e928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399903 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805396}
-
Ossama Mahmoud authored
Previously, on the login screen in kiosk mode, the shutdown button is to the left of the Apps button. But when DeviceRebootOnShutdown policy is turned on, the restart button is to the right of the Apps button. To make the order more consistent, now both shutdown and restart buttons are to the left of the Apps button. R=antrim@chromium.org, rsorokin@chromium.org Bug: 1113244 Change-Id: I410f8122cd5c5024d2f8f558d842fdf5124a97e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387055 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805395}
-
Jan Wilken Dörrie authored
This change removes the stale kGooglePasswordManager base::Feature from both Desktop and Android code. In addition, it also removes the corresponding chrome://flag and associated navigation to settings logic. Bug: 903249, 904821, 1126051 Change-Id: I8a77293fc61b4a721b2bae3c197dcade2cc5ea14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401338Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805394}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/168986591cc1..d281ff186273 2020-09-09 vyshu@google.com paygen: Stop adding unused attributes to update payload 2020-09-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-09 vapier@chromium.org cros_portage_upgrade: rename blacklist->ignore 2020-09-09 ahassani@chromium.org Reland "cros_update: Delete it." 2020-09-09 saklein@chromium.org commandline: Remove build-target type. 2020-09-09 vapier@chromium.org git: trim unused project methods 2020-09-09 bpastene@chromium.org cache: Handle trailing garbage when untarring via pbzip2. 2020-09-08 tcwang@google.com afdo: Only check milestone and timestamp for CWP profiles. 2020-09-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-08 manojgupta@chromium.org cbuildbot: Enable goma even with latest toolchain 2020-09-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-04 vapier@chromium.org gs_unittest: simplify stub tarball creation 2020-09-04 vapier@chromium.org gs: rm: add -- before path 2020-09-04 vapier@chromium.org image_test: ban tcl & update java packages 2020-09-04 saklein@chromium.org sysroot_controller: Ignore package versions in InstallPackages. 2020-09-03 moragues@google.com trogdor: add factory builder for factory-trogdor-13443.B 2020-09-03 vyshu@google.com remote_access: fix style 2020-09-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-03 morg@google.com Skip unit tests for grunt-arc-r board builders 2020-09-03 seanabraham@chromium.org config_lib: borealis is a special suffix to remove for HW testing 2020-09-02 mmortensen@google.com BuildAPI: Use optional packages in Packages.GetTargetVersions. 2020-09-02 gredelston@google.com test_that: Rename whitelist-chrome-crashes 2020-09-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-02 bpastene@chromium.org cache: Use 'pixz' when extracting .xz tarballs if it's installed. 2020-09-02 yichengli@chromium.org artifacts: Exclude private fingerprint libraries If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I9e2c4dd0273665b09311bd32cc43a1ce6c3f5b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401606Reviewed-by:
-
Sergei Glazunov authored
With this patch, PartitionAlloc holds the reference count (i.e. the number of associated CheckedPtrs) for every non-direct-mapped allocation. On free(), if the count doesn't equal zero, the allocation is poisoned and quarantined until there are no references left; therefore, use-after-free issues affecting CheckedPtr-protected pointers become unexploitable. This is a highly experimental feature, which is disabled by default. Bug: 1073933 Change-Id: Icda4b6e0c303e472df4222e1418bf0fdfe9aeef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385456 Commit-Queue: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805392}
-
Alice Wang authored
This CL batches AccountManagerFacadeTest. Bug: 1120258 Change-Id: I8dd38caa05b3d689b022d2e1f14ac959b346f51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398479Reviewed-by:
-
Adithya Srinivasan authored
crrev.com/c/2364049 fixed changed "GetChildCount" to return 0 for any node that is a leaf, and portals are considered leaf nodes (with prune tree enabled on Android) [1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/accessibility/browser_accessibility_android.cc;l=450;drc=6e8b402a6231405b753919029c9027404325ea00 Bug: 1120210 Change-Id: I021197d1f06ce92a1752f43c0aff85e9e66665f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391641 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Alexander Surkov authored
Bug: 1124366 Change-Id: Ib4e8309bf5e248623af7577fb74d3451d6c39bf8 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396620 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805389}
-
Koji Ishii authored
This reverts commit e7896817. Reason for revert: The fix for the most substantial issue crbug.com/1121885 was fixed, and the Google Keep issue crbug.com/1124446 was fixed too. This patch sets EditingNG to "experimental" for M87. Note, M86 is still "test". Original change's description: > Change EditingNG from experimental to test > > EditingNG has some instabilities such as <crbug.com/1121885>. > In order to help users who turn on "Experimental Web Platform > features" from hitting these issues, this patch changes > EditingNG back from "experimental" to "test". > > Once ourstanding issues were resolved, we will change it back > to "experimental". > > This is a revert of r791809 <crrev.com/c/2319947>. Some > rebaselines are needed because these tests do not seem to > honor "test" status. > > Bug: 707656, 1125477 > Change-Id: I433200cb7fb450036a631ee8ed578ab395413540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390936 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804839} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Bug: 707656 Bug: 1125477 Change-Id: I3e95b3630f2510378e39434bf52756b581647333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398359Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805388}
-
Josh Nohle authored
Fixed: b/166115080, 1106369 Change-Id: Iee1d5c90fd6c9d8e1ad38462f9611654275c0bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381734 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Sky Malice authored
Bug: 1124000 Change-Id: I9df9d450e7e1cd053407b24e83421a7d1242a19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389241Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Ioana Pandele authored
This reverts commit 849b3b5d. Reason for revert: The assumption that the progress signal comes after status signal was wrong, so this change causes a bug when re-running the check. Since this was meant to be merged, reverting + fix is easier than fixing in a follow-up CL. Original change's description: > [PwdCheckAndroid] Add delay between check status header updates > > This CL adds a delay to status updates whenever multiple updates are > notified to the mediator in a short time window. > The minimum time interval between updates is set to 1 second. > > Bug: 1122026, 1092444 > Change-Id: I64d9c95a11a5ed9b9d6fcf8941c260bf8b3a64ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390642 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805236} TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com Change-Id: I737eee5e355033542dc9ba8393eedc3390baf5de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122026 Bug: 1092444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401620 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1123907 Change-Id: Iff61b2298aecfa7f06f0755886896817613a50aa Tbr: davidvc@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401326Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805384}
-
Jeremy Roman authored
A cheap way of saving a kilobyte of binary size by simply making some fields narrower. This decreases the size of this from 20 bytes to 12 bytes per entry. 8 bytes could be done with some more intrusive repacking, but there are diminishing returns. Change-Id: If89d2025b6b374766d602cd7caafac5e675d4c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243252 Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805383}
-
mhasank authored
This is spin-off from https://crrev.com/c/2381050 and addressess the same re-entrancy problem for arcvm ConciergeClient::Observer is implemented by arc_vm_client_adapter.cc and crostini_stability_monitor.cc arc_vm_client_adapter.cc has the same issue as the container so the TEST below ensures that the change is same crostini_stability_monitor.cc is only firing metric ConciergeClient::VmObserver is implemented by arc_vm_client_adapter.cc, lock_to_single_user_manager.cc, crostini_manager.cc, cros_usb_detector.cc and arc_session_manager.cc I checked all the consumers and I don't see anything registering another observer in the event handler ConciergeClient::ContainerObserver is implemented by CrostiniManager when CrostiniManager gets OnContainerStartupFailed, it fires a callback as well The callback is ultimately StartLxdContainerFinished which then fires OnContainerStarted (in case of failure) on its own observer Which is implemented by CrostiniInstaller in which it fires its own callback that comes from Install method which seems to be only used in unit tests. ConciergeClient::DiskImageObserver is implemented by CrostiniDisk and PluginVMInstaller CrostiniDisk registers callback in OnResize which is a callback of ResizeDiskImage ResizeDiskImage is called in OnVMRunning which is a callback for ResizeCrostiniDisk which is called by CrostiniHandler::HandleResizeCrostiniDisk and ResolveResizeCrostiniDiskCallback is the callback that ultimately gets fired which invokes a javascript function PluginVMInstaller registers itself in OnConceirgeAvailable In the event handler, the PluginVMInstaller fires its own observer which is implmeented by PluginVmInstallerView which only updates the labels on UI. I don't see any place where we're adding another observer during these callbacks which would need to receive the same event that is currently being observed therefore the change is safe. BUG=b:164816080 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow TEST=deploy to dut, turn on crostini, successfully launch terminal, turn off crostini Change-Id: Ida55a24b04f87053bcfb7c958b63cc0ea883fa33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389060 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805382}
-
Xida Chen authored
Bug: 625562 Change-Id: I77bc4e7761e81254f73971f026d5e74a0a2d2d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394755 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805381}
-
Alexander Surkov authored
Bug: 1124366 Change-Id: I2dccf90e0de2ef06969630c0d6b890f5e619cf39 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392848 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium da5bb9a6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ib1415a7612717e7582a9869965035a26971390dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401059Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805379}
-
Brian Ho authored
SkiaOutputSurfaceImplOnGpu now creates a SharedImageFactory with a reference to its member SharedContextState, but due to C++ ordering of destructors, ImplOnGpu's destructor will actually decrement the refcount of (and potentially destroy) its SharedContextState before invoking SharedImageFactory's destructor. Unfortunately, ExternalVkImageFactory's destructor performs nontrivial work using the SharedContextState which may now be freed. This CL fixes this bug by explicitly deleting the SharedImageFactory before ImplOnGpu releases its members. Bug: 1125210 Change-Id: I5b625284622df537fd20ad58384cabbe7c46cf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399600 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#805378}
-
David Van Cleve authored
This reverts commit 55327727. Reason for revert: closes tree due to compile failure Original change's description: > Roll Catapult from dc9083e4831f to 6acdaf066c12 (1 revision) > > https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12 > > 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/catapult-autoroll > Please CC rmhasan@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: chromium:11249650 > Tbr: rmhasan@google.com > Change-Id: I54ff4cc762cc377c12d3a6a7a73d506dffb50304 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401598 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#805359} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,rmhasan@google.com Change-Id: Idb9a153ae3986b1ff1df4e74a9bb0d7b32369810 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:11249650 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401306Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805377}
-
Sean Gilhuly authored
Bug: 1021566 Change-Id: I5cde1174d6715c3d81dc0bf9f446bde6f567b7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391261Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#805376}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1313d1aa7a18..21bebc68fda6 2020-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 880013579381 to 0a1061da0c7f (14 revisions) 2020-09-09 johnstiles@google.com Return a 'made-changes' flag from control-flow optimization. 2020-09-09 reed@google.com remove unused (and bit-rotting) Lua support 2020-09-09 nifong@google.com Add a short description for concat and setmatrix saying whether it's a translate or something else 2020-09-09 cwallez@chromium.org Roll third_party/externals/spirv-cross/ 7778792ae..bdbef7b1f (19 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Ibe82846287a44ba3bd38516afdda043f84045fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401602Reviewed-by:
-
