GitLab

Overlay was sized to visible size, but it is not scaled together with the page.
Therefore, the correct size is equal to viewport size.

BUG=508136

Review URL: https://codereview.chromium.org/1327503002

git-svn-id: svn://svn.chromium.org/blink/trunk@201573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following Blink r201401, a plugin element's persisted plugin will be
cleared out upon the plugin element being removed from the tree or being
re-attached and there being no layout object. With Oilpan, this may
bring about disposal of the underlying plugin.

A disposed persisted plugin is consequently observable if subsequently
try to return the plugin wrapper object for the plugin element -- add
the required check so as to handle this properly.

R=haraken
BUG=526999

Review URL: https://codereview.chromium.org/1326603002

git-svn-id: svn://svn.chromium.org/blink/trunk@201572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1325833007

git-svn-id: svn://svn.chromium.org/blink/trunk@201571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vmpstr@chromium.org
BUG=525286
TEST=fast/hidpi/image-srcset-intrinsic-size-zero.html

Review URL: https://codereview.chromium.org/1326723002

git-svn-id: svn://svn.chromium.org/blink/trunk@201570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should not matter in regular case, as the Page, DatabaseClient and
InspectorDatabaseAgent all have the same lifetime.
But it looks like we can have DevTools initialized twice for the page in OOPIF case.

BUG=526162

Review URL: https://codereview.chromium.org/1323443004

git-svn-id: svn://svn.chromium.org/blink/trunk@201569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash occurs because longpress may cause script to run (blur, focus event
handles) which  may detach the frame. To prevent crashing we protect FrameView
while handling the longpress event and also guard against |frame->settings()|
being NULL which happens when frame detaches.


BUG=519905

Review URL: https://codereview.chromium.org/1315983004

git-svn-id: svn://svn.chromium.org/blink/trunk@201568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There was no explanation about LayoutBlock acting as the
concept of containing block. While at it, documented some
design decisions around the positioned descendant map.

Review URL: https://codereview.chromium.org/1304953005

git-svn-id: svn://svn.chromium.org/blink/trunk@201566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a new type of paint invalidation test for slimming paint v2.

- They are reftests, to check the correctness of painted result;
- Tracks paint invalidation objects and checks them against expected
  list.

This CL converts two paint/invalidation tests into the new style.

Will convert some fast/repaint and compositing/repaint tests into this
style for spv2 after this CL. The original tests are not suitable for
spv2 because
- it's hard to determine if a test is actually failing or needs
  rebaseline for spv2;
- they don't cover correctness of paint results.

BUG=524134

Review URL: https://codereview.chromium.org/1324763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The chromium-side fix in https://crrev.com/a609797f appears to have
fixed the flakiness of this test, per the dashboard. This change removes
the flakiness expectation so we can now catch regressions impacting this
test in the future.

TBR=philipj@opera.com
BUG=526337, 399523, 303419, 284782, 266631
TEST=http/tests/media/media-source/mediasource-duration.html

Review URL: https://codereview.chromium.org/1325823005

git-svn-id: svn://svn.chromium.org/blink/trunk@201564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

BUG=497761,510398

Review URL: https://codereview.chromium.org/1312353004

git-svn-id: svn://svn.chromium.org/blink/trunk@201563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Changed instrumentation-service-worker.js so the value NaN can be copied properly in cloneNotification.
- Added testing of NaN and null in serviceworker-notificationclick-event-data-reflection.html

BUG=525652

Review URL: https://codereview.chromium.org/1311413006

git-svn-id: svn://svn.chromium.org/blink/trunk@201562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Uncontrolled window clients should now be allowed to register one-shot
background sync events, as long as they have a registered service worker.
This patch removes the old test (which expected exactly the opposite
behaviour.) Part 3 changes the behaviour in Chromium, and a new layout test for
the correct behaviour is added in part 4.

This is part 2 of a now-four-part blink-chromium-blink dance.
Part 1: https://codereview.chromium.org/1309393003
Part 2: https://codereview.chromium.org/1324903002 (this patch)
Part 3: https://codereview.chromium.org/1316743002
Part 4: https://codereview.chromium.org/1314453003

BUG=5188884

Review URL: https://codereview.chromium.org/1324903002

git-svn-id: svn://svn.chromium.org/blink/trunk@201561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following recent spec change:
https://github.com/w3c/presentation-api/commit/628e6af030bc7dcb056191d7ffac60800fbe624d

BUG=527020

Review URL: https://codereview.chromium.org/1322123002

git-svn-id: svn://svn.chromium.org/blink/trunk@201560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As defined at [1], opaque FormData objects block JavaScript access to
'get()', 'getAll()', 'has()', and iteration. The data is available
internally for consumption in Fetch, but can't be directly accessed by
JavaScript in a page's context.

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#opaque-formdata

BUG=526995

Review URL: https://codereview.chromium.org/1323043002

git-svn-id: svn://svn.chromium.org/blink/trunk@201559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Full path: transitions/equivalent-background-image-no-transition.html

It seems to be failing consistanly every other day.

BUG=521764
NOTRY=true
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/1311413005

git-svn-id: svn://svn.chromium.org/blink/trunk@201558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Elements styled with "will-change: transform" are supposed to behave like
transformed elements for the purposes of containing block creation, even
if their transform value is "none". The idea is that setting a transform on
such elements should be fast, involving only moving a composited layer
rather than changing layout. Currently, this is implemented by changing the
computed value of transform from 'none' to the identity transform. However,
changing the computed value of transform causes animations on such
elements to interpolate incorrectly, since interpolating from 'none' is not
equivalent to interpolating from the identity (in particular, interpolating
from the latter can lead to matrix decomposition rather than numerical
interpolation, producing visually different results).

This CL changes makes "will-change: transform" no longer change the
computed value of transform. Instead, this CL makes
ComputedStyle::hasTransformRelatedProperty return true for elements with
"will-change: transform".

BUG=525886

Review URL: https://codereview.chromium.org/1318273003

git-svn-id: svn://svn.chromium.org/blink/trunk@201557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the appropriate DOMException is being thrown, we can test for that.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1314493008/
  [2] https://codereview.chromium.org/1316973002/
  [3] This CL.

BUG=522206

Review URL: https://codereview.chromium.org/1313493003

git-svn-id: svn://svn.chromium.org/blink/trunk@201556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=442139

Review URL: https://codereview.chromium.org/1318293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=pdr@chromium.org,mlamouri@chromium.org
BUG=527044,521764

Review URL: https://codereview.chromium.org/1309843008

git-svn-id: svn://svn.chromium.org/blink/trunk@201554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/1265953002/ contained a typo which
moved all 'plugin' content to blockable mixed content. It should have
been slightly more selective. Oops. :(

BUG=513163

Review URL: https://codereview.chromium.org/1326593002

git-svn-id: svn://svn.chromium.org/blink/trunk@201553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These test very likely need a rebaseline following
https://codereview.chromium.org/1322933003

BUG=506669,506669
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/1326493003

git-svn-id: svn://svn.chromium.org/blink/trunk@201552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=machenbach@chromium.org
BUG=chromium:527009
LOG=n

Review URL: https://codereview.chromium.org/1316203004

git-svn-id: svn://svn.chromium.org/blink/trunk@201551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove some now-unbound virtual slimmingpaint test entries along with
removing expectation for

 svg/as-background-image/animated-svg-animation-control.html

which was removed in r201021.

R=haraken
BUG=345655,370906,356658,356742,456357,522652
NOTRY=true

Review URL: https://codereview.chromium.org/1323963002

git-svn-id: svn://svn.chromium.org/blink/trunk@201550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Alternative approach for http://crrev.com/1274023003

Add WebThreadSupportingGC::createForThread(), which takes an
existing thread and add GC support for the thread.

If a thread is not given WebThreadSupportingGC creates a new thread
and owns it, otherwise it just uses the given thread.

BUG=518708

Review URL: https://codereview.chromium.org/1319363002

git-svn-id: svn://svn.chromium.org/blink/trunk@201549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prepares moving WorkerInspectorProxy and WorkerInspectorProxy::PageInspector to the heap.

BUG=509911

Review URL: https://codereview.chromium.org/1253293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=510650,525479
R=japhet

Review URL: https://codereview.chromium.org/1304183006

git-svn-id: svn://svn.chromium.org/blink/trunk@201547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature will not be used in Blink in the immediate future, so
remove it.

There are no callers or users.

BUG=348877
TEST=compiled

Review URL: https://codereview.chromium.org/1325613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |absoluteCaretBoundsOf()| for |VisiblePosition| to
"VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp"
to simpler for improving code health and ease of templatizing |VisiblePosition|
class to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1324873002

git-svn-id: svn://svn.chromium.org/blink/trunk@201545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Discussion: https://codereview.chromium.org/1306083008/
BUG=526608

Review URL: https://codereview.chromium.org/1322673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The StylePropertySet passed in to CSSParser::parseValue already has a
parse mode associated with it, which we can use instead of passing a
separate parser mode argument.

Review URL: https://codereview.chromium.org/1312843008

git-svn-id: svn://svn.chromium.org/blink/trunk@201543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Inline CSSCounterValue::listStyle in CSSCounterValue::customCSSText()
where it's used, and renamed listStyleIdent() to just listStyle().

Review URL: https://codereview.chromium.org/1314353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/1322083002

git-svn-id: svn://svn.chromium.org/blink/trunk@201541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460722

Review URL: https://codereview.chromium.org/1326523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace deprecated --enable-overlay-fullscreen-video with
--force-overlay-fullscreen-video so that the former can be
removed on the chromium side.

BUG=511376
TEST=virtual/android/fullscreen layout tests

Review URL: https://codereview.chromium.org/1314983004

git-svn-id: svn://svn.chromium.org/blink/trunk@201539 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves static member function |normalizeRange()| out from
|VisibleSelection| to "EditingUtilities.{cpp,h}" to make |VisibleSelection|
class not to use |PositionInComposedTree| directly for ease of templatazing
|VisibleSelection| to introduce composed tree version.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1328493002

git-svn-id: svn://svn.chromium.org/blink/trunk@201538 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebVector<WebVRDevice>* (ownership not transferred)
  => const WebVector<WebVRDevice>&

1/3: https://codereview.chromium.org/1317243002/
2/3: https://codereview.chromium.org/1309803006/
3/3: https://codereview.chromium.org/1321763002/

BUG=493531

Review URL: https://codereview.chromium.org/1317243002

git-svn-id: svn://svn.chromium.org/blink/trunk@201537 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=460722
R=domenic@chromium.org

Review URL: https://codereview.chromium.org/1308553005

git-svn-id: svn://svn.chromium.org/blink/trunk@201536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames |visiblePositionOf()| to |createVisiblePosition()| to follow
a review comment in http://crrev.com/1326563002, to indicate this function
isn't cheap like a accessor for improving code health.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311853004

git-svn-id: svn://svn.chromium.org/blink/trunk@201535 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Attributes from CSSPrimitiveValue and updated callsites to
instead create CSSFunctionValues. This only affects the 'content'
property (no other properties currently support CSS attributes).

BUG=523893

Review URL: https://codereview.chromium.org/1312543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer have internals.settings.setThreadedHTMLParser.
Remove its reference from a performance test.

BUG=None

Review URL: https://codereview.chromium.org/1308273008

git-svn-id: svn://svn.chromium.org/blink/trunk@201533 bbb929c8-8fbe-4397-9dbb-9b2b20218538