- 12 Nov, 2019 25 commits
-
-
Natalie Chouinard authored
Move ContentSettings-related methods from PrefServiceBridge to WebsitePreferenceBridge. This is part of a larger change to limit PrefServiceBridge to only feature-agnostic logic related to the native PrefService. Bug: 1016957 Change-Id: Id0f8dbca0444a3deaeb66ef64229066032b0d29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902258 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714348}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a2bf4dc..52f8e51c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifbf4f72e57566ae81106ac28b54827dc7730d8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908921Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714347}
-
rbpotter authored
Update Print Preview to use Polymer 3. This removes its usage of HTML imports. Also update pdf_scripting_api.js to be a module, since Print Preview can now import it. Reduces the size of Print Preview's resources in optimized builds by around 34k (7.7%): Before (P2): crisper.js 311k, vulcanized.html 132k = 443k total After (P3): print_preview.js 407k, vulcanized.html < 2k = 409k total Fixed: 1012574 Change-Id: Ic0cd4706ae9b1e395032d2b3758f4d9976ec52a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900688 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714346}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d3b6135c44d..2d0a87cb7e91 Created with: gclient setdep -r src-internal@2d0a87cb7e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879 Change-Id: If67d6fe3117f7fe9a45de73101313dabcdb1d41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910310Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714345}
-
dalyk authored
This error code will be used when a DoH server hostname cannot be resolved due to a DNS issue. Bug: 1016325 Change-Id: Icfe5ecd2d80c3182a540340adb7858b8a0c6f88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906904Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#714344}
-
Julian Watson authored
Bug: 1017511 Change-Id: I5a7773cf33fbd69c0d400dbbf2fdf99cd4dfed48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904559 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#714343}
-
Simon Que authored
Previously reverted as possible culprit in long build times on Oct 29-30, but turned out not to be. Revert CL: crrev.com/c/1890997 No new changes in reland CL except for rebasing. ========================================== CI builders: - Android ASAN (dbg) - Android arm Builder (dbg) - Android arm64 Builder (dbg) Try builders: - android_clang_dbg_recipe - android_compile_dbg - android_n5x_swarming_dbg - android_arm64_dbg_recipe - android-oreo-arm64-dbg - android-pie-arm64-dbg Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: Ib1ddb51218ab9cacb4a83ee98560ba8a3b23b4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909948Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#714342}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::ReferenceBoxForClipPath()| to utilize |NGInlineCursor| for prepration of migrating to |NGFragmentItem|. Bug: 982194 Change-Id: Idb4ed39dc2185033b3a0607398649e099f543506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909066 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714341}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3c4707d608f2..503d196f2b70 git log 3c4707d608f2..503d196f2b70 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 chrisforbes@google.com Allow depth/stencil attachment to be VK_ATTACHMENT_UNUSED in clear Created with: gclient setdep -r src/third_party/swiftshader@503d196f2b70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/144280552 Change-Id: I059654d87b94210995569952d3114fc658e7fceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714340}
-
Varun Khaneja authored
The current implementation of checking high confidence allowlist returns NO_MATCH if any of the following apply: 1. The DB isn't enabled yet. 2. If the URL scheme can't be checked. 3. If the list hasn't been loaded from the disk yet. Since Chrome now falls back to hash based checks in the case of an allowlist match, it's safe to return MATCH if any of the above conditions happen. Bug: 963165 Change-Id: I3b311ed6124865c5e3236bd83dec62a640b6d881 Fixed: 1022628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906645 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714339}
-
Asanka Herath authored
R=mmenke@chromium.org Bug: 927182 Change-Id: I610973df09e2fe1e370a4ca2b2c3ecc90af790c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907150 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714338}
-
Xianzhu Wang authored
This is the first step to make scroll independent of cc::Layer. TBR for trivial change under ui/compositor R=bokan@chromium.org TBR=flakr@chromium.org Bug: 1015625 Change-Id: I38234b39f525e54076b0a209b56fcffd0478b359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904875 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714337}
-
Ben Kelly authored
This is important since we do not want to expose the existence of the x-CacheStorageCodeCacheHint header for an opaque response by accident. Bug: 1007272 Change-Id: Ide6f863e732a7b145a244e5ad0f5670bf740a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906808 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714336}
-
Maggie Cai authored
This CL fixes the issue where the new function in intent_helper.mojom didn't increase MinVersion number. BUG=853604 Change-Id: I4f40724a1c0e4d66d4333d90e9c3dd2d926837ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909050Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714335}
-
Xianzhu Wang authored
We should always accumulate the update rect and never set it directly. This change can prevent errors, and avoid duplicated union code and the comments above them explaining the reason of union. Change-Id: I53fbfe9d8b67bdab841b66a8123ad4b6b4cf6f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910520 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714334}
-
Eric Orth authored
Makes it so requesting cancellation and shutdown behavior can be consistent with all other HostResolver requests, including cancellation of requests on ContextHostResolver destruction. For now, just interacts with the previously created DnsClient (but now private) ::SetRequestContextForProbes() and ::CancelProbesForContext(). In a subsequent CL, will move all the logic for actually starting probes outside DnsClient so that this Request object will actually start and cancel the probes more directly. Bug: 1013350 Change-Id: I60554a0a3406383e90563b1d08f2a830f595b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838300 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Yusuke Sato authored
With this CL, ArcVmClientAdapter copies two prop files in /usr/share/arcvm to /run/arcvm/host_generated with or without modifications (depending on whether the board is unibuild) before asking vm_concierge to start ARCVM. BUG=b:123309049 TEST=try, verify manually on coral, verify chrome can run cros_region_data command. Change-Id: Ic04676f3fc07fea8bb5b4a61525206151cd6d5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906471Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714332}
-
Mirko Bonadei authored
While testing the WebRTC component build [1], lld-link started to complain with the following error: undefined symbol: __imp__CertOpenStore@20 This is caused by the fact that //remoting/host:common don't have crypt32.lib in its libs and it was relying on WebRTC to link it. In component build mode, WebRTC is a shared library and its libs are not propagated so //remoting/host:common needs to explicitly tell GN to link against crypt32.lib. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 Bug: webrtc:9419, 1023444 Change-Id: I35e60f96d616c5b56be719a488e354f471842a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910231 Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714331}
-
Scott Violet authored
See http://go/android-api-guidelines?cl=head#no-public-typedefs BUG=none TEST=none Change-Id: I162c73dd1d5f4f6bbab06e27b52cbf63afe61159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909275Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714330}
-
David Benjamin authored
Bug: 908955 Change-Id: I237b5be47f7f2518714c2f83f4f9d44a9060f605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906476 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Chromite changes to deploy locales/*.pak.gz files has landed. NOTE: This CL depends on the following chromite change (which copies .gz locale files to the Chrome OS image): https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1903536 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1883292/ Original reviewer: TBR=agrieve@chromium.org For trivial change to resource_bundle.cc: TBR=sky@chromium.org Bug: 1017864 Change-Id: I384f1c2d0a2771e9121723ce8d10519f1ac1af9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906944 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714328}
-
Dan Beam authored
Bug: 1020450 Change-Id: I2bfef825d6b5802acf708a8ee482038706ad8537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904812Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714327}
-
Jimmy Gong authored
Bug: 1022622 Test: end to end manual Change-Id: I4202b54fb2788308da01b649b0b8e77bc4b51cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903819 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Bug: 1023162 Change-Id: Ia8d07cf6ea1742c27b781d5214e47b347e7d3317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906458Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714325}
-
Henrique Nakashima authored
Its usage was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1691241 Change-Id: I9e4bd841ea4b632a0fbb1df7ff0338f23989884e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910426Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#714324}
-
- 11 Nov, 2019 15 commits
-
-
Meredith Lane authored
This reverts commit 95adcd45. Reason for revert: https://crbug.com/1023346 and further review required Original change's description: > Integrate element reflection with the Accessibility Tree > > This change now migrates the existing accessibility code to rely on the > attr-associated-elements set via the content attribute or IDL attributes. > > Followup work to: https://crrev.com/c/1687013, https://crrev.com/c/1781917 > > Bug: 981423 > Change-Id: If004f20d67ec6795ed3e0b54a73ff6999aed0af8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826397 > Commit-Queue: Meredith Lane <meredithl@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714129} TBR=aboxhall@chromium.org,tkent@chromium.org,meredithl@chromium.org Change-Id: I2b14b7e6fc604c9b7c584730f70128593b5b859f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911059Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#714323}
-
Wez authored
Previously WebEngine was falling back to SW compositing after 3 GPU process crashes. This is not desirable when Vulkan is enabled because it may mask other issues. Also not all features work correctly with SW compositing (e.g. it's not compatible with HW video decoder). Also added --disable-software-rasterizer to disable SwiftShader as we should never need to use it on Fuchsia. Bug: 38358 Change-Id: I3dca90da04e51762e83f90217a574189545a358b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905267Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Dana Fried authored
See notes below. Revisited with bugfix and better testing. Bug: 1021332, 1003500 Fixes: 1021332, 1003500 This reverts commit a078d9ff. Reason for revert: Reverting a revert after a more thorough bugfix. Original change's description: > Revert "Layout invalidates when child view's visibility changes. > " > > This reverts commit 9932d106. > > Reason for revert: Broke a test with insufficient testing (see crbug.com/1021332) - will require additional investigation. > > Original change's description: > > Layout invalidates when child view's visibility changes. > > > > > > > > Exactly what it says on the tin. > > > > > > > > This is a fix for legacy layouts (fill, box, grid) which aren't derived > > > > from LayoutManagerBase and which do not benefit from the logic in that > > > > class which handles the invalidation. LayoutManagerBase still overrides > > > > this logic with something more sophisticated. > > > > > > > > If in the future a legacy layout overrides ViewVisibilitySet(), it > > > > should either call the base implementation or handle the invalidation on > > > > its own. > > > > > > > > > > Bug: 1003500 > > > > Change-Id: I9eccef21784175820816852e1b9c05d0713ef2eb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894260 > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Reviewed-by: Siyu An <siyua@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711966} > > TBR=siyua@chromium.org,dfried@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1003500 > Change-Id: I9f82556592e9e8db02900620085250e696ab30c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899387 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712497} Change-Id: Icffc2998f6e92602ec39a5533fafe0fe4ea65335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900146Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#714321}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I504c2d512f83cd8858183cf14c5eae57b5705b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910303Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#714320}
-
John Budorick authored
Bug: 1011474 Change-Id: Ia35fbae4f6cf33052df6b0b1932ef641606caa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908719Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714319}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1023079 Change-Id: Iad81472ebfbdbd65d72391e1d9d38d23c2317a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907519Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714318}
-
Regan Hsu authored
Centering options should not appear for wallpaper images that are not saved on the user's device. Currently, they do for all images. This CL ensures that the 'center' and 'center cropped' options only appear for wallpaper images that are local to the device. screenshots: local image - https://screenshot.googleplex.com/iJmCUfbRiYK provided by google - https://screenshot.googleplex.com/kuD2X94vTUV Bug: 1022341 Change-Id: Icbf5afceb9dcd6615f9afb7fd0d5e1b8a6f3b982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904868Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714317}
-
Navid Zolghadr authored
Change-Id: I52d65971d0c049e7c7bc8c86a69303d60b26fa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908718Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714316}
-
Theresa Wellington authored
BUG=1023437 TBR=pkotwicz@chromium.org Change-Id: I55cb5b40474a13a7e026c6c74e50f40d8c7f184c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906900Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3573aac4baff..fc903818f301 git log 3573aac4baff..fc903818f301 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 dburger@chromium.org Remove more references to the no longer relevant binhost-pre-cq. 2019-11-11 dburger@chromium.org Paladin build timeout back to 5 hours. Created with: gclient setdep -r src/third_party/chromite@fc903818f301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4634e310d2b36ae47ff21764859d44b461c19f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909649Reviewed-by:
-
Yutaka Hirano authored
...to remove a finch warning. Bug: 1018081 Change-Id: Idbbe2b9c5eda9051ecac9887bccdf754046caeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906457 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714313}
-
Sergey Ulanov authored
shadow-call-stack is enabled by default on Fuchsia now, so we no longer need to enable it explicitly. Bug: 821951 Change-Id: I221bc557bf93dfd5bf7c1659f7f8dfc32129c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898631 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#714312}
-
Toni Barzic authored
Instead of translating and changing opacity of the whole app list contents view, update the individual pages. This makes expand arrow translation unnecessary (it was causing the arrow to disappear for a moment when transitioning between peeking and full-screen state). Animate the apps container children's opacity separately - previously, the apps grid opacity was reset to match the final state when transitioning between app list view states, and we were relying on contents view animations to set up opacity as expected. This had an unintended consequence of apps grid clearing out when moving to closed state. Additionally, fixes ResetForShow not to reset search box opacity and contents opacity if the view is already animating to kClosed state (so if the app list is animating when the view state changes, the search box and contents opacity position gets animated from the current state instead of snapping to kClosed values first). BUG=1022656,1022655 Change-Id: I06d6521a067d81e159624d269ecc476435e19610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907473 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714311}
-
Lei Zhang authored
Several tests effectively have one-off implementations of GetRootAccessibilityNode(). Replace them. Fix some nits along the way. Change-Id: I966102e33d0d38fcd99291343c49a240a6884d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906302Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#714310}
-
Alex Newcomer authored
Just check that work area updates don't occur unless going to/from tablet mode. Bug: 1019531 Change-Id: Ie823fad80c4617137482ea3755b48490f01c71bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907414 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714309}
-
