GitLab

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setCompositionFromExistingText

BUG=590369

Review-Url: https://codereview.chromium.org/2316963003
Cr-Commit-Position: refs/heads/master@{#417196}

BUG=None
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2321803002
Cr-Commit-Position: refs/heads/master@{#417195}

Original issue: http://crrev.com/2299673002
Second attempt: http://crrev.com/2299283002

Fix the flakiness by not trying to toggle accessibility off and on between the
two runs of the same page within each test.

Code leftover from the pre-OOPIF days was causing us to exit early from
the RenderAccessibilityImpl constructor for some child frames that were
already loaded. Everything worked fine if accessibility was already enabled
when loading the frame, but if the frame was already loaded and then
accessibility was enabled, this could cause it to fail to create an
accessibility tree.

The code in RenderAccessibilityImpl is no longer needed because now we
have exactly one accessibility tree per frame.

This wasn't caught by tests because we didn't cover both scenarios, we
always enabled accessibility first.

Added two variants of existing tests that load the page first and then
enable accessibility.

BUG=640231
TBR=dtseng@chromium.org

Review-Url: https://codereview.chromium.org/2317323002
Cr-Commit-Position: refs/heads/master@{#417194}

This patch:
- makes StylesSourceMapping listen to styleSheetAdded/styleSheetRemoved
  events by itself. SASSSourceMapping doesn't need to - it relies on
  SourceMapAttached event.
- disposes CSSWorkspaceBindings.TargetInfo properly, by disposing
  CSS mappings.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2298373002
Cr-Commit-Position: refs/heads/master@{#417193}

https://chromium.googlesource.com/skia.git/+log/828ed1777da7..5e3a63075397

$ git log 828ed1777..5e3a63075 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 mtklein GN: default to -O1
2016-09-07 msarett Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGamma
2016-09-07 msarett Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of https://codereview.chromium.org/2294993002/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319553004
Cr-Commit-Position: refs/heads/master@{#417192}

New feature in 2.8:
- block assignment
  {% set var_name %} content {% endset %}

Manually edited files:
  README.chromium
  get_jinja2.sh

BUG=

Review-Url: https://codereview.chromium.org/2316103002
Cr-Commit-Position: refs/heads/master@{#417191}

This refactors the favicon decode+downscaling+reencode logic into a
utility method and calls it on the history thread instead of
janking the UI thread.  (I left in a call in the original site as a
fallback path, but it will typically early-return as the work was
already done.)

I also added TRACE_EVENTs to help diagnose future performance issues.

BUG=644573

Review-Url: https://codereview.chromium.org/2313563002
Cr-Commit-Position: refs/heads/master@{#417190}

Using input language instead of the application locale to determine the Omnibox's text input type on Windows.

This cl contains a small refactoring of:
1) Changes GetInputLocale() to IsInputLocaleCJK(), so that the function would less likely to be abused.
2) Makes InputMethodBase to have empty implementations for OnInputLocaleChanged/IsInputLocaleCJK.

BUG=344834

Review-Url: https://codereview.chromium.org/2298123003
Cr-Commit-Position: refs/heads/master@{#417189}

There are known bugs affecting this test and it's failing
intermittently on linux_optional_gpu_tests_rel.

BUG=644572
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2320033002
Cr-Commit-Position: refs/heads/master@{#417188}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/80c86caa50d1..e385b94f6be7

$ git log 80c86caa5..e385b94f6 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [devil] Add experimental keyboard script.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2317423002
Cr-Commit-Position: refs/heads/master@{#417187}

TBR=fmalita@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2322853002
Cr-Commit-Position: refs/heads/master@{#417186}

The share intent is started with a delay because of screenshot capturing
and compressing. But, lot of times the other activity never uses the
screenshot. The screenshot capture, compress to jpeg and write to file
can be done in background when the user is selecting the app shared to.

This CL introduces a BlockingFileProvider that provides an empty file
uri without any contents and shares an intent. While sending the intent
it also triggers the screenshot capture. When the file is actually
requested by the other app, the file provider will wait till the capture
is done and the file is written. The blocking practically never happens
because the user takes some time to click on the app, before which the
capture is finished.
The BlockingFileProvider is made default file provider and the
CompatibilityFileProvider logic is added to it.

BUG=615229

Review-Url: https://codereview.chromium.org/2143133002
Cr-Commit-Position: refs/heads/master@{#417185}

This allows V8 to indirectly throw a DOMException, as is required to handle
certain kinds of errors encountered during serialization.

BUG=chromium:148757

Review-Url: https://codereview.chromium.org/2316763002
Cr-Commit-Position: refs/heads/master@{#417184}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/49f9a08dca7722a11e339291bb6e252c4056a1a5 Remove ignored bot_update "force" parameter. (iannucci@chromium.org)

R=iannucci@chromium.org
BUG=643885

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2321563003
Cr-Commit-Position: refs/heads/master@{#417183}

Add properties for getting the session type and the playstore status to
chromeosInfoPrivate. This CL also whitelists the GetHelp and the Demo
apps to be able to use the API.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG=644432,644446

Review-Url: https://codereview.chromium.org/2314313002
Cr-Commit-Position: refs/heads/master@{#417182}

BUG=539723

Review-Url: https://codereview.chromium.org/2321433002
Cr-Commit-Position: refs/heads/master@{#417181}

This CL implements experimental feature to skip 'Sign In' button
in OptIn flow. Currently it is implemented as 'sandbox' on server
side and this is available only for internal IP addresses. It is
optional and can be activated in chrome://flags.

BUG=b/28987931
TEST=Manually on device in both modes.

Review-Url: https://codereview.chromium.org/2320813002
Cr-Commit-Position: refs/heads/master@{#417180}

Current deps diffs shows lots of files differs only first certain bytes on Windows.  They are COFF timestamp difference, and we do not usually need to check.  Let me skip showing them.

BUG=314403

Review-Url: https://codereview.chromium.org/2303063003
Cr-Commit-Position: refs/heads/master@{#417179}

This is in preparation for deploying the Mac ASAN bot, which will spawn
jobs on multiple GPU types.

Add "can_use_on_swarming_builders" flag for non-swarmed
tab_capture_end2end_tests.

This CL is a no-op with regard to the generated JSON files. The next CL
will add the new builder/tester.

BUG=644920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,maruel@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2325533002
Cr-Commit-Position: refs/heads/master@{#417178}

Bezier swatches will complement color swatches.

BUG=642782

Review-Url: https://codereview.chromium.org/2297873004
Cr-Commit-Position: refs/heads/master@{#417177}

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972

Review-Url: https://codereview.chromium.org/2307353002
Cr-Commit-Position: refs/heads/master@{#417176}

Document::attach/detachLayoutTree is confusing. It's indeed attaching/detaching
layout trees but doing more things than that. In particular, Document::detachLayoutTree
does a bunch of disruptive operations unlike other Node::detachLayoutTree.

It's better to rename Document::attach/detachLayoutTree to Document::initialize/shutdown
and make it clear that they can be called only once when the Document gets
initialized/shut down.

BUG=610176

Review-Url: https://codereview.chromium.org/2318913002
Cr-Commit-Position: refs/heads/master@{#417175}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dd201d4c3af933224a9563515766f3eff245f688 Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. (kbr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644920

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320723004
Cr-Commit-Position: refs/heads/master@{#417174}

BUG=639095

Review-Url: https://codereview.chromium.org/2320563003
Cr-Commit-Position: refs/heads/master@{#417173}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7381c2dc..697e77ea

$ git log 7381c2dc..697e77ea --date=short --no-merges --format='%ad %ae %s'
2016-09-06 yyanagisawa@chromium.org cros_chrome_sdk: a flag to skip starting goma in cros_chrome_sdk.
2016-08-31 yunlian@chromium.org chromite: add peppy to the chromiumos-sdk bot

BUG=639432

Review-Url: https://codereview.chromium.org/2319513002
Cr-Commit-Position: refs/heads/master@{#417172}

https://pdfium.googlesource.com/pdfium.git/+log/7b68f616e492..8c2a8cda1bdb

$ git log 7b68f616e..8c2a8cda1 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 tsepez Fix spelling of "Formated" in several variables

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2324693002
Cr-Commit-Position: refs/heads/master@{#417171}

https://chromium.googlesource.com/chromium/src/+/397fa7cad

BUG=644122
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2325493003 .

Cr-Commit-Position: refs/heads/master@{#417170}

Using update-w3c-deps in Chromium cf4d11d6.

Review-Url: https://codereview.chromium.org/2309603003
Cr-Commit-Position: refs/heads/master@{#417169}

The browser process normally never needs to validate sync tokens unless
it's returning resources to a renderer, so it's possible the highest
verified flush ID will almost never be updated and the list of
unvalidated flush IDs will grow indefinitely. Force a validation if that
happens to avoid wasting memory.

BUG=635051
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2318933005
Cr-Commit-Position: refs/heads/master@{#417168}

https://chromium.googlesource.com/skia.git/+log/14fe8cc16d2a..828ed1777da7

$ git log 14fe8cc16..828ed1777 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 msarett Add color xform support to SkWebpCodec

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2319723003
Cr-Commit-Position: refs/heads/master@{#417167}

This patch:
- removes WI.CSSWorkspaceBindings.pushSourceMapping. There's no need to
  push any source mappings - rawLocationToUILocation can always query
  SASSSourceMapping first and then StylesSourceMapping.
- removes WI.CSSWorkspaceBindings.HeaderInfo. The class was inlined into
  WI.CSSWorkspaceBindings.TargetInfo.

BUG=642583
R=dgozman

Review-Url: https://codereview.chromium.org/2300523002
Cr-Commit-Position: refs/heads/master@{#417166}

The test was crashing in the controller.GoBack() case with PlzNavigate enabled. Reason being we don't find a frame to navigate to. Thanks to clamy for pointing out
that the sequence numbers setting code in the frame navigation code caused that.

Fix is to add the item sequence number and document sequence number to the page state. Added a helper
function to the TestRenderFrameHost class called CreatePageStateForURL
which provides this functionality.

BUG=510836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2309583002
Cr-Commit-Position: refs/heads/master@{#417165}

This patch iterates on the raster/decode split to include skewport into
consideration. Specifically, in addition to limiting preraster to 1000
pixels, we also limit it by half of the skewport extent, where skewport
extent is the largest padding in any direction away from the viewport.

The tough scrolling cases seems to indicate that checkerboards
remain roughly the same with this patch.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317913002
Cr-Commit-Position: refs/heads/master@{#417164}

https://chromium.googlesource.com/angle/angle.git/+log/5a7e20e..9df01f8

BUG=614178,chromium:638323,644846

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2320863002
Cr-Commit-Position: refs/heads/master@{#417163}

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage (SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484

Review-Url: https://codereview.chromium.org/2313593002
Cr-Commit-Position: refs/heads/master@{#417162}

This pulls out all of the lifetime logic for the WorkerThread into the base class ThreadedMessagingProxyBase.

This will allow us to re-use all of the lifetime logic (I've created a followup demo patch which does this https://codereview.chromium.org/2312493002/)

BUG=567358

Review-Url: https://codereview.chromium.org/2310673002
Cr-Commit-Position: refs/heads/master@{#417161}

* Fail if it finds a non-trivial AndroidManifest.xml
* Fail if it finds any .so files
* Fail if it finds any assets
* Support proguard.txt

This also tweaks the naming of the sub-jar targets to give them better
target names (which show up in .jar names).

TBR=bshe
BUG=640836

Review-Url: https://codereview.chromium.org/2309643002
Cr-Commit-Position: refs/heads/master@{#417160}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/576345e444a3..80c86caa50d1

$ git log 576345e44..80c86caa5 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 jbudorick [telemetry] Make browser finding on android tolerate device faults.

BUG=644270

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321813002
Cr-Commit-Position: refs/heads/master@{#417159}

Currently, it's impossible to work on remote module as it tries to load source from the cloud.

BUG=none

Review-Url: https://codereview.chromium.org/2324633002
Cr-Commit-Position: refs/heads/master@{#417158}

VS 2015 Update 3 offers numerous improvements such as improved
language conformance, fixes to avoid linker crashes, and
improved code-gen for faster performance. Update 3 also resolves
some problems with incremental linking silently falling back to
a full link.

It also fixes an internal compiler error in /analyze builds.

The landmines change is needed because otherwise things like the
out\Release\cdb directory do not get regenerated.

The process for creating this package is:
- Create a clean Windows VM running Windows Server 2012 R2 (en_windows_server_2012_r2_vl_with_update_x64_dvd_6052766.iso, SHA1: 247EAEE5628850A41F0C51471656AAFB2492EA08, Standard Edition)
- Install depot tools, run ‘gclient’, and add depot_tools to the path
- Install VS 2015 Professional Update 3 - must have been installed after July 12th to get the latest fixes - with these settings and nothing else:
 * Visual C++ and make sure the three nodes underneath are also selected
 * Under Universal Windows App Development Tools make sure the "Tools (1.4.1) and Windows 10 SDK (10.0.14393)" and the "Windows 10 SDK (10.0.10586)" nodes are selected and nothing else
- Copy the *Debugger and Tools*.msi installers from another machine and run them. The 10.0.14393 versions (Anniversary Edition) should be used.
- Then run:
    python depot_tools\win_toolchain\package_from_installed.py 2015

It is also possible to package the 14393 SDK by running this command,
but that change is being saved for later:
    python depot_tools\win_toolchain\package_from_installed.py 2015 -w 10.0.14393.0

BUG=627216,636468,427616,637456

Review-Url: https://codereview.chromium.org/2106203002
Cr-Commit-Position: refs/heads/master@{#417157}