Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 22 Oct, 2014 3 commits
    • dcheng's avatar
      Standardize usage of virtual/override/final in chrome/browser/browsing_data · d2d19203
      dcheng authored 
      The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/666123002

Cr-Commit-Position: refs/heads/master@{#300575}
      d2d19203
    • jbauman's avatar
      Reset DelegatedFrameHost SurfaceFactory when output_surface_id changes. · b64da3f3
      jbauman authored 
      This is similar to the DelegatedFrameResourceCollection logic and avoids returning resources created by one output surface to a different one.

Review URL: https://codereview.chromium.org/650533004

Cr-Commit-Position: refs/heads/master@{#300574}
      b64da3f3
    • dcheng's avatar
      Standardize usage of virtual/override/final in printing/ · d5a0f18a
      dcheng authored 
      The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668073002

Cr-Commit-Position: refs/heads/master@{#300573}
      d5a0f18a
  3. 21 Oct, 2014 37 commits