- 20 Apr, 2020 40 commits
-
-
Nate Chapin authored
Make Fullscreen a Supplement of LocalDOMWindow instead of Document. Since it is also an ExecutionContextLifecycleObserver, this ensures consistency of the objects it uses for lifetime. Bug: 1029822 Change-Id: I98122f283004345d72d9dfe2f1833739f592d026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106734Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#760592}
-
Nate Chapin authored
External SVG documents are loaded using the DocumentResource subclass of Resource, which stores the external Document. As of https://chromium.googlesource.com/chromium/src/+/099517c767c6ef8d66408c03004d9e3a12be5011, that Document is created with a context Document. The MemoryCache architecture allows the reuse of Resources across different Documents, and it seems wrong for an external SVG Document to get used in a different Document than the one that is considered its context Document. This introduces a new registry for loading SVG external documents, and makes DocumentResource an implementation detail of that registry. It ensures that these resources are not kept in the MemoryCache, and because the registry is per-Document, it ensures that the external documents will not be shared across contexts. Bug: 1029822 Change-Id: Ibcff651a2c22ec924ff92d01b0bb63ff17f399ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128234 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#760591}
-
Vasilii Sukhanov authored
Mocks: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g7c9229dfe2_22_49 Bug: 1049200 Change-Id: I8ba3e7687379e9bc36f12c64f0b61845bbd7f2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157228Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#760590}
-
Boris Sazonov authored
Reason: flaky on android-arm64-proguard-rel https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/1491. TBR=mdjones@chromium.org Bug: 1072455 Change-Id: Ic4254f73673041cccd94fbe493d4c6fb8c31a9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156988Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#760589}
-
Stephan Hartmann authored
has only forward declaration of NodeSetSizePosInSetInfo. Therefore, move declaration from ax_tree.cc. std: :unordered_map<T, U> requires U to be fully declared. ax_tree.h Bug: 957519 Change-Id: Ic1f4bf3ebfea229ece84251e46d4461b31873868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132403Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#760588}
-
Brian Sheedy authored
Switches the win10_intel_hd_630_experimental mixin to trigger tests only in chromium.tests.gpu.experimental.template, as apparently the OR operator is explicitly not supported for pools for security reasons. TBR=ynovikov@chromium.org No-try: true Bug: 1065505, 1053803 Change-Id: I846d13d0f402c9ba7d98ebc0b2d8fbb826510a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154499 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#760587}
-
Nicolas Ouellet-Payeur authored
Change-Id: I3f3d2cc165a943e3ef3fcc6ba12c46695bb4eae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155836Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#760586}
-
Adam Langley authored
Change-Id: Ic7da643ae9bb4e946059e120b333752e043a3976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155806 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#760585}
-
Omer Katz authored
Bug: 986235 Change-Id: Ic8553f6c9858997d6db493c9a12e016bd84fb55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148788 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760584}
-
Tao Bai authored
Bug: 1064420 Change-Id: I5b02d5f7f8352285b0927f516c9cb8563915a7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147846Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#760583}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: Ie3e8c6ebddc62694ac0055470c447ad8a28a258e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101852Reviewed-by:
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/f9e0cda2d81858d10ceeadb0d21f4026f8602cf7..367d64f84c3c1d01381c18c5a239b85eef47633c The following commits have Chromium bugs associated: 9fc31378f Make ec_GFp_simple_cmp constant-time. The following commits have update notes: 9fc31378f Make ec_GFp_simple_cmp constant-time. Bug: 1014199 Change-Id: Ifffd70c6cd2351a885d0346431140357c143da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155832 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#760581}
-
Ben Kelly authored
Currently FetchResponseData is initialized from a ResourceResponse in two places; fetch_manager.cc and fetch_event.cc. The code in these two different locations is often out of sync. This results in the service worker navigation preload Response not working like other Response objects. This CL refactors the initialization into a common routine that is called from both sites. This is in preparation to add more attributes that need to be set during initialization in a later CL. Bug: 1069813 Change-Id: I67b244bce8066a7e7d291c78fbf48ca863c19598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147193 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Sam Sebree authored
This change uses the native_theme and scrollbar_theme properties to set correct dark mode styling for scrollbars. Bug: 929098 Change-Id: Ia06047ca3ec8571cf25acaf8de4731f1ccc16459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148283Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760579}
-
yilkal authored
After web time limit is reached, uninstalling a web app will lead AppService to notify ChildUserService to resume web activity for the app. This cl ensures that ChildUserService only pauses or resumes web time limit if the app is chrome. Bug: 1072035 Change-Id: Idf8250bf96c8b0717fe78af9b73e1d802e87723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154494Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760578}
-
Kevin Babbitt authored
The cause of the flakiness is that we weren't waiting long enough for the pinch zoom change to be reflected in the accessibility tree. Waiting for kLocationChanged appears to address the issue - with this change I was able to run the flaky test case 1000x without a single failure. Bug: 1069850, 1070647 Change-Id: If0cba1804776125885db3d0a2aedfeeca9340048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155077Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760577}
-
Kurt Horimoto authored
The completion block added to FullscreenAnimator updates the FullscreenModel and cleans up state in the FullscreenMediator. FullscreenMediator calls StopAnimating() in its Disconnect() function, which is guaranteed to be executed before deallocation. This calls into FullscreenAnimator's |-stopAnimation:| with a |withoutFinishing| value of YES, which according to the UIViewAnimating protocol, should immediately stop the animation. However, UIViewPropertyAnimator's implementation does not guarantee that the completion blocks are called synchronously, so there is a possibility that the completion is executed after the mediator's destruction. The previous implementation of AnimateWithStyle() used a pointer to the FullscreenModel to attempt to prevent crashes here. However, this is incorrect, as the raw pointer value is used. When the mediator is disconnected, it resets the |model_| ivar to nullptr, so when the pointer value is checked in the completion block, it was a use-after- free error. It only worked because the ivar was reset, but this behavior was non-deterministic, as the memory can be reallocated before the completion block is executed. Instead, this CL updates FullscreenMediator to support weak pointers, and uses a weak pointer from within the completion and animation blocks to prevent use-after-free issues. Additionally, this CL cleans up FullscreenMediator::AnimateWithStyle() to early return before creating the animator if there is no fullscreen progress update, preventing the animation observer callbacks from being executed unnecessarily. Bug: 1071777 Change-Id: I75aa1a54899d99befcdba140a2fefd846d785bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155071 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#760576}
-
Antonio Gomes authored
This is a follow up of [1], where test expectation were using chrome-specific scrollbar dimensions. The issue has been identified and logged on WPT dashboard [2]. [1] https://crrev.com/c/2130046 [2] https://wpt.fyi/results/css/css-grid/grid-model/grid-container-margin-border-padding-scrollbar-001.html?diff&filter=ADC&run_id=498640001&run_id=496590001 R=rego@chromium.org BUG=767015, 1063749 Change-Id: I470118aea6bc2108022a831b392ccf1345210717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154917Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#760575}
-
arthursonzogni authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/2154786 improves ./stale-script.html For consistency and because the test looks slightly nicer, this patch applies the same kind of refactoring to ./stale-image.html Bug: 1070117 Change-Id: Idae5a373154d9f6e8cc63d054d3abfe2662b621e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152797 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#760574}
-
Zach Trudo authored
File Changes: ~ chrome/browser/chromeos/ | ~ BUILD.gn | Added reporting_record_proto, and reporting_constants_proto | targets + chrome/browser/chromeos/policy/messaging_layer/ | + proto/record.proto | Contains Record, WrappedRecord, and EncryptedRecord. | + public/record_constants.proto | Contatins constants that the user will use to indicate the | destination and priority of their records. Change-Id: I2ee585d8294781ea4cece76d74b72513d787596f Bug: b:153365169 Change-Id: I2ee585d8294781ea4cece76d74b72513d787596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139854 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#760573}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I939f1d9d0db3e858c539a436021f47dc619222b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157065 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#760572}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca96cb78e35e..1f9465beae14 git log ca96cb78e35e..1f9465beae14 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 vapier@chromium.org chrome_committer: convert to python3 only 2020-04-20 slangley@chromium.org reven: Don't generate factoriy image or run HWtests for reven image. 2020-04-18 vapier@chromium.org perf_uploader: fix various bugs caught by python3 2020-04-18 manojgupta@google.com cros_fuzz: Fix bytes vs str for msan 2020-04-17 vapier@chromium.org cbuildbot: make builders/stages subdirs python3 only [reland] 2020-04-17 rohitbm@chromium.org Stop arc-cts-qual and arc-gts-qual suites kicking off from builders 2020-04-17 vapier@chromium.org paygen: fix bytes-vs-str comparison Created with: gclient setdep -r src/third_party/chromite@1f9465beae14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I3c404b26bee66fc81890be5663fc2e950250a27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760571}
-
Nate Chapin authored
This gets us to a point where all cases where we swap the attached Document based on web content go through DocumentLoader. XSLT was the last case that directly instructed LocalDOMWindow to install a new Document. This had caused problems with extensions getting document lifecycle notifications in an unexpected order because the Document was changing without a "navigation". Note that LocalFrame::ForceSynchronousDocumentInstall still manually calls LocalDOMWindow::InstallNewDocument, as do a few unit tests. Bug: 1041916 Change-Id: I01d669c2e82de55bec9cd90dbc7fd376fab35234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148828 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Sean Gilhuly authored
On Windows, create a VsyncProviderWin in SkiaOutputDeviceDawn. Then following each swap buffers, use the current timestamp snapped to the next vsync interval as the presentation time. Bug: 1021566 Change-Id: Id7e1fb3ec4c4d63517e556be6e36a824356e7e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154596Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#760569}
-
Alice Wang authored
This CL removes a null check for Robolectic version < 3.7. Since our current Robolectric version is 4.3, we don't need this check anymore. Bug: 779568 Change-Id: I6a325a807304efb3769c5291e82c127250ecdb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152835Reviewed-by:
-
Chris Lu authored
TranslateInfobarDelegate is currently only allows for one observer. This change replaces its observer_ property with a ObserverList so that more than one object can be an observer. Change-Id: I67c2a1ee2e2bee8ba532bc4b4adc1d2237dc1bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153330Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#760567}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/449b1157a738..9b5e16c09e4f git log 449b1157a738..9b5e16c09e4f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 jvanverth@google.com Add capture routines for D3D 2020-04-20 mtklein@google.com Revert "gather8/16 JIT support" 2020-04-20 mtklein@google.com gather8/16 JIT support 2020-04-20 robertphillips@google.com Handle mipmap creation failure in DDL test harness 2020-04-20 michaelludwig@google.com Add inner bounds of round rect function Created with: gclient setdep -r src/third_party/skia@9b5e16c09e4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: Ic94d83ec094c4a375afd597d246d91f10b2b07ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157188Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4a5765265d3d..bef0404d78ed git log 4a5765265d3d..bef0404d78ed --date=short --first-parent --format='%ad %ae %s' 2020-04-20 jbudorick@chromium.org devil: update arm & arm64 chromium dependencies. Created with: gclient setdep -r src/third_party/catapult@bef0404d78ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: If45fa01f724eb90e2e90e22cfdd40371f982c9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157190Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is a reland of 2d2185d8 The fix is to remove the ifdef check. I incorrectly assumed that DCHECK would strip the code on release configurations. Original change's description: > [iOS][Credential-Provider] Observe changes in the password store > > Updates the credential store with changes from the password store. > Renames SyncAllCredentials to RequestSyncAllCredentials to make clearer > the async nature of it. > Creates entry functions for adding, updating, and removing passwords > which will be used to also keep up to date the OS metadata in a follow > up CL. > Injects the credential store for easier testing. > > Bug: 1066803 > Change-Id: Id79c3b276517c7bb223b3988db4d1a8c25e00025 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152814 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760483} TBR=vasilii@chromium.org Bug: 1066803 Change-Id: Ie50f790c6cc8715c13017fc930327019f137fb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157045Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#760564}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3fda0023405..ab16a956e574 git log f3fda0023405..ab16a956e574 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 alexrudenko@chromium.org Reattach the target before reloading Created with: gclient setdep -r src/third_party/devtools-frontend/src@ab16a956e574 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f28d90bbc58989f0c81c9c5ebb97c381c497232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157186Reviewed-by:
-
Bo Liu authored
Copy implementation from chrome. Retrieve min_width from ui::Display. Bug: 1052496 Change-Id: I453919244580e4c22439b8d7aa5a7da1c9aec289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154852 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Previously FuchsiaAudioRenderer wasn't reporting any statistics to the pipeline. As the result the pipeline was always reporting 0 for audio_decoded_bytes. Fixed it to report this parameter after every packet it sent to the AudioConsumer. Note that decoding itself is handled by the AudioConsumer implementation, so the data may be decoded a bit later than it's reported. Bug: 1067068 Change-Id: Iecbce0d757b6c753360073faf5a073b71b33e1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148379 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#760561}
-
Andrew Xu authored
This CL verifies that home launcher animation smoothness metrics are recorded correctly in the following two scenarios: (1) Enter/exit overview mode (2) Show home launcher from in-app shelf by gesture swipe. Bug: 1059449 Change-Id: If908f0d0a0e5f545fbbbe6f06a1b47f1cc9beaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155351Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760560}
-
Peter Wen authored
Lint target API should be updated when we support new android APIs. Fixed: 999000 Bug: 999000 Change-Id: Ie724208e04689f2a4c90671f18a8599c258186f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156747 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#760559}
-
Katie D authored
The bubble is by default centered in its anchor view, and can be moved anywhere within the anchor view as long as it is not too close to the sides or bottom. If the bubble is moved within the anchor view, it tries to stay at the same place with respect to the anchor as the anchor changes size. Bug: 1055150 Change-Id: Ic161a99e75bfcc7387b44ee14bed0bc996276e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150691 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
Andrew Grieve authored
They are unused since Chrome doesn't run on Wear OS. Bug: None Change-Id: I0282de56b7c35d4e651543a8cf649b1fe259a227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154823 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#760557}
-
Dan Harrington authored
LoadMore is different enough from LoadStreamTask, that I made a new task type, LoadMoreTask. This workflow requires that the model is already loaded. Additionally, StreamModel is responsible for saving changes to persistent storage, which is not the case for LoadStreamTask. Bug: 1044139 Change-Id: Id9d8bd932a7d855c91bd01161ed03b572ba04208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148041Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#760556}
-
Peng Huang authored
The crash is because the vkAcquireNextImageKHR() fails with VK_ERROR_SURFACE_LOST_KHR, probably the platform window is closed, or a new swapchain is created with the same platform window. Since vkAcquireNextImageKHR() is called just before rendering DDL to the vkmage, if there isn't a new vkimage is available, it is too late to properly handle it. Fix the problem by call vkAcquireNextImageKHR() immemorially after vkQueuePresentKHR() call. If vkQueuePresentKHR() call is successful, then the surface should be good, and vkAcquireNextImageKHR() should be successful too. If surface is lost, vkQueuePresentKHR() will return VK_ERROR_SURFACE_LOST_KHR., and then the PresentBuffer() will return SWAP_FAILED to caller. Caller should be able to handle it properly like it does with GL and glSwapBuffers(). Bug: 1070754 Change-Id: I697cca3a282d046e9592d554403f7c10c811cf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155197 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#760555}
-
gogerald authored
Change-Id: I8b922761cf9bb18af70e09dfa78b3711fcb067ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157245 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
I cannot repro on my eve or caroline device, but according to comment#4 in bug 1050195, and comment#9 in bug 1050330, it seems theoretically it can be caused by aync reading of the lid angle driver "cros-ec-lid-angle". So when the device first starts or comes out from sleep, the driver "cros-ec-lid-angle" is not present yet, so Chrome is doing its own lid angle calculation, and later when the reading result comes back and"cros-ec-lid-angle" flag is properly set, Chrome does not do the lid angle calculation anymore, but the old lid angle is not reset to 0.f, so it might interfere with the tablet state calculation. Bug: 1050195, 1050330 Change-Id: I9c650ee2becbabfb20101a192ebfa5eeb7b677dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153899 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#760553}
-
