- 20 Feb, 2019 40 commits
-
-
Jeff Fisher authored
This fixes a couple presubmit issues when running on Windows: * check_gn didn't properly normalize paths * eslint didn't execute in node successfully since the bin style for the npm install was unix specific (it's a CMD file on Windows) Bug: 929919 Change-Id: Iec7e1057254047bd0a6539e16df964dc8a58d528 Reviewed-on: https://chromium-review.googlesource.com/c/1459576Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#633810}
-
Robbie McElrath authored
This test occasionally crashes with the network service enabled because a request hits the Interceptor after its been deleted. Change-Id: Ib09e8c6cdf1208ced3297af37e2261c880bae0f1 Reviewed-on: https://chromium-review.googlesource.com/c/1478307Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#633809}
-
Wez authored
Work-around some issues with the component launcher implementation by falling-back to using LaunchInfo-provided services if the ApplicationConfigManager cannot be found in the CastRunner's incoming service directory. Bug: 893229 Change-Id: I500920cb21186fdbd60f59783f359fdaf65aecaf Reviewed-on: https://chromium-review.googlesource.com/c/1476594Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#633808}
-
Tom Anderson authored
BUG=801780 R=thakis Change-Id: I60588de2dd5de1fe92f9731592d7ebd4468764c2 Reviewed-on: https://chromium-review.googlesource.com/c/1479410 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#633807}
-
Manu Cornet authored
Change-Id: I212670f81a9e4f01f06ba70cb312585fdaceab1c Reviewed-on: https://chromium-review.googlesource.com/c/1478658Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#633806}
-
Azeem Arshad authored
The AndroidMessagesIntegration feature flag was added to control launch of messages integration in ChromeOS. This feature is now enabled by default. This CL removes this flag and it's references. Bug: 930985 Change-Id: Id389f972d976fc5878c95a5e702e953018eb83b9 Reviewed-on: https://chromium-review.googlesource.com/c/1476116Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#633805}
-
John Abd-El-Malek authored
Bug: 931436 Change-Id: Iecf75ad198afdd0a9d01486e610d62e4e31cdce6 Reviewed-on: https://chromium-review.googlesource.com/c/1477928Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#633804}
-
Gordana Cmiljanovic authored
Original CL: https://chromium-review.googlesource.com/909216 [MIPS][tcmalloc] Fix mipsel compile errors tcmalloc is using very old version of linux_syscall_support.h The following mipsel related changes are pulled from lss project: https://chromiumcodereview.appspot.com/10067027 https://codereview.chromium.org/13846002 https://codereview.chromium.org/913723002/ https://codereview.chromium.org/836473006 Bug: 810356, 794147 BUG=724399,b:119055259 Change-Id: I9609460412d27ab8ed963577af6c284d8cb898d4 Reviewed-on: https://chromium-review.googlesource.com/c/1475153Reviewed-by:
-
Ben Pastene authored
This is more in-line with the other simplechrome trybots, which don't have DCHECKs enabled. R=achuith, dpranke, jbudorick Bug: 931794 Change-Id: I5347d222ef823d4c1318057c7d1833d7afef43a9 Reviewed-on: https://chromium-review.googlesource.com/c/1478947Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#633802}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd080e04f1e4..ad6d56748d98 git log fd080e04f1e4..ad6d56748d98 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 gmeinke@chromium.org cbuildbot: plumb snapshot revision flag 2019-02-20 nya@chromium.org artifact_stages: Upload Tast private test bundles. Created with: gclient setdep -r src/third_party/chromite@ad6d56748d98 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5faf2e4d7c0d773e6bfd5ddd338bd25fd7b98815 Reviewed-on: https://chromium-review.googlesource.com/c/1478938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633801}
-
Daniel Rubery authored
This required updating several tests to use "safe" download types, such as jpg or txt. For the download browser tests, the URL is forced to be "download-known-size", so I changed the expectation to match the format "Unconfirmed <number>.crdownload". A little bit of test data needed to be changed, namely: - simple_exe.cc was renamed simple_exe.txt, since cc is uncommon - zipfile_no_binaries.zip now has contents "simple_exe.txt" instead of "simple_exe.cc", for the same reason. - small_archive.rar now has contents "limerick.txt" instead of "limerick", since "limerick" is an uncommon extension. Bug: 918991 Change-Id: Iaef193e32a825b3b977fdae55ec43e7c5aaa327f Reviewed-on: https://chromium-review.googlesource.com/c/1459317Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#633800}
-
Nick Harper authored
Change-Id: I09d3416dc11140754a35033b4fbb45a76a44ee6a Reviewed-on: https://chromium-review.googlesource.com/c/1478082Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#633799}
-
Ian Kilpatrick authored
Horray! There should be no behaviour change. Bug: 635619 Change-Id: I12507f3e8144353fb58dc5837d33f4bc567d58b3 Reviewed-on: https://chromium-review.googlesource.com/c/1476514 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#633798}
-
Charlie Reis authored
This makes it possible to see precursor and nonce info for the origin for diagnostics, following r631964. Bug: 918565, 919144, 931895 Change-Id: I7b07e4e34177a0a532c254e313d65ad28e28cdd7 Reviewed-on: https://chromium-review.googlesource.com/c/1478096 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#633797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/109b5fb5f5b2..76d7ce275223 git log 109b5fb5f5b2..76d7ce275223 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 srte@webrtc.org Disabling flaky RecievesVp8SimulcastFrames test. 2019-02-20 nisse@webrtc.org Reland "Update VP9EncoderImpl to use EncodedImage::Allocate" Created with: gclient setdep -r src/third_party/webrtc@76d7ce275223 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ide3de360c9d5172234f987a013ab1706c22ebae2 Reviewed-on: https://chromium-review.googlesource.com/c/1477404Reviewed-by:
-
Dan Harrington authored
This was never added to the BUILD.gn file, so was never actually built or tested. Change-Id: I07b614c628146e0aee639bd5908bb8ff877c407e Reviewed-on: https://chromium-review.googlesource.com/c/1478500Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#633795}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: I9219f576a344873f8cb5414ab7a1ba5e156f5527 Reviewed-on: https://chromium-review.googlesource.com/c/1474632Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#633794}
-
manuk authored
Bug: 931541 Change-Id: Ic30aa92c18ebcb4dc09216fef7a09f5e430bf572 Reviewed-on: https://chromium-review.googlesource.com/c/1477807Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#633793}
-
Salvador Guerrero authored
When a leveldb_proto database is requested we try to open both the unique and shared databases, when only one of those opened we used to return that database, regardless of whether we should, this CL incorporates the init and migration status to that logic to avoid returning a database with stale data Bug: 870813 Change-Id: Ide70a7d8c861f017fd55ae5faa53f5f73369f228 Reviewed-on: https://chromium-review.googlesource.com/c/1471378 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#633792}
-
Ian Kilpatrick authored
Previously we stored two objects if we wanted to cache a layout result, the layout result, and the constraint space. This patch stores the constraint space which generated the layout result on the layout result itself. We only store a "valid" constraint space on a layout object if the NGLayoutResult holds onto a box-fragment with an associated layout_block_flow. E.g. we *don't* store it for line-box results, or inline-level box fragments generated from an NGInlineItem (borders of a span, etc). This also means that the NGConstraintSpace reference is stored with the NGContainerFragmentBuilder when performing layout. This removes the const reference from the NGLayoutAlgorithms to the constraint space, and moves it into the fragment builder. The logic within layout_scrollbar.cc was needed in order to pass: scrollbars/custom-scrollbar-changing-style-relayout-body-scrollablearea.html Effectively we were now caching a layout that we weren't previously. As scrollbar size is a "side-input" to our layout system we need to properly invalidate the "owner" of the scrollbars if the size may have changed. Bug: 635619, 932990 Change-Id: I358d3a501916602aed3cedff0dd5c96137d6fe97 Reviewed-on: https://chromium-review.googlesource.com/c/1476510 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Robert Ogden authored
Uses real hostnames for the test servers instead of localhost. Change-Id: Ib57c83ff1295b3b2cd47c515d2c7e1ec9d8f80c8 Reviewed-on: https://chromium-review.googlesource.com/c/1478501Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#633790}
-
Yuwei Huang authored
This CL implements a basic FTL client that can retrieve a list of ICE servers, and an executable for playing with it. Bug: 927962 Change-Id: I351d4af231689b5de533f3c34252a91cee2e5211 Reviewed-on: https://chromium-review.googlesource.com/c/1445312 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#633789}
-
Cliff Smolinsky authored
Recent changes to the handling of user_input_in_progress caused a regression in OmniboxViewViews::OnBlur() where the edit state is not reverted when the current text exactly matches the permanent text. This resulted in page icons such as the bookmarks star from remaining hidden when they should be shown. This change adds a check to see whether the text has been edited but currently is an exact match for the permanent text and does a revert. This is necessary because users may have no idea that they are currently in "edit mode" because the text looks unchanged. Bug: 932782 Change-Id: Ie6d7218daa27a4f59eafaac9c76477925b50e384 Reviewed-on: https://chromium-review.googlesource.com/c/1475947 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
-
Evan Stade authored
The only part of the widget that's actually drawn by Ash is the header, which has its own layer. The client area is drawn by the browser process. Therefore the native widget's aura::Window can be LAYER_NOT_DRAWN. Bug: 931873 Change-Id: I5d27505d7ed1d662ae811a8b719170494c72d9fb Reviewed-on: https://chromium-review.googlesource.com/c/1471348 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#633787}
-
Nico Weber authored
- Remove semicolons after the _CLASS_PROPERTY_TYPE macros. Since they add something in namespace ui, it's difficult to require a semicolon after them and most clients don't have one there anyways. This part of the CL was created by running: for p in DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE \ DEFINE_EXPORTED_UI_CLASS_PROPERTY_TYPE \ DEFINE_UI_CLASS_PROPERTY_TYPE ; do git grep -l $p | xargs perl -i -p0e 's/('$p'\([^)]+\));?/\1/g' done - Also remove semicolons after DEFINE_(OWNED_)UI_CLASS_PROPERTY_KEY for consistency with DEFINE_UI_CLASS_PROPERTY_TYPE since these two macros are often used next to each other: for p in DEFINE_UI_CLASS_PROPERTY_KEY \ DEFINE_OWNED_UI_CLASS_PROPERTY_KEY ; do git grep -l $p | xargs perl -i -p0e 's/('$p'\([^)]+\));?/\1/g' done Bug: 926235 Change-Id: I73913d93b99d8b1e6eef774b923beee612e6c480 Reviewed-on: https://chromium-review.googlesource.com/c/1478071Reviewed-by: -
liberato@chromium.org authored
ordering="prefix" turns out to be not the right thing. The variant name is intended to be at the end, such as: Media.Learning.MediaCapabilities.DroppedFrameRatioTask.BaseTree Change-Id: Ib71ede8b9214edd08f6c25c1e1a771158309ece1 Reviewed-on: https://chromium-review.googlesource.com/c/1477751Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#633785}
-
Elly Fong-Jones authored
TBR=rohitrao@chromium.org Bug: 933827 Change-Id: I9c4b3e2f8f1088cb5a2c78a6aed500a682874edd Reviewed-on: https://chromium-review.googlesource.com/c/1478488Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#633784}
-
Marc Treib authored
instead of ProfileSyncServiceMock. In general, it's always preferred to use SyncService rather than ProfileSyncService, and in particular there's no need for a mock here. Bug: 910518 Change-Id: I7515ae070a7859ae767ec66acced9e0d5ec0e521 Reviewed-on: https://chromium-review.googlesource.com/c/1477680 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#633783}
-
Dirk Pranke authored
This reverts commit 258ed8d5. Reason for revert: Suspect this introduced memory leaks and broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20Leak/30388 Original change's description: > Synthetic input waits on compositor display > > This CL makes synthetic input - the kind used in web tests and > telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame > has been submitted by the renderer and displayed by the display > compositor before resolving the completion callback. This means client > code that wants to wait until any observable side-effects of this input > is visible to further input need only wait on the gesture's completion > callback. > > To give a motivating example: suppose we wish to write a test that > scrolls an out-of-process iframe into view and clicks on a button in the > frame. The code might look something like this: > > gpuBenchmarking.smoothScroll(1000, () => { > gpuBenchmarking.tap(0, 0); > }); > > This code contains a race today. The callback for smoothScroll is > invoked as soon as the ScrollEnd is received in the renderer. However, > until a new compositor frame is submitted from the renderer, the tap > may occur against stale hit testing geometry. This is a major source of > flakiness in our tests. > > This CL fixes the problem by forcing the renderer to perform a full > redraw at the end of each gesture. The redraw produces a compositor > frame and we invoke the callback once the compositor frame is displayed. > We do this by reusing the RequestPresentation mechanism in RenderWidget. > RequestPresentation required two modifications to work in web tests > which use a single thread proxy with no scheduler: > > - LayerTreeHost::Composite needs to check the forced redraw flag to > determine whether we need to raster, otherwise it won't produce a > frame > - RequestPresentation must request a main frame since there's no > scheduler to perform the commit, which is what SetNeedsForcedRedraw > requests. > > The timing change exposed an issue in the > overlay-play-button-tap-to-hide.html test so this CL also cleans that > test up to listen to the animation changes in media controls properly. > > Finally, it's possible we may get input in a RenderWidget that's not > currently displayed. e.g. A click event sent via ChromeDriver causes a > TouchStart followed by a TouchEnd. The TouchStart causes a window.open > which opens and focuses a new tab. The TouchEnd then happens on the > background tab. In this case, we should resolve the callback rather than > waiting on a CompositorFrame that'll never come. See ChromeDriver test > testNetworkConnectionTypeIsAppliedToAllTabs for an example of this. > > Bug: 902446 > Change-Id: Ib2dddee08400dfa1137c674c47c0d7106961162f > Reviewed-on: https://chromium-review.googlesource.com/c/1390329 > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633753} TBR=danakj@chromium.org,bokan@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org Change-Id: I7a479a4af8fbec4b4452ff6d9d7b5b9df246f4a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902446 Reviewed-on: https://chromium-review.googlesource.com/c/1479370Reviewed-by:
-
Benoît Lizé authored
Memory metrics for ParkableStrings are only reported for background compression. This adds reporting for foreground compression as well, 5 minutes after a renderer starts tracking its first parkable string. Bug: 924164 Change-Id: Iac04e86101e132fa9d67c6cfd25b16e2bce89fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1474663Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#633781}
-
Saman Sami authored
This used to be not possible in Skia, but that has been fixed recently. Bug: 933441 Change-Id: I21442bfad311ac2aa1bb73bd57737e0e0332096f Reviewed-on: https://chromium-review.googlesource.com/c/1478937Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#633780}
-
Lukasz Anforowicz authored
Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457 Change-Id: I6227f9d8a43329510f4fae37ab9429c9dbf59f48 Reviewed-on: https://chromium-review.googlesource.com/c/1441277 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#633779}
-
Lutz Justen authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5949b3349ded..274866056499 $ git log 5949b3349..274866056 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 ljusten system_api: Add kerberos service proto 2019-02-04 ljusten kerberos: Stub out D-Bus service 2019-02-14 zuan system_api: Ran gn format on BUILD.gn 2019-01-29 chirantan system_api: Make params a repeated field in StartPluginVmRequest 2019-02-08 lamzin system_api: add peak shift policy to power manager 2019-01-31 yshavit bluetooth: add suspend/resume infrastructure per powerd guidelines 2018-10-12 chinglinyu debugd: support stopping a running perf profiler session. Created with: roll-dep src/third_party/cros_system_api BUG=chromium:933798 Change-Id: Idd980b0c267d0e00685ada8a5d7e30944c5c8e89 Reviewed-on: https://chromium-review.googlesource.com/c/1478894 Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#633778}
-
Ryan Sturm authored
Change-Id: I5d259c9103c8e6d2853673ab6d31e956e4724f84 Reviewed-on: https://chromium-review.googlesource.com/c/1474836Reviewed-by:
-
Tim Volodine authored
The following tests are passing: -ClientOnPageStartedTest.testBrowserInitiatedRedirectHangingNavigation -ClientOnPageStartedTest.testRendererInitiatedRedirectHangingNavigation BUG=893572,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ia376d146c02c22a4db8e3fdc217e129652c970d6 Reviewed-on: https://chromium-review.googlesource.com/c/1478879 Auto-Submit: Tim Volodine <timvolodine@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The FileManager tests have been rewritten to use browser side injection. This feature can now be removed. Change-Id: If9780de594d26c93f6f80ee2adf558ff5811df98 Reviewed-on: https://chromium-review.googlesource.com/c/1473404 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#633775}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9eb094567b2a..e8ab7db4d4da git log 9eb094567b2a..e8ab7db4d4da --date=short --no-merges --format='%ad %ae %s' 2019-02-20 chiniforooshan@chromium.org Tracing: handle empty list of ranges Created with: gclient setdep -r src/third_party/catapult@e8ab7db4d4da The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931766 TBR=sullivan@chromium.org Change-Id: Ie4478b8bccb17feeb432d6a3f2f67a52fbb7d1c9 Reviewed-on: https://chromium-review.googlesource.com/c/1477403Reviewed-by:
-
Avery Musbach authored
The present CL was originally for Issue 926602, but has become focused on code refactoring (Issue 932207), with a low-risk fix for Issue 926602 separated out into CL 1471013. The refactoring in the present CL seems to have incidentally fixed the additional functional problem shown in this video (an ugly animation): https://photos.app.goo.gl/xGnVGQgexPgxMpRcA Bug: 932207 Change-Id: Ia191e7d3495c09ec07237c57596de43106e7d548 Reviewed-on: https://chromium-review.googlesource.com/c/1446368 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#633773}
-
Madeleine Barowsky authored
Changes return type of DecodeToYUV from bool to void and passes errors through Failed(). Bug: 900589 Change-Id: If9e9b81d1516eeb7504f79e67a9a77cad4c36151 Reviewed-on: https://chromium-review.googlesource.com/c/1477814 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#633772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc42944741bc..c74512c7ff9e git log bc42944741bc..c74512c7ff9e --date=short --no-merges --format='%ad %ae %s' 2019-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8f79d388784c..f4b99b674a1b (1 commits) 2019-02-20 mtklein@google.com update NDK to r19b 2019-02-20 brianosman@google.com Use upper case hex in viewer's zoom window 2019-02-20 herb@google.com Break up InitDistanceFieldPaint 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c74512c7ff9e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: If283bae26101aa21fa30055e1684d9328f71df63 Reviewed-on: https://chromium-review.googlesource.com/c/1477405Reviewed-by:
-
