- 09 Nov, 2017 40 commits
-
-
Caleb Rouleau authored
I think this used to be used for back when we had a legacy benchmark, but our current benchmark is TBMv2, so we can't configure which metrics to generate in which cases anymore. Bug: 632021 Change-Id: I5c9c3ce7c823c59984fd4989194d389be0569986 Reviewed-on: https://chromium-review.googlesource.com/759318Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#515083}
-
Vlad Tsyrklevich authored
Add a blacklist entry for a newly failing icall. Bug: 772906 Change-Id: Ib424f3eb57d2b0184df69cdb34fccdcb0ae788c8 Reviewed-on: https://chromium-review.googlesource.com/759231Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515082}
-
Weidong Guo authored
Changes: 1. Move cursor first when left or right key is hit and focus is on a textfield (e.g. search box and folder name). 2. If the cursor is at the right end of the textfield and there's no selection of text, hit right will move focus outside the textfield. (The same for left key.) 3. If the cursor is at the right end of the textfield and there's text selection, hit right will unselect the text and cursor will be at the right end. (The same for left key.) BUG=781099 TEST=AppListViewFocusTest.HittingLeftRightWhenFocusOnTextfield Change-Id: I0b143ce0c213a509e912729f455ca0a14e10ab9a Reviewed-on: https://chromium-review.googlesource.com/752625 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515081}
-
Dirk Pranke authored
This is being done as part of migrating traffic off of tryserver.chromium.linux and onto tryserver.chromium.chromiumos, for better load balancing. R=smut@google.com BUG=732531 Change-Id: If4695fd38b1452fbbe37fa3ba4d99cb1c68f4130 Reviewed-on: https://chromium-review.googlesource.com/759271Reviewed-by:
smut <smut@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515080}
-
Matt Reynolds authored
The BookmarkModel maintains an index of bookmark titles and URLs for quick lookup by the omnibox autocomplete provider. Bookmark folders should be excluded from this index to prevent them from appearing as autocomplete suggestions. However, there was a bug that caused a bookmark folder to be added to the index when the folder is renamed, allowing it to appear as a (useless) autocomplete suggestion. This CL checks to ensure that only URL nodes are added to the index. BUG=778266 Change-Id: Ie24fe0f7a8c4ef7ea6327683eb3d5a5d175250eb Reviewed-on: https://chromium-review.googlesource.com/757543 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515079}
-
Qiang Xu authored
design doc: go/cros-keyboard-window-movement changes: - Add keyboard shortcuts (Search + Alt + Arrow Keys) for moving active window between displays. - Candidate displays should be completely off the bounds of original display in the moving direction or cycled direction. - It will try to find the displays in the direction provided, if not found, then the displays in the cycled direction. - First, try to find the least apart distance in the given direction or cycled direction. - Second, for those that have the same least apart distance in the above, the one that has less vertical offset wins. - added test coverage Follow-up work: - Dealing with window resizing issue - UMA, a11y Bug: 778438 Test: emulator tests and added test coverage Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I49be94635d5460e686f16b6e56fc2baf865ab794 Reviewed-on: https://chromium-review.googlesource.com/738826 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#515078}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1413d75bc715..2a1ca3f68bc9 $ git log 1413d75bc..2a1ca3f68 --date=short --no-merges --format='%ad %ae %s' 2017-11-08 tandrii Add luci_migration recipe module. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ie10f1562012dc8f442c355da2532ee5ef7f12611 Reviewed-on: https://chromium-review.googlesource.com/758626Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515077}
-
Erik Luo authored
In Elements panel, the ClassesPaneWidget's autocomplete - now shows sorted suggestions - will not suggest classnames that are already applied Bug: 772824 Change-Id: I344e14c8e5edbb0c592ae44599725eb08a7d298a Reviewed-on: https://chromium-review.googlesource.com/747275 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515076}
-
Eric Lawrence authored
This change updates the iOS HTTPBad implementation to more closely match the implementation in /content. Specifically, the legacy bitflags are moved from the ContentStatusFlags to a SSLUserData object attached to the SSLStatus, fixing a layering violation. Updates to the flags are handled at the browser layer (rather than in the /web layer). A WebStateObserver watches for the FormActivityRegistered event and sets the insecure_input_event flag on the SSLUserData if the page is loaded from a non-secure context, implementing HTTPBad Phase 2 for iOS. Bug: 720094, 689082 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2f54a3aff212f8378a52b809c717a577ca4c8a69 Reviewed-on: https://chromium-review.googlesource.com/755889Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#515075}
-
Nathan Bruer authored
We look for some headers in devtools for things like if a cookie was set or if there is a last-modified. This will ensure when checking them we compare against the lower case keys. R=dgozman,lushnikov,einbinder BUG=None Change-Id: Idf8b8fb2445d71ab6262e94fedbb19653a9b2449 Reviewed-on: https://chromium-review.googlesource.com/758753 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#515074}
-
Michael Martis authored
Change-Id: I9bbfdc9c8b6ef5c23decce6f470aed2f5cf468e2 Reviewed-on: https://chromium-review.googlesource.com/759637Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#515073}
-
Ella Ge authored
Enable factional mouse type pointer event by default Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ssfd-_V26Ls Bug: 773813 Change-Id: Ie8010d27b4c0a6b43fec7cfab04e153dce21536d Reviewed-on: https://chromium-review.googlesource.com/753511Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#515072}
-
Lei Zhang authored
Change-Id: I80e1256b45907d93a2c71aa77cb1eed24550a61d Reviewed-on: https://chromium-review.googlesource.com/759230Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#515071}
-
Matt Falkenhagen authored
This upstreams service worker tests: chromium/extendable-message-event.html chromium/unregister-on-detached-iframe.html These tests are useful as a WPT as it tests web-exposed behavior. Expand the tests and upstream them as detached-context.https.html. Bug: 688116, 603817, 543198 Change-Id: I2b9798e19a1b1ec76d9a4472f412acb324a50e0c Reviewed-on: https://chromium-review.googlesource.com/759136Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515070}
-
Christopher Lam authored
Bug: None TBR: sky@chromium.org Change-Id: I155d1cb27ad13253702d152517aa9718ae48bacb Reviewed-on: https://chromium-review.googlesource.com/752964Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#515069}
-
Kevin Marshall authored
Also refactor fuchsia_executable_runner to accept data_deps values from the invoker. Bug: Change-Id: I039548d80b98538692df8b04b4410b09474ad4d8 Reviewed-on: https://chromium-review.googlesource.com/758968Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#515068}
-
Michael McGreevy authored
Developers using devtools to simulate add to home screen currently receive no feedback if the site they are testing on suppresses the app banner. This can make it seem like the devtools functionality is flaky. This CL adds console logging for this situation, to help developers understand why the install banner has been suppressed. Bug: 739344 Change-Id: Iaebbee3a6b7e01b0956112d9bdcf42043b179128 Reviewed-on: https://chromium-review.googlesource.com/743141 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#515067}
-
Alex Newcomer authored
In the launcher, suggested apps and search results share a class, SearchResultTileItemView. The code path for launching a suggested app and a SearchResult is the same,and we were recording SuggestedApp clicks as SearchResult clicks. This CL modifies the code path to consider if the SearchResultTileItemView is a suggested app before recording metrics. I also included a UMA test in AppsGridViewTest. Bug: 779654 Change-Id: Ia059879c097b5845021bb9ed4050da51e70ac007 Reviewed-on: https://chromium-review.googlesource.com/751961 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515066}
-
Matt Mueller authored
When using ProfileIOData::SetCertVerifierForTesting, the test verifier is wrapped in a per-profile object that queries the shared verifier. The lifetime requirements are unchanged (the test cert verifier must outlive any profiles using it). Bug: 780611 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9be3d8e7591cf55a03d08382a82ef2f8124152a2 Reviewed-on: https://chromium-review.googlesource.com/756016 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515065}
-
Steven Bennetts authored
Bug: 693114 Change-Id: I8b3c0ef0342009794a97c0c9afdcdb417710aee4 Reviewed-on: https://chromium-review.googlesource.com/752075 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#515064}
-
Stephen Martinis authored
Bug: Change-Id: I9a0372f0eb4f57d73b8ec24ba0255b39e6b3dbf2 Reviewed-on: https://chromium-review.googlesource.com/729212Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#515063}
-
Alexei Svitkine authored
Previously, we would use a CoreFoundation-based version of these functions implemented in time_mac.cc because time_t on Mac was capped at year 2038. However, with 64-bit that is no longer the case and we can just use time_exploded_posix.cc. From UMA sampling profiler data (see bug), we know that the CoreFoundation versions of these functions are slow and currently account for around 80ms cost during startup. After this change is submitted and makes it to Canary, we can see how the POSIX versions of these functions perform - hopefully much faster than the CoreFoundation ones. Some code in net/ had assumptions around the min and max years that are supported on different platforms by these functions. To make that logic a bit cleaner, this CL introduces two constants in time.h specifying the platform-specific limits - so that downstream code like net can use them instead of baking their own assumptions. Some net error codes are changing as a result of this clean up - which can be seen in the updated net tests. BUG=781601 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2cf030fd4d3ed8da87e41bc8ba3dc3b1b99e8f6d Reviewed-on: https://chromium-review.googlesource.com/754079 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#515062}
-
Tarun Bansal authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 782780 Change-Id: I419786e99fa6f794d5c84041f131254588328d9f Reviewed-on: https://chromium-review.googlesource.com/758721 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#515061}
-
Vladimir Levin authored
This patch enables us to be able to use linux fonts in oop raster mode, with the exception of webfonts. The changes are summarized below: - Introduce PaintTypeface, a Paint equivalent of SkTypeface - Introduce PaintTextBlob, a Paint equivalent of SkTextBlob - Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder - Introduce PaintFont, a Paint equivalent of some of the SkPaint flags that deal with fonts. - Serialize and deserialize drawTextBlobOp - Update platform/fonts to use PaintTypeface in places that end up being painted - Update FontPlatformData to use PaintTypefaces The difference from the initial patch is that we initialize allocated run buffers in the unittests. TBR=enne@chromium.org Bug: 777631 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6a019a993c72938c47ecb3be27bb9a79f5fdc9dc Reviewed-on: https://chromium-review.googlesource.com/756213Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515060}
-
Luciano Pacheco authored
Files from third_party/WebKit/Source/core that included Vector.h but weren't using Vector<>. This is the last batch for Vector.h. Also added the include Vector.h to WebDevToolsAgentImpl.cpp and ObjectPainter.cpp because they use Vector but weren't including. Bug: 398455 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I43af2eb8231d35c65ec64883acc80d9aff2e18af Reviewed-on: https://chromium-review.googlesource.com/756173 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515059}
-
Steven Bennetts authored
This reverts commit df214af3. Reason for revert: Failing on chromium.chromiumos waterfall: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/46590 Original change's description: > Content_Browsertest with --enable-viz > > This will enable content_browsertests --enable-viz on the > chromium_chromeos_rel_ng bot. > > The filter file is a list of tests which fail, as they traditionally rely on > information that is now in a different process. We'll bring more online as we > create the appropriate test apis. > > TBR=sky@chromium.org > TEST=viz_content_browsertests > > Bug: 760181 > Change-Id: I4e015d93aec3526c0f0fe2aa0cccafff998fc5a7 > Reviewed-on: https://chromium-review.googlesource.com/758603 > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514969} TBR=sky@chromium.org,jonross@chromium.org Change-Id: Iffeb787272a63c3fb447e2f149c01274e7c6675d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760181 Reviewed-on: https://chromium-review.googlesource.com/759656Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515058}
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /chrome/browser/sessions This pass focuses on ML::SNTA in same scope as RunLoop variable Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 781352 Change-Id: Ie28ff95630b68ff5dc11c920f652fd721920af63 Reviewed-on: https://chromium-review.googlesource.com/758929 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515057}
-
Dan Sinclair authored
When traversing the |deferred_page_unloads_| list and handling the unloads it's possible for new pages to get added to the list which will invalidate the iterator. This CL swaps the list with an empty list and does the iteration on the list copy. New items that are unloaded while handling the defers will be unloaded at a later point. Bug: 780450 Change-Id: Ic7ced1c82227109784fb536ce19a4dd51b9119ac Reviewed-on: https://chromium-review.googlesource.com/758916 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#515056}
-
Daniel Cheng authored
This lets the code dispatch to LocalFrame or RemoteFrame as appropriate. Bug: 608780 Change-Id: I95f4c5298461f907959124169fd01cee06659df9 Reviewed-on: https://chromium-review.googlesource.com/748031 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#515055}
-
Vladimir Levin authored
This patch adds these histograms: Compositing.{Browser,Renderer>.CachedImagesCount.{Gpu,Software} To measure the maximum amount of images that we cache over the lifetime of the cache. This is meant to guide the maximum number of images we would keep in software and overall a data point to understand image usage on the web. R=ericrk@chromium.org, khushalsagar@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ice882e68f8b1d536bd8a4b072c55c0f0a0081a4f Reviewed-on: https://chromium-review.googlesource.com/758820Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515054}
-
Peiyong Lin authored
Previously when we need to simulate clock ticks in tests, we need each indivisual components like PageCoordinationUnitImpl to carry its own tick clock, and we have to create helper functions to set the clock properly among different components. This is fragile and redudant. This patch introduces a ResourceCoordinatorClock which provides 4 helper methods to manipulate clock in testing across components. There's also a recent patch adding timing functions to chrome/browser/resource_coordinator: https://chromium-review.googlesource.com/c/chromium/src/+/723674 BUG=775691 Change-Id: I05e5d1fd688aaa35c8d8abcc4707439f00d9c958 Reviewed-on: https://chromium-review.googlesource.com/756211 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#515053}
-
Bill Orr authored
This change moves daydream-specific assets to a vr_daydream_resources.grd, which is processed on all enable_vr builds, but only included in Chrome on enable_gvr_services builds. Test code can still depend on these assets even if running on desktop. BUG=743687 Change-Id: Ie2516ae2534858044c00f281eb2f71d0cccd8aef Reviewed-on: https://chromium-review.googlesource.com/752035 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515052}
-
Min Qin authored
NetLog is going to be moved into the network service process. We should switch to traceevent for logging purpose instead. BUG=767450 Change-Id: Ic81994a1685057f73716fa7b33a366f94d50dd26 Reviewed-on: https://chromium-review.googlesource.com/750050 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515051}
-
Mike Reed authored
Bug: 782858 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If4a5bc70f8a9eac788960abfb3e2b4db5eec2438 Reviewed-on: https://chromium-review.googlesource.com/755214Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#515050}
-
Yafei Duan authored
This CL is the third CL of implementing OfflinePageModelTaskfied. It contains: - GetPages* workflow, with GetOfflineIdByClientId. - Related tests for GetPages* workflow. More details: go/offline-page-model-migration Bug: 753595 Change-Id: Ie95389fdb7ac6bfa61fb1ed663f0aa3583c3d11d Reviewed-on: https://chromium-review.googlesource.com/752688Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#515049}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba9cf60e..ad1474a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I159eaadcac569a24b382f2f239da50c4df070ae6 Reviewed-on: https://chromium-review.googlesource.com/758919Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515048}
-
Matthew Jones authored
This change sets the 'toolbar ready for captute' flag when a tab is shown rather than waiting for the URL to be updated. When a tab is reparented for Chrome Home, the activity restarts and resets the flag. Since the URL of the tab technically hasn't changed, the onUrlUpdated even is not called and the URL bitmap is therefore never updated. BUG=781692 Change-Id: I209f81d4f9bed0e2566d7a42c84294c8af1b863e Reviewed-on: https://chromium-review.googlesource.com/757816Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#515047}
-
Gabriel Charette authored
This pass focuses on ML::SNTA in same scope as RunLoop variable Scripted via https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Please CQ if LGTY This CL was uploaded by git cl split. R=jam@chromium.org Bug: 781352 Change-Id: I2c2c6cb8f19d5c3163c0a0012df38d67822dbf42 Reviewed-on: https://chromium-review.googlesource.com/758930 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515046}
-
Nathan Bruer authored
Fixes bug where detect minified code would expect the string to always exist on content for UISourceCode. We now check it's nullcase. R=lushnikov,einbinder BUG=None Change-Id: Ie3c28d246017075549b0fca6c262b2f84bc77bff Reviewed-on: https://chromium-review.googlesource.com/758746Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#515045}
-
Alexander Alekseev authored
This CL adds |chromeos_board| Gaia URL parameter. Bug: 782641 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9980437bc95c5ca0287721798cd93f32ef87970 Reviewed-on: https://chromium-review.googlesource.com/758716Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#515044}
-