- 30 May, 2018 40 commits
-
-
Kenneth Russell authored
Sort gtests in the same way the src/testing/buildbot version does, to minimize differences when switching over to that script. Apply swarming_settings to gtests, not just isolated_scripts. Tbr: ynovikov@chromium.org Tbr: geofflang@chromium.org Bug: 844815 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifd791b9e459230f78b020bf46f031b3d3691e64a Reviewed-on: https://chromium-review.googlesource.com/1079850Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#563068}
-
Owen Min authored
Adjust the dialog based on UI review. 1) Align the enterprise logo with the head of button instead of tail. 2) Append "..." into the launching information. 3) Using close button instead of cancel button. Bug: 840018 Change-Id: I5689eceef9ad9b9061d5e4a3d1e314456704b6a2 Reviewed-on: https://chromium-review.googlesource.com/1072207Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563067}
-
Shakti Sahu authored
For incognito profiles, the infobar is not being shown since the DownloadManagerService only starts observing the download item updates after we open download home in incognito. Fixed this bug in this CL. Bug: 846139 Change-Id: I507c285901474ce47f09a1610639805afe3c904f Reviewed-on: https://chromium-review.googlesource.com/1073078 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#563066}
-
Dave Tapuska authored
Previous attempts of adding and removing to the top layer were done synchronously. The spec has been updated to do this asynchronously and this change matches those changes. Bug: 240576 Change-Id: Ic57a651596c685daa4b32d78421de5db912c106e Reviewed-on: https://chromium-review.googlesource.com/1066600 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#563065}
-
Ahmed Fakhry authored
Based on UX feedback. BUG=848070 Change-Id: I794b8069d74379887ad5ad04070873eb8aeaaf94 Reviewed-on: https://chromium-review.googlesource.com/1080170Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#563064}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:595206 Change-Id: I1abab36d1af07acb7198048f0082423a2d58e258 Reviewed-on: https://chromium-review.googlesource.com/1080176Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#563063}
-
Erik Luo authored
Tooltips only show when the mouse target is visible/has offsetParent. Elements using shadow DOM can have <content> elements in the event path, which may be visible despite having no offsetParent. Bug: 847387 Change-Id: Ie5dab99d27146787ad7b14bdf95c7932af1e712d Reviewed-on: https://chromium-review.googlesource.com/1077328Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#563062}
-
Dominic Mazzoni authored
This reverts commit 714e3f7d. Reason for revert: reproducible crash: http://crbug.com/847276 Original change's description: > Reland "Re-land: Avoid serializing the same accessibility node twice in the same message" > > Reverted second time speculatively to see if it was related to > failures on Win10 Tests x64 (dbg), but it didn't seem related. > > This reverts commit 50da791e. > > Original change's description: > > Revert "Re-land: Avoid serializing the same accessibility node twice in the same message" > > > > Speculative revert, see build failures on Win10 Tests x64 (dbg): > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/803 > > > > Bug: http://crbug.com/846837 > > > > This reverts commit 983e926b. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > Re-land: Avoid serializing the same accessibility node twice in the same message > > > > > > Originally landed: r560165, crrev.com/c/1063007 > > > Reverted: r561246, crrev.com/c/1069891 > > > > > > TBR=dtseng@chromium.org > > > Bug: 651614, 845778 > > > > > > Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff > > > Reviewed-on: https://chromium-review.googlesource.com/1072875 > > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#561913} > > > > TBR=dmazzoni@chromium.org,dtseng@chromium.org > > > > Change-Id: I5cbf8006e4917a9c008143ae4b746543d2b038c2 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 651614, 845778, 846837 > > Reviewed-on: https://chromium-review.googlesource.com/1074050 > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#562043} > > TBR=dmazzoni@chromium.org,dtseng@chromium.org > > Change-Id: I3dc8009836eb084271a3ac5239311008dc17105b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: http://crbug.com/846837, 651614, 845778, 846837 > Reviewed-on: https://chromium-review.googlesource.com/1074587 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562118} TBR=dmazzoni@chromium.org,dtseng@chromium.org NOTRY=true Bug: http://crbug.com/846837, 651614, 845778, 846837, 847276 Change-Id: I342db1180d09bc9eaa1a9c8fc7054fa2ca366eb6 Reviewed-on: https://chromium-review.googlesource.com/1079090 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#563061}
-
Alexis Hetu authored
When an OpenGL implementation exposes the GL_OES_texture_half_float_linear extension, the YUV format can be set to L16F. Since OSMesa doesn't expose this extension, the test currently doesn't fail in this case, but it fails when ran with SwiftShader. This fixes the issue. Bug: chromium:848035 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I076ee00ba187f6d89cc51de41f15f0872d4d728c Reviewed-on: https://chromium-review.googlesource.com/1080030Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#563060}
-
Reid Kleckner authored
ASan and CFG leads to slow process startup. Chromium's test runner uses lots of child processes, so this means things are really slow. Disable CFG for now. This should help keep the ASan bots from timing out. BUG=846966 R=brucedawson@chromium.org Change-Id: Id2d66e97badc67dc29af557ff6bdbbd9cfd3c0b5 Reviewed-on: https://chromium-review.googlesource.com/1074337Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#563059}
-
Sergey Ulanov authored
Previously ServerAliveInterval and ServerAliveCountMax were both set to 1 in SSH config used to connect to Fuchsia from the runner script. This means that SSH diconnects after it fails to deliver 1 keep-alive message within 1 second. This interval is too short, which was causing timeouts and spurious test failures in net_unittests. Increase these values to 2 and 5. BUG=847915 Change-Id: I88d786626512f08da19444615f13285aac461dcb Reviewed-on: https://chromium-review.googlesource.com/1079325Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#563058}
-
Bill Orr authored
This change removes a synchronous call from browser code into VRDevice, in anticipation of making VRDevice a mojo interface. Browser-side now controls whether a device is fallback. The change here is temporary until further refactors to support XR. Fallback devices will be removed, and requestSession will have more logic to determine which device should be returned. Change-Id: I4707eecf3a0ca8356f7139934c2e1fc79f934d37 Reviewed-on: https://chromium-review.googlesource.com/1080039Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#563057}
-
Tien-Ren Chen authored
With the new layout test flag --enable-display-compositor-pixel-dump, BrowserCompositorMac gets desired viewport size in device pixel from the renderer through BrowserCompositorMac::SynchronizeVisualProperties(), and convert that from device pixel to DIP and cache it. However BrowserCompositorMac doesn't know the overriden device scale factor by test scripts, thus the DIP viewport size will not be properly divided by the overriden device scale factor. When next time RenderWidgetHostImpl::SynchronizeVisualProperties is invoked, it will query the current viewport size, we would get the already scaled value and multiply it by the overriden device scale factor again. This makes the viewport size keeps growing until it exceeds the maximum texture size and crash. This CL makes BrowserCompositorMac to use the device scale factor from the render frame metadata, so the correct DIP size of the viewport can be derived. BUG=667551 Change-Id: I21f042ba8c158ce139d1ca6693d135b2fbb7b852 Reviewed-on: https://chromium-review.googlesource.com/1080031 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#563056}
-
Aldo Culquicondor authored
Bug: 846478 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: If825417bb9682cfc98299df85bb3e4960001977c Reviewed-on: https://chromium-review.googlesource.com/1073871 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#563055}
-
Scott Violet authored
If an embedding is created such that the embedder intercepts events, then the embedder should get events regardless of capture. BUG=837692,837696 TEST=covered by test Change-Id: I8ed3e30ff7973d319bb5ac91323382c1743818c1 Reviewed-on: https://chromium-review.googlesource.com/1080092Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#563054}
-
Daniel Erat authored
Update StatisticsProvider to drop pairs received from crossystem that have "(error)" values. NameValuePairsParser ignores duplicate values, so we should get rid of these so they don't prevent us from saving real values later. Also downgrade a "Statistics loaded after waiting ___ ms" LOG(WARNING) to VLOG(1), since this seems to be the common case on a caroline ToT device and it just ends up cluttering the logs. Bug: 844258 Change-Id: Idf869617a03992e51a720359b4ebfdac91dec6e9 Reviewed-on: https://chromium-review.googlesource.com/1072706Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#563053}
-
Robert Ogden authored
Also adds an option to sort by hostname on the DataSaver settings page so that the TalkBack navigation experience is consistent with the other table headers. Bug: 836018 Change-Id: Ic837d520ea613185398b0b2214640b80a41bcfa4 Reviewed-on: https://chromium-review.googlesource.com/1077588Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#563052}
-
Karan Bhatia authored
Currently we create default web request rules registries for the declarative web request API even if the API is not available to the current environment. This is wasteful and detrimental to performance, since the initial registry load blocks the first network request (tracked via Extensions.NetworkDelayRegistryLoad UMA). This CL changes RulesRegistryService so that the default WebRequestRulesRegistry is registered only if the declarative web request API is avaialble to the current environment. This, for example, means that no default web request rule registries would be created on the stable channel. Rules registries corresponding to webviews and the default content rules registry would still be created. This also helps fix issue 777717 and renderer cache is not cleared redundantly on each extension load/unload/uninstall when the API is not available. BUG=693243, 777717 Change-Id: I7384fed71a86aea3f5cc8d2eafd1445b439dd76a Reviewed-on: https://chromium-review.googlesource.com/1072497Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563051}
-
Malay Keshav authored
This patch changes the logic the list of zoom values are computed for a given display. The new logic has 2 scenarios for listing the zoom values for a given display. 1) Displays with device scale factors assigned to them, will now have zoom values ranging from the inverse of device scale factor to device scale factor. If there are still slider ticks avaiable we use them to add zoom levels beyond the device scale factor. Doing this allows the user to go to the native resolution of the display and on the other hand it also allows them to zoom in if required. We no longer allow the user to go to a zoom below the native resolution of the display as this is a very unlikely scenario and introduces artifacts. This also gives finer control to the user in setting the zoom level. How this effects a pixelbook for example? On pixelbook we used to have a zoom range of 50% to 175%. Due to the wide range, the consecutive values were too far apart and users wanted zoom values that were mostly in the range of 70% to 100%. With the new change, the range will go from 50% to 130%. 2) Displays with no device scale factors assigned to them will use a static list of initialized zoom values. Bug: 845634 Change-Id: I69a761856dab4e5b37b85420f6f6dfebdb2dead5 Component: Display zoom, display util Reviewed-on: https://chromium-review.googlesource.com/1069561 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#563050}
-
Thomas Guilbert authored
Bug: 842402 Change-Id: I0639f8bd383481f8727e149fedb8b46201b895ad Reviewed-on: https://chromium-review.googlesource.com/1077616Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#563049}
-
Min Chen authored
- Add "Feedback" item to power button menu if user is logged in and screen is unlocked. Since sending feedback was not allowed at login and lock screen. finch side change: https://critique.corp.google.com/#review/197648342 spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view Bug: 845558 Change-Id: I93dadb2f3e12fd389ed649c2fa5884a31971704b Reviewed-on: https://chromium-review.googlesource.com/1069627 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#563048}
-
Devlin Cronin authored
Update references to ExtensionService in c/b/task_manager to use extensions::ExtensionService. There should be no behavior change as a result of this CL. Bug: 117261 Change-Id: I18111ab851102ba21239b4ae7b7ee54ec0fc1076 Reviewed-on: https://chromium-review.googlesource.com/1080021Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563047}
-
Johannes Henkel authored
This is a reland of 888c9108 Original change's description: > Delete HeadlessBrowserContext::Observer::OnChildContentsCreated. > > This isn't used. > > Change-Id: Id61efee5ce35617c6ab65c6c19a059b36323176f > Reviewed-on: https://chromium-review.googlesource.com/1065076 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559821} Change-Id: I52e6f2361da7dd900eef24dea4aefd57fa8dda9a Reviewed-on: https://chromium-review.googlesource.com/1073619Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#563046}
-
danakj authored
It was being used to report if it was there or not, and in some dead functions. The test checking IsSoftware() didn't actually care, (it used it to pass HARDWARE or SOFTWARE to a funciton that only checks for RESOURCELESS_SOFTWARE) and the dead code is now removed. TBR=jam Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia5c19a3ac25dc3d2ae58e44cee25d2c44ec61dff Reviewed-on: https://chromium-review.googlesource.com/1079688 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#563045}
-
Devlin Cronin authored
Update references to ExtensionService in c/b/notifications to use extensions::ExtensionService. There should be no behavior change as a result of this CL. Bug: 117261 Change-Id: Ie3133eeb0a9778c909420b3f531e2d34d4270686 Reviewed-on: https://chromium-review.googlesource.com/1079901Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563044}
-
Reid Kleckner authored
It was recently enabled in https://chromium-review.googlesource.com/c/chromium/src/+/1076594, but it does not pass. I have not debugged it, I'm just trying to get things back to green now that we are running this test more widely. TBR=sky@chromium.org, thakis@chromium.org BUG=848049 Change-Id: Ic0842dce2ddc10951b28e3e095f746c06076ecfe Reviewed-on: https://chromium-review.googlesource.com/1080073Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#563043}
-
Devlin Cronin authored
URLRequests terminate with a status of canceled if the device is suspended during download. In order to accommodate for this when downloading an extension, add this to the cases in which we retry automatically. Bug: 824454 Change-Id: Ia3187c0ca0150968d8eae67f8f265bb6f7e7ab6e Reviewed-on: https://chromium-review.googlesource.com/1079689Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563042}
-
Qiang Xu authored
Bug: 846890 Test: manual Change-Id: I37b4a89130d282a497058485bcd1c24fd87b326d Reviewed-on: https://chromium-review.googlesource.com/1074224Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#563041}
-
Hwanseung Lee authored
GamepadDispatcher caches the last gamepad that was connected or disconnected as well as its index and connection state. but The cached value is no longer used. Bug: 843305 Change-Id: I20b30f88d638f94b4a41f593a6976f7ae5f3d4e8 Reviewed-on: https://chromium-review.googlesource.com/1077879Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#563040}
-
Jialiu Lin authored
DownloadItem::GetHash() returns raw SHA-256 hash that is not hex encoded. This may cause DCHCEK failure when passing on the DangerousDownloadInfo::ToValue() since the raw hash may not be UTF8. Therefore, this CL HexEncode the raw sha256 first before passing onto the event router. Bug: 846156,796087 Change-Id: Iab51535d7de0b37841851b4887ffca9cf099bd39 Reviewed-on: https://chromium-review.googlesource.com/1079436Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#563039}
-
Joe Downing authored
These tests are similar to the tests in the content layer, however these test exercise Chrome E2E instead of using stubs. BUG=680809 Change-Id: I371d1cdec025517634e62b7ee4cde674c480307c Reviewed-on: https://chromium-review.googlesource.com/1068122 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#563038}
-
Mike Wasserman authored
Use PrefRegistrySyncable's new whitelist for delayed pref registration. (there's a race between ash prefs connecting to chrome and sync init) Avoids PrefServiceSyncable::AddRegisteredSyncablePreference DCHECKs. See the bug and earlier patch sets for debug code to trigger the race: 1) Build chromeos=1 on linux desktop with this patch applied 2) Run chrome --user-data-dir=/tmp/foo --login-manager 3) Go through setup, sign in to an existing account 4) Launch chrome again, sign in quickly, wait ~10s for a DCHECK Bug: 788918 Change-Id: Ib505194900b34154b3896373b93c951a6eeb8715 Reviewed-on: https://chromium-review.googlesource.com/1012788Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#563037}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5033ec9..2cf653be Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4cc42260783ae16d8711536fc234e96a54f4d432 Reviewed-on: https://chromium-review.googlesource.com/1079256Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#563036}
-
wutao authored
When SetIcon in the SearchResultTileItemview, the icon is not resized for different display size. Therefore the image quality is bad when the scale is not 1. Resizing the icon will fix this bug. Bug: 842997 Test: manual Change-Id: I00189636fbb2499e778f777d7e93cd60a3cc9057 Reviewed-on: https://chromium-review.googlesource.com/1080011Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#563035}
-
Takumi Fujimoto authored
Make MRViewsUI filter out pseudo sink, since it is not used in the Views dialog and should not show up on the sink list. Bug: 842778 Change-Id: Icb7b5197bfcf15b7abd14389025e16f2d6391f4e Reviewed-on: https://chromium-review.googlesource.com/1070494Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#563034}
-
erikchen authored
Previously, OOP HP relied on base TLS to implement its re-entrancy bit. Base TLS cannot be used after thread destruction has started. This means that frees that occurred during thread destruction were not being logged. This CL implements a very simple cross-platform TLS re-entrancy bit. Since it's only a single bit, the data can be stored in the TLS value without needing any additional allocations. This means that it can be safely used during thread destruction. With this CL, frees that occur in thread destruction will be correctly recorded. Allocations still depend on base TLS, so they will be missed. Bug: 839416 Change-Id: I2e1aab9de73122f234a4b11b826e491c347dcfd5 TBR: gab@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1076448Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#563033}
-
Alexei Filippov authored
This is a reland of 250e7ef1 Original change's description: > Reland "DevTools: Support CPU profiles in OOPIFs" > > This is a reland of 91d5ec53 > > Original change's description: > > DevTools: Support CPU profiles in OOPIFs > > > > BUG=832313,820250 > > > > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf > > Reviewed-on: https://chromium-review.googlesource.com/1011350 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553688} > > TBR=dgozman > > Bug: 832313, 820250 > Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de > Reviewed-on: https://chromium-review.googlesource.com/1065230 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560049} TBR=dgozman Bug: 832313, 820250 Change-Id: I7eee078d51e23034ac8c08ce315949c4d78c7092 Reviewed-on: https://chromium-review.googlesource.com/1079729Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#563032}
-
Karan Bhatia authored
r487664 disallowed content script injection in the New Tab Page. However, the check in RendererPermissionsPolicyDelegate::IsRestrictedUrl for the same, might not work due to the following reasons: - There might be a race between checking if the extension can inject the script and setting the new tab url in the renderer (SearchBouncer). - The New Tab page url in the SearchBouncer might be set incorrectly due to incorrect handling of multiple profiles by InstantService. Fix this by checking if the current renderer process is an Instant (NTP) renderer. This should work since the NTP renderer process should not be shared with other sites. BUG=844428, 662610 Change-Id: I45f6b27fb2680d3b8df6e1da223452ffee09b0d8 Reviewed-on: https://chromium-review.googlesource.com/1068607Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563031}
-
Stephen Chenney authored
LayoutRectOutsets appear in painting code and are otherwise cumbersome to log. R=pdr@chromium.org Change-Id: Iab1cb66b3692bf48250d896e0448dfbd8e3ee8ec Reviewed-on: https://chromium-review.googlesource.com/1078938Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#563030}
-
Max Moroz authored
The CL depends on https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1073394 Bug: 846721 Change-Id: I183e6adf370da3de30f16b2b6917a9a5d927e37b Reviewed-on: https://chromium-review.googlesource.com/1073395Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#563029}
-