GitLab

As pointed out in the bug, unhandled errors on worker threads were not
properly being propagated for the parent thread to handle as the spec
requires (https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2).
This fix adds in the code to do that.

Bug: 685303
Change-Id: Ie3e7ec03153a43efdc6e70b874d6b1a1d8ac35ef
Reviewed-on: https://chromium-review.googlesource.com/c/1287208
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605857}

This changes the prior DCHECK() on double-calls to CompositeAllFramesThen()
into a NOTREACHED/return. Previously, it was possible, in release builds,
to start another composite while the previous one was still running, causing
use-after-free situations. This doesn't normally happen in layout testing,
and can't happen at all in a Chrome build, but this protects from
ClusterFuzz issues.
See https://clusterfuzz.com/v2/testcase-detail/4929420383748096

Bug: 899465
Change-Id: I2acd1128bf808b035850c9f36779326f18585864
Reviewed-on: https://chromium-review.googlesource.com/c/1311131
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605856}

This reverts commit 406c50b3.

Reason for revert: Speculative revert to fix the test external/wpt/workers/semantics/structured-clone/shared.html

first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530

If this won't fix the test, I'll reland the patch.

Original change's description:
> Fix 64 bit truncation warnings in renderer/core/fetch.
> 
> Use appropriate types in fetch code.
> 
> BUG=879657
> 
> Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e
> Reviewed-on: https://chromium-review.googlesource.com/c/1298329
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605685}

TBR=bokan@chromium.org,dtapuska@chromium.org

Change-Id: I36f8751112daf958ef849549b2c94a57c297ab8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879657
Reviewed-on: https://chromium-review.googlesource.com/c/1321251Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605855}

The "help" ad-hoc parsing only works in the simplest case:
  grit help
  grit help foo

When passing options to grit, the "help" builtin fails and producing
confusing output:
  $ grit -i ... help
  No such tool.  Try running 'grit help' for a list of tools.
  $ grit -i ... help xmb
  No such tool.  Try running 'grit help' for a list of tools.

Delay parsing of the "help" tool until after we've processed grit's
core options.

Bug: 747171
Change-Id: Iae5fdee2493346cee4272368ac8862647433faaf
Reviewed-on: https://chromium-review.googlesource.com/c/1320690Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605854}

The current combination of WindowTargeter with MaskedWindowDelegate
isn't working well with Mash. Instead of doing this, it needs to
use window targeter's new API for setting window masks.

The GetEventHandlerForPoint should be fixed in a way to follow
this new way.

BUG=901546
TEST=the new test case also covers

Change-Id: I0b095777450fab3fa28ff9ebd8473667f644ab9e
Reviewed-on: https://chromium-review.googlesource.com/c/1320689Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605853}

This is a reland of c33a38d7

Original change's description:
> Re-baseline tests after --enable-display-compositor-pixel-dump
> 
> This CL enabled display compositor pixel dumps by default, which caused
> this group of tests to fail due to either a) minor antialiasing artifacts,
> or b) known differences in output due to being captured from the browser
> side.
> 
> https://chromium-review.googlesource.com/c/chromium/src/+/1213864
> 
> These bugs should be resolved with this CL:
>  - crbug.com/881040: Media controls now contain an overflow menu.
>  - crbug.com/667551: A bunch of tests are listed under this bug, and just
>                      require rebaselining to fix non-material single-pixel
>                      antialiasing failures.
>  - crbug.com/895556: These tests double their background size when the flag
>                      is enabled. These were already fixed by another CL,
>                      so they are NOT being rebaselined here, just removed
>                      from TestExpectations.
> 
> 
> Bug: 895912, 881040, 667551, 895556
> Change-Id: I14a1065df604151ed06f2a6be4da7eaa53968705
> Reviewed-on: https://chromium-review.googlesource.com/c/1303179
> Commit-Queue: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605004}

Bug: 895912, 881040, 667551, 895556
Change-Id: I9b9d41cfda7ea06cf64313537ba2eaaa6336b513
Reviewed-on: https://chromium-review.googlesource.com/c/1318171Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605852}

Add enable_cast_wayland_server flag to selectively enable exo server use.
Add a Cast-specific implementation of wm_helper.
This implementation contains the minimum required to make exo work on cast shell.

support EXO.

Bug: 896710
Test: Built on ChromeOS, is not utilized yet as cast does not yet
Change-Id: I0e38a415fbdecdbe7f116885ed9048834cbca1b5
Reviewed-on: https://chromium-review.googlesource.com/c/1294835
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605851}

After resetting the operation runner, we should clean up any existing
FileSystemCancellableOperation bindings as they all point to operations
that no longer exist.

Bug: 899146
Change-Id: I70cf4008f64534a1ac22c2ffe507d5b2a9d16208
Reviewed-on: https://chromium-review.googlesource.com/c/1301960Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605850}

Renames the "user ID" and "instance name" fields to "instance
group" and "instance ID", respectively, per discussion on the bug.

A follow-up will change the types of the instance group and ID fields to
be optional UnguessableTokens instead of free-form strings.

TBR=jam@chromium.org

Bug: 895591
Change-Id: I0c4d75f5e12a468dad251f238813bc79c497830a
Reviewed-on: https://chromium-review.googlesource.com/c/1318836
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605849}

In W3C mode, Element Send Keys command should get keys from string
property "text", instead of list property "value".

Bug: chromedriver:2649
Change-Id: I68b915ad572c289364d797aa34496b2278cb3997
Reviewed-on: https://chromium-review.googlesource.com/c/1320208Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605848}

https://chromium.googlesource.com/catapult.git/+log/0273c5e3c23a..70df4ea4898e


git log 0273c5e3c23a..70df4ea4898e --date=short --no-merges --format='%ad %ae %s'
2018-11-06 dpranke@chromium.org Address review comments from https://crrev.com/c/1171862.
2018-11-06 eroman@chromium.org Add --proxy-bypass-list parameter to explicitly allow proxying of localhost.


Created with:
  gclient setdep -r src/third_party/catapult@70df4ea4898e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:835690,chromium:901896
TBR=sullivan@chromium.org

Change-Id: Icea4759cfbfe703010fc8136b82755bd9be74c18
Reviewed-on: https://chromium-review.googlesource.com/c/1320614Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605847}

FrameSink debug labels are useful to identify the client associated with a
particular FrameSink or Surface. This CL introduces the appropriate plumbing
to allow printing the FrameSink debug label given a FrameSinkId from the
surfaces layer. The debug label will now be printed if a temporary
reference is orphand and will be garbage collected.

Bug: 655231
Change-Id: I75abd9b6aff484fee946e2ee584bd9927a0b843c
Reviewed-on: https://chromium-review.googlesource.com/c/1320018Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605846}

After calling these method, return values of TextInputClient is not
updated.
This CL removes the text input state update timer when calling the
methods to prevent send a false state.

Bug: 897691
Test: Ran on DUT
Change-Id: I7fdb7f8038391f7e9433ad1de0e0607232e2e890
Reviewed-on: https://chromium-review.googlesource.com/c/1319396Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605845}

Reland "Update existing Switch Access tests"

This is a reland of d4860fed

Original change's description:
> Update existing Switch Access tests
>
> Bug: 897365
> Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9
> Reviewed-on: https://chromium-review.googlesource.com/c/1306787
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605719}

Bug: 897365
Change-Id: Ic0b73345f79bf5a075fd42cbea69a74b0e890257
Reviewed-on: https://chromium-review.googlesource.com/c/1320027Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605844}

Change-Id: I20754af1acb09faa74d73d1ba1dbc627ca740759
Reviewed-on: https://chromium-review.googlesource.com/c/1320731
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605843}

Change-Id: I798f714ba544e01370f9289067a0e180d7b67f45
Reviewed-on: https://chromium-review.googlesource.com/c/1308035
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605842}

Chrome-proxy is piecemeal constructed when NetworkService is enabled. For example,
the secure hash is added from the post_cache_headers in NetworkContext. 'frfr' is
added for first media requests from the blink layer. This CL adds page ID for
mainframe requests via post cache headers in URLLoader.

Bug: 893728
Change-Id: I9110896ed7242e424b02e2c125a080dd853d6325
Reviewed-on: https://chromium-review.googlesource.com/c/1318431Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605841}

Bug: 900959
Change-Id: Iae62ce77d2fd38105120d86799e52157d6313f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1313738
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605840}

This reverts commit 18a9ef45.

Reason for revert: Broke the accessibility test (again): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/29232

Please note this does not look like a flake, after this landed a dozen runs failed consistently. 

Original change's description:
> Full AttachLayoutTree on a new Document not necessary.
> 
> We called AttachLayoutTree on a new Document which just got its
> LayoutView created. The new Document should not have any child nodes,
> it's not marked initially dirty, but trying to land this change the
> first time we caused flakiness for a Window accessibility test.
> 
> Instead of the AttachLayoutTree call, do the AXObjectCache update which
> would otherwise be called from Node::AttachLayoutTree.
> 
> This is a new attempt after the previous got reverted:
> 
> https://chromium-review.googlesource.com/c/chromium/src/+/1317889
> 
> Bug: 902050
> Change-Id: I4e366013549627b54f016d76b3dcbf12ea115f70
> Reviewed-on: https://chromium-review.googlesource.com/c/1319610
> Reviewed-by: Anders Ruud <andruud@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605657}

TBR=futhark@chromium.org,andruud@chromium.org

Change-Id: Ied8ff9426940489ac4693abdb34001f44b13478c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 902050
Reviewed-on: https://chromium-review.googlesource.com/c/1321229Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605839}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6eef2ff50b8c..9e5f6a771e82


Created with:
  gclient setdep -r src-internal@9e5f6a771e82

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icdc56be655426d87954602251063a6caa6a2d73c
Reviewed-on: https://chromium-review.googlesource.com/c/1320612Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605838}

This change adds a note and an example to clarify why it's safe to
return read-only views in struct traits accessors.

Change-Id: I0b6b646de10dd01fe5ae347f48d9a119b6e118a6
Reviewed-on: https://chromium-review.googlesource.com/c/1316787
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#605837}

This reverts commit 50444a9b.

Reason for revert: We want shill sandboxing default-enabled on M72.

Original change's description:
> Revert "Wire up ShillSandboxing flag to be enabled by default"
>
> This reverts commit e034d163.
>
> Reason for revert: We want to change shill sandboxing back to
> default-disabled rather than default-enabled. We will still roll out
> sandboxing to 50% of users in M70.
>
> Original change's description:
> > Wire up ShillSandboxing flag to be enabled by default
> >
> > In a previous CL:1173260 I meant to wire up this feature flag to be
> > enabled by default. Somehow I mistakenly landed the code with the
> > FEATURE_DISABLED_BY_DEFAULT flag instead.
> >
> > Bug: 649417
> > Test: Same as CL:1173260
> > Change-Id: I2154749addb0539be9a2ef53c368d80dc10bee41
> > Reviewed-on: https://chromium-review.googlesource.com/1190644
> > Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> > Commit-Queue: Micah Morton <mortonm@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586444}
>
> TBR=stevenjb@chromium.org,mnissler@chromium.org,mortonm@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 649417
> Change-Id: Ice783f6bced9828e1ae8fb966f00f5dc32aff3f2
> Reviewed-on: https://chromium-review.googlesource.com/1251326
> Reviewed-by: Mattias Nissler <mnissler@chromium.org>
> Commit-Queue: Micah Morton <mortonm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595474}

TBR=stevenjb@chromium.org,mnissler@chromium.org,mortonm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 649417
Change-Id: I1a949e2711d59945b838fabb321c9dfaed3f0799
Reviewed-on: https://chromium-review.googlesource.com/c/1269947Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Micah Morton <mortonm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605836}

Bug: 863221
Change-Id: Id2fe5975439c2d2cb5ee59c80f7c02a7fce3320d
Reviewed-on: https://chromium-review.googlesource.com/c/1318834Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605835}

https://skia.googlesource.com/skia.git/+log/5d3deb7301b1..fe454acf5ef1


git log 5d3deb7301b1..fe454acf5ef1 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4169b31090db..1d8c8dba995a (1 commits)
2018-11-06 reed@google.com split out fontmetrics into its own struct
2018-11-06 mtklein@google.com Reland "make enum santizer fatal"


Created with:
  gclient setdep -r src/third_party/skia@fe454acf5ef1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: Id9f53a74892e8aa0fc475d07df5c18b5a67c6b7e
Reviewed-on: https://chromium-review.googlesource.com/c/1319953Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605834}

Bug: 827318,876947
Change-Id: I72ead221b797a90c19d7742422d65a29ed5f1741
Reviewed-on: https://chromium-review.googlesource.com/c/1318849Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605833}

This adds 2 entrypoints:
- CreateSharedImage, which takes a GpuMemoryBuffer to wrap into a shared
image (equivalent to CreateImageCHROMIUM+BindTexImage2DCHROMIUM)
- UpdateSharedImage, which updates the binding after CPU/external writes
to the GMB (equivalent to ReleaseTexImage2DCHROMIUM+BindTexImage2DCHROMIUM).

This is only plumbed to SharedImageBackingFactoryGLTexture in this CL.

Bug: 870116
Change-Id: Ie7645b65649b0f34d5431fc00f62da9d5661c570
Reviewed-on: https://chromium-review.googlesource.com/c/1316250Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605832}

Also get rid of the SIZE placeholder constant, since it requires
additional case statements in switches. Define kMaxValue instead: clang
enforces the correct definition of this value, and the UMA enumeration
histograms can take advantage of it without any weird casting.

Bug: 742517
Tbr: oshima@chromium.org
Tbr: thestig@chromium.org
Change-Id: I34373733f7be363aa1d70827ae88dc03c6934819
Reviewed-on: https://chromium-review.googlesource.com/c/1312685
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605831}

Bug: 678391
Change-Id: I7751e50a050d32f826315832d6e250137eaba1cf
Reviewed-on: https://chromium-review.googlesource.com/c/1320730Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605830}

This callback may be reached as part of a close document action
after the engine has been destroyed. Further inspection of the code
shows that the same might also happen for Print().

Bug: 901640
Change-Id: I8faaeaf72adb37441f9e9c977093273c9e055e91
Reviewed-on: https://chromium-review.googlesource.com/c/1320810Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605829}

https://android.googlesource.com/platform/external/perfetto.git/+log/cc7964918f7c..02924fce9a91


git log cc7964918f7c..02924fce9a91 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 primiano@google.com Merge "UI: tracks drag & drop + minor fixes"


Created with:
  gclient setdep -r src/third_party/perfetto@02924fce9a91

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I51387a85e5496afa1a2d2959fcd7dae3809c18ed
Reviewed-on: https://chromium-review.googlesource.com/c/1320789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605828}

As there are no implicit conversions, break the inheritance completely
and clean a few remaining callsites.

R=gab@chromium.org
TBR=gab@chromium.org
BUG=891670

Change-Id: Ib8cd1461c24cecec70248e31597198fc670ec857
Reviewed-on: https://chromium-review.googlesource.com/c/1312481Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605827}

Vectors of primitive types and strings were previously implemented; this
extends support to vectors of unions and structs.

Bug: 883496
Change-Id: Id00174b05d04c3f432fae39112afde658e533806
Reviewed-on: https://chromium-review.googlesource.com/c/1318676
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605826}

We're looking to merge this (ideally temporary) metric into M71.
A problem has been discovered with regards to checkout flows that span
multiple domains, and this will help determine its impact.

Bug: 892299
Change-Id: I79c9acba23eb750aecf0171ee92d0de456c2ce0e
Reviewed-on: https://chromium-review.googlesource.com/c/1315953Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#605825}

This reverts commit 9fb6183a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 605820 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzlmYjYxODNhZWY2NzhmYjJmMmJhM2I5ZTU0MGQwZDYxNTU1Y2U1ODQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-rel/9695

Sample Failed Step: compile

Original change's description:
> Move legacy DNS-related net/ mojo interfaces to proxy resolver service.
> 
> Also moves the code that imlepments each side of the interfaces from
> net/ over to the location of the single consumer of each of them, in
> the proxy_resolver and network services.
> 
> This CL is strictly a move, with no code changes. I will do some cleanup
> work in followup CLs.
> 
> Bug: 901419
> Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97
> Reviewed-on: https://chromium-review.googlesource.com/c/1320209
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605820}

Change-Id: Ib6e8a9b7501437d72a0a59df5881cdfc5dd12c0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901419
Reviewed-on: https://chromium-review.googlesource.com/c/1320594
Cr-Commit-Position: refs/heads/master@{#605824}

* Remove jialiul@ (has left Chrome)
* Add drubery@ to a few dirs where he's the expert now
* Add COMPONENT info to all of them
* Other misc cleanups

Bug: 894851
Change-Id: I60e6b0f8651486a656363fe2b215b1451ae75615
Reviewed-on: https://chromium-review.googlesource.com/c/1318909
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605823}

Instead open links in app windows. See details
on the bug.

BUG=899092
TEST=Manual; all links open inside app windows rather than tabs.

Change-Id: I2fc0dc02a17fb37daec9c715ba1801d35cc1a629
Reviewed-on: https://chromium-review.googlesource.com/c/1320216Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605822}

No flag flip.

In QUIC, fix a bug where write blocked causes a spurious ack alarm to be set.
Protected by FLAGS_quic_reloadable_flag_quic_fix_spurious_ack _alarm.
Merge internal change: 219926538
https://chromium-review.googlesource.com/c/chromium/src/+/1318583

Remove unused constants from QuicConstants.
n/a (Remove unused constants)
Merge internal change: 219898685
https://chromium-review.googlesource.com/c/chromium/src/+/1318674

Factor out common code for sending control frames.
Code refactoring, no functional changes.
This CL extracts common code out of the several QuicControlFrameManager
methods that WriteOrBufferXxxFrame uses to actually perform the write.
This done in support of work for IETF QUIC STOP_SENDING frame.
Merge internal change: 219844258
https://chromium-review.googlesource.com/c/chromium/src/+/1318672

Create connecting methods in QuicSpdyStream to prevent its own class/subclasses
from calling QuicStream::WritevData() and QuicStream::WriteMemSlices() directly.
This CL prepares for change in IETF HTTP/QUIC mapping.
no behavior change.
Merge internal change: 219826835
https://chromium-review.googlesource.com/c/chromium/src/+/1318581

Replace FLAGS_quic_enable_version_99 with (enabling_blocked_by)
FLAGS_quic_reloadable_flags_quic_enable_version_99.
Merge internal change: 219787903
https://chromium-review.googlesource.com/c/chromium/src/+/1318573

Remove RetransmittableOnWireDelegate and the associated alarm and replace it
with the ping alarm in QuicConnection.
n/a (RetransmittableOnWireAlarm and PingAlarm are client only)
Merge internal change: 219732352
https://chromium-review.googlesource.com/c/chromium/src/+/1318569

Prevent all class/subclasses of QuicSpdyStream from calling
QuicStream::WriteOrBufferData() directly.
Instead, call QuicSpdyStream::WriteOrBufferData().
This CL prepares for change on IETF HTTP/QUIC mapping.
no behavior change.
Merge internal change: 219711495
https://chromium-review.googlesource.com/c/chromium/src/+/1317897

Change method signature of data frame encoder to take a length instead of a
frame struct. The reason is that often times when the encoder is called,
there isn't a well constructed data frame that is ready to use. Computing
the length of data is much easier.
n/a --unused code.
Merge internal change: 219708783
https://chromium-review.googlesource.com/c/chromium/src/+/1317920

Use GetCryptoStreamId() rather than hard-coded 1 for crypto stream ID
Test used a hard-coded 1 for the crypto stream ID. This is not the case when
Version 99 is enabled. This change uses GetCryptoStreamId() to get the
actual crypto stream ID for the current version.
n/a -- tests only
Merge internal change: 219471728
https://chromium-review.googlesource.com/c/chromium/src/+/1318445

Add OnCanCreateNewOutgoingStream to QuicSession,
Also revises the simple server session and grpc client session
so that they will receive the notification that more streams are avialable.
N/A code all in support of and protected by flag for version-99 (IETF QUIC).
Merge internal change: 219177525
https://chromium-review.googlesource.com/c/chromium/src/+/1318440

Change-Id: I5819d9c9a9fc45fc5cbeba2f3ddd8b925ae1c381
Reviewed-on: https://chromium-review.googlesource.com/c/1318678Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605821}

Also moves the code that imlepments each side of the interfaces from
net/ over to the location of the single consumer of each of them, in
the proxy_resolver and network services.

This CL is strictly a move, with no code changes. I will do some cleanup
work in followup CLs.

Bug: 901419
Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97
Reviewed-on: https://chromium-review.googlesource.com/c/1320209Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605820}

CanvasImageProvider is an inner class of CanvasResourceProvider,
that only needs to be defined on the header for the base::Optional
use of it. This CL changes that to std::unique_ptr<> like its sister
member |canvas_|, moves its implementation to the .cc file and
inlines the 1-line methods.

Also I replaced a base::Unretained() with a WeakPtr() since
I didn't see why wouldn't it work.

No new code intended beyond that, just cleaning up what there is.

Bug: 839970
Change-Id: I8f3b299c12662a7a83c72ac7bc3eae1b8c1f27ea
Reviewed-on: https://chromium-review.googlesource.com/c/1318816
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605819}

This simplifies "some" of the dependencies from the
AutocompleteCoordinator to the list view itself.  The
key handling is going to get a bit gnarly, but this
is closer to being able to move the bulk of the coordinator
into the existing AutocompleteMediator.

NOPRESUBMIT=true
BUG=898522

Change-Id: I71f6458220d4ba48c80db4aa18a3e78fe910872e
Reviewed-on: https://chromium-review.googlesource.com/c/1316832
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605818}