GitLab

test-25fps.*.frames.md5 contains the golden md5 values on decoded video frames
in VDA unittest. These values must be identical on any platforms.

BUG=chromium:856562
TEST=VDA unittest at eve, veyron_minnie, hana

Change-Id: I3c63b92dcc52b8a3a6cc1dc4a2dd9e9147e5ec7b
Reviewed-on: https://chromium-review.googlesource.com/c/1172271
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600744}

This reverts commit 1e0ee862.

Reason for revert: Don't use popen() as it is not available on Windows.

Original change's description:
> Revert "[Cronet] Create a sample app for native api."
>
> This reverts commit b54f7c7f.
>
> Reason for revert: breaking the tree
>
> Original change's description:
> > [Cronet] Create a sample app for native api.
> >
> > Bug: 786559
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> > Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274426
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Commit-Queue: Misha Efimov <mef@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600438}
>
> TBR=pauljensen@chromium.org,mef@chromium.org
>
> Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 786559
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Reviewed-on: https://chromium-review.googlesource.com/c/1286935
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600444}

TBR=tguilbert@chromium.org

Change-Id: I4935a11d8f20e97122fccd9451a201d135d5db8a
Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/c/1286745Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600743}

Currently, this method is simply calling ResetChildren() on the current
RenderFrameHost. It used to do more, but this is no longer the case.

This CL removes this method. Seeing RenderFrameHostImpl::ResetChildren()
in the code is more explicit about what happens. It is easier to
understand.

Bug: 609963
Change-Id: Ia82726f445b127ccca3758d7578e71eb32a49cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1286421
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600742}

Adds flags on all browser layers which are used for enabling in a Finch
trial.

Tbr: jochen@chromium.org
Bug: 843903
Change-Id: I50d9aa479b1fb6e27588eae000138564f377b523
Reviewed-on: https://chromium-review.googlesource.com/c/1286854
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600741}

https://android.googlesource.com/platform/external/perfetto.git/+log/613fd1daf8d6..6db99a9ca272


git log 613fd1daf8d6..6db99a9ca272 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 fmayer@google.com Add PERFETTO_DFATAL.
2018-10-18 fmayer@google.com profiling: Send total size attributed to allocation.
2018-10-18 primiano@google.com Don't create executable files (0755 -> 0644)
2018-10-17 primiano@google.com Merge "perfetto-ui: Remove flame chart for now"


Created with:
  gclient setdep -r src/third_party/perfetto@6db99a9ca272

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:895473
TBR=perfetto-bugs@google.com

Change-Id: Ib4834e886bba5678a3626c5a03027053ece37b22
Reviewed-on: https://chromium-review.googlesource.com/c/1288676Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600740}

Bug: 896303
Change-Id: Icf856bfa95640cbb44e75d35cc0e8514aac69e62
Reviewed-on: https://chromium-review.googlesource.com/c/1286850
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600739}

Since crrev.com/c/1233716, the keyboard accessory doesn't affect the
bottom controls anymore - which is largely correct since it uses a
separate mechanism to reserve that space.
Unfortunatly, the BottomToolbar (Chrome Duet feature) doesn't recognize
the opened accessory sheet as a keyboard and reserves space for bottom
controls that don't exist.

This will change when the way keyboards are detected is reworked in
crrev.com/c/1286426 but until this and its ancestor lands, the effects
of the accessory on the bottom controls are reintroduces with this CL.

Bug: 894747
Change-Id: I0467d10700c597cfe5fbf8a6463b220268ad6160
Reviewed-on: https://chromium-review.googlesource.com/c/1288592Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600738}

This CL fixes the tests so they can run with the fullscreen refactoring
flags enabled by default.
It also fixes an issue with the ntp_util functions.

Bug:none

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iec703052548d3f7c024d47c30d7a429162144d85
Reviewed-on: https://chromium-review.googlesource.com/c/1261523Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600737}

These buttons have two modes: a context menu and an "activation", which usually
shows a popup but may also take an action on the page or similar. They
subclass MenuButton, so down-arrow is wired to activation instead of to opening
the menu by default. This change causes extension actions to always open their
context menu on down-arrow instead of activating, since otherwise the context
menu is keyboard-inaccessible.

Bug: 696268
Change-Id: If0f12c3ac5b1168cc74ea5df848ecf30d0662e09
Reviewed-on: https://chromium-review.googlesource.com/c/1286738Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600736}

* Disable network configuration field if the field is enforced by policy.
* Add policy network indicator if the field is controlled by policy.

Bug: 877424
Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2
Reviewed-on: https://chromium-review.googlesource.com/c/1251447
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600735}

This hasn't been used for a couple years, and ChromeNetworkDelegate and
ContentShellNetworkDelegate are going away, with the advent of the
network service, so it won't be hooked up to the experimental features
command line flag, either.

We may need to add this back to the network service at some point,
but for now, simplest just to remove it.

Bug: None
Change-Id: If7bfffb64aa2407ad8a66cb092e726a50ed34fc0
Reviewed-on: https://chromium-review.googlesource.com/c/1287209Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600734}

Move all stroke bounds related computations into the
CalculateStrokeBoundingBox() method in LayoutSVGShape. Add a new enum
StrokeGeometryClass, and pass that as an argument to the method.
Currently all callsites use a constant argument value. This will be
modified in a future CL.

Split out computation of the bounds for non-scaling-stroke into a new
method CalculateNonScalingStrokeBoundingBox().

Also fold LayoutSVGShape::CalculateObjectBoundingBox() since it only has
a single caller.

Bug: 435097
Change-Id: I538b31f98dc7f0777e2538ef74b5e3553b435a7f
Reviewed-on: https://chromium-review.googlesource.com/c/1276770
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600733}

Bug: 893051
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I39db4b25332a5816aebd2ab3842142060496d06e
Reviewed-on: https://chromium-review.googlesource.com/c/1268018Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600732}

Null Java strings shouldn't be passed down to C++ code. This CL adds
code to check for a null host string or null strings in exclusionList
and throw a null pointer exception.

Bug: 896285
Change-Id: I6af64350de8a93031741c8951a7efe2df7111ccd
Reviewed-on: https://chromium-review.googlesource.com/c/1286849Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600731}

This reverts commit 883e2427.

Reason for revert: Still failing:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53613
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53612

Original change's description:
> Enable ServiceWorkerNavigationPreloadTest.NetworkFallback.
> 
> I suspect the errors were that we were getting no preload request and
> two fallback requests, which seems plausible based on the existing
> comment. Loosen the test expectations accordingly.
> 
> Bug: 896230
> Change-Id: I539b56343d5057975352f74b482b61583174fb13
> Reviewed-on: https://chromium-review.googlesource.com/c/1288330
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600688}

TBR=falken@chromium.org,kinuko@chromium.org

Change-Id: I7f2ac588a506f1c346db8925b4657b67b5c8b654
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896230
Reviewed-on: https://chromium-review.googlesource.com/c/1288593Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600730}

The test is flaky on mac

TBR: brianosman@google.com
Bug: 896205
Change-Id: I43684426c8f90b69d72effd3034cafb20ca80d28
Reviewed-on: https://chromium-review.googlesource.com/c/1288572Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600729}

This CL migrates the BandwidthManagementCollectionViewController to a
UITableViewController base class.
It also creates the SettingsRootViewControlling protocol to allow easier
migration between the CollectionVC and the TableVC in settings.

Bug: 894791, 894837
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7710c43f38a65359743336745afd8510ed8f9591
Reviewed-on: https://chromium-review.googlesource.com/c/1277788
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600728}

GetInputImeEventRouter uses the incognito profile as a common reference
for an incognito profile and its original profile. But when a profile is
destroyed, it deletes the reference based on the profile itself.

This can cause problems when Chrome starts in incognito mode, then a
regular window is opened, and the incognito window is closed. In this
scenario, the InputImeEventRouter is deleted when the incognito profile
is closed, but it is still referenced by the original profile.

To fix this, the original profile is used as the reference for both
modes as it is always destroyed after the incognito one.

Bug: 856135
Change-Id: Ieb4f006e9cc5c36cd9264fd0b1b4ef490e1f3162
Reviewed-on: https://chromium-review.googlesource.com/c/1288350Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600727}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/709540d7b2c2..413a5120b915


Created with:
  gclient setdep -r src-internal@413a5120b915

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia698daae1e449c29ab3b087f7622123ad6e67b67
Reviewed-on: https://chromium-review.googlesource.com/c/1288088Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600726}

Add TemplateURLFetcherFactory for iOS to support downloading and parsing
OSDD(Open Search Description Document) in web pages. This is a prerequisite
for supporting custom search engines.

Bug: 433824
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4ec872f6d9e6541009a3353cb63520ede9fc1470
Reviewed-on: https://chromium-review.googlesource.com/c/1288531Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600725}

The WhitespaceAttacher should just ignore empty text nodes as if they
weren't there in order to consider correct text node siblings for
figuring out which whitespace nodes need a LayoutText.

Bug: 894674
Change-Id: I27a96779678c972093dec6e5f2e19d6a40939065
Reviewed-on: https://chromium-review.googlesource.com/c/1288351
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600724}

This fixes on of the funniest bugs so far: when tapping the empty bar of
the keyboar accessory, a tap sound would be emitted. Tapping multiple
times or sliding would be interpreted as multiple quick taps and emit a
weird buzzing noise.
By suppressing the sound effect, the element is still tappable for
accessibility purposes but the sound isn't audible anymore. This only
affects the empty space in the bar - the key icon or other buttons are
still emitting the tap sound to confirm a successful interaction.

Bug: 895767
Change-Id: I4477417edc99324420f88b7a688afe21eee1e9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1288534Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600723}

Make use of the "promise" function in framework.js to reduce the number
of indents. In addition, some minor refactoring.

Bug: None.
Change-Id: Ifb4202146b7efae2075a93b6b735e8d17cad13a2
Reviewed-on: https://chromium-review.googlesource.com/c/1286456
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600722}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=grt@chromium.org

Bug: 681136
Change-Id: I29dd163da1243fb036c9a828210ce5c3a3a9f444
Reviewed-on: https://chromium-review.googlesource.com/c/1288337Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600721}

Update the documentation of RenderFrame{Created,Deleted}

The comments said it was about the creation/deletion of RenderFrameHost,
but in reality, it is about its RenderFrame. This is different.

Bug: 609963
Change-Id: Id83af9e82e7d544e68759dff2ffcefabb62c3374
Reviewed-on: https://chromium-review.googlesource.com/c/1286143
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600720}

Just confusing to have separate group for core owners.

Change-Id: I8d63d3a47e88c42d00fdaceac9c417ebdb0af711
Reviewed-on: https://chromium-review.googlesource.com/c/1288393Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600719}

According to the comment on DiskCache::ReadData[1], it's not guaranteed
that the completion callback is called when the read request immediately
succeeds. We should use TRACE_EVENT_ASYNC_BEGIN1() macro only after
ERR_IO_PENDING because otherwise async events never finish.

[1] https://cs.chromium.org/chromium/src/net/disk_cache/disk_cache.h?l=301&rcl=93f9ef9762b0c9158dd8acb0ceb52dbd14a308a3

Change-Id: Ie70730b8dfffd0777a68eabd9970216054cdc7ab
Bug: 896604
Reviewed-on: https://chromium-review.googlesource.com/c/1288336
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600718}

This CL creates a TableView item for handling a footer which would
display a link in a TextView.
This is designed as a replacement for CollectionViewFooterItem.

Bug: 894791
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id4b84e5b17920237016314447bed9a25140ab30c
Reviewed-on: https://chromium-review.googlesource.com/c/1286416
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600717}

For custom properties registered with <integer>, it should according to
CSS Values and Units Level 4 be possible to apply non-integral values,
and then have the value round to the nearest integer computed value time.

To do this, this CL ...:

 * Changes the parsing of <integer> values such that non-integral calc()
   expressions are allowed.
 * Recognizes such calc()-expressions computed-value time, resolves them,
   and rounds them to the nearest integer.
 * Wraps values such as CSS.number(1.5) in calc() if necessary, when
   setting such values using Typed OM.

R=futhark@chromium.org

Bug: 641877
Change-Id: I2d4d7c4d72c9b2069f2fe10b1be1b4b94d5900e2
Reviewed-on: https://chromium-review.googlesource.com/c/1280663
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600716}

This is possible now that we have infrastructure that glues an
IdentityTestEnvironment instance to a Profile, and it enables removing
the test's knowledge of SigninManager.

Bug: 896180
Change-Id: I074c0d2886561b264612ce2d34c5ca41b81de3be
Reviewed-on: https://chromium-review.googlesource.com/c/1286810Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600715}

The HiDPI version of the test is flaky on windows bots as well.

TBR: kenrb@chromium.org
Bug: 896609, 882458
Change-Id: Ifc8fdb8f33ce319398566b22737fcfe7f8f3d972
Reviewed-on: https://chromium-review.googlesource.com/c/1288532
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600714}

This is a reland of 9ecd2358 that:
- Updates FakeDriveFs to create a .Trash directory.
- Move files directly instead of delegating to MoveFileLocal.
- Leave (non-recursive) DeleteDirectory unchanged.

Original change's description:
> Turn DriveFS directory deletes into moves into a trash directory.
>
> Change NativeFileUtil to allow moving a directory to an existing
> directory.
>
> Bug: 829696
> Change-Id: I6e233fa2a9ad161d1457d06fc6b6eda3ab3955d7
> Reviewed-on: https://chromium-review.googlesource.com/c/1278624
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Sergei Datsenko <dats@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600283}

Bug: 829696
Change-Id: Ied7836010a00a8f3226b8f65e02568b3f2c2a47d
Reviewed-on: https://chromium-review.googlesource.com/c/1286025
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600713}

https://chromium.googlesource.com/catapult.git/+log/519565187c85..3d878160972c


git log 519565187c85..3d878160972c --date=short --no-merges --format='%ad %ae %s'
2018-10-18 cbruni@chromium.org [telemetry] Support unicode keys in KeyPressAction
2018-10-18 bpastene@chromium.org devil: Exit w/ a non-zero code when unlock_bootloader.py fails.
2018-10-17 nharper@chromium.org netlog_viewer: match QUIC sessions table rows with headers
2018-10-17 mlippautz@chromium.org V8 GC metrics: Add GC cycle time
2018-10-17 nharper@chromium.org Fix path for serving netlog_viewer locally in README.md


Created with:
  gclient setdep -r src/third_party/catapult@3d878160972c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:878390,chromium:843903
TBR=sullivan@chromium.org

Change-Id: Iaa3306106064794f6b10421d28eaddff58126f5c
Reviewed-on: https://chromium-review.googlesource.com/c/1288024Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600712}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I2efd3b383325c3df5996fd9dda2e7ab5da01c5aa
Reviewed-on: https://chromium-review.googlesource.com/c/1288517Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600711}

Bug: 806868
Change-Id: I3948803d43dfd91ccec1e6fe0fa57b4d197de1e6
Reviewed-on: https://chromium-review.googlesource.com/c/1286148
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600710}

Video: https://drive.google.com/open?id=16GEAtsIQLbSjYlrIC3a1hby8gVxjgYAz

Bug: 891299
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8601ac0eb934e42dbe6ca6389b91ed35d3228964
Reviewed-on: https://chromium-review.googlesource.com/c/1264383
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600709}

This reverts commit 2018a9ef.

Reason for revert: Reverting as this was fixed on the V8 side and this restores a consistent state where  all callbacks assume non-null ThreadState.

Original change's description:
> bindings: Fix second pass callbacks fired during teardown sequence
> 
> Work around the problem where second pass callbacks are fired during
> teardown.
> 
> Previously, these callbacks where just dropped which is not correct for
> other reason, e.g., when components keep a state per process and not
> just per Isolate.
> 
> Bug: chromium:890631
> Change-Id: I1fd66f9ffee86c5c7bff053303c741c4dedefdb0
> Reviewed-on: https://chromium-review.googlesource.com/c/1253782
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597525}

TBR=haraken@chromium.org,mlippautz@chromium.org,clemensh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:890631
Change-Id: I8d6f55fe926093ba776d182d9c154ee0b6538ed1
Reviewed-on: https://chromium-review.googlesource.com/c/1288270Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600708}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286016

This CL was uploaded by git cl split.

R=haraken@chromium.org

Bug: 753973
Change-Id: Ife13d645bede991ae8959759be878ed5bdf3733e
Reviewed-on: https://chromium-review.googlesource.com/c/1288156Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600707}

This CL adds a class to ease testing of subclasses of
ChromeTableViewController, in the same way CollectionViewControllerTest
is easing the testing of subclasses of CollectionViewController.

Bug: 894791
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I159849612b16d5475d581c79601f93de04e6b705
Reviewed-on: https://chromium-review.googlesource.com/c/1283025
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600706}

In some circumstances, ProfileSyncService wants to fully reset
SyncServiceCrypto's state. Currently, it destroys and recreated the
whole object. That works, but it's problematic if we want to pass
pointers to the SyncServiceCrypto object elsewhere.
Instead, this CL adds a Reset() method to SyncServiceCrypto. For
convenient implementation, and to make sure *everything* gets reset,
all the mutable state gets wrapped into a new struct.

Bug: 884159
Change-Id: Ia2590301a6236461e4df20d7f83fee5599e5483c
Reviewed-on: https://chromium-review.googlesource.com/c/1286424
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600705}