GitLab

R=oysteine@chromium.org

Bug: 867931
Change-Id: I257c7b6e6220e9e00eecf3ab14b4cb6e19d55a1b
Reviewed-on: https://chromium-review.googlesource.com/1162635Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580654}

Test: compiles
Bug: none
Change-Id: I7651e96e727110205740e0884550d559f9078abd
Reviewed-on: https://chromium-review.googlesource.com/1162582Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580653}

Adds checks before modifying whether or not a tab uses extra padding to
ensure that padding doesn't get changed while the tab is closing.
Without these checks, tab titles would suddenly jump several pixels to
the left near the end of the tab's closing animation.

Found while reproducing/fixing
Bug: 859321

Change-Id: Id7db4b160530535af520cdfaf99202aa863a019a
Reviewed-on: https://chromium-review.googlesource.com/1162359
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580652}

https://chromium.googlesource.com/catapult.git/+log/27928c385ec6..d30f10814bd0


git log 27928c385ec6..d30f10814bd0 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 bsheedy@chromium.org Fix ReplaceSystemApp not granting permissions
2018-08-03 wangge@google.com Long Term Health Tool File Reorganization


Created with:
  gclient setdep -r src/third_party/catapult@d30f10814bd0

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:870782,chromium:863390
TBR=sullivan@chromium.org

Change-Id: I61cecf50cbb85a042494bab6182d719c6cb8b714
Reviewed-on: https://chromium-review.googlesource.com/1162387Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580651}

apparently nothing breaks

Bug: 649199
Change-Id: I728637ba8b7ffea50191014f07d9581d08eb33ed
Reviewed-on: https://chromium-review.googlesource.com/1162431Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580650}

Remove the AutoplayMutedVideos feature which is set based on
the autoplay policy command line switch. This means it
ignores if we have overridden the autoplay policy for the
document.

Instead we should perform this check in AutoplayPolicy
which will have the final autoplay policy for the
document.

BUG=865548

Change-Id: Iddfb9d0b3fef3bfa6efc493876094eaf2f8f7799
Reviewed-on: https://chromium-review.googlesource.com/1157215Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580649}

This CL delays startup sound playback until default sound output device
has known type.

Bug: 848485
Change-Id: I911e37afd34d28f142c46ef63b7b6345988d159b
Reviewed-on: https://chromium-review.googlesource.com/1160143Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580648}

Convert it to "new" (2012) NeworkChangeObserver.

Bug: 754695
Change-Id: Ifc63ddff076da40fd1a18d052b73f03e778cbd56
Reviewed-on: https://chromium-review.googlesource.com/1161966Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580647}

inspector_network_agent.cc:
This is a behavior change, there are a fair number of fields here.
E.g., previously, the extra headers would be preserved between
disable() and enable(), now they're cleared out.

inspector_page_agent.cc:
Similarly, this is a behavior change.
E.g., previously, setFontFamilies and setFontSizes settings would
be preserved between disable() and enable(), now it's cleared out.

Bug: 851762
Change-Id: I923a2d49ec92f395c5954116e115686517994a0f
Reviewed-on: https://chromium-review.googlesource.com/1161175Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580646}

R=pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe0b3837e5ffd0919d8162a46c48bb550f9e4780
Reviewed-on: https://chromium-review.googlesource.com/1162586Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580645}

This is a refactoring except for
kVirtualTimeTaskStarvationCount. Previously, the code
called state_->setDouble(...VirtualTimeTaskStarvationCount, ...);
but then read it as an int, so it basically wouldn't get saved.
Now it's always an int.

Bug: 851762
Change-Id: I288274ddddc44c910d89ef1fb8c1a6eacd54d8c5
Reviewed-on: https://chromium-review.googlesource.com/1161329
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580644}

Before:
https://drive.google.com/open?id=1HZzgWAeGjTOREQzj-uBROCDvS-kBMwJL
After:
https://drive.google.com/open?id=1WTN_Bhjdwrhz1kMZAQDSbKTmc0YhZrb6

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5b3d162b495a22d55cce42fd643a4c9d982e8c87
Reviewed-on: https://chromium-review.googlesource.com/1162158Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580643}

Delete unused SuggsetionsMetrics methods and mark corresponding
user actions as obsolete.

BUG=

Change-Id: I2c9d43d517ed03162dbe5fa051639a0cc342846a
Reviewed-on: https://chromium-review.googlesource.com/1162316Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580642}

Don't record a histogram entry for NewTabPage.ActionAndroid2 or the
Suggestions.Card.Tapped user action when a contextual suggestion
is clicked.

BUG=870424

Change-Id: I7d10c1b00628c83f4dbde2a4353707a483722656
Reviewed-on: https://chromium-review.googlesource.com/1162319Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580641}

Fixing this build fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/475

Bug: 855186
Change-Id: I49b743e6d699e47768ff8d47ea2ac63dcb1ee49f
Reviewed-on: https://chromium-review.googlesource.com/1150445
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580640}

This reverts commit df2048be.

Reason for revert: Causing gclient sync failures https://crbug.com/870845

Original change's description:
> android: build: Use .pydeps file to store Python dependencies.
> 
> ProTip: start by looking at the pythonic_action() definition
> in internal_rules.gni to review changes in this CL.
> 
> This CL tries to make "gn analyze" smarter by ensuring that
> it knows about Python module dependencies, for any python
> script under //build.
> 
> At the moment, these dependencies are computed by
> build_utils.WriteDepFile() automatically (unless the
> add_pydeps=False argument is passed). This adds all imported
> module paths to the generated .d file written by the script.
> 
> Unfortunately, because this .d file is generated by the
> actions, the corresponding Python sources are not part of
> the target's inputs, known by GN at parse time, and thus do
> not appear in "gn analyze" properly.
> 
> This CL tries to solve the problem by adding a new template
> named "action_with_pydeps", which acts as "action", but also
> expects a foo.pydeps file for every foo.py invoked through
> the 'script' scope variable.
> 
> This '.pydeps' file is read directly at GN parse time and
> added to the action's target inputs.
> 
> These .pydeps contain the path of each imported module, one
> per line, and are generated with build/print_python_deps.py
> 
> Benchmarking shows no significant difference in the time
> taken to perform a "gn gen out/Release" on a full Chrome
> for Android checkout.
> 
> + Add --inplace option to print_python_deps.py in order to
>   make its usage more human-friendly (the new mode cannot
>   become the default because PRESUBMIT.py depends on the
>   current behaviour).
> 
> + Remove some --depfile options on a few Python scripts that
>   don't need it anymore (e.g. when their inputs and outputs
>   are now fully known by GN at parse time).
> 
> + Remove uses of compute_inputs_for_analyze in rules.gni and
>   internal_rules.gni (as well as exec_script() calls to
>   print_python_deps.py). Note that the variable itself is still
>   needed for grit inputs, see tools/grit/grit_rule.gni for
>   details).
> 
> BUG=NONE
> R=​agrieve@chromium.org
> 
> Change-Id: I8d7c07ab93b032fdc0c7f9dbeb2173767f52eeff
> Reviewed-on: https://chromium-review.googlesource.com/1131190
> Commit-Queue: David Turner <digit@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580545}

TBR=digit@chromium.org,agrieve@chromium.org,estevenson@chromium.org

Change-Id: I626eb8997c8808fc91aec9115287be34d17d493e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: NONE
Reviewed-on: https://chromium-review.googlesource.com/1162522Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580639}

Bug: b/111886441
Test: Successfully cast DRM content to an Android device with CMA audio
enabled.

Change-Id: Ica7ef53f25a5ff305a7726cebe4fca511a43502d
Reviewed-on: https://chromium-review.googlesource.com/1152464Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Melisa Carranza Zúñiga <melisacz@google.com>
Cr-Commit-Position: refs/heads/master@{#580638}

ui::CreateInputMethod is called implicitly within the Setup of
AshTestBase (somewhere within ash::Shell::Init()), which conflicts
with ui::SetUpInputMethodFactoryForTesting(). So the CHECK fails
if TextInputTest runs along with other tests in exo (i.e. without
gtest_filter flags).

Actually SetUpInputMethodFactoryForTesting can be called for
every tests in exo, so that is moved there.

BUG=870690
TEST=exo_unittests succeed without --gtest_filter flag

Change-Id: I9e9bb009b7b5af3715759ee29ac6c94f9614eecf
Reviewed-on: https://chromium-review.googlesource.com/1162621Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580637}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

Looking at this code, I don't think we can escape the SERIAL_EXECUTOR
here, since there appears to be non-thread-safe things happening in the
AsyncTasks, and no guarantee they won't get scheduled at the same time.

Bug: 869907
Change-Id: I7c1e1a74e48c2d2e774d71e04d89a83c02562e5b
Reviewed-on: https://chromium-review.googlesource.com/1162662Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580636}

This reverts commit 3b42f46a.

Reason for revert: Crashing internal bots

Test Case '-[GoogleServicesSettingsTestCase testOpeningServicesWhileSignedInAndConsentGiven]' started.
0803/040411.392060:FATAL:unified_consent_service.cc(155)] Check failed: identity_manager_->HasPrimaryAccount().
0   ios_chrome_unified_consent_egtests  0x000000010d19df38 base::debug::StackTrace::StackTrace(unsigned long) + 72
1   ios_chrome_unified_consent_egtests  0x000000010d19df9d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_unified_consent_egtests  0x000000010ce8adac base::debug::StackTrace::StackTrace() + 28
3   ios_chrome_unified_consent_egtests  0x000000010ced068b logging::LogMessage::~LogMessage() + 315
4   ios_chrome_unified_consent_egtests  0x000000010cecf495 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_unified_consent_egtests  0x000000011054785e unified_consent::UnifiedConsentService::OnUnifiedConsentGivenPrefChanged() + 638

Original change's description:
> [iOS] Start unified consent service at startup
> 
> Bug: 827072
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49
> Reviewed-on: https://chromium-review.googlesource.com/1159062
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580485}

TBR=msarda@chromium.org,sdefresne@chromium.org,jlebel@chromium.org

Change-Id: I4d94ba1e7630c81f666d336882c17c993ac5ef02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1162402Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580635}

This CL adds TRACE_EVENT0() to some important CanvasResourceDispatcher
methods: DispatchFrame{Sync}() and PrepareFrame(), which are now used
more frequently, for lowLatency cases.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I66dfd2f47eaba0183d34c5e1f09f759d6f0fcf1b
Reviewed-on: https://chromium-review.googlesource.com/1161974Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580634}

Change-Id: I8998c03e69247f53bc183bac631b891eada88784
Reviewed-on: https://chromium-review.googlesource.com/1162623Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580633}

Per the spec, the query view should remain at the bottom of the UI
container until the response is received. To accomplish this, this CL:

- Adds active_query_view_ pointer.

The lifetime of a query view is now:
- pending_query_view_: created when query is pended.
- committed_query_view_: pointer swapped when query is committed.
- active_query_view_: pointer swapped when query response is received.

A committed query that is aborted will not reach the "active" state
when the motion spec is enabled.

To prevent regression of current UI behavior, when the motion spec is
disabled we immediately "activate" a query when it is committed.

See bug for spec/demos.

Bug: b:112114187
Change-Id: Icea7ebccc9f0a5aa554c88d969fa79000855b9db
Reviewed-on: https://chromium-review.googlesource.com/1159826
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580632}

This CL adds GridLayout.animatesItemUpdates, which can be used to
disable animations from occurring when items are inserted or removed.
This is done to prevent the interleving of the new tab insertion
animation and the tab presentation animation.

Bug: 864982
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7867fc475a6d399a8ecbe45df456fd6082f6d8eb
Reviewed-on: https://chromium-review.googlesource.com/1161560Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580631}

This reverts commit 2e803140.

Reason for revert: speculative revert, seems to have introduced the following failure: https://bugs.chromium.org/p/chromium/issues/detail?id=870827
Original change's description:
> chromeos: splits ash's file list into public/sources sections
> 
> I'm putting all the '.h' files into public. We can refine the list as necessary
> later.
> 
> I'm doing this as I would like to have private headers that other targets can't
> include (well, except tests).
> 
> BUG=none
> TEST=none
> 
> Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85
> Reviewed-on: https://chromium-review.googlesource.com/1161498
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580581}

TBR=jamescook@chromium.org,sky@chromium.org

Change-Id: Icfed283e1b854f9639fe111fbd83b948b8d6147f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1162207Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580630}

Extend resource fetch priority experiment to support being enabled
only in the loading use case.

Bug: 870349
Change-Id: I980f078f3a48bc7ab240e475869125d6dc9ffa55
Reviewed-on: https://chromium-review.googlesource.com/1159064Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580629}

Fix resize observer crash in PiP interstitial when
we detach, re-attach and detach the video element.

BUG=870449

Change-Id: I6989587384cf34c5b6da8cbaec3ab8ca48b58f94
Reviewed-on: https://chromium-review.googlesource.com/1162514Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580628}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/51da39f993c8..fb6f97363738


git log 51da39f993c8..fb6f97363738 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 athilenius@google.com Move betty-inremental from baremetal to GCE


Created with:
  gclient setdep -r src/third_party/chromite@fb6f97363738

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I335c7bd1d8f34d162f090a59117949b17a3c6e0b
Reviewed-on: https://chromium-review.googlesource.com/1162383Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580627}

The WM_SIZING message is now handled by HWNDMessageHandler. When the
aspect ratio is set for a window on Windows OS, the handler will adjust
the final RECT bounds to adhere to the given aspect ratio.

Bug: 853276
Change-Id: I54099581012d3f59e3d0535ed1285a25bb512cd9
Reviewed-on: https://chromium-review.googlesource.com/1136226
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580626}

Launch bug: 863984

Bug: 865140
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I021aa78fd002dc74a8c9965afce1906bdff7acdb
Reviewed-on: https://chromium-review.googlesource.com/1161217
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580625}

Modify ownership model of |int64_t* start| in
PartialData::ShouldValidateCache() and
PartialData::GetAvailableRangeCompleted().  Previously ownership was
passed into a callback, which outlived the GetAvailableRange() call.
However, when using a CompletionOnceCallback, that is destroyed as soon
as GetAvailableRange() returns asynchronously, so a different ownership
model is needed for |start| to provide the same lifetime guarantee.

Bug: 807724
Change-Id: Ibd4bae1be23d6570618d2abdb93e398cd97c35e6
Reviewed-on: https://chromium-review.googlesource.com/1161963Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580624}

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1156566 with fixes in the fake test class for Mac debug flake in 2 tests.

TBR=nasko

Bug: 800212
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If3e60cba6c6d501855b0197d891aea4c769a4361
Reviewed-on: https://chromium-review.googlesource.com/1162263
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580623}

[TaskScheduler] Forward all public TaskScheduler headers to forwarding headers in preparation for source move

Core move CL : https://chromium-review.googlesource.com/c/chromium/src/+/1161088

Move strategy :
 1) Rebase this CL on ToT and mass migrate all callers of public base/task_scheduler
    headers to their matching *_forward.h header.
 2) Land core move CL
 3) Mass migrate away from *_forward.h headers in
    https://chromium-review.googlesource.com/c/chromium/src/+/1161116

This move strategy was chosen to keep as much git history as possible
in (2). See code comments on forward headers for details.

Once this CL and its follow-ups are approved, I will sync it to
top-of-tree, mass migrate all existing users of these headers to
their *_forward.h version in this CL (TBR'ed) and follow-up with
the other two swiftly back-to-back.

TBR=robliao@chromium.org (for mass migration of existing callers)

Bug: 867421
Change-Id: Iea684e022181c0611abe7f92629599afc369822b
Reviewed-on: https://chromium-review.googlesource.com/1161179
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580622}

Since it's been a week after refreshing pathological_mobile_sites,
remove the old pages.

Bug: 852530
Change-Id: I75096a10510f8d9bec5838deeb6dcd00e0c55fc0
Reviewed-on: https://chromium-review.googlesource.com/1162344Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Amy Qiu <amyqiu@google.com>
Cr-Commit-Position: refs/heads/master@{#580621}

The EME spec requires the order of some events. For example, after
update() [1], we should "run the Update Expiration algorithm on the
session, providing expiration time", then "resolve promise with true".
The former is part of the ContentDecryptionModuleClient interface,
while the latter is a callback on the ContentDecryptionModule interface.
To preserve the order, this CL uses associated interface [2] to ensure
message ordering.

[1] https://w3c.github.io/encrypted-media/#dom-mediakeysession-update
[2] //src/mojo/public/cpp/bindings/README.md#Associated-Interfaces

Bug: 869550
Test: CDM_10/ECKEncryptedMediaTest.MessageTypeTest/0 working, see Bug
Change-Id: I1afd1657581f83347235357fb26972a6ba657f1c
Reviewed-on: https://chromium-review.googlesource.com/1162309Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580620}

The gl renderer for all chromium tests was recently changed from OSMesa
to SwiftShader. OSMesa offers a synchronous API to OpenGL, while
SwiftShader is asynchronous (draw calls are received and yield before
the drawing operation is complete, letting chromium resume its execution).

Because of this it seems like the affected MacOS tests here can become
idle while rendering is happening in the background, causing the tests to
fail. To solve this, we need to actually wait for drawing to be completed,
rather than waiting for an idle period, in order to resume the test. Doing
this allows these tests to pass.

R=ccameron@chromium.org

Bug: chromium:870465
Change-Id: I6f1555b93a83d80b06e72b3a469c01dde44e1312
Reviewed-on: https://chromium-review.googlesource.com/1162350
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580619}

Bug: None
Test: Manual Test
Change-Id: Ia0ab2867db8b047049534632d4ffdbc6e618ce56
Reviewed-on: https://chromium-review.googlesource.com/1162508Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580618}

ApplicationCommands conforms to BrowsingDataCommands, but we need to explicitly dispatch them still.

Change-Id: I02dbf849677c7391a6a123917f7773d2330be003
Reviewed-on: https://chromium-review.googlesource.com/1162279Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580617}

test_process.exe was being linked with /SUBSYSTEM:CONSOLE, despite being
a windowed app with a wWinMain entry point. With lld-link.exe this seems
to work fine, suggesting that lld ignores the/SUBSYSTEM flag. lld-link
may change this behavior (https://bugs.llvm.org/show_bug.cgi?id=38397)
so it seems worthwhile to fix the build flags for this executable. Doing
so will also be less confusing.

Bug: 869503
Change-Id: I52a61aab678fa135f3da8c10bc82a4cdf649b5ae
Reviewed-on: https://chromium-review.googlesource.com/1157656
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580616}

This provides a consistent alignment point for theme authors, makes some themes
(e.g. Dots) look correct (other themes want other values, e.g. 0, so there's no
one "right way" here), and prevents mirroring above the top of the frame image
in Refresh, since no mode has a frame height above the tabs > 16 DIP.

Bug: 866671
Change-Id: I1d79627e2735d54a332013ee70a2c71f107a898f
Reviewed-on: https://chromium-review.googlesource.com/1157878
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580615}