GitLab

 - Changing button and separator height to 32px.
 - Changing separator margin to 16px.
 - Removing obsolete logic to use a negative margin for non primary buttons.
   It is obsolete since both types of buttons now have a border and they can
   use the same amount of margin.

Bug: 841858,832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1b3bf0d5a7f6b4e81bc5e25a16b422a54487214b
Reviewed-on: https://chromium-review.googlesource.com/1054552Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558075}

Adding new classes to be used by the C++ code.
These classes will be serialized into the proto messages

Bug: 803135
Change-Id: Ib0cae24a8d0cc7ff8fee5a14d6c80070b092b8ff
Reviewed-on: https://chromium-review.googlesource.com/1050797
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558074}

We have a crash being reported in UrlBar that's caused by an
IndexOutOfBoundsException being thrown while trying to change the selection as
the result of a touch event. It is not immediately apparent how to reproduce the
crash, but I'm fairly confident we can prevent it without much consequence by
swallowing the exception.

Bug: 837419
Change-Id: Ie059e72ad2aea02446a801f0ab5e013ab0203bf4
Reviewed-on: https://chromium-review.googlesource.com/1053227Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558073}

Change-Id: I187c5cb0d8271c695234bd4a8fb724be7aa02c35
Reviewed-on: https://chromium-review.googlesource.com/1055848Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558072}

ChunkedDataPipeUploadDataStream was incorrectly failing requests when
the size was received before the stream was initialized.

Bug: 810555
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If5e163644be5a4d27e8e7a3f4d2539e4b445ded1
Reviewed-on: https://chromium-review.googlesource.com/1055752
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558071}

Previously, it returned a static value, but this didn't make sense since
each request should have its own ID.

Bug: 824568, 752273
Change-Id: I34fa7f33efc6abf92f459aff712b0caab7258426
Reviewed-on: https://chromium-review.googlesource.com/1056354
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558070}

Bug: 842099
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic52a5afc94ab2de1e5745df995441b1c5e6f152b
Reviewed-on: https://chromium-review.googlesource.com/1055815Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558069}

Previously, we only notified NotifyFaviconsChanged when an existing icon
was modified, not on initial creation.

The FaviconCache in the Omnibox component caches null results from the
FaviconService, so we want to be notified when a new favicon is
downloaded. This supports the Chrome Material Refresh work.

There are only two users of this API so far, the Bookmarks, and Sync.

For bookmarks, notifying when a new icon is downloaded should be
harmless. Bookmarks should already have a favicon in the database, so
it generally shouldn't happen. Even if it does happen, it would cause
some "extra work" to occur as the bookmark icon is updated - nothing
catastrophic, and potentially beneficial (maybe we should have been
doing this work on favicon creation anyways).

The Sync observer ignores icon_url updates already.

Bug: 88243, 823535
Change-Id: Ia233f1dfa83d7e748c43b4f0117f56b14424a1a8
Reviewed-on: https://chromium-review.googlesource.com/1054568Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558068}

- Updates the policy in the agent cookie when it is changed in the scheduler.
- Disarm the wait_for_navigation after the navigation.
- While restoring the virtual time settings, respects the policy.

Part of the "A BeginFrame is already in flight" flaky test fix.

Change-Id: I930cff2b2f187708be3a1b3ba0ca5d77944686b4
Reviewed-on: https://chromium-review.googlesource.com/1054152
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558067}

Bug: 798569
Test: Manual build and test
Change-Id: I8050699311b1cb5c19859178ee5dcedebfa2538f
Reviewed-on: https://chromium-review.googlesource.com/1054700
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558066}

Using wpt-import in Chromium c508903e.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17321

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I626405df73d483ee16672ba52bf0ae00d5a09246
Reviewed-on: https://chromium-review.googlesource.com/1056107
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558065}

BUG=793908,793913,793944

Change-Id: I0d1828f8dba43140ad5c8b54eb6e33b84b9d8f50
Reviewed-on: https://chromium-review.googlesource.com/1054703Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558064}

Improve the base::Bind* and base::Callback usage by adapting
Once/Repeating callbacks in RequestCoordinator and Offliner related
code.

Bug: 841474
Change-Id: I95b14867b4ba3b666188b48ad94749f21c7720d1
Reviewed-on: https://chromium-review.googlesource.com/1053527
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558063}

https://pdfium.googlesource.com/pdfium.git/+log/ce7a8158376d..626a093f5fde

$ git log ce7a81583..626a093f5 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 hnakashima Rename last CFWL_ComboBox::DisForm* methods.
2018-05-11 hnakashima Remove more dead code from CFWL_ComboBox.
2018-05-11 hnakashima Remove CFWL_Widget::SetFocus(). It is non-op.
2018-05-11 hnakashima Inline or renamed more CFWL_ComboBox::DisForm methods.
2018-05-11 hnakashima Remove CFWL_ComboBoxProxy.
2018-05-11 hnakashima Reland "Filter out "Type" and "DecodeParms" from trailer keys."
2018-05-11 hnakashima Inline Disform_* methods.
2018-05-11 hnakashima Revert "Filter out "Type" and "DecodeParms" from trailer keys."

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3dcfea79eb76675d62f215e739a5474a3f434717
Reviewed-on: https://chromium-review.googlesource.com/1056211
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558062}

Adds the mojom declaration and its corresponding audio::StreamFactory
implementation, allowing clients of the Audio Service to create loopback
streams. Loopback streams are virtualized audio input streams. They
collect the audio from one or more audio output streams, and mix it
together into a single input stream. An example use case is tab capture.

Bug: 824019
Change-Id: I10256b516f7e19f6e312aec7fd33dc737df095fa
Reviewed-on: https://chromium-review.googlesource.com/1041662
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558061}

Currently we have two versions of MojoRendererService::Create() which
are very similar. This CL merges them to avoid confusion.

Bug: 586211
Change-Id: I82a6d14b7723f7f4280905f4842aa6e69a02c863
Reviewed-on: https://chromium-review.googlesource.com/1056128Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558060}

NOTRY=true  # test by PRESUBMIT
TBR=eyaich@chromium.org

Bug: 841492
Change-Id: I1b8bf1c05ea18f86ddbf676c24eeac6637a97348
Reviewed-on: https://chromium-review.googlesource.com/1056299Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#558059}

Add the ability to set a closure which is run when the object is
deleted.

Bug: 824568, 752273
Change-Id: I54b205e363d0302292647e47643dd07cbf8ce7e9
Reviewed-on: https://chromium-review.googlesource.com/1056225Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558058}

GetAssociatedWebContents has been used in echoPrivate.getUserConsent
to determine to which window to attach the user consent dialog.
The API function is used from a component echo extension's event page,
and was relying on GetAssociatedWebContents to select the active tab as
the target for the dialog (note that this was not always the right
tab/window to use).

To address this issue, the echoPrivate.getUserConsent has been updated
to accept tabId, which identifies the tab to use for the user constent
dialog, and the extension was updated to pass the target tabId in. It
should now be OK to stop depending on GetAssociatedWebContentsDeprecated
to select the target tab.

Calls from extension contexts will now require the tabId to be
specified. The only circumstance the tabId can be omitted is when the
function is called from a platform app window (in which the sender web
contents will point to the desired target for the user consent dialog).

BUG=461394

Change-Id: I49c9dd5a8ffd9543bb441bc694dbc929ac8c2782
Reviewed-on: https://chromium-review.googlesource.com/1054489
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558057}

For now, packet info only includes the packet number, but passing a struct makes
it easier to extend this functionality in the future.

Quartc obtains the packet number from QuicConnection::packet_generator(), which
exposes a packet_number() accessor.  This is set to the current packet number
during calls to write packets.

For context, the packet number will be used to join QUIC's debug events (in
particular, QuicConnectionDebugVisitor::OnPacketSent) with similar debug events
from the underlying ICE transport stack, in order to implement
go/quartc-packet-notifications.

Merge internal change: 194326896

Change-Id: I65bc1c7bdc424a15dbcb92d4d3e04dda2f3715e5
Reviewed-on: https://chromium-review.googlesource.com/1055877Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558056}

This reverts commit a25e3672.

Reason for revert: broke Windows tests using ANGLE's GL back-end.
Breaks the CQ for graphics-related tests, and ANGLE's CQ.

example builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1063
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20dEQP%20Release%20%28NVIDIA%29/3528

Original change's description:
> Reland "win: Link with lld instead of link.exe by default"
> 
> The nacl browser_test failures on Win7 that caused the last revert are fixed.
> There's a known bug about this regressing binary size (crbug.com/838449),
> but with in-progress patches binary size will soon be 200 kB smaller and
> these should all be rolled in by branch point, so let's reland this to find
> more unknown unknowns.
> 
> Original change's description:
> > win: Link with lld instead of MSVC's link.exe by default
> >
> > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > link.exe, but it's significantly faster and it can also handle LLVM's
> > internal representation, which will enable us to do link-time
> > optimization and control-flow integraty checks with Clang.
> >
> > While lld is much faster at linking, it doesn't support incremental
> > links, meaning builds that only touch a few files and re-link a large
> > executable may become slower.
> >
> > This is the first attempt at switching everything over, with the
> > purpose of gathering data and finding unknown unknowns. It's likely
> > temporary until something breaks.
> >
> > is_win_fastlink is implicitly ignored when using lld, as lld without
> > fastlink is faster than link.exe with it.
> >
> > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > link.exe to make sure that configuration keeps working.
> >
> > Bug: 792131
> 
> Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db
> Reviewed-on: https://chromium-review.googlesource.com/1054521
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557987}

TBR=thakis@chromium.org,rnk@chromium.org

Change-Id: Ida516adc6708c59407b817c8425c14bd3153d5b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1056327Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558055}

content_shell was trying to create log file in DIR_EXE. This doesn work
on platforms where the directory is not writable, particularly on
Fuchsia. Updated content_shell to use DIR_TEMP on Fuchsia.

Bug: 778467
Change-Id: I03198062e0c067340479209c99056a4e0b460ea4
Reviewed-on: https://chromium-review.googlesource.com/1054785
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558054}

This introduces a wrapper for SignatureVerifier when the public key
comes from a certificate.

Bug: 795086, 803774
Change-Id: I177e4a2b3ea1b94afbac914c051be9f2b8b67985
Reviewed-on: https://chromium-review.googlesource.com/924349
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558053}

This removes the WebLayerImpl subclass, pushing all the implementation
into the base WebLayer class. Then blink can instantiate it directly
since it lives in blink/public/platform/ so we don't need to go through
WebCompositorSupport anymore. Thus we remove that as well, leaving
cc/blink empty and we can remove the directory and all reference to it
in DEPS and BUILD files.

This makes it easier to reshape WebLayer to be the same as cc::Layer
so that we may type-alias it along the path to removing WebLayer.

R=chrishtr@chromium.org
TBR=jam

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77744e2672f239d3d2c14a274e2de4cb658b8f48
Reviewed-on: https://chromium-review.googlesource.com/1055804Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558052}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59e400635dcd..eb85cead4784

$ git log 59e400635..eb85cead4 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I43c29d911a065af6922a4e47eec8d3166c42310e
Reviewed-on: https://chromium-review.googlesource.com/1056127Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558051}

Bug: 824568, 752273
Change-Id: Ie4aac00d5b077c3d1af3114e73447dd52065da75
Reviewed-on: https://chromium-review.googlesource.com/1056213Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558050}

Now that <foreignObject> gets a PaintLayer, hit testing no longer works correctly
in the presence of a non-rectangular SVG clip path. This is because SVG children elements
which are not <foreignObject> cannot have a PaintLayer, and PaintLayer is the only way
hit testing currently knows how to account for clip-path.

Fix this for "simple" clip-paths by adding a method to perform hit test clipping
on the clip paint property tree. It works by checking all clips and clip-paths
stored on the clip paint property tree between the local and ancestor points
(in this use-case the ancestor is the containing PaintLayer), applying transforms
as necessary.

Non-"simple" clip paths (defined as SVG clip paths which have more than 42 edges
or having text) are not fixed by this CL. The former condition could be handled in the
future by adding a ClipPathForHitTesting to ClipPaintPropertyNode which stores the
clip-path beyond 42 edges.

Bug:833076

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iabbce97d412fe38a4b775739517d28628ef67964
Reviewed-on: https://chromium-review.googlesource.com/1055788
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558049}

Change-Id: I5d69a8eb4a09f10a0127a445c971419dd7a79ea4
Reviewed-on: https://chromium-review.googlesource.com/1054384Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558048}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43ae3f6d..65c09667

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I71107fa42202edfbded30a34a5a52f8699b96af0
Reviewed-on: https://chromium-review.googlesource.com/1055750Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558047}

[Chromecast] If enableTouchInput() is called before CastWebContents is started, set enabled in delegate

Bug: internal b/77303649
Test: none
Change-Id: Ied34147646151de7b44e0b4ff5960e616ff422d9
Reviewed-on: https://chromium-review.googlesource.com/1043276
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558046}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I86ad1383c8531e7f1272aa22d4d1e7374ae18ab3
Reviewed-on: https://chromium-review.googlesource.com/1053186Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558045}

This histogram is not being used and is not fully functional.

This CL was split from crrev.com/c/1055738, and removes UseHistory
from StreamSocket and TCPClientSocket.

Follow-ups will remove HttpRequestInfo::RequestMotivation and
Two StreamSocket methods that are no effectively no-ops.

Bug: 629382,842337
Change-Id: Ieff43ffe0a1ede69a517217bcd9f3af15e57e8c1
Reviewed-on: https://chromium-review.googlesource.com/1055761
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558044}

Works for Windows users only, at the moment.
Next: Make it work for Chrome OS users.

Bug: 796332
Change-Id: I1a14597851aaa239b15620c1f0444357176345a1
Reviewed-on: https://chromium-review.googlesource.com/1055940Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558043}

Only fetch(request, {keepalive: true}) is allowed as it is
guaranteed to be delivered even if the renderer gets discarded.

Bug: chromium:838684
Change-Id: I2966a7f9365ff8ab97a4a8cfc20b8df8c3e96561
Reviewed-on: https://chromium-review.googlesource.com/1038343Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558042}

Bug: 813232
Change-Id: Ibdddfa25e97f0c5fbf5e737305d16f6dcd70ecd0
Reviewed-on: https://chromium-review.googlesource.com/1055801Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558041}

[MessageLoopForIO] Rename variables after standardizing MessagePumpForIO::FdWatchController class name.

Missed those in associated migration.

Alleviates reading confusion I experienced while reviewing
https://chromium-review.googlesource.com/c/chromium/src/+/695914

R=fdoray@chromium.org, scottmg@chromium.org

Bug: 825327
Change-Id: I2f9befb037d7931ef4471da660c3f9eeb91e8ecd
Reviewed-on: https://chromium-review.googlesource.com/1054414Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558040}

changes:
In crrev.com/c/930661, chrome changes the bounds locally which is backed
by ClientControlledShellSurface without requesting Android for bounds
change. This could lead to widget size inconsistent state.

Bug: 831035
Test: test coverage
Change-Id: I2d3c0fbc6b39f9637ac55d7f0292c2cc8a08c78e
Reviewed-on: https://chromium-review.googlesource.com/1010906
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558039}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia1da47333ae15edb2cbeda1b0b7d0db9f30606a9
Reviewed-on: https://chromium-review.googlesource.com/1055654Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558038}

No expected change to behavior, but this should have a slight
performance boost to the support library.

Previously, for each method call on a boundary interface, we would
iterate over method parameter types and convert each type to the
corresponding type visible by delegateLoader. This work is redundant,
because we only ever pass pre-L frameworks types (e.g., WebView, String,
InvocationHandler) and primitives.

This work would not be redundant if we passed BoundaryInterfaces as
parameters to some BoundaryInterface methods, however we don't ever
intend to do so.

Bug: 837820
Test: ./gradlew :webkit:connectedAndroidTest
Change-Id: Icd3bfc620a45f9acd437da514ae5a02b3d8a6b02
Reviewed-on: https://chromium-review.googlesource.com/1054122Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558037}

This histogram is not defined in histograms.xml and is not being used.

Bug: 643561
Change-Id: Ib85c40e3f5df88df51caba61f9888e887219ee83
Reviewed-on: https://chromium-review.googlesource.com/1055951Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558036}