GitLab

Because initial sync may take as long as 10 minutes to occur for new
accounts, do not defer creation of the OEM folder, instead re-position
it when sync data arrives.

BUG=chrome-os-partner:29764
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/413033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285606 0039d316-1c4b-4281-b951-d872f2087c98

As described in its class comment, a ui::KeyEvent can be either of two
distinct kinds. When constructing a ui::KeyEvent from a native event,
the distinction is made by a new IsCharFromNative() call, in the same
way that other ui::Event properties are determined, instead of having the
caller inspect the native event itself. Removing the redundant |is_char|
parameter from constructors also prevent accidental synthetic `mixed'
events that consuming code does not handle.

Incidentally, while KeyEvent constructor calls are being touched, use
EF_NONE instead of 0 to make that argument's purpose clear.

BUG=380349
TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests

Review URL: https://codereview.chromium.org/404203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285605 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285604 0039d316-1c4b-4281-b951-d872f2087c98

bootstrap.py:
+ no_bootstrap => no_rebuild

NOTRY=true
R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/412053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285603 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178934&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285602 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/416203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379912

Review URL: https://codereview.chromium.org/422493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285600 0039d316-1c4b-4281-b951-d872f2087c98

This implements WebServiceWorkerRegistration based on the latest spec
and resolves a register promise with it instead of a ServiceWorker object.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj 

[1] Blink: https://codereview.chromium.org/413123002/
[2] Chromium: This patch.
[3] Blink: Remove the macro and fix a bunch of layout tests.


BUG=396400
TEST=compile (tests will be added by subsequent patches)

Review URL: https://codereview.chromium.org/415963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285599 0039d316-1c4b-4281-b951-d872f2087c98

Adding base::StatisticsRecorder::Initialize() to run_all_unittests to mirror another change we had made to the content test suite in https://codereview.chromium.org/330473003/

BUG=387751
TEST=Suggestions*,Blacklist*

Review URL: https://codereview.chromium.org/410673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285598 0039d316-1c4b-4281-b951-d872f2087c98

Currently this was just an action directly into extensions_unittests.

But we want to share the same pak file between extensions_unittests and app_shell.

So in order to do this we create a new target called "extensions_pak" and make
 extensions_unittests depend on it.

After this lands, app_shell will be refactored to use extensions.pak too.

BUG=397250
TEST=extensions_unittests
R=jamescook@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/413293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285597 0039d316-1c4b-4281-b951-d872f2087c98

Support 'mlogin' screen type for multi-profile login to onFocus event to IME extensions. This is the follow up change per comment in https://codereview.chromium.org/418273002/

BUG=395621
TEST=None

Review URL: https://codereview.chromium.org/417183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285593 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178924:178929&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/419813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285592 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/418333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285591 0039d316-1c4b-4281-b951-d872f2087c98

This was something that was missed as part of this review:
https://codereview.chromium.org/352173005/

BUG=
TBR=mad
NOTRY=true

Review URL: https://codereview.chromium.org/420713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285590 0039d316-1c4b-4281-b951-d872f2087c98

Partially reverts crrev.com/284112 by moving the verifier test from unit_tests target back to browser_tests, because of trust information leaking between test cases.

BUG=396497

Review URL: https://codereview.chromium.org/419213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285589 0039d316-1c4b-4281-b951-d872f2087c98

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/416373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285588 0039d316-1c4b-4281-b951-d872f2087c98

LabelButton's GetPreferredSize() gets called a lot, and it's pretty
expensive (creates a temporary label every time). To make it less sucky, we
should cache its last computed size and reuse that, just like Label does.

BUG=373906

Review URL: https://codereview.chromium.org/371633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285587 0039d316-1c4b-4281-b951-d872f2087c98

The CT verifier is needed in the off-the-record profile to
do SCT validation. Currently the CT verifier is stateless
so it is safe to share it with the OTR profile.

BUG=395648

Review URL: https://codereview.chromium.org/411333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285584 0039d316-1c4b-4281-b951-d872f2087c98

The password entry field in user pods should always have a white
background color, even if it is disabled.

BUG=396008
TEST=Manual

Review URL: https://codereview.chromium.org/409093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285583 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285582 0039d316-1c4b-4281-b951-d872f2087c98

This change makes the CLD2 header files ok to use regardless of whether or not
the CLD2_DYNAMIC_MODE define is set when including them. No-op implementations
have been added to the C++ code in CLD2 for the cases where client code
incorrectly calls dynamic-mode methods with a non-dynamic build of the library.
This allows including projects (such as Chromium) to opt for runtime checks
instead of compile-time checks when dealing with CLD2, which in turn greatly
simplifies the build logic for code that depends on CLD2.

BUG=367239
TBR=toyoshim

Review URL: https://codereview.chromium.org/422493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285581 0039d316-1c4b-4281-b951-d872f2087c98

Currently, destroying a ui::TouchEvent removes its tracking id from the slot mapping. Because MenuEventDispatcher::DispatchEvent was creating
(and destroying) a touch event, the tracking id was being
removed too early.

This patch refcounts the tracking ids, so the tracking id won't be removed until it should be.

BUG=394437

Review URL: https://codereview.chromium.org/400213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100538
TBR=yurys@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/419813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162783

Review URL: https://codereview.chromium.org/400873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285578 0039d316-1c4b-4281-b951-d872f2087c98

Disable WindowAnimationsTest.LockAnimationDuration and WindowAnimationsTest.HideShowBrightnessGrayscaleAnimation under Dr.Memory

BUG=397478
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285577 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285576 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=N/A
R=xians@chromium.org

Review URL: https://codereview.chromium.org/417943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285574 0039d316-1c4b-4281-b951-d872f2087c98

Leave a note about suppressing data races in TSan v2.

BUG=351259
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/416363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285573 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178912:178923&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/423463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350377

Review URL: https://codereview.chromium.org/404353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285571 0039d316-1c4b-4281-b951-d872f2087c98

Three-sided patch:
[1] Blink: https://codereview.chromium.org/409403002
[2] Chromium: reuse a ServiceWorkerHandle
[3] Blink: https://codereview.chromium.org/411863003

BUG=395928

Review URL: https://codereview.chromium.org/412833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285570 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285569 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/0925a5784c8424e3f9d75dbf4612ada12dc37131..75770afff8cdcd77ddb594a68de71f2b6f5cd393

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/423433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285568 0039d316-1c4b-4281-b951-d872f2087c98

Shows the enroll button when the device is not enrolled, and shows the unenroll
button when the device is enrolled.

When the enroll button is clicked, sets a variable in the local state and
reboots.

TEST=maunally test the settings page.
BUG=chromium:353050
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/405383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285567 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
3) Rename methods to use CamelCase style.
4) Rename file name to mock_spell_check.

BUG=331299

Review URL: https://codereview.chromium.org/410283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285566 0039d316-1c4b-4281-b951-d872f2087c98

Instead, app_list::OmniboxProvider is responsible to set true to SearchTermsArgs::from_app_list.

BUG=388515

Review URL: https://codereview.chromium.org/399063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285565 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [WebSocket] Send a close frame when the renderer process is gone. (https://codereview.chromium.org/390773002/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5350

Original issue's description:
> [WebSocket] Send a close frame when the renderer process is gone.
> 
> Renderer processes may die without clearing its |WebSocketBridge|s.
> It is helpful to send a close frame with code = 1001 in such a case.
> 
> BUG=392534
> R=ricea@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285557

TBR=ricea@chromium.org,jgraettinger@chromium.org,eroman@chromium.org,mmenke@chromium.org,yhirano@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392534

Review URL: https://codereview.chromium.org/416333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=jianli@chromium.org (for notifications_api.cc)

Review URL: https://codereview.chromium.org/415143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285562 0039d316-1c4b-4281-b951-d872f2087c98