GitLab

Implements ash::internal::LogoutConfirmationDialogView which is supposed
to be used by ash::internal::LogoutButtonTray.

BUG=223846
TEST=new unit test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242286

Review URL: https://codereview.chromium.org/40053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243530 0039d316-1c4b-4281-b951-d872f2087c98

The old approach chose the nav dot width by measuring a phantom
dot containing the string "Most Visited," but only when the Most
Visited dot is shown. This approach fails when it isn't shown,
or when the string "Apps" is longer than the string "Most Visited"
in the user's local language.

Screenshots on the bug.

BUG=248495

Review URL: https://codereview.chromium.org/110523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243529 0039d316-1c4b-4281-b951-d872f2087c98

Trace-viewer side change is here: https://codereview.appspot.com/39310043

Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png

Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit

TBR=phajdan.jr
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242671

Review URL: https://codereview.chromium.org/109933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243528 0039d316-1c4b-4281-b951-d872f2087c98

Finally - the first two functions which go for good!

BUG=322682
TEST=covered by other unit tests

Review URL: https://codereview.chromium.org/109823010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=223574
TEST=manually tested

Review URL: https://codereview.chromium.org/108163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243526 0039d316-1c4b-4281-b951-d872f2087c98

Event names and dictionary values in the event router of Files.app can be
replaced with constants and types generated by the IDL compiler.

BUG=330638
TEST=none

Review URL: https://codereview.chromium.org/107813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243525 0039d316-1c4b-4281-b951-d872f2087c98

Add support for having multiple queries to be active at the same time
given that their targets are different.

BUG=328808

Review URL: https://codereview.chromium.org/106623008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243524 0039d316-1c4b-4281-b951-d872f2087c98

 * Move shared constants between V1 and V2 to drive_backend_constants.
 * Drop dependency from FakeDriveServiceHelper to APIUtil

BUG=331991

Review URL: https://codereview.chromium.org/103013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243523 0039d316-1c4b-4281-b951-d872f2087c98

for assistive technologies on Windows. This changeset adds support for

- article (xml-roles:article)
- header (xml-roles:banner)
- aside (xml-roles:complementary)
- address (xml-roles:contentinfo)
- footer (xml-roles:contentinfo)
- main (xml-roles:main)
- nav (xml-roles:navigation)
- section (xml-roles:region)

Patch from Takeshi Kurosawa <taken.spc@gmail.com>
BUG=253027
TEST=content\renderer\accessibility\accessibility_node_serializer.cc

Review URL: https://codereview.chromium.org/98183011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332341
TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/127753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243519 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243517 0039d316-1c4b-4281-b951-d872f2087c98

R=engedy@chromium.org
TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/123423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243516 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332331
TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/127813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243515 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a revert of r234889 "[Files.app] Show files beginning with '.' (dot)", which causes Issue 330513.

BUG=196539, 330513

> [Files.app] Show files beginning with '.' (dot)
> 
> BUG=196539
> TEST=manually tested
> R=hirono@chromium.org
> 
> Review URL: https://codereview.chromium.org/71503003

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/127803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243514 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243513 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164506:164655&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/127673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243512 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/127653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243511 0039d316-1c4b-4281-b951-d872f2087c98

The API has long been in stable, so the test files shouldn't be in an "experimental" directory hierarchy.  Also, fixed minor issues caught by PRESUBMIT: 1) Removed tabs.  2) Corrected LOG(INFO) statements to more-appropriate LOG(ERROR).

Review URL: https://codereview.chromium.org/127353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243510 0039d316-1c4b-4281-b951-d872f2087c98

No one uses this class.

R=enne@chromium.org
BUG=NONE
TEST=NONE(No functional change)

Review URL: https://codereview.chromium.org/127173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243509 0039d316-1c4b-4281-b951-d872f2087c98

GCM API tests disabled on Windows due to the failure on official
window builds. Most of them are not enabled with the help from
using ScopedCurrentChannel trick.

BUG=324982
TEST=Enabling tests

Review URL: https://codereview.chromium.org/126913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243508 0039d316-1c4b-4281-b951-d872f2087c98

Add the override annotation to all necessary methods in .../quic/.

Merge internal change: 59008686
https://codereview.chromium.org/126243002/


Enabled StopPacketProcessing unit test.
Added EXPECT_CALL for OnUnauthenticatedPublicHeader.

R=rch@chromium.org
BUG=331630
https://codereview.chromium.org/113073003/


Add an end-to-end test which verifies that QUIC 13 does not generate
QUIC_STREAM_RST_BEFORE_HEADERS_DECOMPRESSED errors.

Merge internal change: 58990354
https://codereview.chromium.org/121883003/


Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where
the high water mark is not raised past the current transmission of a
packet whose previous packet has been ACKed. This bug was first
observer in jri's lab experiments.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58760014
https://codereview.chromium.org/125183004/


Correctly handle NACK-based "retransmission" of packets which no longer
have retransmittable data associated with this. These can be the result
of TLP retransmission or a current transmission of a packet whose
previous transmission have been acked.

Fix QUIC bug related to ACKs of previous transmission of packets.

Merge internal change: 58758718
https://codereview.chromium.org/125183003/


Simplify RTO interaction between the QUIC sent packet manager and the
send algorithm. The manager no longer needs to abandon each packet
individually.

Merge internal change: 58755766
https://codereview.chromium.org/125253004/


Remove a QUIC test only flag(limit_rto_increase_for_tests) to limit the
RTO increase in EndToEndTests.

This is no longer necessary now that two TLP's and early retransmit have
been added.

Merge internal change: 58591658
https://codereview.chromium.org/112953003/

Review URL: https://codereview.chromium.org/126513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311902
TEST=run install-build-deps.py in saucy chroot.

Review URL: https://codereview.chromium.org/126333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243506 0039d316-1c4b-4281-b951-d872f2087c98

In both aura and win this function is Not Implemented

BUG=

Review URL: https://codereview.chromium.org/126053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243505 0039d316-1c4b-4281-b951-d872f2087c98

This CL simplifies how DriveAppRegistry stores App info.
Main purpose is to add |all_apps_|, the explicit list of
all application currently registered.

BUG=332014

Review URL: https://codereview.chromium.org/125813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243504 0039d316-1c4b-4281-b951-d872f2087c98

Since these tests run on non-Windows platforms, the pak file seems to be loaded
fine and these .rc files should not be necessary.

BUG=297672
NOTRY=true

Review URL: https://codereview.chromium.org/125103007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243503 0039d316-1c4b-4281-b951-d872f2087c98

Moved the 'if' clause to check if the translation is performed automatically to TranslateManager. TranslateBubbleView::ShowBubble is called not only from TranslateManager but also when the user clicks the icon explicitly. In the latter case, the translate bubble should be shown whether the automatic translation is done or not.

BUG=330684
TEST=manual

Review URL: https://codereview.chromium.org/124833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243502 0039d316-1c4b-4281-b951-d872f2087c98

Adds various metrics related to GCM connection stability and persistent store
usage.

BUG=284553

Review URL: https://codereview.chromium.org/123453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243501 0039d316-1c4b-4281-b951-d872f2087c98

The new design of the window headers does not use a super transparent window header when there is just one window on screen.
The solo window feature is also broken in the M32 and M33 branches (crbug.com/330212)

BUG=297187
TEST=None
R=jamescook
TBR=oshima (For trivial change in chrome/browser/chromeos/login/login_display_host_impl.*)

Review URL: https://codereview.chromium.org/123023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243500 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to remove the WebGraphicsContext3D getter from
cc::ContextProvider.

TBR=maruel@ for trivial PRESUBMIT.py change
BUG=181120

Review URL: https://codereview.chromium.org/117233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243499 0039d316-1c4b-4281-b951-d872f2087c98

Add local_id to DirectoryFetchInfo.
After this change, there is no need to set dummy resource ID for the grand root.

BUG=324719
TEST=unit_tests

Review URL: https://codereview.chromium.org/107293013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243497 0039d316-1c4b-4281-b951-d872f2087c98

This basically reverts r222408 for iOS

BUG=330074
TEST=net_unittests

Review URL: https://codereview.chromium.org/103533012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243495 0039d316-1c4b-4281-b951-d872f2087c98

[Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

Also moves test files around:
  (1) The data previously in chrome/test/data/safari_import/ was moved to chrome/test/data/import/safari/default/.
  (2) A new test data directory was created at chrome/test/data/import/safari/empty_bookmarks_menu/.

BUG=248431
TEST=unit_tests
R=jeremy@chromium.org

Review URL: https://codereview.chromium.org/119833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243494 0039d316-1c4b-4281-b951-d872f2087c98

base::TimeTicks is a monotonic clock, unlike base::Time, which may change if
the system time is changed.  Switch over the video capture pipeline to use this
clock.

BUG=249215
TEST=local build, run on CrOS snow, desktop Linux

Review URL: https://codereview.chromium.org/101843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243493 0039d316-1c4b-4281-b951-d872f2087c98

... that accepts a RefCountedMemory. This saves some buffer copying in
many places, specially welcome with big images.

Review URL: https://codereview.chromium.org/78903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243492 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243486 0039d316-1c4b-4281-b951-d872f2087c98

> [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.
> 
> The extension provides fast bitmap operations with no external
> dependencies. However, it is not available on all platforms.
> 
> BUG=323813
> TEST=telemetry bitmap_unittest
> R=bulach@chromium.org, tonyg@chromium.org
> 
> Review URL: https://codereview.chromium.org/121493004

TBR=szym@chromium.org

Review URL: https://codereview.chromium.org/127533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243478 0039d316-1c4b-4281-b951-d872f2087c98

With the exception of the chrome.app.runtime.onLaunched() event,
events will only be dispatched to ephemeral apps that are running.
This was implemented by adding a "can_load_ephemeral_apps" flag to
extensions::Event. Only events which enable this flag will have the
ability to load the event page of apps.

BUG=312460
TEST=browser_tests (EphemeralAppBrowserTest.*)

Review URL: https://codereview.chromium.org/118033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327430

Review URL: https://codereview.chromium.org/120753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243476 0039d316-1c4b-4281-b951-d872f2087c98

The "Mappy" sample still provides an example of a content script searching for
text.

The new icon comes from http://en.wikipedia.org/wiki/File:Video_icon2.png, which
is public domain.

TEST=Install the extension, and visit http://www.html5rocks.com/en/tutorials/video/basics/. The page action icon should show up.
BUG=330359
NOTRY=true

Review URL: https://codereview.chromium.org/124603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243475 0039d316-1c4b-4281-b951-d872f2087c98

There are two issues:
1. App laucher uses the active profile's original profile to determine
if we're in guest mode (and thus always assuming guest session is not
active).
2. Every file manager event router (each profile has one) opening
a file manager window when removable device is inserted. So the
original profile's event router will open a window too.

BUG=329658
TEST=
1. Login as guest, launch file manager from the app launcher, open a doc file
from the file manager using quick office, and verify the doc is opened in off
the record window (Ctrl-T should open guest tab).
2. Login as guest, insert an SD card, make sure only 1 file manager window is
opened. From the opened file manager window, open a doc file using quick
office and make sure the document is opened in off the record window.

Review URL: https://codereview.chromium.org/115733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243474 0039d316-1c4b-4281-b951-d872f2087c98