GitLab

TBR=fserb@chromium.org

Bug: 857576
Change-Id: Ie09bb209328a8fe54d23e8d069b9fd744bbc9cfa
Reviewed-on: https://chromium-review.googlesource.com/1119159Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571279}

https://chromium.googlesource.com/angle/angle.git/+log/dc66ef9dc48b..fa5d84be4145


git log dc66ef9dc48b..fa5d84be4145 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 lucferron@chromium.org Vulkan: Fix offset handling for vertex buffers
2018-06-28 geofflang@chromium.org Vulkan: Refactor config generation out of platform specific code.
2018-06-28 jmadill@chromium.org Vulkan: Split tree ops into separate files.
2018-06-28 geofflang@chromium.org Update dEQP EGL expectations for Vulkan on Windows.
2018-06-28 courtneygo@google.com Emulate eglSwapBuffersWithDamageKHR when needed
2018-06-28 jmadill@chromium.org Vulkan: Roll glslang (June 2018).
2018-06-28 lucferron@chromium.org Vulkan: Framebuffer blit support for depth/stencil cases
2018-06-28 jmadill@chromium.org Vulkan: Work around unused sampler validation.


Created with:
  gclient setdep -r src/third_party/angle@fa5d84be4145

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Id1d292ce00eb39c3c3e7984ed26eff194cb92b59
Reviewed-on: https://chromium-review.googlesource.com/1118812Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571278}

This reverts commit cf42dd28.

Reason for revert: Due to http://crbug/853780, this code is no longer used.

Original change's description:
> Add fallback icon support to MV tiles
> 
> Tiles with missing/small favicons will display fallback icons instead, which consists of a colored circle and the first letter of the tile title. The fallback color will either be gray for missing favicons or the dominant color of the small favicon.
> 
> This change depends on https://crrev.com/c/1096670.
> 
> Screenshot: https://screenshot.googleplex.com/dbu8dxk97sX.png
> 
> Bug: 837798
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: Ie6ddf538396bcf8fbfd11cb9e9f0bad075301edd
> Reviewed-on: https://chromium-review.googlesource.com/1096680
> Commit-Queue: Kristi Park <kristipark@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567493}

TBR=treib@chromium.org,estark@chromium.org,kristipark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837798
Change-Id: I3631acae23acde679ad436832aea623f3b4e74ba
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1117802
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571277}

Zucchini makes the assumption that a valid DEX file has code items.
However, this contraint was not applied to whether the DEX file
contained valid and parsable code. As a result when attempting to find
references for within these code items, which weren't successfully
parsed, Zucchini would crash.

The solution is to impose a requirement that at least one code item was
parsed to create a disassembler.

Found during fuzzing of DEX files in CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1117123

Change-Id: I76fcbb9267099a7fe3d6eb61c345ffbfaf772fff
Reviewed-on: https://chromium-review.googlesource.com/1118851
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571276}

This is a rename-only change to make the review easier, namely
  kPersistentReleaseMessage -> kPersitentUsageRecord
as kPersistentReleaseMessage was never used.

Note that 'persistent-release-message' was removed from the EME
spec and the blink code, but never removed from CdmSessionType.

See Bug for details on the motivation of the change.

Bug: 856925
Test: None
Change-Id: I245cb8cce14e9d6a02bf75c69eafe061a429010d
Reviewed-on: https://chromium-review.googlesource.com/1117137Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571275}

Adds ProcessFilterConfig part to TraceConfig. The functionality
allows clients to whitelist processes that need to record traces.

It is going to be used by DevTools to limit the trace collection
to inspected processes. It will greatly reduce overhead of performance
recording, especially when it is being run in a browser having lots
of tabs open.

BUG=849887

Change-Id: I6395170509cd9b2ff688ee675a768393d0e95c8a
Reviewed-on: https://chromium-review.googlesource.com/1087947Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571274}

This reverts commit 0127f2eb.

Reason for revert: Failing test bot https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3661

Original change's description:
> [Mac] Get Suggestions from Whole Text and Current Selection
> 
> Currently, the SuggestedTextTouchBarController generates text
> suggestions based only text being selected and doesn't take any
> surrounding text into account. The goal is to generate text
> suggestions from all the text present in the textfield and the
> current cursor position, which results in behavior more similar to
> Safari's text suggestions.
> 
> First, WebContents::DidChangeTextSelection() and
> WebContentsObserver::DidChangeTextSelection() were modified to pass in
> the whole text in the textfield and the current selection range
> instead of the selected text.
> 
> The method requestSuggestionsForText: was modified to
> requestSuggestionsForText:inRange: so that it may receive the full
> text in the textfield along with the range of the current selection.
> 
> The WebContentsTextObserver was edited to also observe when a
> webpage finishes loading. This way, the controller can check whether
> the cursor is in a textfield before the text selection changes. This
> is necessary for websites in which a textfield is autofocused.
> This currently does not account for text that may be in the
> autofocused textfield, which will be addressed in a later CL.
> 
> Bug: 717553
> Change-Id: I3d56d7e590ba11c9a6c1c2e55f5bf1bb1b398985
> Reviewed-on: https://chromium-review.googlesource.com/1101962
> Commit-Queue: Tessa Nijssen <tnijssen@google.com>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sarah Chan <spqchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571208}

TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com

Change-Id: Iab7f11ad32948d911bd23f27bbb5cf48721cff45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 717553
Reviewed-on: https://chromium-review.googlesource.com/1119265Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571273}

We could have different encryption scheme support when using hardware
secure codecs. For example, when not using hardware secure codecs, we
support both "cenc" and "cbcs", but when using hardware secure codecs,
we may only support "cenc".

This CL updates KeySystemProperties::IsEncryptionSchemeSupported() and
KeySystemConfigSelector so that we can differentiate encryption schemes
supported in normal mode and in hardware secure mode.

WidevineKeySystemProperties is also updated to take
"hw_secure_encryption_schemes" returned by KeySystemSupport.

TBR=slan@chromium.org

Bug: 853261
Test: Added new test cases
Change-Id: I3ca9eba3e01adb5395a700969d2f985765d2544d
Reviewed-on: https://chromium-review.googlesource.com/1116426Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571272}

Bad merge job from refactored //chrome equivalent put
wrong condition here.  Causing crash on chromecast
chromevox.

Bug: 110944578
Test: Manual verification

Change-Id: Ibfd228dce524ce9498d97d1cedfe36ca3c698321
Reviewed-on: https://chromium-review.googlesource.com/1119071Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571271}

This lets us show the popup in VR.

+ UMA log when user tries to open certificate and whats more links on
popup while in VR.

+ Hide modal dialogs in VR when exit prompt is shown. Otherwise, the
exit prompt will be on top of the modal dialog.

+ Add support for dialogs to the VR testapp.

Bug: 828573
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr
Change-Id: I02e4381a914aff867abae33739aa6427ec1d9796
Reviewed-on: https://chromium-review.googlesource.com/984954
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571270}

Move key_idle_power_cases.py into rendering folder and refactor classes
to inherit from RenderingStory. Since this page set uses
android_screen_restoration_shared_state, modify rendering_shared_state
to behave in the same manner

Bug: 849392
Change-Id: I458523224946ddaec24f57c8d310e863088aa5a6
Reviewed-on: https://chromium-review.googlesource.com/1117576
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571269}

Using wpt-import in Chromium 7baa2dc1.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20302

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: Ic647a2d7bcfa9e4e663d09a167d1757901933352
Reviewed-on: https://chromium-review.googlesource.com/1119090
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571268}

Also added background that displays on hover, and tweaked the sidebar so its
transparency effect does not show the scrim.

https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-06-28/

Bug: 847599
Change-Id: I7c9b404cf4b6a468c297a4b147b41d47e4998f7a
Reviewed-on: https://chromium-review.googlesource.com/1119108
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571267}

Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/share

Continuation of work in bug 646094.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug: 846456
Change-Id: Ib4c6260e49b28bc78ec06059d3a15a2937d2f313
Reviewed-on: https://chromium-review.googlesource.com/1096008Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#571266}

Refine strings for safe browsing extended reporting toggle in settings.
Also add screenshot hashes to assist translation.

Bug: 856270
Change-Id: I5ce9940861c9ff4ea7167fc1d9f9140c1e42cb1c
Reviewed-on: https://chromium-review.googlesource.com/1117447Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571265}

We convert from rotation matrix to quaternion, but the calculation
wasn't stable.  It was mostly correct, but would occasionally give
NaN or other invalid values when w was near zero.

Rather than trying to correct the math, this change converts to using
common helpers.

BUG=852959

Change-Id: Ieecac34c0d7dd8d4abf550f1a93df017644237ef
Reviewed-on: https://chromium-review.googlesource.com/1117869Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571264}

Sometimes publishing an offline page results in the CANCELLED error.
Add some UMA to help discover how the cancelled results happen.

Bug: 856857
Change-Id: I14f35135ad9c76bb4093cce57c49a5b888a7c2df
Reviewed-on: https://chromium-review.googlesource.com/1116178Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571263}

Bug: 854301
Change-Id: Ifd2289c07dd1a63cbe328bc327dee2c74db8e7eb
Reviewed-on: https://chromium-review.googlesource.com/1112633Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571262}

deqp/functional/gles3/shaderoperator/common_functions.html
on Mac AMD

TBR=kbr@chromium.org

Bug: 820225
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0515e950a90cda632ee52070dfa3c743ff19de2d
Reviewed-on: https://chromium-review.googlesource.com/1119094
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571261}

TBR=carlosk@chromium.org
NOTRY=true

Bug: 857520
Change-Id: I319bf632a140514597272287a28682c84e38ffad
Reviewed-on: https://chromium-review.googlesource.com/1119196Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571260}

Interface is implemented by Chrome and a handle is passed to the assistant
service during initialization.

Design doc: go/croissant-device-actions

Bug: b/78189672
Change-Id: I3c5bfe94772d0a6d058e4736d481325318d0b461
Reviewed-on: https://chromium-review.googlesource.com/1110452
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571259}

TBR=jbudorick@chromium.org

Bug: 836447
Change-Id: I0eb9eaf50b369c401072be20456558f66ed86ab7
Reviewed-on: https://chromium-review.googlesource.com/1118761Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571258}

https://skia.googlesource.com/skia.git/+log/8849c9571022..d3420de4a9ff


git log 8849c9571022..d3420de4a9ff --date=short --no-merges --format='%ad %ae %s'
2018-06-28 jvanverth@google.com Return to low-precision ovals
2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-28 brianosman@google.com Revert "Reland "Revert "Update GPU DM/nanobench configs for color testing"""
2018-06-28 jvanverth@google.com Adjust ellipse center epsilon further to fix dropouts
2018-06-28 mtklein@chromium.org try moving NativeFonts CPU Android bot to Nexus 5x
2018-06-28 egdaniel@google.com Reland "Make GrVkBackendContext no longer derive from SkRefCnt."


Created with:
  gclient setdep -r src/third_party/skia@d3420de4a9ff

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I315bd8c6f2188fc452e2864e57738d46c0c12c32
Reviewed-on: https://chromium-review.googlesource.com/1118811Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571257}

Registers a download_manager service with the in-process ServiceManager,
giving it access to the network service.

The service instance is initialized on startup and runs indefinitely,
providing a dedicated service manager connection for the Android
DownloadManagerService object.

Bug: 695115
Change-Id: Ia372fd417679b8b31c0986d087289d2fc20c09f6
Reviewed-on: https://chromium-review.googlesource.com/1117573Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571256}

The previous CL (crrev.com/c/1103218) did not add the entries for the
new histograms in histograms.xml (preventing them from getting collected
by UMA). This CL makes a small change to the previous CL to simplify the
histogram names (re-using the same base autofill histograms as already
exist), and adds their suffixed histograms recursively to the set of
affected histograms for the SecurityLevel suffix.

These metrics are used for splitting some of the existing autofill
histograms by the SecurityLevel of the page on which they occur (to be
able to distinguish autofill behavior on different types of pages).

This also adds two owners to the "SecurityLevel" suffix as it is now
applied to histograms not already owned by Enamel folk.

Bug: 853347
Change-Id: I9151b55a69e92353d17634b60aba5725e67d3c08
Reviewed-on: https://chromium-review.googlesource.com/1117740Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571255}

This mode ports the ability to show Dex method counts rather than binary size
from the old UI. The mode previously required recompiling with a flag using the
supersize command, but the new UI supports it as client side toggle.

Bug: 847599
Change-Id: I613975cf20e45b30a1017ec0d8f6aee287c134e6
Reviewed-on: https://chromium-review.googlesource.com/1117598
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571254}

It turned out that we always need AdjustForBacking when the ancestor is
a paint invalidation container, or if its mapping to backing is no-op.

Change-Id: I6438c5b7d708ad204e8f14314013e0a2d61dcc6a
Reviewed-on: https://chromium-review.googlesource.com/1118707Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571253}

Turns out base:: file operations (PathExists/ReadFileToString, etc)
do not distinguish files "foo" vs "foo." or "foo ". In general
foo(\.|\ )+ would be treated the same as foo. This CL makes
verified_content's tree hash code aware of this.
Move existing content_verifier unittest under simple/ sub-directory
and add test coverage for change in this CL under dot_space_suffix/
sub-directory.

Bug: 696208
Change-Id: I63bcee5500385645f32d88a64cb053d8f852eca7
Reviewed-on: https://chromium-review.googlesource.com/1116349
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571252}

The cache generation mechanism was needed

1 to avoid cost of hashmap indexing of all remaining cached display
  items when searching for the matched cached display item of a newly
  appearing display item without any invalidation (e.g. when a scrolling
  contents layer is painted with a new interest rect);

2 to ensure correct caching of one display item client painting on
  multiple paint controllers.

Now for 1, we have subsequence caching which can reduce the chance of
full cached display item list indexing. For 2, we separate some code
from PaintController::CommitNewDisplayItems() into FinishCycle() so
that multiple PaintControllers can update the caching status of clients
synchronously, so we can remove the cache generation mechanism for
simplicity.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I08e3a1f8883584b3a30c4dfa498489df64be012c
Reviewed-on: https://chromium-review.googlesource.com/1117712Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571251}

The app at webauthndemo.appspot.com interprets the spec very literally
and fails assertion operations if the counter is not strictly monotonic.
Use a timestamp to work around that for now.

Bug: 837392
Change-Id: I50ed0bc1b6f9822764b920e051970fb8430914b8
Reviewed-on: https://chromium-review.googlesource.com/1112798
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571250}

This makes spoken feedback work in the shortcut_viewer app.

* AXHostService in the browser receives AX node trees and events from
  remote apps and forwards them to the ChromeVox extension
* AXHostServiceClient sends the initial tree from the remote app
  when ChromeVox is enabled. It sends updates when MusViewsDelegate
  sees views events (similar to ChromeViewsDelegate in browser).
* The node tree comes from the widget's client area because oop-ash
  creates a widget in both the window manager (for its frame) and
  in the client app (in case it wants to draw a frame). For now
  we assume the window manager owns the frame.

TODOs:
* Focus support
* Multiple widgets in client app
* Multiple client apps

TBR=sky@chromium.org
NOPRESUBMIT=true

Bug: 851578
Change-Id: I92a9fb7dbead9b329b0e4ea12d238428a63b4212
Reviewed-on: https://chromium-review.googlesource.com/1099572
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571249}

Not all of RenderWidgetHostNSViewClient can be mojo-ified (e.g, the
method that returns a raw pointer to the accessibility class), and
some may not be a good idea to mojo-ify (event conversion ... which
may not be as big a deal as I make it out to be). To handle this,
create a RenderWidgetHostNSViewLocalClient interface, and two
implementations: RenderWidgetHostViewMac, and ForwardingLocalClient
(which stubs out functionality that isn't present in the app shim, and
converts events to pass over mojo).

Also remove the "OnNSView" prefix from all methods, because it was
excessively verbose.

Remove the stubbed-out NoopClient, because it can now be replaced with
an un-bound mojo instance.

Bug: 821651
Change-Id: I3c7ab0e910e448292f188001ef5a786d661afb51
Reviewed-on: https://chromium-review.googlesource.com/1116354
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571248}

"Frame content" coordinates are no longer a thing.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6e82c57a8bc9008402407639d4e2e4a60161e337
Reviewed-on: https://chromium-review.googlesource.com/1117889
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571247}

I realized that there's some more nuance in the way DELETE_ON_CLOSE and
the DeleteFile disposition work.

BUG=none
NOTRY=true

Change-Id: Ie47f7da5ad9a84eac798841023aeee84a2da76d7
Reviewed-on: https://chromium-review.googlesource.com/1118232
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571246}

This reverts commit 9eeaba4e.

Reason for revert: Will re-land with fix

Original change's description:
> Revert "gtest perf tests: Output well formed test results json"
> 
> This reverts commit 71b865f4.
> 
> Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307)
> 
> Original change's description:
> > gtest perf tests: Output well formed test results json
> > 
> > This CL changes the run_gtest_perf_test.py script to output well formed
> > test results json.
> > 
> > Bug: 855234
> > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796
> > Reviewed-on: https://chromium-review.googlesource.com/1112635
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#570943}
> 
> TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org
> 
> Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 855234
> Reviewed-on: https://chromium-review.googlesource.com/1118238
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#571083}

TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org

Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855234
Reviewed-on: https://chromium-review.googlesource.com/1118789
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571245}

This is to enable web development work where a webserver is running in
a Crostini VM/container and then connected to from Chrome.
penguin.linux.test will resolve to the default container's IP address
and <container>.<vm>.linux.test will resolve to any container/VM that
is running.

Bug=849134
Test=Verified with service worker example

Change-Id: I23d170e29747d0d1e660171f635b1ded9348ac32
Reviewed-on: https://chromium-review.googlesource.com/1118919Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#571244}

This makes these tests fail, so mark them as such in TestExpectations

Bug: chromium:857576
Change-Id: Id7e112322585c786bb4b66d0875fcd05b9c75763
Reviewed-on: https://chromium-review.googlesource.com/1118853
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571243}

This is a reland of ccd4ec08

Difference from the original CL is minor, but indeed the cause of
failures on debug bots:

  -  headers.AddHeadersFromString(request.all_headers);
  +  for (auto it : request.headers)
  +    headers.SetHeader(it.first, it.second);

Basically, network::ResourceRequest::all_headers can contain
lines that do not match the "key: value" syntax expected by
net::HttpRequestHeaders. Hence, we iterate over
network::ResourceRequest::headers instead.

TBR=emaxx@chromium.org,sorin@chromium.org,rdevlin.cronin@chromium.org,droger@chromium.org,mmenke@chromium.org

Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
>
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
>
> Major remarks:
>
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
>
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
>
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
>
> BUG=773295,844973
>
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

Bug: 773295, 844973
Change-Id: I3a8252aecf687d08e41c0d09cb9bd245fe3f712b
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118646Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#571242}

Use a base::NoDestructor rather than a LazyInstance.

Connect the display link callback via display id rather than
DisplayLinkMac to ensure that no stale pointer issues can
cause crashes.

In addition, "<= 0" was used on uints. Fixed.

This reverts the speculative fix that was committed in
119ecfdd as it did not
target the actual issue.

BUG=564780
TEST=crashes go bye?

Change-Id: I779bd50fb3ffd1a96c5e8bd1e89ac18b19b7bef8
Reviewed-on: https://chromium-review.googlesource.com/1117615
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571241}

PassingTraits is a injection point to control base::Callback behavior
around an internal value transfer. However as it doesn't have a user
outside of the file, and is probably not worth exposing.

This CL replaces the injection point with single std::conditional for
simpler code.

Change-Id: I0cc10ad148fbd9f041eb9a5a3097c5a8ef77b473
Reviewed-on: https://chromium-review.googlesource.com/1118061
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571240}