- 23 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70ea9260ee89..4ff408590093 git log 70ea9260ee89..4ff408590093 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 reed@google.com start to divert legacy paint method impls to font 2018-11-23 reed@google.com start to hide textparams on SkPaint 2018-11-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4ff408590093 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I112fd1a800479c7c67b3e3ebee3665a0806bf67e Reviewed-on: https://chromium-review.googlesource.com/c/1349447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610685}
-
Chris Harrelson authored
fragmented content. This is necessary because overflow-scrolled content can be placed into a non-visible fragment clip. When scrolling into view, those clips need to be adjusted to allow the content to be visible. Long-term we can remove this slow path. Bug: 903287 Change-Id: Ia237d72f91084aa4ef125a9ba765b5d00143f48b Reviewed-on: https://chromium-review.googlesource.com/c/1344219 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610684}
-
Findit authored
This reverts commit 579d6501. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610667 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTc5ZDY1MDE0YzlkNmNjMjQ4ZWMxZGU0NzAxM2JmNmMyMGM3MjE1OAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26746 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/resource-timing/buffer-full-store-and-clear-during-callback.html Original change's description: > Align resource timing buffer full processing to spec PR 168 > > This change implements the processing model from PR 168[1], when > it comes to setResourceTimingBufferSize(), clearResourceTimings() > and the firing of the resourcetimingbufferfull event. > > [1] https://github.com/w3c/resource-timing/pull/168 > > Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80 > Reviewed-on: https://chromium-review.googlesource.com/c/1345269 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Commit-Queue: Yoav Weiss <yoav@yoav.ws> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610667} Change-Id: I0840bd9b763030b6e200e8f9a94c73c7982044a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908181 Reviewed-on: https://chromium-review.googlesource.com/c/1349498 Cr-Commit-Position: refs/heads/master@{#610683}
-
Mounir Lamouri authored
Encrypted media will require a different callback as there is a new attribute in the returned type so a WebMediaCapabilitiesDecodingInfo will be introduced. This change allows to cut a lot of boilerplate from the incoming CL. Bug: 907909 Change-Id: I61f6296c4a35678b8d4054d3df703b74471b1afb Reviewed-on: https://chromium-review.googlesource.com/c/1348258 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610682}
-
Peng Huang authored
For a mask layer, the color's alpha channel has to be 255, otherwise a DCHECK() in cc::RenderSurfaceImpl::TileMaskLayer() will be triggered. Bug: 897731 Change-Id: I9281ebdd1eccde58642297618051b2a1fb0a81e7 Reviewed-on: https://chromium-review.googlesource.com/c/1349454Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610681}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c35e39bb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ie84d1a5e6d1de7d6b172923aa9f04a4544832601 Reviewed-on: https://chromium-review.googlesource.com/c/1349472 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56c40ba6743e..9b900579b59b Created with: gclient setdep -r src-internal@9b900579b59b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifaa5b131e19b3271090728cbcfcee75099bc0110 Reviewed-on: https://chromium-review.googlesource.com/c/1349446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610679}
-
Andrew Grieve authored
Works around d8 bug: https://issuetracker.google.com/issues/119945929 Bug: 897969 Change-Id: I30c18836040d025ed9dbba3ebde6c33d8459b5be Reviewed-on: https://chromium-review.googlesource.com/c/1349854Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610678}
-
Steve Kobes authored
Bug: 581518 Change-Id: Icaaf62a88941961421f64454a06e9a53c4c39eee Reviewed-on: https://chromium-review.googlesource.com/c/1349849Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610677}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9b61866c69fd..70ea9260ee89 git log 9b61866c69fd..70ea9260ee89 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 reed@google.com don't define flag -- let clients do that 2018-11-23 reed@google.com Use SkFont in textblobs Created with: gclient setdep -r src/third_party/skia@70ea9260ee89 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I41a60e8bda17dfebf5135af884c737a7b1a5cfe5 Reviewed-on: https://chromium-review.googlesource.com/c/1349445Reviewed-by:
-
Mounir Lamouri authored
It was re-enabled as part of: https://chromium-review.googlesource.com/c/chromium/src/+/1342764 Bug: 898370 Change-Id: Icd0e3ff7f4cf953e563d8182394aa7fb159911ac TBR: kylixrd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349475Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610675}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25c4fce2cebb..6c18a1afa1a7 git log 25c4fce2cebb..6c18a1afa1a7 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 abenner@google.com Fix git cl format --python when diff.noprefix flag is set Created with: gclient setdep -r src/third_party/depot_tools@6c18a1afa1a7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:846432 TBR=agable@chromium.org Change-Id: I72da7b6f97e3b3026d79ae8ddddee692a11896d8 Reviewed-on: https://chromium-review.googlesource.com/c/1349444Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit 148c3506. Reason for reland: The original patch is not the cause of test failure. Test still fails after the revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43312 Original change's description: > Revert "Make EndOfSentence stop at block boundaries" > > This reverts commit aee1ee31. > > Reason for revert: Suspect this CL caused https://bugs.chromium.org/p/monorail/issues/detail?id=4576 > > Original change's description: > > Make EndOfSentence stop at block boundaries > > > > This patch stops EndOfSentence from crossing block boundaries, since > > block boundaries are also sentence boundaries. > > > > Bug: 778507 > > Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993 > > Reviewed-on: https://chromium-review.googlesource.com/c/1337432 > > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608850} > > TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 778507 > Change-Id: I7d48146bd7fb27c34427f543ad3b54443ae63715 > Reviewed-on: https://chromium-review.googlesource.com/c/1340815 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609224} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,kolos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 778507 Change-Id: If89bc2d7b9379af17dd326d92f9eb6e31d5d78f8 Reviewed-on: https://chromium-review.googlesource.com/c/1347032 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#610673}
-
Patrick Monette authored
Due to an issue with printing drivers possibly loading third-party DLLs that mustn't be blocked, initiating a printing operation now disables the hook in chrome_elf for the remainder of the process' lifetime. This is a short term solution to allow us to ship third-party blocking. Bug: 809738, 892294 Change-Id: I0b583197c2b619226e5a4a05836451b9f30eb133 Reviewed-on: https://chromium-review.googlesource.com/c/1312166Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#610672}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/600375480473..56c40ba6743e Created with: gclient setdep -r src-internal@56c40ba6743e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If9d659b1563ca5cbfc2455fc37a949f9d4be918b Reviewed-on: https://chromium-review.googlesource.com/c/1349443Reviewed-by:
-
Mounir Lamouri authored
Tested locally and everything is fine. Bug: 733494 Change-Id: I23f3cde42b14d2461fc94a391c6427d5c2aa9e1d Reviewed-on: https://chromium-review.googlesource.com/c/1263569 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610670}
-
Nicolás Peña authored
This CL moves the tests in http/tests/event-timing to external/wpt/event-timing. The slow image is change from php based to python based. The click is now handled by test driver. and setTimeout is replaced with step_timeout. Bug: 841224 Change-Id: I035c087550a2d9a67cda1aed88553c16967d04b6 Reviewed-on: https://chromium-review.googlesource.com/c/1349451 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#610669}
-
Liquan(Max) Gu authored
TextPaintTimingDetector and ImagePaintTimingDetector have the same codes to calculate the visual size of a rect. We can move this common part into PaintTimingDetector. This CL also refactor the logic in CalculateVisualSize for simplification. The new signature return the size value instead of the rect. By do this, we can save the logic of getting size from rect in RecordText and RecordImage. Bug: 869924 Change-Id: Icc2b88db90c1816e24f8ba7446ada701996fc652 Reviewed-on: https://chromium-review.googlesource.com/c/1348859 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610668}
-
Yoav Weiss authored
This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. [1] https://github.com/w3c/resource-timing/pull/168 Change-Id: I3a57196f10e0b4cf2bae5662b0e075673a0c2d80 Reviewed-on: https://chromium-review.googlesource.com/c/1345269 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610667}
-
Sam Maier authored
This reverts commit aaf0add8. Reason for revert: crbug.com/908131 Original change's description: > Reland "Introduce bundle-specific native libraries" > > This is a reland of 50ab16b8 > > Original change's description: > > Introduce bundle-specific native libraries > > > > This will allow native code to be stripped out of the main library > > when it moves to a Dynamic Feature Module. For now, the libraries will > > be identical. > > > > BUG=874584 > > > > Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913 > > Reviewed-on: https://chromium-review.googlesource.com/c/1332248 > > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > > Reviewed-by: David Turner <digit@chromium.org> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608519} > > Bug: 874584 > Change-Id: I197543b47e1613f93164ebd6f9a4c9d84743e284 > Reviewed-on: https://chromium-review.googlesource.com/c/1344875 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610456} TBR=digit@chromium.org,yfriedman@chromium.org,cjgrant@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874584 Change-Id: I3a80af1de5e8e932c47262290449082d93cf0da5 Reviewed-on: https://chromium-review.googlesource.com/c/1349856Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#610666}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 128d9b67. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ic69b103830303e2d026e7436fdc89ace288c242d Reviewed-on: https://chromium-review.googlesource.com/c/1349461 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/43e8ebcaf284..17079a5cc1f2 git log 43e8ebcaf284..17079a5cc1f2 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 perezju@chromium.org [soundwave] Cleanup .gitignore Created with: gclient setdep -r src/third_party/catapult@17079a5cc1f2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903026 TBR=sullivan@chromium.org Change-Id: I3c4ceeafde37f60af2a24df14e5ff926eeaa932f Reviewed-on: https://chromium-review.googlesource.com/c/1349440Reviewed-by:
-
Mounir Lamouri authored
Bug: 906320 Change-Id: Ib746b529aa0be13d913a4ee08528e1f8b0d822d4 TBR: mythria@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349791 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Dan Elphick authored
Change deprecated v8::Handle to v8::Local. Bug: v8:8238 Change-Id: Ic6fcf5f8aba221d2c48f11502656df88b1b84a24 Reviewed-on: https://chromium-review.googlesource.com/c/1348470Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: If5fc6dcdc8f5a24a5b34f9b2811f48fdd55a77aa Reviewed-on: https://chromium-review.googlesource.com/c/1349675Reviewed-by:
-
Mounir Lamouri authored
Bug: 898546 Change-Id: I18f631b57d17eb9750ec37b1e7a00fa0d7d3cbea TBR: yvesg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349450 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/095cc6722fa5..9e71de132fbc git log 095cc6722fa5..9e71de132fbc --date=short --no-merges --format='%ad %ae %s' 2018-11-23 baldurk@baldurk.org Add cmake option to turn off SPIRV_TIMER_ENABLED (#2103) 2018-11-23 dgkoch@users.noreply.github.com Add basic support for EXT_fragment_invocation_density (#2100) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e71de132fbc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I08206fc9377d6acbc744a2b383c807f53092e101 Reviewed-on: https://chromium-review.googlesource.com/c/1349438Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfbb007cffb6..600375480473 Created with: gclient setdep -r src-internal@600375480473 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib65fe04fd228d71e78018f86c44118cb1188ccd0 Reviewed-on: https://chromium-review.googlesource.com/c/1349441Reviewed-by:
-
Mounir Lamouri authored
This reverts commit 97df93d4. Reason for revert: added test was falky, see crbug.com/908071 Original change's description: > Don't unmount zip files when canceling password input. > > BUG=808300 > > Change-Id: Ib37a53399efd57a9306e4b47630391c265825b90 > Reviewed-on: https://chromium-review.googlesource.com/c/1345692 > Commit-Queue: Anand Mistry <amistry@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610336} TBR=noel@chromium.org,amistry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true Bug: 808300 Change-Id: If2c4d54fb70b57d33aeec55adc3404836345d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/1349752 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Alexander Shah authored
R=riajiang@chromium.org Change-Id: I1bce7704658f999daf6a7f177d02434661342992 Reviewed-on: https://chromium-review.googlesource.com/c/1349792Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Alexander Shah <zandershah@google.com> Cr-Commit-Position: refs/heads/master@{#610656}
-
Mounir Lamouri authored
This required to create a custom callback class as CallbackPromiseAdapter does not work well with dictionaries. This is also updating the media-capabilities.idl file in WPT, based on: https://raw.githubusercontent.com/tidoust/reffy-reports/master/whatwg/idl/media-capabilities.idl Bug: 907704 Change-Id: I13bb3c43a7461398f7866f033527bd3ce1bed140 Reviewed-on: https://chromium-review.googlesource.com/c/1347001 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#610655}
-
Chris Mumford authored
A speculative fix in ChunkedDataPipeUploadDataStream::ReadInternal which was being passed a null |buf| parameter and dereferencing it. The speculation is that ChunkedDataPipeUploadDataStream::OnHandleReady was being called before ChunkedDataPipeUploadDataStream::ReadInternal had ever been called. ReadInternal is what first sets |buf_| which is used by OnHandleReady. Moving the call to Watch() inside ReadInternal avoids this condition. Bug: 901116 Change-Id: Icda0f96454362b7f996e0fdc9440127f023d99ee Reviewed-on: https://chromium-review.googlesource.com/c/1334000Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#610654}
-
Andrew Grieve authored
I spot checked the last 10 builds on: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Android And it's been fine. I also checked locally that the .jar file has a hermetic timestamp for the file entry (via unzip -lv) Bug: 897970 Change-Id: Ifd38c3b7c197fbf2175cf16f462d56be31d1da2d Reviewed-on: https://chromium-review.googlesource.com/c/1349674Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610653}
-
Andrew Grieve authored
Bug: 897969 Change-Id: Ifef819c0308ffd5065e54915065cd8a586ba217f Reviewed-on: https://chromium-review.googlesource.com/c/1349749Reviewed-by:
-
Mustaq Ahmed authored
Also marks one currently untestable test. Bug: 906791 Change-Id: I17fd03f16e93244be80f9572db8c43e8e0b95678 Reviewed-on: https://chromium-review.googlesource.com/c/1347092 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afef11dc26bd..dfbb007cffb6 Created with: gclient setdep -r src-internal@dfbb007cffb6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7833ac596269b2efa28ef047a29adc95e1436666 Reviewed-on: https://chromium-review.googlesource.com/c/1349439Reviewed-by:
-
Mounir Lamouri authored
It's flaky on all platforms and is starting to flake on the leak bot. Bug: 891155 Change-Id: I1aa21d9232bc88e02cc8c17d08c0ee17dc08434e TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349453Reviewed-by:
-
Stephane Zermatten authored
Before this change, PromptAction only supported normal chips. This change adds support for displaying choice as scripts in buttons with highlights. The way this is done reproduces exactly the way buttons are configured for scripts, sharing the same logic and code. The idea is that it would help keep the two consistent. Bug: 806868 Change-Id: I82b3a49b1339e4aecd1c3dffabb826022fbac1e6 Reviewed-on: https://chromium-review.googlesource.com/c/1348050 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610648}
-
Dave Tapuska authored
Use wtf_size_t as opposed to size_t BUG=879657 Change-Id: If00143969f0c18bbfb54b6b602e5b915e756dd3b Reviewed-on: https://chromium-review.googlesource.com/c/1349750Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610647}
-
Dan Elphick authored
Value::ToObject(Isolate*) is deprecated because it doesn't force the user to check whether a result was actually returned. This changes MessageChannel::Create to use the Context version and calls FromMaybe on the result. This will return an empty Local if ToObject throws which would happen if its input was undefined or null (https://tc39.github.io/ecma262/#sec-toobject). Bug: v8:7279, v8:8238 Change-Id: I51c48350d1c50507d2dff6ef5c5a97cf2b03ddb5 Reviewed-on: https://chromium-review.googlesource.com/c/1344100 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
