- 16 Jan, 2020 40 commits
-
-
Xianzhu Wang authored
The issue happened when an SVG background image was painted with a very small background size rounded to zero, causing infinite tile scale and DCHECK failure in ClipRectOp. Bug: 1039762 Change-Id: Ia94ce2fd350b28696ef8068bd0e756bfc6d87a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002839 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732572}
-
Kent Tamura authored
This reverts commit 3c4c13ac. Reason for revert: Made ChromeVoxBackgroundTest.SelectSingleBasic flaky Original change's description: > Move LayoutMenuList::DidUpdateActiveOption() to HTMLSelectElement > > Also, > - Remove LayoutMenuList::DidSelectOption(). > - Add HTMLFormControlElement::UpdateFromElement() to add > DidUpdateMenuListActiveOption() to each of > LayoutMenuList::UpdateFromElement() calls. > > This CL is a preparation to build a LayoutNG counterpart of LayoutMenuList. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: If7917af101119a830e899a50711a6c1491e22eb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003164 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732313} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I4f571b72f01f0494fc855c1ceb3841e7ff02a963 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006268Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732571}
-
Md. Hasanur Rashid authored
Current implementation of FilterOperation::MapRectReverse() for a blur filter actually does a forward (outset) map of the rect. This patch fixes the erroneous behavior by supporting MapRectReverse() to map backward for a blur filter. Bug: 916583 Change-Id: I43bf4498b89e18ba9c2d1eb341e977944e2226c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986646Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#732570}
-
Daniel Rubery authored
This CL implements the functionality for the download shelf UX to trigger deep scanning. No code currently generates the necessary DownloadCheckResult to generate this UX. It also fixes a minor UX issue where the deep_scanning_label_ was clickable, preventing the open_now_button_ from triggering. Bug: 1020418 Change-Id: I32d1c2144246db6286a994ecb08147d3fd511584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994301 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732569}
-
Mohammad Refaat authored
- Use Browser in TabGridCoordinator and TabGridMediator instead of using TabModel. - The usage of TabModel to restore session inside TabGridMediator haven't been removed, will remove it later after updating the main controller to use the sessionRestorationObserver to check for restoration in progress. - Update the TabSwitcher protocol's setOtrModel to be setOtrBrowser. - The TabSwitcher protocol and its users heavily depends on TabModel so it will be converted to use browser gradually. - Added couple helper methods to access the browser in the mainController. - TabGrid still uses TabModel where it calls the tabSwitcher delegate, this will be changed in a following CL with changing the protocol it self. - Update tests who uses these classes accordingly. Bug: 1042277, 783777 Change-Id: If02cd3128083169b0f9e0956190d8350ce1990fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001849 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732568}
-
Sadrul Habib Chowdhury authored
The BrowserWindow resize metrics have not been relevant since the cancelation of mus+ash project. So remove these metric. Some summary from the data collected: . BrowserWindow.Resize.StepCount: - < 2 at 75%ile. - ~11 at 90%ile. - ~29 at 95%ile. . BrowserWindow.Resize.StepInterval - ~15ms at 50%ile. - ~50ms at 90%ile. - ~112ms at 95%ile. . BrowserWindow.Resize.Duration - ~500ms at 50%ile. - ~1.8s at 90%ile. - ~1.7s at 95%ile. BUG=975256, 975800, 1036977 Change-Id: I41324aba843fb414ccefc20e386ddefa091532ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987916 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#732567}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I55b52e0c687533bab2e50b63423970d9f2ba8ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986960 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Change-Id: I89e6820f1920698f7fc44b625f7f3428c27d20fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003292 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#732565}
-
meacer authored
This CL adds a list of Georgian characters that look like Latin characters. A domain consisting only of these characters and not having a .ge ccTLD or other Georgian TLDs such as .გე will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. This CL also reorders and regroups some of the recent test cases. No popular domain is affected by this change. Bug: 722167 Change-Id: Ib68b3ef68ac55576141b9cb2cd6096d149456227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990326 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732564}
-
Toni Barzic authored
Updates UpdateYPositionAndOpacity::UpdateYPositionAndOpacity to reset transforms for views whose transform might have been changed in ContentsView::AnimateToViewState(). This will ensure that the views are positioned appropriatelly, and prevent them from animating as app list view drag starts. BUG=1042740 Change-Id: I1227a8ae52098d28331075ff1c681a6d16276137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005377 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732563}
-
Sergey Poromov authored
Previously no setup was done for Chrome OS and the tests assumed that RealtimeReporting is never enabled on Chrome OS. Now it covers the same scenarios as on other platforms, but requires some extensive setup. In a follow-up CL I'll add Chrome OS specific tests for different scenarios, e.g.device/user managed/non-managed and etc. Bug: 1012048 Change-Id: I810ae8c541fa0040ff63a8d7377129246a5473c8 Tests: Unit test updated. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002514Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#732562}
-
Michael Crouse authored
Bug: 1041908 Change-Id: I15dda3f992b930bb7280a3c16639c47d2b054680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001285 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732561}
-
Anton Bikineev authored
In the current design HeapObjectHeader sets ObjectStartBitmap in the constructor, which mixes abstractions and violates single responsibility principle, since ObjectStartBitmap is managed by a different entity - NormalPage. This patch decouples ObjectStartBitmap and HeapObjectHeader. Bug: 1029379 Change-Id: Iceb7450be7240d9b0765887b3e06663b56da7617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002820 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732560}
-
Daniel Hosseinian authored
Maps to 'local_discovery.enabled'. The policy enables controllable features on the local discovery UI (chrome://devices), which shows discoverable devices near the user as well as cloud devices registered to them. The local discovery UI also allows users to add classic printers connected to their computers to Google Cloud Print. Fixed: 1011582 Change-Id: Ib905acfc92ae5f10010bca69cae3e611982eb184 Bug: 1011582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977193Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#732559}
-
Bo Liu authored
RenderWidgetHostViews can become "inactive", and then "active" again. This can happen if the origin of a RWHV is still kept alive by another active RWHV, after the RWHV becomes inactive. Then the inactive RWHV can become active again if its WebContents navigates back to the matching origin. RWHVA destroys SynchronousCompositorHost when it becomes inactive in UpdateNativeViewTree. However it does not recreate it when RWHVA is active again later, breaking rendering in Android WebView. Fix this and also clean up by de-duplicating code to create and destroy SynchronousCompositorHost. Bug: 1039586 Change-Id: I7772c9d341f44f5c822f3ac186be236e5d6abf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995841 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732558}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the UrlUtilitiesUnitTest unittests and the UrlUtilitiesTest from junit and ChromePublicTestApk, respectively, to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: Ic8d27df818563d8caa8e9e7dbac02b9e4557e811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998001 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732557}
-
Lei Zhang authored
Just call emplace(k, v), instead of emplace(std::make_pair(k, v)). Also fix lint errors. Change-Id: Ib9ae69f3e21604daf1bcd2297bee960833db5290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005088Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#732556}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5fc197dc7669..5c6a3c247590 git log 5fc197dc7669..5c6a3c247590 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 capn@google.com Remove the GL_NV_read_depth_stencil extension Created with: gclient setdep -r src/third_party/swiftshader@5c6a3c247590 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaced2f9f37d65f35413e60c7b7124dc2d401154f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732555}
-
Tina Wang authored
- No user visible change in this cl. - Add new directory for profile card. - Add basic classes. Change-Id: Ic09d5f097f712a9c58c1ed666eba22fac1d9236c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993146Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#732554}
-
Ryan Sturm authored
This is a reland of 4e23e8e8 Patchset 1 is what previously landed. This caused flakes in other loading predictor browser tests, so I added the holdback to all of the tests. In a follow-up, I will make sure the tests check for preconnects on the appropriate URLs. See https://chromium-review.googlesource.com/c/chromium/src/+/2004181 for revert rationale. Original change's description: > Adding a FTT config for PreconnectSameOriginDesktop > > This experiment is in canary/dev and should be moved to Beta. > > Bug: 1038774 > Change-Id: I4fc9c44e2b68aa58f9eee7210a625103f45edb01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992684 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732219} Bug: 1038774 Change-Id: Id7bd4bddf5b5812d02a8953d0733f8af73007fb6 TBR=tbansal@chromium.org,alexilin@chromium.org Change-Id: Id7bd4bddf5b5812d02a8953d0733f8af73007fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004691Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732553}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01c0d6bd8d7f..bdb0f8a52414 git log 01c0d6bd8d7f..bdb0f8a52414 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 2c436960d2c0..4792a6854238 (3 commits) 2020-01-16 sugoi@google.com Support blendable capability 2020-01-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src f63dd5c9d874..881bbb347a08 (1 commits) 2020-01-16 jonahr@google.com Expose GL_ANGLE_framebuffer_blit in NULL backend Created with: gclient setdep -r src/third_party/angle@bdb0f8a52414 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029829 Tbr: jonahr@google.com Change-Id: I4387a446682487ca735f0423c6bee716a858c125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005308Reviewed-by:
-
Takumi Fujimoto authored
This CL adds a secondary_title field to media_router.mojom.MediaStatus, corresponding to the media.metadata.subtitle field in Cast SDK media status messages, which contains artist names for media. The artist name is shown in a Cast notification item in Global Media Controls. Other labels are also rearranged to match the mocks. Screenshot: https://drive.google.com/file/d/1Ecr-7WsGFE7Be3MuPvsau3SEUwKPQPJr/view?usp=sharing Bug: 1042016 Change-Id: Iff3cc50af41ef24e6a4e8ec10090acbffe049f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003388 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#732551}
-
Fei Ling authored
Fix issue 1038319: Unable to change chrome language via chrome://settings/languages on Windows-Hebrew machine. The problem is that the chrome installer uses the old language code for Hebrew, "iw", instead of the new code "he". This value is saved in the user's local state. The language model in langauges.js does not recognize this language code, thus the bug. Fixed: 1038319 Change-Id: Ib227b2972989c2fa87fdc2d4be408040ad137c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990476Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Fei Ling <feiling@chromium.org> Cr-Commit-Position: refs/heads/master@{#732550}
-
Oriol Brufau authored
Unlike ::before and ::after, in ::marker 'content: normal' and 'none' should behave differently: the former should display it normally, the latter should prevent it from generating a box. Before this patch, 'normal' and 'none' were both stored as nullptr, so they were indistinguishable. This patch makes 'none' be stored as a NoneContentData instead. However, 'none' keeps behaving as 'normal' for anything different than ::marker. In getComputedStyle, 'none' keeps resolving to 'normal' for anything different than ::marker, ::before and ::after, and 'normal' keeps resolving to 'none' for ::before and ::after. Inheritance is not affected either since the 'content' property can't be inherited in Chromium. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-computed-content.html TEST=external/wpt/css/css-pseudo/marker-computed-size.html TEST=external/wpt/css/css-pseudo/marker-content-019.html marker-content-019.html fails in legacy. Change-Id: Ib71ef18dfb7f7c98e76888bffb408a17fa458235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002517Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#732549}
-
Wenyu Fu authored
Add focus & setEnabled related enhancement to RadioButtonWithEditText and add some test. Change-Id: Iad713ddaa108f084e9f98e882bcd6e6135384756 Bug: 1036470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991717 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732548}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I182a534bbca26fd66c8c907c2ef0bd9c72168fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005332Reviewed-by:
-
Robert Ma authored
Bug: 1036130 Change-Id: Ie6bf04fcdae3af73aa7f412acbfd9cf692ad156d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002747 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#732546}
-
Zhuoyu Qian authored
Update the function GetUsageCachePathForOriginAndType to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: I05ddacce6d15c9d6125b92e425cc79b251e26b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004356 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732545}
-
Kurt Horimoto authored
Added in this CL: - Response info types for password modal delegate callbacks. - Coordinator and mediator classes to handle UI setup. - Update mock passwords delegate to set the URL. Bug: 1030357 Change-Id: Ia5b375869234b26b36df6220a1b2908847723e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995635 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732544}
-
danakj authored
Drop the RenderWidget::StartStopCompositor() method and just have the two sites call LayerTreeView::SetVisible() directly. Turn TODOs into comments explaining things or delete them where they don't make sense anymore (we're done them!). RenderViewImpl::CloseWindowSoon() should check if there is a main frame instead of checking if it owns a RenderWidget, so we can move ownership over to RenderFrameImpl. These two are equivalent currently. R=avi@chromium.org Bug: 419087 Change-Id: I8449ed02d694eb28046b8ae2d7439640bdbf49ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003630 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732543}
-
Demetrios Papadopoulos authored
flattenhtml does not work with Polymer3 generated files. Instead register images with the WebUIDataSource so that they can be served by a chrome://extensions URL. Bug: None Change-Id: I33346fac61b1f4d0937615fa8dde38c22809de89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003196Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732542}
-
Henrique Nakashima authored
This is CL 3/5 for moving ChromeFeatureList to the .flags package. Bug: 1041468 Change-Id: Ib46b9ecab62300d54e7f236ee75ddd150af2d019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003441 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732541}
-
Stephen Chenney authored
The Blink.MainFrame.UpdateTime metric was missing from the affected metrics list for the PreLCP, PostLCP and AggregatedPreLCD suffixes. Bug: 1040545 Change-Id: Ie8db9ac44d14b41617bf381cd5a743832c0cc881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001247 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732540}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4b8eefe5653..2cd5d43f022c git log c4b8eefe5653..2cd5d43f022c --date=short --first-parent --format='%ad %ae %s' 2020-01-16 halcanary@google.com [minor] docs/examples: cleanup 2020-01-16 mtklein@google.com Revert "Simplify VertexRegenerator GrStrikeCache handling" 2020-01-16 herb@google.com Simplify VertexRegenerator GrStrikeCache handling 2020-01-16 herb@google.com Handle color and translation outside of VertexRegenerator Created with: gclient setdep -r src/third_party/skia@2cd5d43f022c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Ica2985cdbba32c491d817c87e8e09cba6d466354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003625Reviewed-by:
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/1f4fe2d7c33b..e5e25bc2ec5c $ git log 1f4fe2d7c..252403d10 --date=short --no-merges --format='%ad %ae %s' 2020-01-15 vasilvv Remove the DCHECK from ParsedQuicVersion constructor. 2020-01-15 wub gfe-relnote: For QUIC BBRv2, always count the number of loss marking events in a round and only exit PROBE_UP if that number is above a threshold. Protected by --gfe2_reloadable_flag_quic_bbr2_always_count_loss_events. 2020-01-15 bnc Remove Http2StrCat, use QuicheStrCat instead. 2020-01-15 bnc Move Http2Optional to QuicheOptional. 2020-01-14 bnc Move SpdyWrapUnique to QuicheWrapUnique. 2020-01-14 nharper gfe-relnote: Add kSupportedVersions to quic_versions.h, no behavior change 2020-01-14 renjietang Code cleanup in QuicStreamSequencer. 2020-01-14 fayang gfe-relnote: In QUIC, rename IsCryptoHandshakeConfirmed to OneRttKeysAvailable in QuicSession. Renaming only, not protected. 2020-01-14 wub gfe-relnote: Mimic QUIC BBRv2 style loss based exit in BBRv1 code. Protected by --gfe2_reloadable_flag_quic_bbr_loss_based_startup_exit _and_ connection option 'LRTT'. 2020-01-14 wub gfe-relnote: (n/a) Deprecate --gfe2_restart_flag_quic_use_circular_deque. 2020-01-14 fayang gfe-relnote: In QUIC, rename handshake_confirmed in handshaker to one_rtt_keys_available to make it clearer and more informative. Renaming only, not protected. 2020-01-14 quiche-dev Internal QUICHE change 2020-01-14 wub gfe-relnote: (n/a) Make QUIC BBRv2's initial ack height filter window tunable by flag --quic_bbr2_default_initial_ack_height_filter_window. No behavior change when the flag is at its default value. 2020-01-13 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_skip_packet_number_for_pto. 2020-01-13 fayang gfe-relnote: In QUIC, add a multiplier (default to 2) to consider overshooting happens if bytes_lost_with_network_parameters_adjusted_ * bytes_lost_multiplier_with_network_parameters_adjusted_ > IW. Protected by existing gfe2_reloadable_flag_quic_bbr_mitigate_overly_large_bandwidth_sample. 2020-01-13 dschinazi Refactor some QUIC version code 2020-01-13 dschinazi Refactor handling of supported versions 2020-01-13 dschinazi Internal QUICHE change 2020-01-13 wub gfe-relnote: Add QuicUdpSocketApi, a de-platformized version of QuicSocketUtils, and use it in some non-production code. No behavior change, not protected. 2020-01-13 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_ietf_loss_detection. 2020-01-10 rch gfe-relnote: When a QUIC client receives an unexpected crypto tag, include the tag in the connection close details. Not flag protected. 2020-01-10 fayang gfe-relnote: Change cwnd bootstrapping UpAndDown experiment group IW to 10. Protected by existing gfe2_reloadable_flag_quic_bbr_mitigate_overly_large_bandwidth_sample. 2020-01-10 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_pto. Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ibf95032d6b672e9e888a9aa560827ed03e907bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003868 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#732538}
-
Natalie Chouinard authored
Move constants related to Autofill settings alongside the code that uses them. This will help future Settings modularization efforts. Change-Id: Ie50712842bafa681adfae29e46325b9b3cab9452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004050 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
-
Jae Hoon Kim authored
Measure the rate in which PluginVM DLC is fallingback to rootfs resident PluginVM. A good metric to have in order to determine a stable state of DLC(s) to deem removal from rootfs in the future. Bug: chromium:145814572 Test: unit_tests --gtest_filter=PluginVm* Change-Id: Ib13aa2f6922954bc18f973abf746a3485d0980fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004056 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732536}
-
Tibor Goldschwendt authored
This prepares for reusing the grid for the backgrounds settings. Also, this CL adds support for non-full (i.e. the last row has empty spaces) grids. Bug: 1032328 Change-Id: Iab76c9bce52b832833d09301c560963b9ab2618c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003294 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#732535}
-
Eric Stevenson authored
This is a reland of 24f7b916. Fixed in the reland: Disabled failing test when !DCHECK_IS_ON. Original change's description: > Android: Better error messaging for some UnsatisfiedLinkErrors. > > A common cause of UnsatisfiedLinkErrors is that the native library > hasn't been loaded yet. It's difficult to tell the difference between > this and other UnsatisfiedLinkErrors. > > This CL adds generated code that queries LibraryLoader to determine > library loading status and throws an explicit error when a native > method is called before the library has been loaded. > > Bug: 1022938 > Change-Id: I63980990abaef16da3847a05eda01cb116779560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976905 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729461} Tbr: agrieve@chromium.org Bug: 1022938 Change-Id: I47651e6a222d55383689495ea2fc532d1d38d10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001438 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#732534}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=thomasanderson@chromium.org Bug: 1041419 Change-Id: I508a1fc4a66d5650bd7f635b45af94827577d2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998623 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732533}
-
