GitLab

Review URL: https://chromiumcodereview.appspot.com/11299256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170760 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=155525


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170483

Review URL: https://chromiumcodereview.appspot.com/11280115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170759 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise we show a Google logo and identity on third-party websites
when the user backspaces away the query.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11308284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170758 0039d316-1c4b-4281-b951-d872f2087c98

Reverting because this code will be used in the future (it is currently behind a #ifdef check).


BUG=161992


Review URL: https://chromiumcodereview.appspot.com/11412247

TBR=sergiyb@google.com
Review URL: https://codereview.chromium.org/11316307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170757 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170755 0039d316-1c4b-4281-b951-d872f2087c98

> [Android] Suppress missing licensing info warning for third_party/guava and third_party/jsr-305
> 
> 
> R=torne@chromium.org
> BUG=163896
> NOTRY=true
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11280278

TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/11418294

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170754 0039d316-1c4b-4281-b951-d872f2087c98

Try bots results can be seen from codereview.chromium.org/11348345

BUG=
TEST=tree
TBR=tasak
Review URL: https://codereview.chromium.org/11308324

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170753 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/162100
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11421194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170752 0039d316-1c4b-4281-b951-d872f2087c98

Instead of using bundled versions of guava, we now instead build guava
ourselves. Also, we need to build jsr-305 as it is the only dependency
guava has.

BUG=159873

Review URL: https://codereview.chromium.org/11415141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170751 0039d316-1c4b-4281-b951-d872f2087c98

Adds --enable-instant-extended-api to about:flags for all platforms.  Also
removes the < DEV channel restriction.

BUG=163719
TEST=Observe about:flags on other platforms.
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/11414278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170749 0039d316-1c4b-4281-b951-d872f2087c98

Implemented behind --ash-network-state-handler
Copies the bulk of the NetworkMenuIcon logic to ash; NetworkMenuIcon will eventually be deprecated.

BUG=161869
For .grd changes:
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/11361274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170748 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to inherit from testing::Test and then have to use TEST_F(),
if you aren't overridding SetUp() or TearDow(). So if you don't need to customize
it, you can use TEST() macro directly and it does that for us automagically.

Fix all the cases found with the following command line:

$ git grep -n1 "public testing::Test" base/ | grep "};"

TEST=base_unittests
R=willchan@chromium.org

Review URL: https://codereview.chromium.org/11308261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170747 0039d316-1c4b-4281-b951-d872f2087c98

NetworkChangeNotifierAndroid was only firing 'network connection changed'
events although many clients subscribe to 'IP address changed events'.
One of them is ClientSocketPoolBaseHelper which invalidates its socket pool
whenever the IP address changes. The lack of this notification on Android could
have led to an invalid socket being used.

This is a first approach. Later on this can be improved to only fire the
notification when the IP address actually changed.

This issue was found as part of the following bug investigation although this
CL doesn't claim to fix the bug.

BUG=149231

Review URL: https://codereview.chromium.org/11411287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170746 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glider
Review URL: https://codereview.chromium.org/11415260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170745 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163902,163904,163922,163924
TBR=glider
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170744 0039d316-1c4b-4281-b951-d872f2087c98

Create different implementations for desktop Chrome / CrOS, and change
initialization to keep the CrOS version in BrowserPolicyConnector
instead of the Profile.

BUG=chromium:108928
TEST=compiles and passes tests, cloud policy works as before.
TBR=phajdan.jr@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/11415094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170742 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170741 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11418289/
Review URL: https://codereview.chromium.org/11412301

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170740 0039d316-1c4b-4281-b951-d872f2087c98

Android's time_t is 32-bit by default, but the platform provides
a <time64.h> providing for time64_t and associated functions.

Use time64_t in base/time_posix.cc to implement base::Time::Exploded
conversion routines. This avoids un-necessary clamping of the year
to the 1901-2038 range when calling base::Time::Explode() or
base::Time::FromExploded().

BUG=162007
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11308176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163210

Review URL: https://codereview.chromium.org/11428091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170737 0039d316-1c4b-4281-b951-d872f2087c98

The FindThirdPartyDirs function no longer filters out empty/missing
directories as of r170273; update webview_licenses to do this. Also,
actually print the name of the directory causing a license error to make
debugging failures easier.

BUG=

Review URL: https://codereview.chromium.org/11421199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170736 0039d316-1c4b-4281-b951-d872f2087c98

R=torne@chromium.org
BUG=163896
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11280278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170733 0039d316-1c4b-4281-b951-d872f2087c98

Change summary:
- Add 'const' to ShellDelegate::IsUserLoggedIn()
- Use TrayImageItem::UpdateAfterLoginStatusChange delegate instead of ShellObserver::OnLoginStateChanged()
- Add a pref: kShouldAlwaysShowAccessibilityMenu
- Add a checkbox to chrome://settings

BUG=158287
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11280236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170732 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=162375

Review URL: https://codereview.chromium.org/11414292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170730 0039d316-1c4b-4281-b951-d872f2087c98

Add a tool to look for unused suppressions.

BUG=112065

Review URL: https://chromiumcodereview.appspot.com/11421163

TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/11415256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170727 0039d316-1c4b-4281-b951-d872f2087c98

Widen some suppression, add general Histogram suppression (hope the other ones
will be unused then); exclude some tests.

BUG=163880
TBR=glider
NOTRY=true
Review URL: https://codereview.chromium.org/11419286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161748


Review URL: https://chromiumcodereview.appspot.com/11421166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170725 0039d316-1c4b-4281-b951-d872f2087c98

Part 1: https://chromiumcodereview.appspot.com/11362183/

The second part of this change implements the "true" path,
i.e. the user provides us with a new AwContents to host
the popup window. This arrives asynchronously.

While we are waiting for the reply from the user, we defer
loading of the popup contents using a resource throttle.

When we receive the callback we replace the ContentViewCore that
is contained in the new AwContents with one that wraps the WebContents
for the popup. This triggers an update to the AwIoThreadClient for
that AwContents, which resumes the deferred load for the popup.

Android only change and android bots green
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/11348075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170721 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170720 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170718 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=163855

Review URL: https://codereview.chromium.org/11348346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170717 0039d316-1c4b-4281-b951-d872f2087c98

Two reasons to do this:
- We should prevent LocalFileSystemService's RemoteChangeProcessor
  methods from being called for origins that may not have been
  initialized in the local side yet. (If we run the initialization
  simultaneously it's not straightforward to disallow this)
- It's not easy to undo the RegisterOrigin if local-side's
  initialization fails.

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/11316270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170716 0039d316-1c4b-4281-b951-d872f2087c98

Sharable constants and methods are moved to common/cloud_print so they can be shared by all cloud print related features.  Classes/constants/methods in service/cloud_print are moved into namespace cloud_print. Tests are added. 

BUG=163603

Review URL: https://chromiumcodereview.appspot.com/11360151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159981


Review URL: https://chromiumcodereview.appspot.com/11299270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170714 0039d316-1c4b-4281-b951-d872f2087c98

This adds default implementations to the Cocoa and Gtk shell windows. The views shell window is currently the only class that implements these in a non-default way; the Cocoa and Gtk will get their own implementations in a follow-up patch.

This is needed to have the app window setBounds() and getBounds() APIs operate
on content bounds rather than window frame bounds.

R=ben@chromium.org,rsesek@chromium.org,estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11369237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170713 0039d316-1c4b-4281-b951-d872f2087c98

R=kinaba@chromium.org
BUG=160904


Review URL: https://chromiumcodereview.appspot.com/11418127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170712 0039d316-1c4b-4281-b951-d872f2087c98

from Routing IDs, instead of using ChildThread::ResolveRoute. This avoids a
potentially unsafe downcast from IPC::Listener* to RenderViewImpl*, if the given
routing_id does not correspond to a RenderView.

BUG=163008


Review URL: https://chromiumcodereview.appspot.com/11316209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170708 0039d316-1c4b-4281-b951-d872f2087c98

An upload of a large file requires multiple requests of ResumeUploadOperation
which should be tested.

BUG=162348
TEST=none

Review URL: https://codereview.chromium.org/11308315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163204
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11418256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170705 0039d316-1c4b-4281-b951-d872f2087c98