GitLab

BUG=http://crbug.com/14144

TEST=click on a tile in the NTP.  Happiness --> window does not auto-hide.

Review URL: http://codereview.chromium.org/125166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18472 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jar
BUG=14138

Review URL: http://codereview.chromium.org/126167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18471 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug where ExtensionHost and ExtensionView weren't getting closed properly when a browser window was closed.

BUG=13975
TEST=see bug for repro steps


Review URL: http://codereview.chromium.org/125164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18470 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus

Some tests fail on mac, disable them.

Review URL: http://codereview.chromium.org/126178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12832

Review URL: http://codereview.chromium.org/126157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18468 0039d316-1c4b-4281-b951-d872f2087c98

Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original author of this code considered the case where VK_OEM_PLUS isn't defined. For example, it seems that 0xbb is VK_EQUAL for embeded environments and VK_OEM_PLUS is never defined.
Review URL: http://codereview.chromium.org/119154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=ExtensionViewTest.Incognito


Review URL: http://codereview.chromium.org/126175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18466 0039d316-1c4b-4281-b951-d872f2087c98

Make XHR work in Workers. Creates a 'shadow page' in a worker process to proxy the loading requests through.
BUG=4361
TEST=none
Review URL: http://codereview.chromium.org/126070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18465 0039d316-1c4b-4281-b951-d872f2087c98

This fixes <http://crbug.com/13805>.

I've filed http://crbug.com/14142 for a more graceful solution.

Review URL: http://codereview.chromium.org/126171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18464 0039d316-1c4b-4281-b951-d872f2087c98

bookmark bar:
- re-show on buttons when done dragging
- match g_object_ref in drag-begin with g_object_unref in drag-end
bookmark manager:
- get rid of default tree view drag handling (we override it all anyway, and it was causing problems)
- fix index out of bounds crash
- when you drag onto a folder, add it at the end of the folder rather than the beginning.

TEST=single bookmark dragging should be fully functional, non crashing
BUG=14019

Review URL: http://codereview.chromium.org/126163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18463 0039d316-1c4b-4281-b951-d872f2087c98

entries needed to permanently fix.

Review URL: http://codereview.chromium.org/125162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/125165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18461 0039d316-1c4b-4281-b951-d872f2087c98

Trivial tweaks to get most of it to build on Linux.

BUG=none
TEST=run ui_tests --gtest_filter=AutomatedUITestBase, verify that six to eight are enabled and all pass

Review URL: http://codereview.chromium.org/125142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18460 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/125163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18459 0039d316-1c4b-4281-b951-d872f2087c98

shelf visible.

We explicitly remove the download shelf view from the browser
view hierarchy during a window close operation. This avoids
calling back into the partially deleted view hierarchy with
download deleted observer notifications. Explicitly removing
the shelf allows the observer notifications to run first while
the views are still valid.


To reproduce:
1. Launch Chrome
2. Open an incognito window
3. Download something in the incognito window
4. The download shelf should become visible with one entry
5. Close the incognito window
6. Crash

BUG=13681 (http://crbug.com/13681)

Review URL: http://codereview.chromium.org/126082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18458 0039d316-1c4b-4281-b951-d872f2087c98

Also move some of the old mocks into their own namespace.  They were causing linker confusion due to inlining or something which generated bad test executables that segfaulted.

Review URL: http://codereview.chromium.org/126170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/126176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18456 0039d316-1c4b-4281-b951-d872f2087c98

Step one of having a completely mocked FFmpeg library.

Review URL: http://codereview.chromium.org/126160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18455 0039d316-1c4b-4281-b951-d872f2087c98

Upgrade BackForwardMenuModelViews to use new menu API. Also adds accelerator to the "Show Full History" item.

This requires bringing the owner-draw system for native menus over from the old code. I haven't really changed anything in it other than the format of dwItemData. This code could be improved/simplified by using gfx::Canvas more, but don't want to do it here.

BUG=none
TEST=make sure BackForwardMenuModel tests still pass, test the menu functionality in the toolbar.
Review URL: http://codereview.chromium.org/126092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18454 0039d316-1c4b-4281-b951-d872f2087c98

Fix connecting_sockets_map_ to get updated before running callback.
BUG=none
TEST=TCPClientSocketPoolTest.RequestTwice
BUG=http://crbug.com/13952

Review URL: http://codereview.chromium.org/126168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=14105
TEST=sh tools/valgrind/chrome_tests.sh --build_dir xcodebuild/Debug --test unit --gtest_filter=RenderWidgetHostTest.Resize
Review URL: http://codereview.chromium.org/126159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18452 0039d316-1c4b-4281-b951-d872f2087c98

the same process.

BUG=13997
Review URL: http://codereview.chromium.org/126067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18450 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scherkus

Updating some more flaky tests.

Review URL: http://codereview.chromium.org/126172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18449 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/125157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18448 0039d316-1c4b-4281-b951-d872f2087c98

Not sure why this happened, but the baselines in my previous commit were off.

TBR=eroman
BUG=none
TEST=build bot.

Review URL: http://codereview.chromium.org/125156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18447 0039d316-1c4b-4281-b951-d872f2087c98

Bump up the default fd limit on the Mac; stopgap fix for page cyclers, but something we want long-term to improve performance once we handle fd exhaustion with delays.

BUG=none
TEST=Launching with --file-descriptor-limit=20 should crash the renderer almost immediately.
Review URL: http://codereview.chromium.org/125151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/122007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18445 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/125145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18444 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10301
BUG=http://crbug.com/10433
BUG=http://crbug.com/10435
BUG=http://crbug.com/8404
R=eroman
TEST=watch the build bot.

Review URL: http://codereview.chromium.org/125140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18443 0039d316-1c4b-4281-b951-d872f2087c98

TBR=stoyan
BUG=http://crbug.com/14132
Review URL: http://codereview.chromium.org/125153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18441 0039d316-1c4b-4281-b951-d872f2087c98

More flaky tests appear to be flaky.

TBR=scherkus

Review URL: http://codereview.chromium.org/125150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18440 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18437 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r18414.
Broke reliability bot.

Review URL: http://codereview.chromium.org/128001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=nirnimesh

Review URL: http://codereview.chromium.org/125146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18435 0039d316-1c4b-4281-b951-d872f2087c98

Add a regression test for 14056. This verifies that HttpNetworkTransaction sets the "referrer" field expected by the DNS prefetch observer.

BUG=14056

Review URL: http://codereview.chromium.org/126112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18434 0039d316-1c4b-4281-b951-d872f2087c98

object-embed-plugin-scripting changed upstream in r44674.  nth-child-dynamic is a new test.

TBR=levin

Review URL: http://codereview.chromium.org/126155


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18433 0039d316-1c4b-4281-b951-d872f2087c98

Defines enums for kParentEntry and kChildEntry in
MemEntryImpl. Also has code in MemBackendImpl to
create a slave entry. Parent entries are non-sparse
entries until sparse API are called on them, and
they would start to keep a list of child entries.
Child entries hold partial content and are not
susposed to be accessible from the public and
are managed by the parent entry that created it.
Child entries are registered in the backend's
ranking list to allow individual eviction. More
details about how child entries are to be used
are in the comments.

TEST=DiskCacheEntryTest.MemoryOnlyEnumerationWithSlaveEntries

Review URL: http://codereview.chromium.org/120004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18432 0039d316-1c4b-4281-b951-d872f2087c98

Some tests appear to be flaky in build bot, adjust their expectations.

TBR=scherkus

Review URL: http://codereview.chromium.org/126142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18431 0039d316-1c4b-4281-b951-d872f2087c98