GitLab

This reverts commit de013df9.

Reason for revert: 
Suspect causing the following failure on Linux ChromiumOS MSan Tests:
CrashRestoreComplexTest.RestoreSessionForThreeUsers:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6545%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrashRestoreComplexTest.RestoreSessionForThreeUsers%2F0

  Uninitialized value was created by a heap allocation
    #0 0xa37813 in __interceptor_posix_memalign /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:165:3
    #1 0x1276df0f in base::AlignedAlloc(unsigned long, unsigned long) ./../../base/memory/aligned_memory.cc:31:7
    #2 0xaab5970 in Message ./../../mojo/edk/system/channel.cc:120:7
    #3 0xaab5970 in mojo::edk::Channel::Message::Message(unsigned long, unsigned long, unsigned long) ./../../mojo/edk/system/channel.cc:74:0
    #4 0xaaf24f0 in make_unique<mojo::edk::Channel::Message, unsigned long &, const unsigned long &, unsigned long &> ./../../buildtools/third_party/libc++/trunk/include/memory:3079:32
    #5 0xaaf24f0 in CreateMessage<void> ./../../mojo/edk/system/node_channel.cc:140:0
    #6 0xaaf24f0 in mojo::edk::NodeChannel::CreateEventMessage(unsigned long, unsigned long, void**, unsigned long) ./../../mojo/edk/system/node_channel.cc:182:0
    #7 0xab389d6 in mojo::edk::(anonymous namespace)::CreateOrExtendSerializedEventMessage(mojo::edk::ports::UserMessageEvent*, unsigned long, unsigned long, mojo::edk::Dispatcher::DispatcherInTransit const*, unsigned long, std::__1::unique_ptr<mojo::edk::Channel::Message, std::__1::default_delete<mojo::edk::Channel::Message> >*, void**, unsigned long*, void**) ./../../mojo/edk/system/user_message_impl.cc:144:33
    #8 0xab3bafd in mojo::edk::UserMessageImpl::AppendData(unsigned int, unsigned int const*, unsigned int) ./../../mojo/edk/system/user_message_impl.cc:465:21
    #9 0xaac2f8c in mojo::edk::Core::AppendMessageData(unsigned long, unsigned int, unsigned int const*, unsigned int, MojoAppendMessageDataOptions const*, void**, unsigned int*) ./../../mojo/edk/system/core.cc:545:16
    #10 0xaaaceb6 in MojoAppendMessageDataImpl ./../../mojo/edk/embedder/entrypoints.cc:96:18
    #11 0x176afb6a in CreateSerializedMessageObject ./../../mojo/public/cpp/bindings/lib/message.cc:93:8
    #12 0x176afb6a in mojo::Message::Message(unsigned int, unsigned int, unsigned long, unsigned long, std::__1::vector<mojo::ScopedHandleBase<mojo::Handle>, std::__1::allocator<mojo::ScopedHandleBase<mojo::Handle> > >*) ./../../mojo/public/cpp/bindings/lib/message.cc:198:0
    #13 0xe293231 in ash::mojom::AppListControllerProxy::ResolveOemFolderPosition(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, syncer::Ordinal<syncer::StringOrdinalTraits> const&, base::OnceCallback<void (mojo::StructPtr<ash::mojom::AppListItemMetadata>)>) ./gen/ash/public/interfaces/app_list.mojom.cc:1004:17
    #14 0x21340e32 in ChromeAppListModelUpdater::ResolveOemFolderPosition(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, syncer::Ordinal<syncer::StringOrdinalTraits> const&, base::OnceCallback<void (ChromeAppListItem*)>) ./../../chrome/browser/ui/app_list/chrome_app_list_model_updater.cc:372:25
    #15 0x21318489 in app_list::AppListSyncableService::ResolveFolderPositions() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:701:21
    #16 0x21315b92 in app_list::AppListSyncableService::HandleUpdateFinished() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:459:3
    #17 0x21311a0d in app_list::AppListSyncableService::BuildModel() ./../../chrome/browser/ui/app_list/app_list_syncable_service.cc:412:3
    #18 0x126f6624 in Run ./../../base/callback.h:95:12

Original change's description:
> Reland "app_list: merge AppListViewDelegate into AppListClientImpl in Chrome."
> 
> This is a reland of db8976b8
> 
> Original change's description:
> > app_list: merge AppListViewDelegate into AppListClientImpl in Chrome.
> >
> > This commit does a few things:
> >
> > - merges the Chrome AppListViewDelegate into AppListClientImpl;
> > - cleans up unused references;
> > - updates methods to proper accesses.
> >
> > Ownership of major classes:
> >
> > - Each user has its own AppListSyncableService, and it holds its own
> >   AppListModelUpdater, ModelBuilders, etc.
> > - There's only one AppListClientImpl in ChromeBrowserMainExtraPartsAsh
> >   shared by all users, and it holds Search classes, a mojo pointer to
> >   the AppListControllerImpl in Ash, etc.
> > - There's only one singleton AppListServiceImpl shared by all users,
> and
> >   it holds AppListControllerDelegateImpl.
> >
> > Their lifecycles:
> >
> > - Among these classes, AppListClientImpl is the first to be initiated,
> in
> >   PreProfileInit. It binds to AppListController in Ash, and then tells
> >   AppListServiceImpl two pointers (AppListController*,
> AppListClientImpl*).
> > - When AppListServiceImpl receives the two pointers, it should have
> been
> >   initiated as a singleton.
> > - The AppListClientImpl is associated with the current active user
> profile
> >   when it's accessed from AppListServiceImpl.
> >
> > Bug: 733662
> > Change-Id: Iac6de011185bf88c4b3c575871b69bd7a67c340b
> > Reviewed-on: https://chromium-review.googlesource.com/974660
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Commit-Queue: Jiaquan He <hejq@google.com>
> > Cr-Commit-Position: refs/heads/master@{#546247}
> 
> Bug: 733662
> Change-Id: Ia779e0ec795a9457dc7214f38b528c2dab688b90
> Reviewed-on: https://chromium-review.googlesource.com/991232
> Commit-Queue: Jiaquan He <hejq@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547956}

TBR=xiyuan@chromium.org,hejq@google.com

Change-Id: Iccc96b53a54fbc46ca02af619c9746079d1ba7f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 733662
Reviewed-on: https://chromium-review.googlesource.com/994438Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#548003}

Virtual keyboard's extension may call this function when controller has
been destroyed(when system switch from virtual keyboard to physical
keyboard) or in full width mode, no need to throw exception in these
cases.

Bug: 825709
Change-Id: I8e565f7b090f619d08814af55450ad0f437486cd
Reviewed-on: https://chromium-review.googlesource.com/994497Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Li Zhao <iloahz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548002}

When I set up the bot I imagined it was a "buildbot" bot, but AFAIK
it will work fine in LUCI as well. Or actually, I have no idea, but
it appears the chromium.linux buildbot waterfall has gone away.

If there's no change needed on the recipe side, this should be
enough to fix it.

Bug: chromium:776284
Change-Id: I3cff6f866a241db1f4a60446480f6f7c40e95ef7
Reviewed-on: https://chromium-review.googlesource.com/991853Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548001}

NavigationPreload is enabled by default[1] and the function is no longer used.

[1] https://www.chromestatus.com/feature/5734842339688448

Bug: 661071
Change-Id: I36955d9458743dc38fda0c31f6900c728b772f94
Reviewed-on: https://chromium-review.googlesource.com/989522Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548000}

Moving the floating keyboard on a secondary monitor did not work well.
The keyboard movement would be bounded to certain nonsensical ranges
that would correspond to the primary display.

Bug: 828701
Change-Id: Ic910ee48d4cfa17b37334b7d9c719090da502414
Reviewed-on: https://chromium-review.googlesource.com/994632
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547999}

Enables heap verification when running in the incremental marking configuration.

No-try: true
Bug: chromium:757440
Change-Id: I4bc75ac0779021e34d0e637192157695567e825c
Reviewed-on: https://chromium-review.googlesource.com/993056
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547998}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I2ab4e22c26cf710fbc22adeb951c1eb12440f354
Reviewed-on: https://chromium-review.googlesource.com/975281Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547997}

The code guide doesn't allow "using namespace", and they have
a tendency to cause problems with jumbo builds so this is just
a cleanup to avoid possible future problems.

Change-Id: I058ed20ba072036b1995cf039ddb3c2ffc884483
Reviewed-on: https://chromium-review.googlesource.com/992952Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#547996}

This is based on:
https://webrtc-review.googlesource.com/c/webrtc.DEPS/+/66463
https://webrtc.googlesource.com/src/+/1d7392a45c95794b385f6a7c3a9dfa5428c4bbed

Bug: webrtc:7602

Change-Id: Id7f0cdb64cc98cc7c561e6cc99ddbb33db58ab92
Reviewed-on: https://chromium-review.googlesource.com/992320Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547995}

This creates problems when running on a case sensitive file system.

When the path of a checkout contains uppercase characters, the
following command fails:

$ gn gen out/win64 --args='target_os="win" target_cpu="x64"'
ERROR at //build/config/win/BUILD.gn:338:27: Script returned non-zero exit code.
vcvars_toolchain_data = exec_script("../../toolchain/win/setup_toolchain.py",
.... src/build/toolchain/win/setup_toolchain.py", line 240, in main
  assert vc_bin_dir
AssertionError

Bug: None
Change-Id: If4c792e9d04d56987a87a55e824d764a1c4e62ed
Reviewed-on: https://chromium-review.googlesource.com/985835Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547994}

The original cl was here:
https://chromium-review.googlesource.com/c/chromium/src/+/990092
This CL fixes the following problems with the original CL:
1. The apk_merger script fails because the unwind tables were only added
   in 32-bit apk. The merger script expects all the files to be same and
   the ones different should be checked.
 1a. The resources.arsc is non-hermetic and ordering is affected by
     adding file to only one apk. As a workaround for crbug/828528,
     add an empty (valid) unwind table file to the 64 bit monochrome
     apk to make the resource.arsc consistent.
 1b. The merger script simply adds all the files in apk which are not
     same. To keep the script simple and functional, the unwind resource
     is renamed to unwind_cfi_32 and unwind_cfi_empty in respective
     builds and the app_merger is updated to specify this file is
     expected to be different and included. This causes an extra file
     (4 byte) in the merged apk.

2. The unwind tables were always generated for "libchrome.so" for all
   chrome apks. The different chrome_apk(s) have different shared
   libraries like libchromefortest, etc.. So, update the unwind asset to
   get unwind table for the right library for each apk. Only adds assets
   to *_public_apk(s).

3. The monochrome_apk_checker was failing because the unwind file
   included was different in chrome_apk and monochrome_apk. This CL adds
   the asset to all apk at the same time and adds exception for this
   file.

BUG=819888
TBR=dpranke@chromium.org

Change-Id: Ibceeeacc19fa424d519891b8c17e349ee6c2dfd6
Reviewed-on: https://chromium-review.googlesource.com/991236
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547993}

This patch removes flag-specific expectation files that are
the same as the on in parent chains (platform/linux, platform/win,
or generic.)

This can happen when once rebaselined, but the actual images get
back to the original and rebaseline again, or rebaseline occurred
in parent after flag-specific rebaselines.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I30b71082585604a68ca082b56a3a2c66ac50ffe6
Reviewed-on: https://chromium-review.googlesource.com/994436
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547992}

According to the spec [1], shorthands with pending-substitution values
should be serialized as empty strings. Only shorthands which were
specified with explicit var() references should be serialized to the
original value. Update our implementation to match this.

[1]: https://drafts.csswg.org/css-variables/#variables-in-shorthands

Bug: 687653
Change-Id: Icb3acdcc88452a32077fe7f67ecc6c3614b4d91c
Reviewed-on: https://chromium-review.googlesource.com/994734Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547991}

This patch adds an interface for updating the Crostini App Registry
over D-Bus at org.chromium.VmApplicationsService:UpdateApplicationList.

The proto is being added in:
https://chromium-review.googlesource.com/q/I05b05f03

Bug: 821662
Change-Id: I7effada1c0de237ef3ec49da84d5c1f76415781e
Reviewed-on: https://chromium-review.googlesource.com/965803
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547990}

This patch changes "remove-list-from-range-selection.html" to utilize
|selection_test()| for ease of maintenance.

Note: "remove-list-from-range-selection.html" is failed on layout_ng bot
du by pixel test.

Bug: 679977, 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1c3257701ae53ceacbb651ca544925d982a30e5d
Reviewed-on: https://chromium-review.googlesource.com/991625
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547989}

This reverts commit 605ee933.

Reason for revert: The overall approach is hacky and has introduced too many regressions.

Original change's description:
> Change TranslateHelper to use a textContent-like text dump
> 
> Currently, TranslateHelper caputres page innerText to decide the
> page language. The text capturing is done in
> RenderFrame::DidMeaningfulLayout(), in which we normally have the
> clean layout, which is necessary for computing innerText.
> 
> However, due to some layout bug [1], we don't always have clean
> layout at the call site. As fixing the layout bug is hard, this
> patch changes the text capture algorithm to return a string similar
> to textContent [2] instead, which doesn't require clean layout.
> 
> The difference between the new and old text capture is subtle:
> 
> - textContent may include invisible text nodes, while innerText never
>   does that. However, this patch uses a slightly modified textContent
>   that doesn't include text nodes in STYLE or SCRIPT elements.
>   Other invisible text may still be included.
> 
> - textContent is a simple concatenation of all text nodes. innerText
>   does some "formatting" by inserting/deleting some whitespace
>   characters, including:
>   - Insertion of '\n' between blocks of text (e.g., between <div>)
>   - Insertion of '\t' between table cells
>   - This patch uses a custom dump algorithm that still collapses
>     consecutive whitespaces; however, the collapsing happens regardless
>     of style
> 
> [1] crbug.com/803403 and crbug.com/585164. The crash happens in the
>     wild, but we haven't even found a stable repro case yet.
> 
> Bug: 803403
> Change-Id: I7e108d368cbcaccbbb60582323a9e9e041d95269
> Reviewed-on: https://chromium-review.googlesource.com/891582
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Rachel Blum <groby@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536969}

TBR=toyoshim@chromium.org,groby@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,napper@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 803403
Change-Id: I15189591a99f40ad105f32ccc75de8bd008aa998
Reviewed-on: https://chromium-review.googlesource.com/994712Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547988}

Existing code performs bidi adjustment for 'unicode-bidi: plaintext' only
for the right edge of InlineBoxes. This patch makes it handle both edges
to allow caret to appear at the left edge.

This patch also makes the bidi adjustment code symmetric for left and
right edge handling, so that we can de-duplicate in future refactoring.

Bug: 828657, 771398
Change-Id: I3fd22280327c7186fcfddfb0ba1bb13c4a5dfeff
Reviewed-on: https://chromium-review.googlesource.com/994389Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547987}

This value is logged when the user quits the app during in-progress
downloads.

Bug: 981327
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If19c9e16045ab0af2af1a77a941df843cc6fdeb8
Reviewed-on: https://chromium-review.googlesource.com/987200
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547986}

A new method is added to the Aura shell interface. When client call this
method, the startup ID is set as a property on the Aura window.
This is going to be used to identify a specific virtual machine
applications that a window is for.

TEST: still compile.
Bug: 828147
Change-Id: If86547f4a58ca7793887acfdbb7f6eb0036bf761
Reviewed-on: https://chromium-review.googlesource.com/990791Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547985}

Change ChromeDriver build bot setting for Windows, to generate
full symbols.

Change-Id: I31ea9abd5ff619f12f15da8ef46ad01590f162a3
Reviewed-on: https://chromium-review.googlesource.com/994735Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547984}

This CL imposes a limit on the maximum number of page patterns an extension can
whitelist using the chrome.declarativeNetRequest.addWhitelistedPages API. This
limit is currently set to 100. A new property MAX_NUMBER_OF_WHITELISTED_PAGES is
introduced in the declarativeNetRequest API for the same.

It is important to limit this since the whitelisted patterns are stored in the
browser memory (and also persisted across sessions using Extension preferences).

BUG=811460, 696822
Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing

Change-Id: I674da154107ac06269827272576f1af911f13338
Reviewed-on: https://chromium-review.googlesource.com/987392
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547983}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b9e32970..69d8b7f7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I9cc5ca1cc6d66d307e476a5e39980e8202fb5332
Reviewed-on: https://chromium-review.googlesource.com/994156Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547982}

HTMLSlotElement starts to detect unsupported member functions being called
after https://chromium-review.googlesource.com/c/chromium/src/+/989525.

This CL avoids a crash by early return.

Note that *distributed nodes* are a kind of old-fashioned concept after Blink
supports slots-in-flat-tree. We might want to remove that in the future.

Bug: 776656
Change-Id: Ibe8c4cf935a7f03fe4e716b6877b9bdb8b964983
Reviewed-on: https://chromium-review.googlesource.com/992075
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547981}

This reverts commit 8bc8a796.

Reason for revert: It broke some tests on waterfall bots.
 
Original change's description:
> [PE] Change CHECK to LOG(WARNING) in PaintController::FindOutOfOrderCachedItemForward
> 
> The situation doesn't cause corrupted rendering but just slightly
> affects performance. It's fine not to DCHECK given that the situation
> is rare.
> 
> Bug: 805024
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Iac8cd617d5df51da2516fc6a9df1308a0daaedd0
> Reviewed-on: https://chromium-review.googlesource.com/990074
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547923}

TBR=wangxianzhu@chromium.org,pdr@chromium.org

Change-Id: If8c1dcd5e7d2f89ba688eadec9d3d047df777055
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805024
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/994338Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547980}

The flag kIgnoreOverflowClipAndScroll can be passed to PaintLayerClipper
to compute clip rect in the space of the scrolled box of the root layer.
This is done by first computing clip rect in the space of the border box,
then apply an anti-scroll to the rect if the rect was affected by the
scroll.

Prior to this CL, the condition that determines whether the anti-scroll
is needed was incorrect. It used a function that determines whether two
layers can ever have relative movement upon scrolled, and is allowed to
return false positive. This CL instead traverses the layer tree to see
whether the root layer is a part of the containing block chain.

BUG=825543

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ifec0bddb9511aa3b878cc0757bb8fb6f59cfb0ab
Reviewed-on: https://chromium-review.googlesource.com/987319Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547979}

In crrev.com/547515 I removed this block of code from
ChromeViewsDelegate::CreateNativeWidget:

  if (params->context)
    params->context = params->context->GetRootWindow();

The Screencastify extension uses DesktopMediaPickerDialogView, which
apparently supplies a context window with no parent. We were relying
on the code above to make params->context null so it would trigger a
fallback code path.

It's not clear why that code was added in the first place. It
appeared in https://crrev.com/230793 as part of a revert of some
RLZ refactoring. However, we depend on the code now, and I cannot
guarantee that all browser code supplies a context with a valid
root window, so put it back.

TBR=oshima@chromium.org

Bug: 828626, 311339
Test: none
Change-Id: I70b9a884fdf471d34d626237b72b92325cba5df8
Reviewed-on: https://chromium-review.googlesource.com/994461Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547978}

https://skia.googlesource.com/skia.git/+log/c0528e2418e0..42f8bc40fd37

$ git log c0528e241..42f8bc40f --date=short --no-merges --format='%ad %ae %s'
2018-04-03 khushalsagar Add API for SkTextBlob serialization into caller's memory.
2018-04-03 herb Clean up buffering and serializatoin.
2018-04-03 egdaniel Check if fan point is finite in GrAAConvexPathRenderer.
2018-04-03 caryclark fix global method indentation
2018-04-03 caryclark fix SkImageInfo indentation
2018-04-03 mtklein limit cpu features of skcms on bots we limit skia
2018-04-03 egdaniel Drop draw in GrAAConvextPathRenderer if calculation of center of mass ends up in NaN
2018-04-03 kjlubick Improve MSAN docs
2018-04-02 bungeman Hardcode a font for lcd testing on MacOS.
2018-04-03 mtklein remove CC,CXX,CPPFLAGS from compile environment
2018-04-03 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 2fd9445b9..770177dc9 (1 commit)
2018-04-03 egdaniel Check for divide by zero in fill_in_2D_gaussian_kernel
2018-04-02 brianosman Remove legacy API support from Flutter
2018-04-03 egdaniel Check for divide by zero in fill_in_1D_gaussian_kernel
2018-04-03 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 6c4b7c42f..2fd9445b9 (1 commit)
2018-04-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 30b604d8d..5d232d53b (1 commit)
2018-04-02 caryclark fix pathop fuzzes
2018-04-03 kjlubick Move oss-fuzz to MockGPUCanvas
2018-04-03 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ b21124236..6c4b7c42f (1 commit)
2018-04-03 caryclark update autogenerated includes
2018-04-03 caryclark fix bugs exposed by documenting SkImageInfo
2018-04-03 egdaniel Allow for divide by zero in miter calculation in GrAAConvexTessellator
2018-04-03 senorblanco GrTessellator: fix for points that become infinite on stroking.
2018-04-03 kjlubick Catch infinite numbers in computeMatrices
2018-04-03 bsalomon Increase precision in GrSRGBEffect
2018-04-03 jvanverth Add SkOffsetSimplePolygon.
2018-04-03 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 75dc22828..b21124236 (1 commit)
2018-04-03 robertphillips Fix non-GPU release bots
2018-04-02 bsalomon Speculative fix for crbug.com/823920

Created with:
  roll-dep src/third_party/skia
BUG=chromium:822218,chromium:823920


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Icf13588f60da5904b13fd14f4c6e042f7a0b10b6
Reviewed-on: https://chromium-review.googlesource.com/994708
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547977}

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I603c9303c30f6054c175b6ef0c21e2bbd7c0c893
Reviewed-on: https://chromium-review.googlesource.com/971162Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547976}

Also, rename the following functions as follows:

- SlotAssignment::RecalcAssignmentNg => SlotAssignment::RecalcAssignment
- SlotAssignment::RecalcAssignment => SlotAssignment::RecalcAssignmentForDistribution

No behavior change.

Bug: 776656
Change-Id: I9b13f2c840533299c670a08d1015524e0d71824d
Reviewed-on: https://chromium-review.googlesource.com/992078Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547975}

This CL relands the conversion which failed due to Windows bots trying
to run the compilation without Java. A GN flag has since been added
which fixes the issue.

Original: https://chromium-review.googlesource.com/c/chromium/src/+/954822

Bug: 632206
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iee3e684bd66873deaab742ad9d545a8c1b8dd8ce
Tbr: dpapad@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/985712Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547974}

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I2470b02838678052524ab146fe3438a885e7799e
Reviewed-on: https://chromium-review.googlesource.com/994540Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547973}

Re-enable all GalleryBrowserTestInGuestMode tests, listed below, which
were disabled in issue 804413 due to linux-chromeos-release bot flakes
on the CQ. (Guest mode RenameImageOnDownloads disabled on issue 508949
before issue 804413).

  GalleryBrowserTestInGuestMode.RenameImageOnDownloads
  GalleryBrowserTestInGuestMode.
      CheckAvailabilityOfShareButtonOnDownloads
  GalleryBrowserTestInGuestMode.ResizeImageOnDownloads

Bug: 804413, 508949
Change-Id: I254a9597c7fdd727cfb888db4c552cc3ad67b0a6
Reviewed-on: https://chromium-review.googlesource.com/992592Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547972}

It was suggested to make the parent OmniboxResultView the recipient
of button presses. This CL makes that change, and minor clean up to
privatize methods which no longer need to be public.

Bug: 780835
Change-Id: If124040f26a41839fad9518bac1be23c3f52cf88
Reviewed-on: https://chromium-review.googlesource.com/990788
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547971}

For steady state elisions, we currently unelide when the user places
the caret in the URL or makes a partial selection. This restores hidden
schemes and hides the security chip.

However, we don't re-elide in any circumstances currently, even if the
user has made no edits.

This CL re-elides on blur if the user has not made any edits, and
also restores the security chip.

One more note: This CL subtly changes the behavior even with steady
state elisions off. It will revert and re-show the security chip on
blur if the user adds and then deletes a character to the URL
(restoring the original URL). This seems like a harmless and slightly
beneficial change.

Bug: 797354
Change-Id: I87966e388034ed0573756e9f7985540dc4315c83
Reviewed-on: https://chromium-review.googlesource.com/993696
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547970}

These 4 tests:
  fast/clip/overflow-border-radius-combinations.html
  fast/clip/overflow-border-radius-composited.html
  fast/clip/overflow-border-radius-composited-parent.html
  fast/clip/overflow-border-radius-transformed.html
hit a bug in Blink where it fails to apply line-height quirks
as described in crbug.com/828457, and that they fail in LayoutNG
which applies line-height quirks.

https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk

Because these tests are not important for testing the line-height
quirks, this patch changes them to the standard mode so that they
do not hit the bug.

Rebaselines are not needed, because the line-height quirks are
not applied to the expected images.

Bug: 828457
Change-Id: Ic6ad43996210e64a366f521db789d96857ee3108
Reviewed-on: https://chromium-review.googlesource.com/993112Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547969}

This reverts commit 11df4514.

Hooked up CupsPrintersManager to receive update callbacks whenever the
value of the UserPrintersAllowed pref is changed. If the pref is set to
false then CupsPrintersManager will disallow any changes made to
non-enterprise printers.

Bug: 827016

Change-Id: Ibcb047f12e0db6414a25e32e5c9909608979c828
Reviewed-on: https://chromium-review.googlesource.com/992857
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547968}

Testers:
 * "Mac Debug (Intel)"
 * "Mac Retina Debug (AMD)"

R=hinoka@chromium.org

Bug: 790067, 790068, 790070
Change-Id: If54ce561654e263ae906bb38add92efe54eaa924
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/994259
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547967}

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

Bug: 646113,799482

Change-Id: Ic8f6b1f4c120bfd7d57e045a68eb1921b8e6ab5d
Reviewed-on: https://chromium-review.googlesource.com/987238
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547966}

- Implements the changes from crrev/c/991253 to the new HistoryCoordinator.

Bug: 805190
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5b7f47e1f5a706fb15e6833a4c0c01efe8f1ff96
Reviewed-on: https://chromium-review.googlesource.com/994131Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547965}

This cl reorders the functions in search_box_view to make the
readability better.

Bug: 828603
Test: manual.
Change-Id: Ic2fa5c7bb0852504a4b1056d66f60ed7800c9c66
Reviewed-on: https://chromium-review.googlesource.com/994134Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547964}