- 13 Mar, 2020 40 commits
-
-
Thomas Guilbert authored
This reverts commit bbe1b84e. Reason for revert: We no longer have 3 API OWNER LGTMS Original change's description: > [video-raf] Enable video-raf by default > > This CL turns on HTMLVideoElement.requestAnimationFrame() by default. > > Spec: https://wicg.github.io/video-raf/ > Blink-dev intent-to-ship: https://wicg.github.io/video-raf/ > WPT: https://wpt.fyi/results/video-raf > > Bug: 1012063 > Change-Id: I5f44a430078e8272d2f9ebb1482e11e936697fb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101242 > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749965} TBR=kbr@chromium.org,chrishtr@chromium.org,tguilbert@chromium.org Change-Id: I0af2785d83863dea9943a491c3679874de0b8cb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103391Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#750291}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1b6a171ee02..a8c95f74dac6 git log b1b6a171ee02..a8c95f74dac6 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 jmadill@chromium.org Update export_targets to fix presubmit on Windows. Created with: gclient setdep -r src/third_party/angle@a8c95f74dac6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ie099dcff7b6f9a2d415dbff5b1e60c2d6e9fcb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750290}
-
Aaron Leventhal authored
Any non-elements can use the standard layout tree builder traversal to find accessible children. Non-elements include text nodes, and most importantly, the #document node, which is the kRootWebArea. This change only affects <dialog>, but it's an improvement. Previously, a <dialog> would be added as a child in two places: - As a child of the root node, because of layout traversal - As a child within its actual DOM structure Fortunately, it does not show up in the Blink tree twice, because BlinkAXTreeSource has a !IsParentUnignoredOf() which ends up not adding the DOM structure <dialog> child. However, this double adding of children blocks landing of a chain of other fixes necessary to avoid accidental resets of the accessible tree during serialization. NOTRY=true Bug: None Change-Id: I1ebb0ee4d7cdaea285773d391b3e73c0f1ecdb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101325 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750289}
-
Tricia Crichton authored
Enable 2 tests to check an diagnose flakiness. Bug: 1036055, 1036636 Change-Id: I7f79bdf1b21bf29e393af2ea30e34c538ed94b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103027Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#750288}
-
Nico Weber authored
No behavior change. Bug: 346399 Change-Id: I9d9e855d94fc646faecd69580ef280a6763ba28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102631 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#750287}
-
Sam Bowen authored
Bug: 1044253 Change-Id: I652f04d2e7ced7a5289a4d6d0dcef2e577e7a570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076084 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#750286}
-
Christian Biesinger authored
If the override height is indefinite, this function should return true. This fixes the case of max-height: xx% on a replaced item in a flexbox, which otherwise would get resolved to 0 because resolving the percentage for replaced items would convert negative numbers to 0. Fixed: 1048051 Change-Id: I192e65b37a3670226fa764662448bdb4216c9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100771 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#750285}
-
Johannes Henkel authored
Upstream PR: Introduce a crdtp/dispatch.{h,cc} library. https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680 New Rev: 8c2064ea99cffdb5647760ad3953c43e612e07fc Notable downstream changes: - ChromeDevToolsManagerDelegate::HandleCommand no longer carries a method. Reason being, the shallow parser (crdtp::Dispatchable) should be efficient enough to parse an incoming message a couple of times, e.g. once for the content layer and once for the embedder, and if we felt differently then we'd quite possibly want to carry more than just the method - e.g., we'd want to also pass the params. Anyway, for now simplifying this interface. - crdtp::FrontendChannel::FallThrough; here, it's advantagueous to keep the method around, but now it's a crdtp::span. This is much better than const std::string& because the generated code knows exactly which method is going to fall through and we can pass a C++ string literal via this span. - The crdtp/dispatch library presents a somewhat different surface between the UberDispatcher and the session implementations. The session implementations are responsible for creating a crdtp::Dispatchable instance (the shallow parser) which it then hands to the dispatcher for dispatching. Rather than querying for whether it can dispatch and then doing it, the result of the Dispatch indicates whether a method was found and can be executed. There's no more need to instantiate protocol::Value in a devtools session class. - Since the dispatch library uses crdtp::span to represent method names, we no longer need to reference platform specific routines for finding strings and making substrings. As a result, v8_inspector_string.h is losing a few more methods (and same for base_string_adapter_h.template). - crdtp::DispatchResponse (also known as protocol::Response) has some renames for consistency ( Response::Error -> Response::SeverError, Response::OK -> Response::Success). Touches all domain handlers but is mechanical. - All protocol error messages, such as the parameters passed to DispatchResponse::ServerError are required to be UTF8 strings, even for Blink, so when code generates them as WTF::String, we convert them to std::string using WTF::String::Utf8() before passing them to DispatchResponse::ServerError. - We're better about checking messages and sending errors when we can't parse them - esp. we no longer drop messages on the floor if we can't make sense of them; the LOG statements are gone, because we can either send an error or assume that we've previously parsed the message elsewhere and put a DCHECK (e.g., a message received by blink has always been shallow-parsed by the browser before). - DevToolsAgentHost::DispatchProtocolMessage no longer has a boolean return value. Reason being, it's not well defined what the boolean should indicate. If we reject the message and send an error, arguably we've also handled it. And of course, we always do that (now). So it's not useful to generate or check this return value, and there is only one DCHECK on it currently, which is also not covered by tests. - content::DevToolsSession uses binary searches to match method names (e.g. in ShouldSendOnIO). This is because I've switched the method names to span, and implemented similar searches for the dispatching library, so it's best to be consistent. It will also scale better if we add more methods. - The additional unittests added to the CRDTP library upstream cover shallow parsing, dispatching, etc. and are now also part of the content_unittests. - Improves Android binary size by about 36k, by reducing code duplication. There's now just one UberDispatcher, for example, as opposed to one for blink, one for content, one for headless, one for chromium, ... - Speeds up execution by 1-2% (based on internal measurements), because message serialization no longer takes a detour via protocol::Value. Change-Id: I422fe527d6f8a6ffb098b3992728ecba408b571f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047966Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#750284}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b8bae186cbec..be4a731fe43b git log b8bae186cbec..be4a731fe43b --date=short --first-parent --format='%ad %ae %s' 2020-03-13 amaiorano@google.com BUILD.gn: add missing dependency onto marl for SubzeroReactor 2020-03-13 capn@google.com Consistently use TRUE/FALSE in CMakeLists.txt 2020-03-13 capn@google.com Exclude all static libraries from "all" build target 2020-03-13 amaiorano@google.com Subzero: replace Win32 fibers with Marl for couroutines Created with: gclient setdep -r src/third_party/swiftshader@be4a731fe43b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5d3191fc206d56ba3f28363c452c1186cfcf697a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103041Reviewed-by:
-
Shimi Zhang authored
- addWebMessageListener() - removeWebMessageListener() Bug: 918065 Change-Id: Id271f328224942edb962a29fe44617240aa18a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099233Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#750282}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b45bb3bba858..9fd413dec7c0 git log b45bb3bba858..9fd413dec7c0 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 crouleau@chromium.org [Catapult] Update OWNERS files. Created with: gclient setdep -r src/third_party/catapult@9fd413dec7c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:949246 Tbr: rmhasan@google.com Change-Id: Ie9cfaab0feea3e0826e0f88a2aff48f8f53160fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103251Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0bbeee05c7a1..a7657e4fa2fe git log 0bbeee05c7a1..a7657e4fa2fe --date=short --first-parent --format='%ad %ae %s' 2020-03-13 rharrison@google.com Rolling 2 dependencies (#999) Created with: gclient setdep -r src/third_party/shaderc/src@a7657e4fa2fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I75760ddabeda32191e167c91be8ac38f866059c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103042Reviewed-by:
-
Andrew Xu authored
Bug: 1058589 Change-Id: I4b3685014e7714b42aa65640890d94fbdbd4f5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102639 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750279}
-
Benoit L authored
This reverts commit 8e6f8572. Reason for reland: The dependency which broke was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2093606 Original change's description: > base/android: Remove linker tests support. > > The linker tests don't run on bots (and likely not locally either) and > do not support the latest library loading patterns. This is the first > step to remove them, as they add non-trivial complexity in the codebase. > > Bug: 1059707 > Change-Id: Ia14693419792f57dc4f65b2fc7f999e833aec42e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095059 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748365} Bug: 1059707 Change-Id: I3ad7347fdf4868d83ebf1895bee1bd85940ea324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098785Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#750278}
-
Piotr Bialecki authored
Change-Id: I845e082ca413bcfa19a5ca4e06f587ebcb2cb254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101713 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#750277}
-
Daniel Rubery authored
Enterprise deep scanning for DLP violations has a specific list of supported file types and the policy BlockUnsupportedFiletypes should determine whether to blocked files not on that list. This CL introduces a new download danger type for files blocked for that reason so that we can, in future CLs, add UX specific to those files. It also generates this danger type when appropriate, but uses the generic blocking UX. Bug: 1060853 Change-Id: I6a670664d766bed860625cabcbd0d0e9a142e38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101294 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750276}
-
Oksana Zhuravlova authored
TBR=jbudorick@chromium.org Bug: 1061539 No-try: true Change-Id: I4039c07fb0e14ad1dd755cdf55576c1ffe591b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102763Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#750275}
-
S. Ganesh authored
IUpdater::UpdateAll now takes an IUpdaterObserver interface that it will eventually use to sink events. Bug: 1053729 Change-Id: I2a2a9813e2b33c4496b286329084b0e21478ba9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101934 Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750274}
-
Mario Sanchez Prada authored
This CL starts converts the message that notifies the browser process about renderer accessibility events, as well as the ACK response sent back to the renderer process once the original message is handled. Bug: 1010831 Change-Id: I435a29c176cb029cf3e419e0a4934b6c65554c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050316 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750273}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d806b9daa24..41b7ff99df43 git log 4d806b9daa24..41b7ff99df43 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 kayce@google.com Update the What's New UI for Chrome 82 2020-03-13 tvanderlippe@chromium.org Add tooltips to extra network panel settings Created with: gclient setdep -r src/third_party/devtools-frontend/src@41b7ff99df43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:986998 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I77af6bf98cf80abed1c130fe92d7322b550096a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103037Reviewed-by:
-
Adithya Srinivasan authored
Adds a PORTAL_ACTIVATED generated event and handles it on Mac by dispatching the load complete notification which ensures the page gets focus (and VoiceOver also navigates through all the elements on the page, similar to what happens after a regular navigation). Bug: 1057804, 1045608 Change-Id: I2ca343e141c1011a862dd0f5bccd9b329e8f8498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050603 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
-
John Budorick authored
Follow up to crrev.com/c/2095448 Bug: 1060280, 1061511 Change-Id: Idf000e44348a779b0205e9cee610e359cf702e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103132Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750270}
-
Raymond Toy authored
The pause_cb_ Closure is a OnceClosure. Change Pause() and Flush() to take a OnceClosure. This fixes text_render.cc not to use Closure. Every instance is now either RepeatingClosure or OnceClosure. Bug: 1007799 Change-Id: I6ad66ccb149cac914325da98da2f4c0a3965fd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095709Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#750269}
-
Maggie Chen authored
|has_hw_overlay_support_| in the DC overlay Processor is updated after display change. This cap is queried directly from direct_composition_surface_win. All the other overlay_support capabilities which are used for passing data have been removed. |use_dc_overlays_for_video| is removed from |capabilities| of gles2_cmd_decoder and gles2_cmd_decoder_passthrough. |supports_dc_video_overlays| is removed from |capabilities| of output_surface. Bug: 1042989 Change-Id: I9fcfd0a0e9e2e19db00ea0418cfd299e17664cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068920Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#750268}
-
Matthew Mourgos authored
This change adds metrics, for the gesture navigation screen, which records the amount of time that each individual page is shown to the user (pages include Intro, Home, Overview, and Back). Bug: 1055690 Change-Id: Iddc76fc5f3b1666813693418b51ae943eec067fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098770Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750267}
-
Michael Thiessen authored
Bug: 1061460 Change-Id: I5d5c585ff3cecae9ac69c12737130bda89257b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102778Reviewed-by:
-
Hesen Zhang authored
- Defined QueryTile proto and in-memory struct. - Defined a collection_store interface. - Implemented QueryTileStore. TODO in next CLs: proto_conversion, query_tile_store_unittest, query_tile_group_manager(tree operations). Bug: 1060805c Change-Id: I6da3c9be67b34843594476ae1c1302206a19f1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099228 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
David Bokan authored
In https://crrev.com/4d25b125dae5 I changed the scroll tree parenting logic so that elements in position:fixed subtrees have the LayoutView's ScrollNode as the scroll parent. This made sense since scrolling over a fixed element should cause the document to scroll. However, this is slightly different from how the transform tree looks. Because scrolling the document doesn't cause position:fixed eement so translate, these nodes don't have the LayoutView's ScrollTranslation transform node as an ancestor. As a simple example, a scrolling document with a position:fixed <div> scroller will generate the following scroll and transform trees (approximately): *ScrollTree* *TransformTree* Root Root | | VisualViewport Translation VisualViewport | / \ LayoutView Translation / \ | Fixed LayoutView Fixed Scroller Translation The situation above makes sense for what parent-child relationships mean in each tree: the scroll tree encodes how scrolls chain; scrolling on a child should bubble up to its parent in this tree. The transform tree encodes the physical effect of scrolling a node. In the above example, scrolling from the fixed scroller should bubble up to the LayoutView (when the scroller is fully scrolled) but scrolling the LayoutView will not cause movement of the fixed scroller. The above makes sense but caused sticky code to get confused. A sticky constraint is attached to the scroll translation node. With the above situation, this meant that inside a fixed subtree, we'd attach it to the VisualViewport's scroll translation node. This was unexpected; the constraints are in "document coordinates", meaning that to translate them into the viewport space we must apply the scroll offset [1]. The compositor would use the visual viewport's (typically 0) scroll offset to adjust these values, leading to incorrect calculations. This previously worked because the scroll node used in a fixed subtree would be the visual viewport (before the CL mentioned at the top). In [2] we check whether the current overflow clip is also our scroller, prior to the CL this check have failed because "our scroller" was the visual viewport but our clip was the LayoutView. Now they are both the LayoutView. The fix in this CL is to make the check in [2] more stringent; we also want to make sure that our scroller is the nearest scroller in the transform tree. That is, if we scroll it, will we cause the current node to move? If not, we don't need a sticky constraint on the compositor because user scrolling can't change the sticky's offset relative to its clip. [1] https://cs.chromium.org/chromium/src/cc/trees/property_tree.cc?l=321&rcl=628f869d1fda631a85f051ad13b5d278319298fc [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc?l=553&rcl=99a5a1266f303ba6ae46174a2b4cbd165ea7e934 Bug: 1019142 Change-Id: I781943ff43514905d399803c780c6081d7d47e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097542Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750264}
-
Mustafa Camurcu authored
Extend metrics Arc.Runtime.Performance.* until 2021-03-11 TEST=None Bug: b/151314714 Change-Id: Ib07a54a2f162e8bedde7944262e146c89dcc1186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101721 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#750263}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef7ec269b5b5..034b5438d90f Created with: gclient setdep -r src-internal@034b5438d90f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047357 Tbr: jbudorick@google.com Change-Id: I7c6dbc2abb8e7b2a7f8c318dcaf2ea47460e1100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103032Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750262}
-
Mustafa Camurcu authored
Extend metric Arc.PlayStoreShown.TimeDelta until 2021-03-11 TEST=None Bug: b/151314714 Change-Id: Ia5e9320858138a4e6d7f12d0d77cbf2a7f587efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101545 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
-
Sinan Sahin authored
Today, most parts of the code assume the browser controls min-height is 0. This causes issues with the layout size and the fullscreen mode. The most obvious issues currently are: - If a min-height is set, ChromeFullscreenManager#controlsResizeView() always returns true since the controls aren't completely hidden. - Similarly if a min-height is set, position: fixed elements are sized as if the controls are fully showing. This CL changes the "browser controls resize/shrink blink" logic to try and fix the issues listed above. With the changes in this CL, the controlsResizeView bit will be false if the controls are at the min-height. Bug: 1049301 Change-Id: Ieb95e92c983b56b42a640f726c60c2eec9964064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048276 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750260}
-
Mustafa Camurcu authored
Extend metrics Arc.PlayAutoInstallRequest.* until 2021-03-11 Bug: b/151314714 Change-Id: Id7734c89b42aa1122762a82f76b49bd80fd3df77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101543 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
-
Sebastien Marchand authored
This uses the Clang profiling config during the instrumentation step of a PGO build. This allows getting the profiling data out of the sandboxed processes. This is not an ideal end state, ideally the coverage configuration should be refactored and things common to the two configurations should be moved to a new base config. This requires to use the new version of goma, see go/ma-rbe-dogfood (see crbug.com/990981#c26 for more details). To build a PGInstrumented build (first step to do a PGO build) compile with the following GN args: is_component_build = false is_debug = false chrome_pgo_phase = 1 use_goma = true Bug: 1056189 Change-Id: I717efdcbb6993ad574acce4c0f91eb5fb5bf3972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076424 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750258}
-
Jon Mann authored
When Wi-Fi sync is first enabled and a list of synced networks has to be merged with the local networks on a device, use the last connected timestamp to decide which configuration should be used. Bug: 966270 Change-Id: Id7688a0fdb9e7922cee8ffec0ef69b804436e3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093274Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#750257}
-
Jeff Yoon authored
The iOS tests were being run as gtests, but with the isolated merge script because of iOS' output format (standard JSON output). Moving them to use isolated_scripts instead, as it shortens the definition in test_suites.pyl, and accomplishes the same. Bug: 1055164 Change-Id: Icffb1a1cf72681e2ad08c5a3031d50e842a003f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100714Reviewed-by:
-
Mustafa Camurcu authored
Extend lifetime of Arc.IconLoadFromFileTime.* metrics until 2021-03-11 Bug: b/151314714 Change-Id: I2252633d23d8747fd6731f2d4eb3ef69709e550e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100636 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
The first ever default desk created after boot should not trigger any UMA stat reporting. The histograms are deprecated, and replaced by Ash.Desks.NewDesk2, and Ash.Desks.DesksCount2 respectively. BUG=1060709 Change-Id: I09f851009aa05a71e73e914692919d2f8150344e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095973Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#750254}
-
Mustafa Camurcu authored
Extend lifetime of Arc.FirstAppLaunchRequest.TimeDelta metric until 2021-03-11 Bug: b/151314714 Change-Id: I8308e1684468acc8aef37927d40e529ffd05249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100948 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies LeakDetectionRequest to explicitly check for HTTP_TOO_MANY_REQUESTS, indicating the user ran out of quota. It modifies corresponding enums and introduces an optional LeakDetectionError to the LookupSingleLeakCallback, so that the error can be forwarded to consumers like the Password and Safety Check. Bug: 1061108 Change-Id: I86d561b47bbf39e996a425dbd3459eb8bbda52ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100941 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750252}
-
