- 02 Oct, 2014 40 commits
-
-
chrome://settingsvitalyp authored
R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default Review URL: https://codereview.chromium.org/604373006 Cr-Commit-Position: refs/heads/master@{#297882}
-
stgao authored
Two bug fixed: 1. NormalizePath for components. 2. Add expected line separators in reasons. NOTRY=true Review URL: https://codereview.chromium.org/617073010 Cr-Commit-Position: refs/heads/master@{#297881}
-
enne authored
WebViewImpl always makes a root layer in layout, but not all RenderWidgets do. Instead, only DCHECK if there's a readback request. R=jamesr@chromium.org BUG=397321,419644 Review URL: https://codereview.chromium.org/622823002 Cr-Commit-Position: refs/heads/master@{#297880}
-
John Abd-El-Malek authored
BUG=414808 R=maruel@chromium.org Review URL: https://codereview.chromium.org/626553002 Cr-Commit-Position: refs/heads/master@{#297879}
-
avayvod authored
BUG=418653 NOTRY=true The change to report the histogram is here: https://chrome-internal-review.googlesource.com/#/c/178316/ Review URL: https://codereview.chromium.org/620893004 Cr-Commit-Position: refs/heads/master@{#297878}
-
mathp authored
BUG=None Review URL: https://codereview.chromium.org/626513002 Cr-Commit-Position: refs/heads/master@{#297877}
-
ranj authored
Sync wallpaper in storage onchange events, will also upload wallpapers to server when user set custom wallpaper BUG=416566 Review URL: https://codereview.chromium.org/597503007 Cr-Commit-Position: refs/heads/master@{#297876}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/9ccd091..08d02d1 TBR=eustas@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/622433004 Cr-Commit-Position: refs/heads/master@{#297875}
-
fsamuel authored
This test coverage already exists in chrome and extensions now. BUG=330264 Review URL: https://codereview.chromium.org/617123005 Cr-Commit-Position: refs/heads/master@{#297874}
-
reveman authored
Add initial implementation of CHROMIUM_gpu_memory_buffer_image. This extension will replace current usage of CHROMIUM_image and CHROMIUM_image will later become the more generic extension that can be used by clients that need more control over GpuMemoryBuffer instances. BUG=418553 Review URL: https://codereview.chromium.org/617693003 Cr-Commit-Position: refs/heads/master@{#297873}
-
sandersd authored
BUG=224786 Cr-Commit-Position: refs/heads/master@{#297523} (cherry picked from commit 2983dc91) Review URL: https://codereview.chromium.org/617333003 Cr-Commit-Position: refs/heads/master@{#297872}
-
clamy authored
This CL moves the navigation logic for PlzNavigate from RenderFrameHostImpl to NavigatorImpl. The logic for selecting a RenderFrameHost for the naviagtion remains in RenderFrameHostManager. BUG=376006,376091,376014 Review URL: https://codereview.chromium.org/615633005 Cr-Commit-Position: refs/heads/master@{#297871}
-
maniscalco authored
Remove incorrect mention of RefCountedThreadSafe from DeleteSoon's comment. Replace mention of PostDelayedTask with ReleaseSoon in ReleaseSoon's comment. BUG= Review URL: https://codereview.chromium.org/615693002 Cr-Commit-Position: refs/heads/master@{#297870}
-
sievers authored
This functionality can be implemented with sync point callbacks. Now that swap completion is entirely an implementation detail of the OutputSurface this also allows for eliminating some IPC message redundancy. Ideally SwapCompletion would be unsolicited and also include LatencyInfo (where needed/supported). Also remove the message pattern matching logic in gpu_channel.cc for Flush/Echo. This kind of matching does not work reliably, since OnMessageReceived races with HandleMessage (i.e. the next msg might or might not be in deferred_messages_). Also, the original motivation in bug 407529 is described as making sure SwapBuffers gets handled immediately, which was separately fixed by merging the LatencyInfo with the Flush IPC. BUG=417945 Review URL: https://codereview.chromium.org/619453002 Cr-Commit-Position: refs/heads/master@{#297869}
-
rdevlin.cronin authored
Both these switches should be removed, as they allow malware to potentially install extensions on a user's computer. Since the --install-from-webstore switch is also being used to install ephemeral apps, rename it to --install-ephemeral-app-from-webstore, and ensure that this only works on installed ephemeral apps on Windows. (This has sufficient checks in place, such as an extension of the same ID already being installed, that this is safe.) BUG=410833 Review URL: https://codereview.chromium.org/617833003 Cr-Commit-Position: refs/heads/master@{#297868}
-
yusufo authored
We need to start using this method for testing purposes downstream but without the annotations it is getting stripped our by proguard. BUG=372774 Review URL: https://codereview.chromium.org/615843004 Cr-Commit-Position: refs/heads/master@{#297867}
-
anton authored
This removes the need to use the previous "rezip" tool in the build process. That tool is still used in the LGPL compliance script, which will need to be addressed separately. BUG=390618, 388223 Review URL: https://codereview.chromium.org/608853005 Cr-Commit-Position: refs/heads/master@{#297866}
-
tfarina authored
Inital commit: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 The first attempt was reverted because there was no ui_base_unittests_disabled file to disable the test on Android like there was for ui_unittests. Reverted by: https://crrev.com/79c886b2fa50d0634d8d8a84903f9a9ea96f5471 The fix for the revert was made by commit at https://crrev.com/4642d9377d3044c81d0f32298ba0c203976c8cc9 BUG=331829, 373148, 299841, 103304 TEST=None R=sky@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/621963002 Cr-Commit-Position: refs/heads/master@{#297865}
-
noms authored
This menu should look like the Mac one, and have a list of profiles, with a checkmark for the active profile, and Edit/Add Person buttons. Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMVmhCMXFpQUFSVDQ&authuser=1 BUG=404662 Review URL: https://codereview.chromium.org/617963005 Cr-Commit-Position: refs/heads/master@{#297864}
-
alexmos authored
This was causing failures in NavigateToURL for a few content_browsertests when running under --site-per-process. BUG=417518 Review URL: https://codereview.chromium.org/625483002 Cr-Commit-Position: refs/heads/master@{#297863}
-
siva.gunturi authored
This variable is unused, this can be removed. Review URL: https://codereview.chromium.org/618693003 Cr-Commit-Position: refs/heads/master@{#297862}
-
dbeam authored
- chrome/browser/resources/chromeos - ui/login R=nkostylev@chromium.org BUG=419091 Review URL: https://codereview.chromium.org/618163002 Cr-Commit-Position: refs/heads/master@{#297861}
-
hanxi authored
This is due to the include of "extensions/grid/extensions_resources.h" in extension_api.cc. The missing this dependency was already introduced in gn build (https://codereview.chromium.org/596003002/) but not in the extensions.gyp. The missing dependency will fail to build app_shell. BUG=352293 Review URL: https://codereview.chromium.org/619303002 Cr-Commit-Position: refs/heads/master@{#297860}
-
dtrainor authored
Certain versions apparently crash when pulling theme string information in TextView. To attempt to fix this (since it's difficult to reproduce), try to revert the string usage to the old version. BUG=416692 NOTRY=true Review URL: https://codereview.chromium.org/608853007 Cr-Commit-Position: refs/heads/master@{#297859}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/48c0239..9ccd091 TBR=eustas@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/625613002 Cr-Commit-Position: refs/heads/master@{#297858}
-
brettw authored
This is the new GN name for this variable. TBR=scottmg Review URL: https://codereview.chromium.org/620193002 Cr-Commit-Position: refs/heads/master@{#297857}
-
vitalybuka authored
There is no reason to hide private API. BUG=394124 Review URL: https://codereview.chromium.org/611163003 Cr-Commit-Position: refs/heads/master@{#297856}
-
samuong authored
[chromedriver] Disable large data transmission tests on Android (chrome_shell/chromedriver_webview_shell) BUG=chromedriver:913 Review URL: https://codereview.chromium.org/619873005 Cr-Commit-Position: refs/heads/master@{#297855}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/29fe24c..6bd4196 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/620153002 Cr-Commit-Position: refs/heads/master@{#297854}
-
kelvinp@chromium.org authored
See failure logs at http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%282%29/builds/55548 and at the attached bug below. TBR=jam@chromium.org BUG=419769 Review URL: https://codereview.chromium.org/623573003 Cr-Commit-Position: refs/heads/master@{#297853}
-
yefim authored
TBR=asvitkine@chromium.org BUG= Review URL: https://codereview.chromium.org/619163002 Cr-Commit-Position: refs/heads/master@{#297852}
-
dominicc authored
The API use is checked on the Blink side, so these checks are to thwart corrupted renderers. Specifically, renderers that try to register, unregister or get registrations for non-secure origins must be nuked from orbit. It's the only way to be sure. BUG=394213 TEST=content_unittests ServiceWorkerDispatcherHostTest.* Review URL: https://codereview.chromium.org/618113005 Cr-Commit-Position: refs/heads/master@{#297851}
-
jkarlin authored
Revert of Stitch ServiceWorkerCache between renderer and browser. (patchset #8 id:140001 of https://codereview.chromium.org/580063003/) Reason for revert: Trybot tests were stale. Need to rebase and land again. Original issue's description: > Connect the ServiceWorkerCache functionality between the renderer and the browser. > > BUG=392621 > > Committed: https://crrev.com/a934835ea3e3091dc6f57681e5af74c257acd01f > Cr-Commit-Position: refs/heads/master@{#297848} TBR=michaeln@chromium.org,horo@chromium.org,tsepez@chromium.org NOTREECHECKS=true NOTRY=true BUG=392621 Review URL: https://codereview.chromium.org/623703004 Cr-Commit-Position: refs/heads/master@{#297850}
-
jdduke authored
Custom Android OS flavors often tailor themed resources, sometimes in a way that Chrome does not expect or cannot anticipate. As a fallback measure, acquire the selection handle resources from the unthemed context resources when themed resource loading fails. BUG=416081 Review URL: https://codereview.chromium.org/614463002 Cr-Commit-Position: refs/heads/master@{#297849}
-
jkarlin authored
BUG=392621 Review URL: https://codereview.chromium.org/580063003 Cr-Commit-Position: refs/heads/master@{#297848}
-
derat authored
Remove dependencies on Chrome resources from extensions.gyp. BUG=397250 Review URL: https://codereview.chromium.org/615913003 Cr-Commit-Position: refs/heads/master@{#297847}
-
jkarlin authored
BUG=418700 Review URL: https://codereview.chromium.org/617263002 Cr-Commit-Position: refs/heads/master@{#297846}
-
Mark Mentovai authored
BUG=419723 R=pinkerton@chromium.org Review URL: https://codereview.chromium.org/625593002 Cr-Commit-Position: refs/heads/master@{#297845}
-
rkc authored
This is a race condition that gets triggered if we get *both* audible and inaudible directives in the same instruction. This causes us to encode both the tokens, but when ProcessNextTransmit gets called after the samples for the first token are received, it tries to play the other type of token also (for which samples may not have been received yet). The simplest way to fix it is adding a HasKey check to the cache for both types of tokens. We will get called after each of the samples tokens are added to their respective caches, so if we skip playing one particular type of token (since it hasn't landed in its cache yet), we will get called again after it gets added to its cache, so both the tokens will definitely play. R=xiyuan@chromium.org BUG=419585 Review URL: https://codereview.chromium.org/614903007 Cr-Commit-Position: refs/heads/master@{#297844}
-
hirono authored
The BUG 419364 was solved by crrev.com/297660. BUG=419364 TEST=None Review URL: https://codereview.chromium.org/618653003 Cr-Commit-Position: refs/heads/master@{#297843}
-