- 09 Oct, 2020 40 commits
-
-
Sorin Jianu authored
This CL introduces a --tag command line argument and handing of metainstaller tags. If the tag is present in the metainstaller, then the tag is extracted, and the updater is invoked with --tag. This removes the hardcoded --install command line argument that the metainstaller had temporarily used so far. For now, the metainstaller could be invoked in one of the following ways: 1. sign and tag it (using the steps in the design doc), then run it without arguments. 2. run it with --tag=appguid={8A69D345-D564-463c-AFF1-A69D9E530F96} 3. run it with --install --app-id={8A69D345-D564-463c-AFF1-A69D9E530F96} There is a fix in the sign.py script to copy the build contents instead of compressing them, to keep the repacked archive similar to what it was before signing. The metainstaller code does understand BCJ (but it understand BCJ2) so in the future, if compression is needed, use BCJ2 and LZMA. Bug: 1128751 Change-Id: I368a3c5f05f7b091f860c0953ed062630832261a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463524Reviewed-by:Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815747}
-
rbpotter authored
Add input_files and input_files_base_dir arguments for generate_grd, to allow inclusion of files that are not preprocessed and therefore included in the manifest in the grd file. Additional updates to generate_grd: - Rename rollup files that aren't shared.rollup.js - Set file type in the grd as "chrome_html" for HTML/JS files - Adding tests Started from: https://chromium-review.googlesource.com/c/chromium/src/+/2443211 by dpapad@ Also removing some unnecessary kGeneratedPath constants from various Web UI controllers that have been updated to use autogenerated grd files. These autogenerated files contain resource_path properties for each <include>, so stripping the generated portion of the path in webui_util.cc is no longer necessary. Bug: 1132403 Change-Id: Ia707d48fe348b168dce6bf806099ffd209385bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463333 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815746}
-
Zhenyao Mo authored
Currently we have a DCHECK for the returned result. If it ends up failing, then the event wait is forever. BUG=1060785,1077725 R=sunnyps@chromium.org Change-Id: I574831aef3cecab6989f4bd0ec5ce79512472f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463529 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#815745}
-
Yu Su authored
We want to run experiments to set Youtube iOS network traffic as NET_SERVICE_TYPE_AV. Thus we want to make Cronet be able to set iOS socket network service type by using the experimental option from a cronet application. Bug: 168256315 Change-Id: Id6371be70323c3ece724d8d33bd89395cd99211f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461041Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#815744}
-
David Roger authored
This CL adds more logging to understand the circumstances of a profile being deleted. In particular, it adds a metric Profile.DeleteProfileContext and a histogram suffix Profile.State.*_UponDeletion. Bug: 1136483 Change-Id: I10204a435012ad64b67061e5050d9eec2c28da84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461230Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815743}
-
Becca Hughes authored
Adds the variations header that communicates experiment state to the server. This will be used for launch gating. Change-Id: If0b8d3175bd4856a0e255d67792da424f0ce80bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463551 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815742}
-
Ken Rockot authored
Generated JS bindings will unconditionally attempt to send a response when a message implementation resolves the response promise. If the corresponding endpoint has already been closed, this send will fail with a cryptic error due to some partially destroyed state within InterfaceEndpointClient. This change makes InterfaceEndpointClient tolerate such uses by silently ignoring them. Fixed: 1136949 Change-Id: I3102d6b8f96d9d0e5683c9c497eb7b6f22b12be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463586 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815741}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ief4d0b5df967bda4a2f9fde0746f57d443d3d1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460871 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815740}
-
Mason Freed authored
Now that [1] Web Components V0 has been completely disabled, these V0-only tests can be removed, and the virtual test suite can also be deleted. This is a *very* large CL, but it only consists of file deletions. Three folders contain most of the deleted tests, but there are also a few from the http/tests/* folders. Here is the complete list: web-components-v0-only/* virtual/web-components-v0-disabled/* http/tests/htmlimports/* http/tests/custom/xhr-response-does-not-have-registry.html http/tests/custom-elements/no-registry-test.html http/tests/devtools/import-open-inspector.js http/tests/devtools/elements/html-link-import.js http/tests/devtools/elements/styles-3/style-rule-from-imported-stylesheet.js http/tests/devtools/network/network-imported-resource-content.js http/tests/devtools/resource-tree/resource-tree-htmlimports.js http/tests/linkHeader/link-rel-import-css-rule-capital.html http/tests/security/contentSecurityPolicy/nonces/import-enforce-allowed.php http/tests/security/contentSecurityPolicy/nonces/import-enforce-blocked.php http/tests/security/contentSecurityPolicy/nonces/import-multiple-allowed.php http/tests/security/contentSecurityPolicy/nonces/import-multiple-blocked.php http/tests/security/contentSecurityPolicy/nonces/import-reportonly-allowed.php http/tests/security/referrer-policy-attribute-import-no-referrer.html http/tests/subresource_filter/resource-in-import-disallowed.html [1] https://chromium-review.googlesource.com/c/chromium/src/+/2195005 Fixed: 1081941 Bug: 937746 Change-Id: Iec984fb1caed708a6d7959fe153426e59ffadf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454693Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#815739}
-
Mario Bianucci authored
This is a reland of 1d11f9fd The original CL was reverted because of InputHandlerProxyEventQueueTest.VSyncAlignedGestureScrollPinchScroll failing on ChromiumOS MSan builders. This test was flaky in the exact same way prior to my change according to the flakiness dashboard, and ASan and TSan variants are already disabled for what is likely the same issue. The tests fails at roughly the same rate both with and without this CL. Therefore, I spoke with the reverter and we decided it was acceptable to disable the test on MSan. It is disabled on ASan and TSan via crbug.com/1029250, and I will leave a comment there about MSan also being disabled. Original change's description: > De-couple PredictionMetricsHandler from specific histograms > > PredictionMetricsHandler appears to be designed to work for anything > that is predicting points. However, it currently only reports metrics > in the Event.InputEventPrediction.Scroll* histograms. De-couple the > class from these histograms so it can be used for things only than > scroll metrics. > > Bug: 1133785 > Change-Id: Ib34129fc46b20b45810cbd5ca195483e88c513e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441197 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Mario Bianucci <mabian@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#813813} Bug: 1133785 Change-Id: Id02ea108e0f74f4f454049b5957bb7f10287cc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451591Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815738}
-
Prakhar authored
This is mirrored by mac-rel (https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipe_modules/chromium_tests/trybots.py;l=1118;drc=eec8bcd5de88cb9da93b59ed44fa13b9303dfc0f) Bug: 1024915 Change-Id: Iac6ef3b406e599418d182eca88ca5107bd8e4b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462985 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#815737}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3c2e9be46bc..99db0de96759 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lukasza@google.com,flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: lukasza@google.com,flackr@google.com Change-Id: I451429bdd94e9dedf0a81ff9789b11d9f067dd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461700Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815736}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I0f845c83261144b9b50c1ac5adbe30ce89dd2576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450324 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#815735}
-
Zentaro Kavanagh authored
Bug: None Change-Id: I6b8a5d16916b8d6487740c6985fab8a2619ae4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462937Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815734}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If9b702ac703b1f39677358c64ab9661b0126ed1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815733}
-
Steven Bennetts authored
CaptivePortalProvider was introduced to support networking.config which was only integrated into a handful of extensions in the web store, none if which have significant active usage. See issue for details. This CL removes the code from the UI. The API itself will be removed in a follow-up. Bug: 1124419 Change-Id: I7f4e1d2e4389a9940afce6dbdba1067f4635de1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443393 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815732}
-
Mason Freed authored
Previously, there was an anonymous <div> in the shadow dom for the <summary> element, which caused display:contents to not behave in an interoperable way. See [1] for a spec PR that clarifies the spec, and this CL matches the new clarification. The new WPT added here passes already on Gecko and WebKit. [1] https://github.com/whatwg/html/pull/4746 Fixed: 973074 Change-Id: Iba54616c4e54e357dd71b7de30de18bde8ff3983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462217 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#815731}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c251d370b65e..0ad07c924552 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic16f162c74de57851f95592b413cf5aa269d3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463762Reviewed-by:
-
Vadim Bendebury authored
BUG=none TEST=none Change-Id: I9d3cb3fc39a010653aedfdf701b66e6956aa31c5 Signed-off-by:
Vadim Bendebury <vbendeb@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446453Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815729}
-
ckitagawa authored
More gracefully handle OOM in allocating bitmaps by replying with an error rather than crashing. Bug: 1136929 Change-Id: Ic1c47089623e813415cf270bd506b1aab12509a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461805Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815728}
-
Koji Ishii authored
When |NeedsRecomputeVisualOverflow|, r736422 crrev.com/c/2025389 added a workaround to set |NeedsLayout| for legacy objects. But when r740231 crrev.com/c/2046983 changed the condition, it accidentally included LayoutNG |LayoutInline|. This patch fixes the condition to exclude it. Note the fix is limited to FragmentItem as recent ink overflow fix is only applied to FragmentItem. Bug: 1128199 Change-Id: I3c909c3ae176b6c58b4f29f91a3f188feff69eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426147Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815727}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/723d5437e6a0..5a23b9436269 2020-10-09 chrche@microsoft.com Fixing two localization presubmit issues 2020-10-09 tvanderlippe@chromium.org Update Rollup config to allow for multiple entrypoints in a module 2020-10-09 alexrudenko@chromium.org Enable TypeScript for SensorsView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1131500,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic63a3a90278cd6298281af7ccc5e4d649d898ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463723Reviewed-by:
-
Phillis Tang authored
This fixes a bug that we don't call callbacks when neither shortcuts nor run on os login are going to be uninstalled. Bug: None Change-Id: If75611847d06623cafc2405d4e94f9a343ff6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462688Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815725}
-
Garrett Beaty authored
The branch selectors have been modified to refer to a single category (main, standard branch, LTS branch) and the functions have been modified to accept either a single selector or an iterable of selectors with composed selectors being defined. Change-Id: I4d3ad265b62875ec91c6869ffdb35bc85bb652db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462220 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#815724}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.14-r1 to 87-4265.0-1601895675-benchmark-88.0.4285.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I962f9099ded2cd603a36774b612490cb977f31cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463733Reviewed-by:
-
Eric Lawrence authored
The GetConstantsForNetLog function is dead code with no callers. This CL removes it. Bug: 1136617 Change-Id: I06edfe5873e8dd3fd4254e941b64d11529a98a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461901Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815722}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e611beb18340..e9879d106b95 2020-10-09 wenbinzhang@google.com [benchmarking] Stop checking achives for skipped stories If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1136227 Tbr: sadrul@google.com Change-Id: I7bda6f0e52de3da9f3730313f398904a81648fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463722Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.14-r1 to 87-4265.0-1601892862-benchmark-88.0.4285.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7ad90d356afbda9611e17c41cc2b010a627eb061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463731Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.14-r1 to 87-4265.0-1601890590-benchmark-88.0.4285.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia4c087220c4937318b9a89c75732fd9ac15ac3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463532Reviewed-by:
-
Sergey Ulanov authored
content_shell runs https stack, so it depends on the root certs. Bug: 1067477 Change-Id: I84ef67be195870488e886afe2dee9c182bb62e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447038 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#815718}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07b0b1dc..e4ed803f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifcadac29a122c1a22c5ab749e372d066e09aceee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463662Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815717}
-
Michael Bai authored
Previously, the internal class which extends AutofillPopup uses a copy of suggestions when it is created, the copy one won't be changed when suggestions changed. This patch adds the suggestion array as data member, so the internal class will always refer the latest suggestions. Bug: 949555, 1136585 Test: verified manually Change-Id: I4f300be648af4038c7b26f115161d8e56b9575b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462336Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#815716}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c251d370b65e..0ad07c924552 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8e4588571b6e08eef4c8fd16813881e15d4502e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463476Reviewed-by:
-
Collin Baker authored
Adds two metrics logged every 5 minutes: * Per-thumbnail compressed data memory usage * Total compressed data memory usage The former has a sample for each thumbnail every 5 minutes, while the latter has exactly one every 5 minutes. Bug: 11261624 Change-Id: I1595c6a6b771f73e3be9a5497d1cf6f6ec3d1af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462685Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815714}
-
Monica Basta authored
For the profiles that use generic colored avatar, 'OnProfileAvatarChanged' needs to fired for the avatar icon to be updated across different UIs on theme color changes. This CL doesn't handle the switch between light/dark mode that also has an effect on the avatar icon. Bug: 1136851 Change-Id: I11acfffea825bcc87f41640986bb1e3f1858bc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461320 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Lijin Shen authored
TBR=twellington@chromium.org Bug: 1136923 Change-Id: Ideaca2e918c8e70ea42cebd9011b858be344439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462949Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#815712}
-
James Cook authored
browser_tests disable all crosapi calls and do not call LacrosChromeService::Init(). LacrosChromeServiceImpl::init_params_ is therefore "null". However, because LacrosInitParams is a small mojo struct, it is an InlinedStructPtr, and init_params_.get() returns a non-null pointer. This means existing code in lacros can call LacrosChromeServiceImpl::init_params() and get a non-null value. A later CL increases the size of LacrosInitParams, so it cannot be inlined. This causes browser_tests failures because init_params() starts returning null. We want some value for InitParams in tests. Therefore create a default-constructed version in tests. Bug: none Change-Id: I3ee0b15a276d0f04fc024ba3fbd7d2d1a892a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463568 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815711}
-
Gouarb Kundu authored
This change removes the pp::Var dependency from core PDF code by replacing pp::Var with base::Value and converting it to pp:Var at the caller end. This consists of modifying the PDFEngine::GetBookmarks() and the related methods to use base::Value instead of pp::Var. Bug: 1113523 Change-Id: Ia5fbf216b840bee138202e891200e51c10fc6594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428353 Commit-Queue: Gourab Kundu <gourabk@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815710} -
Kartik Hegde authored
Match the mojom definition. TEST=none Bug: chromium:956783 Change-Id: Ie662c3af2776556cdf96aa05928b9e7cf7dc2e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462298Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#815709}
-
Martin Kreichgauer authored
It wrongly asserted that the key size equals the shared secret size, when Authenticate() may also be called with a pinUvAuthToken, which can be any multiple of 16 bytes in legth. Also tighten up parsing of authenticator responses to ensure pinUvAuthTokens are of a valid length for the chosen protocol version. Bug: 1129946 Change-Id: I6d96307159d4e543e1a4f2bf7efa5e2ddefe7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463236Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#815708}
-
