GitLab

Since the recommendation app can be shown in both suggestion chip and zero state UI with different dimension, I added a chip_icon in SearchResultMeataData, so that we can load the icons in different dimension without resizing loss.

TBR=jianli@chromium.org

Bug: 880979
Change-Id: Ibbea1d22eae7c15268bafb1fcca6c9211385b6ed
Reviewed-on: https://chromium-review.googlesource.com/1220813
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593309}

BUG=762641
TBR=stevenjb@google.com, tbarzic@google.com

Change-Id: I6699cead1fbbfefdb38c306b941526cf988bb552
Reviewed-on: https://chromium-review.googlesource.com/1237864Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593308}

Bug: 875032
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I087bd6a9b62f05ccb853db4e5b04639fab0e4e83
Reviewed-on: https://chromium-review.googlesource.com/1238795Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593307}

AbsoluteBoundingBoxRectForScrollIntoView and associated helpers did not
compute the correct bounding box for SVG shapes (or anything but the SVG
root.)
Compute the bounding rect using the stroke bounding box.

Bug: 803440
Change-Id: If25ca98b686f17a0db699e569460cb4c276f06a0
Reviewed-on: https://chromium-review.googlesource.com/1238458Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#593306}

There is no need to call SetNeedsPushProperties on each individual
setter on LayerImpl, so remove them.

LayerImpl's needs to push property status is only useful when they are
on pending tree and waiting to push its properties during activation.
With PropertyTrees, the change to trigger a LayerImpl's need to push
properties on pending trees come from only the main thread's commit.
Since Layer pushing properties to LayerImpl SetNeedsPushProperties on
LayerImpl, there is no need for each individual setter on LayerImpl to
set that status again.

R=enne

Bug: 854256
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3cfc0e3898deb6ae08a88c1f715d035dea624c9b
Reviewed-on: https://chromium-review.googlesource.com/1234999Reviewed-by: enne <enne@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593305}

What: Expand the WebCore.Framebust metric to also measure if the frame
initiating the navigation is an ad frame.

Why: It might be a good idea to prevent framebusting from same-origin
ad iframes without user gesture. This measurement will tell us how
common it is.

Bug: 885146
Change-Id: I6366094b119b6f220ac1a01ea43662423dc961ee
Reviewed-on: https://chromium-review.googlesource.com/1238778
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593304}

- Require minimum height equal the height of the favicon for the vertical stackview in TableViewUrlCell
- If title and host aren't available, use full url spec.

Screenshot: https://drive.google.com/file/d/1C19zooJG80phfS6gDiCnMZQa2NZJd9zA/view?usp=sharing

Bug: 878833
Change-Id: I11e91f583f014f88a208478bef767cb70972ce7b
Reviewed-on: https://chromium-review.googlesource.com/1235319
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593303}

We've seen some anecdotal evidence in local testing that mojo::DataPipe
creation can sometimes take milliseconds to complete.  Currently there
is a pipe created on the ServiceWorker thread for certain FetchEvent
respondWith() code paths.  This histogram will help us determine if
this is introducing jank on the service worker thread.

Bug: 888045
Change-Id: I5f36da2dfbde4bd561c605336949e475f45ecb43
Reviewed-on: https://chromium-review.googlesource.com/1239274Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593302}

Postpone Login WebUI initialization if Oobe is not completed until
OOBE configuration check is complete.

Bug: 854101
Change-Id: If9f7bba80d048d28b8cf17ef57b1558742e7a765
Reviewed-on: https://chromium-review.googlesource.com/1203977
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593301}

This rule was causing @MainDex methods to be obfuscated, even when they
were marked as -keep by a previous rule.

Turns out that this rule is entirely unnecessary for maintaining
@MainDex annotations anyways.

Bug: 887954
Change-Id: I3f371d4c24f91e217494f02b45e9401a8628688a
Reviewed-on: https://chromium-review.googlesource.com/1238784Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593300}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39707b216ffe..fd14ee29e129


Created with:
  gclient setdep -r src-internal@fd14ee29e129

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If8371db0ba1be53bdea290035bd06eed87351cc5
Reviewed-on: https://chromium-review.googlesource.com/1239164Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593299}

https://android.googlesource.com/platform/external/perfetto.git/+log/69356444050a..cd5e40e994a7


git log 69356444050a..cd5e40e994a7 --date=short --no-merges --format='%ad %ae %s'
2018-09-21 hjd@google.com Merge "trace_processor: Stop confusing upid with utid in systrace parsing"


Created with:
  gclient setdep -r src/third_party/perfetto@cd5e40e994a7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I72c844d7100cf53558f2f5e5b648514edf01cb2f
Reviewed-on: https://chromium-review.googlesource.com/1238841Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593298}

It's been deprecated for a while, this CL finally gets rid of it.

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icc06af298f2e46252b2bc3e7ac73b25c66f3fd26
Reviewed-on: https://chromium-review.googlesource.com/1235209Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593297}

Add a new -force-tablet-power-button flag that instructs
the ash::PowerButtonController class to use tablet
power button behavior (i.e. tapping the button turns the
screen off) regardless of whether the device is in tablet
mode or laptop mode.

session_manager will pass this flag on system images
built with the touch_centric_device USE flag.

Bug: 887506
Change-Id: Ib43aad1862172bf1ff8e68e573709a55a8b0c125
Reviewed-on: https://chromium-review.googlesource.com/1237523Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593296}

Give inline space to some vectors (for the full list of flex items
and the violations); these are only kept on the stack, so this won't
affect memory usage.

And uses a new "FlexItemVectorView" class for storage on the FlexLine
instead of copying the items into a new vector for each line.

R=dgrogan@chromium.org,mstensho@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2f60b6de254bc40653379d4eac6f49754b144474
Reviewed-on: https://chromium-review.googlesource.com/1237411
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593295}

in the case of kNavigationPolicyCurrentTab policy. That happens
in a number of cases: loading mhtml archive, about:srcdoc, about:blank,
empty url, renderer debug urls, urls with chrome-native:
or about: scheme.

It would be ideal to get rid of this behavior, but that requires
some investigation. For now, we'll just make it explicit by calling
CommitNavigation from RenderFrameImpl. As a first step, switching
to CommitNavigation in FrameLoader.

Bug: 855189
Change-Id: Id1c5b00c8294b1890a60703f966e5134c5720380
Reviewed-on: https://chromium-review.googlesource.com/1232202
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593294}

This will make the information available on the server more up to date
with the device, since scheduled status reports may not happen once
screen is locked.

Bug: 882597
Change-Id: Idaac23348ae003039308e179daca0e40d8253ac6
Reviewed-on: https://chromium-review.googlesource.com/1236853Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Bruno Santos <brunoad@google.com>
Cr-Commit-Position: refs/heads/master@{#593293}

If FillModesetBuffer fails, clear the modeset buffer to black
to avoid displaying an uninitialized framebuffer.

BUG=b:78892556

Change-Id: Ie3281302117f72bc9ed38ce68e6697b402809256
Reviewed-on: https://chromium-review.googlesource.com/1237142Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593292}

We have two version of a lot of methods: method and methodPromise.
It makes searching of methods usages in codebase a little harder, this
CL replaces all callback based methods with promisified one.

R=luoe@chromium.org

Bug: none
Change-Id: If30da32e1b062734d7db54b9c5a87ece73ef1d39
Reviewed-on: https://chromium-review.googlesource.com/1235212Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593291}

gfx::Canvas has DrawCircle etc. functions that take cc paint flags.
These functions are used for painting in a few places in ash.
ash already has a build-time dependency on //cc/paint.
Just allow cc/paint deps in ash.

Bug: none
Test: checkdeps
Change-Id: I7ddd8dc9cb43d0ab73b4b4435678ae87e3259c67
Reviewed-on: https://chromium-review.googlesource.com/1238447Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593290}

- Move tests from virtual/threaded/fast/animationworklet to animations/animationworklet
- Change virtual test suite to use the animations/animationworklet directory instead
- Remove assumption in WorkletAnimation that we always have threaded compositing enabled.

The above change, allow AW test to run without threaded compositing forcing main thread
animations. Without any other change, 16/28 tests pass. The rest are added to expectations
file where we can start investigating them.


Bug: 887659
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I820e0c8fc317ce718aea48d8fc441f5541766abd
Reviewed-on: https://chromium-review.googlesource.com/1237235Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593289}

On Windows, assigns an accelerator to the Context Menu command that shows
the Emoji panel, both for the native Textfield's context menu and the
render_view's context menu.

The shortcut is "Win" + "Period"

Bug: 880653
Change-Id: Ic6f41762c5903c2984bce93a5ac3185dc41e7199
Reviewed-on: https://chromium-review.googlesource.com/1235220Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593288}

MultiDeviceSetupImpl accepts SecureChannelClient as a constructor argument,
but never uses it.

Bug: 874283
Change-Id: Ie748eee5ed0852ff57f80144376038f7f51f1860
Reviewed-on: https://chromium-review.googlesource.com/1238294Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#593287}

Rebaseline some interfaces/properties that have been exposed in Chrome and
should also be exposed in Android WebView. In particular:
- AbortController, AbortSignal
- Sensor API related interfaces:
  -- e.g. Sensor, Accelerometer, Gyroscope, OrientationSensor, ...
- Web Audio related interfaces modifications:
  -- e.g. BaseAudioContext, AudioParamMap, AudioContext.baseLatency,
  -- e.g. AudioListener.position*, AudioParam.automationRate, ...
- Canvas interface related modifications:
  -- e.g. CanvasRenderingContext2D.filter, ...
- New DOM geometry primitives:
  -- e.g. DOMMatrix, DOMPoint, ..
- New Document/Element/Event related methods/attr:
  -- e.g. Document.linkColor, Document.onpointermove, Document.onvisibilitychange
  -- e.g. DocumentType.replaceWith
  -- e.g. Element.slot, Element.computedStyleMap
  -- e.g. Event.composed
- FontFace related modifications:
  -- e.g. FontFace.display
- FormData modifications:
  -- e.g. FormData.values..
- Gamepad API related:
  -- e.g. Gamepad.vibrationActuator, GamepadHapticActuator
- HTML element related modifications:
  -- e.g. HTMLAnchorElement.referrerPolicy, HTMLAreaElement.download,
  -- e.g. HTMLBodyElement.onafterprint, HTMLCanvasElement.captureStream
  -- e.g. HTMLElement.autocapitalize, HTMLFrameSetElement.onmessageerror
  -- e.g. HTMLImageElement.decoding, HTMLSlotElement
- IndexedDB API related modifications:
  -- e.g. IDBCursor.continuePrimaryKey,
  -- e.g. IDBKeyRange.includes, IDBObjectStore.name
- new Image interface attrbiutes/methods:
  -- e.g. Image.align, Image.decode, ImageData.data,..
- KeyboardEvent modifications:
  -- e.g. KeyboardEvent.isComposing, KeyboardLayoutMap
- Media* related modifications:
  -- e.g. MediaSource.onsourceclose, MediaStreamTrack.getCapabilities,
  -- e.g. MediaStreamTRackEvent
- Network Information API modifications:
  -- e.g. NetworkInformation.downlink, NetworkInformation.rtt
- Node and NodeList modifications
- Option interface modifications
- Performance Timeline API related e.g.:
  -- e.g. PerformanceLongTaskTiming, PerformanceNavigationTiming,
  -- e.g. PerformanceObserver, PerformancePaintTiming, PerformanceServerTiming, ...
- Streams API modifications:
  -- e.g. ReadableStream.pipeTo
- Fetch API modifications:
  -- e.g. Request.cache, Request.destination, Response.redirected
- SVG DOM interface modifications:
  -- e.g. SVGElement.dataset, SVGElement.onpointermove
  -- e.g. SVGImageElement.decoding
- ServiceWorker updates:
  -- e.g. ServiceWorkerContainer.controller, ServiceWorkerRegistration.active
- Other modifications:
  -- SourceBuffer and SourceBufferList changes
  -- URL.searchParams, URL.sort
  -- webkitRTCPeerConnection modifications.
  -- e.g. Path2D.addPath
  -- SecurityPolicyViolationEvent.sample, Selection.removeRange
  -- AnimationEvent.pseudoElement

This patch also removes some deleted interfaces/attributes:
  -- e.g. Attr.nodeValue, ClientRect, DataView, FileError,
  -- e.g. HTMLKeygenElement, NodeFilter, ReadableByteStream,
  -- e.g. webkitAudioContext, webkitOfflineAudioContext,
  -- e.g. webkitIDB* interfaces
  -- e.g. global Bluetooth* attributes

Also replace previously 'attribute' properties which have been replaced
by getters/setters:
  -- e.g. applicationCache, navigator, ondevicemotion,
  -- e.g. document, isSecureContext, onload, ...

BUG=867450

Change-Id: I509b6744a6206a57543ff858a4fd4cbf7754f91a
Reviewed-on: https://chromium-review.googlesource.com/1154910Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593286}

Change-Id: I51fc5a42dfcd9a67e5e5f7985e53849644002414
Bug: 846033
Reviewed-on: https://chromium-review.googlesource.com/1181930Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593285}

Also only import catapult's devil_arm.gni in arm.gni when building for
Android.

Change-Id: I06b544387e02a19ab0959ab64ba121a1d6238ef5
Reviewed-on: https://chromium-review.googlesource.com/1227604Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593284}

This reverts commit 3a7537ab.

Reason for revert: This CL fixes the crash on Chrome OS Asan bots by switching to use
DownloadUIModelPtr instead of unique_ptr. This was already done in DownloadItemView in
the previous commit effort,  but I missed it in DownloadItemNotification.

Original change's description:
> Revert "More OfflineItemModel implementation"
>
> This reverts commit 63cb63c9.
>
> Reason for revert: Crashing in debug builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7920
>
> Original change's description:
> > More OfflineItemModel implementation
> >
> > This CL makes OfflineItemModel inherit from DownloadUIModel
> >
> > Bug: 881499
> > Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db
> > Reviewed-on: https://chromium-review.googlesource.com/1237134
> > Commit-Queue: Min Qin <qinmin@chromium.org>
> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#593030}
>
> TBR=qinmin@chromium.org,shaktisahu@chromium.org
>
> Change-Id: I6fb1e7e1ed50df3147efdfa2e57e38577cffacf8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 881499
> Reviewed-on: https://chromium-review.googlesource.com/1238859
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593226}

TBR=stevenjb@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org

Change-Id: I975e1a38ff8d74a62085a7fc8e941f81d19f08cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881499
Reviewed-on: https://chromium-review.googlesource.com/1238999
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593283}

These are fixes that are needed to enable Autofill in iframes.
It also add more tests for the frame messaging logic.

Bug: 881364
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea417c1d371094489daca66e7477d963d003c716
Reviewed-on: https://chromium-review.googlesource.com/1234333
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593282}

Turns out it does need it. I think MB and/or isolate has a
dependency on this file being written for isolated tests.

Bug: 888000
Change-Id: I57f86167f0bafdb1a4d081d6811bbcff3409b551
Reviewed-on: https://chromium-review.googlesource.com/1239253Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593281}

Implemented StrikeSystem Architecture, which includes functions to
Get, Add, and Clear strike count

Bug: 884817
Change-Id: I3d936dd902213646d6bcd84e9a5fbfe8eee4fbea
Reviewed-on: https://chromium-review.googlesource.com/1231988Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#593280}

Test: ash_unittest HomeLauncherGestureHandlerTest.Split*
Bug: 887163
Change-Id: Iae804b7c6b318177bfa11a154ce3878f491a5836
Reviewed-on: https://chromium-review.googlesource.com/1235322Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593279}

This reverts commit 8e5ef240.

Reason for revert: Relanding with HungRendererController removed as well.

Original change's description:
> Revert "mac: Remove unused TabDialogsMac/TabDialogsCocoa."
>
> This reverts commit 50439b88.
>
> Reason for revert:
> Mac bots start failing after this CL on HungRendererControllerTest.
> The error logs are below.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/29038
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934838111834185888/+/steps/unit_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/HungRendererControllerTest.TestKillButton/0
>
> Original change's description:
> > mac: Remove unused TabDialogsMac/TabDialogsCocoa.
> >
> > Bug: 832676
> > Change-Id: I0fb8d4b1f0197dab0b988a52741724f63a18ee9f
> > Reviewed-on: https://chromium-review.googlesource.com/1236178
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592819}
>
> TBR=ellyjones@chromium.org,thakis@chromium.org
>
> Change-Id: I6554e741ef31bc99da0c90e3c4fd2bb8826a741f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 832676
> Reviewed-on: https://chromium-review.googlesource.com/1237797
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593085}

TBR=ellyjones@chromium.org,thakis@chromium.org,tzik@chromium.org

Change-Id: I5e076b202734c727608279952fad9d1b5657636b
Bug: 832676
Reviewed-on: https://chromium-review.googlesource.com/1238595Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593278}

Update the checks in rules.gni so that _native_libs_file_arg is set in
the same cases that it is used; otherwise APKs that contain a loadable
module but not a "main" shared library fail.

Change-Id: I88e0c169199af9625dcb7750f9bcd0a9b3dca4b7
Reviewed-on: https://chromium-review.googlesource.com/1238781Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593277}

This CL adds a parameter |is_opaque| to CanvasResourceDispatcher's
DispatchFrame{Sync}() and the private PrepareFrame(), and wires it to
the (offscreen, normal) Context's IsOpaque().

Two motivations:
- offscreen canvas should respect the opacity of the context (they
  don't do that now on ToT).
- |is_opaque| is needed when creating the viz::SharedQuadState and
  setting viz::DrawQuad::needs_blending. This quad needs to be opaque
  to promote it to underlay adequately on CrOs (and when promoted to
  overlay, we can also avoid re compositing what's below).

offscreen_canvas_test.cc and html_canvas_element_module_test.cc are
extended to test this new code: for that, Mock mojo objects are
defined in mock_viz_mojo.h, and plugged in the respective tests
so that the CompositorFrames can be inspected for opacity/transparency
(tests are parameterised to try the combinations).

Made a few vars const and a few const constexpr, removed superfluous {}.

Bug: 878801, 705019
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice1f02adee79b13b9a3f8ae915594b71487bb963
Reviewed-on: https://chromium-review.googlesource.com/1228859Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593276}

Bug: None
Change-Id: I15ad232b6e8bff08df4fd701db7f23be13fbb053
Reviewed-on: https://chromium-review.googlesource.com/1238993
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593275}

Instead of storing the lifecycle state in a property, store it in a
typed member and provided a typed accessor. This will simplify code
that empties the working set of renderers in which all frames are
frozen (upcoming CL).

Bug: 885293
Change-Id: Ic414071efa6c5994501948173600c51a7651b2e9
Reviewed-on: https://chromium-review.googlesource.com/1232016
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593274}

The Buffer mode is being removed from the FIDL definition.

Bug: 874155
Change-Id: If308f2074a35b071f4fa50d087944ece89574142
Reviewed-on: https://chromium-review.googlesource.com/1237135Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593273}

https://chromium.googlesource.com/webm/libvpx.git/+log/96e1c6b7ce91..282087a14c84

$ git log 96e1c6b7c..282087a14 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 theonetruecamper sanitizer: fix unaligned load/stores
2018-09-19 theonetruecamper fix UB  when initializing parameterized tests
2018-09-19 angiebird Add feature score for each block
2018-09-19 angiebird Correct mv rows/cols bug in read_frame_dpl_stats
2018-09-17 theonetruecamper Fix stack corruption with x86 and --enable-pic
2018-09-18 huisu Remove unnecessary code
2018-09-18 huisu Remove the SECOND_LEVEL_CHECKS_BEST macro
2018-09-13 jingning Rename set_arf_sign_bias() to set_ref_sign_bias
2018-09-17 jingning Re-work set_arf_sign_bias()
2018-09-17 jingning Update frame index per buffer at encoder
2018-09-17 jzern vpx_mem: allow VPX_MAX_ALLOCABLE_MEMORY to be overridden
2018-09-17 jingning Add a frame_index entry to RefCntBuffer
2018-09-17 jingning Assign GOP frame offset to all the coding frames
2018-09-17 paulwilkins Remove multi_arf_last_grp_enabled flag.
2018-09-17 paulwilkins Remove multi_arf_enabled.
2018-09-17 paulwilkins Remove multi_arf_allowed variable.
2018-08-22 jzern cosmetics: normalize include guards
2018-09-14 pengliu.mail fix a bug of tiny_ssim to handle odd frame sizes
2018-09-14 pengliu.mail fix a bug of tiny_ssim when the bit depth is 8
2018-09-13 angiebird Fix mv_arr assignment
(...)

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I2ec850488441a14dd6ee6118f21f0e13c23f33ec
Reviewed-on: https://chromium-review.googlesource.com/1238824Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#593272}

Bug: 884297
Change-Id: Iff20201277983eed3d851279ed6e7042ae17d250
Reviewed-on: https://chromium-review.googlesource.com/1237554
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593271}

Bug: 881812
Change-Id: I7e9eddb4386baac05e9292463f9f597132c5c14e
Reviewed-on: https://chromium-review.googlesource.com/1222684
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593270}