GitLab

This is a build fix for Mac GCC caused by r106669 <http://crrev.com/106669>.

BUG=none
TEST=fix builds on the "Webkit Mac (valgrind)" bot.
Review URL: http://codereview.chromium.org/8370034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107029 0039d316-1c4b-4281-b951-d872f2087c98

 implemented basic feature such as
   creating/deleting workspace,
   adding/removing windows to/from workspace
   calculate bounds for workspaces.

This is not hooked up with UI yet.

BUG=none
TEST=workspace_manager_unittests added

Review URL: http://codereview.chromium.org/8361025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107028 0039d316-1c4b-4281-b951-d872f2087c98

These methods are currently just used by metrics.  I moved
them from base into the browser a while back, but I think it
makes the most sense for them to live in gfx::Screen.  I'm
also relocating the tests to ui_unittest and making them work
on Aura.

BUG=99711,100341
TEST=ran ui_unittest

Review URL: http://codereview.chromium.org/8382019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=check_perms is green

Review URL: http://codereview.chromium.org/8382025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107024 0039d316-1c4b-4281-b951-d872f2087c98

Fixes bug http://code.google.com/p/chromium-os/issues/detail?id=22018

BUG=chromium-os:22018
Review URL: http://codereview.chromium.org/8382024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107023 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8380022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107020 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8198024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107019 0039d316-1c4b-4281-b951-d872f2087c98

Browse to the page and test that the url is correct for the page.

R=jhawkins@chromium.org
BUG=90420
TEST=browser_tests --gtest_filter=*OptionsWebUITest.*


Review URL: http://codereview.chromium.org/7501004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8351011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org


Review URL: http://codereview.chromium.org/8370026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107015 0039d316-1c4b-4281-b951-d872f2087c98

on all OS_POSIX systems where it's available by checking
the return value.


BUG=
TEST=base_unittests SysInfoTest.MaxSharedMemorySize

Review URL: http://codereview.chromium.org/8381022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101225
TEST=AMD/ATI new drivers are enabled.

Review URL: http://codereview.chromium.org/8379004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107013 0039d316-1c4b-4281-b951-d872f2087c98

Previously the user agent was set when we set the content client,
which was set in the zygote, which didn't have a command line.

Now, we still set the user agent in the zygote, but if the
--user-agent command line switch is passed, we will reset the
user agent in ZygoteMain.

R=jam@chromium.org
BUG=99418
TEST=run chrome with --user-agent=foo on linux, visit
whatsmyuseragent.com, ensure 'foo' is displayed.

Review URL: http://codereview.chromium.org/8296011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107012 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8356032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107011 0039d316-1c4b-4281-b951-d872f2087c98

This flag allows us to avoid compiling and executing JavaBridge code when the
feature is not required. The flag defaults to off, but is enabled on Android.

BUG=96703

Review URL: http://codereview.chromium.org/8383001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107010 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20875
TEST=none
TBR=xiyuan
Review URL: http://codereview.chromium.org/8383021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100887
TEST=Check that the initial 'home screen' has text.

Review URL: http://codereview.chromium.org/8382020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98919
Review URL: http://codereview.chromium.org/8354028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107003 0039d316-1c4b-4281-b951-d872f2087c98

Before we were leaving dangling streams un-Stop()'d, causing delayed messages to
eventually crash the browser when their source_callback_ was followed but
already invalid.

BUG=101228
TEST=trybots, manual testing.

Review URL: http://codereview.chromium.org/8385001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107000 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100411
TEST=no

Review URL: http://codereview.chromium.org/8382018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8359021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106998 0039d316-1c4b-4281-b951-d872f2087c98

1) Added missing headers causing compilation errors
2) Added an #ifdef to prevent the case of a dangling else{} without a preceeding if(){}.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8387005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106997 0039d316-1c4b-4281-b951-d872f2087c98

Removed legacy encoding mechanism that was temporarely used at one point while WebUI was still being developed.

BUG=chromium-os:20875
TEST=none

Review URL: http://codereview.chromium.org/8332013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101401
TEST=less flaky waterfall
TBR=noelallen


Review URL: http://codereview.chromium.org/8332011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106995 0039d316-1c4b-4281-b951-d872f2087c98

The log spam happens when running browser_tests on Chrome OS, or running
Chrome for Chrome OS on Linux desktop.

The source of the spam was XGrabKey in
chrome/browser/chromeos/system_key_event_listener.cc.

We should use this class only when Chrome is running on Chrome OS in
non-test mode.

TEST=the log spam is gone from linux desktop, and function keys work on Chrome OS as before.
BUG=chromium-os:21331

Review URL: http://codereview.chromium.org/8380011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106994 0039d316-1c4b-4281-b951-d872f2087c98

These histograms shouldn't have been _COUNTS histograms in the first
place. _COUNTS histograms bucket the data in exponentially spaced buckets. This
causes, for example, PPAPI crashes to be bucketed together with (and as) GPU
crashes. To avoid messing up collected data and to ensure smooth transition,
renamed histograms.

BUG=chromium-os:21841
TEST=git try, looked at about:histograms

Change-Id: I137499992c60bdf6488561150f5b6642acc862b8


Review URL: http://codereview.chromium.org/8356042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106993 0039d316-1c4b-4281-b951-d872f2087c98

Required for http://codereview.chromium.org/8368013/

BUG= None
TEST= None

Review URL: http://codereview.chromium.org/8383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106992 0039d316-1c4b-4281-b951-d872f2087c98

Added support for up arrow, down arrow, and enter key.

BUG=75782
TEST=


Review URL: http://codereview.chromium.org/8332008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106991 0039d316-1c4b-4281-b951-d872f2087c98

This gets rid of a noisy NOTIMPLEMENTED() in
DraggedTabController::DidProcessEvent().

BUG=98345
TEST=manual: checked that escape aborts tab dragging in aura

Review URL: http://codereview.chromium.org/8372001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106990 0039d316-1c4b-4281-b951-d872f2087c98

There's no guarantee that we'll get the host window size that
we ask for.  This adjusts WindowTest.Transform to not ask for
a specific size, and instead just use the size it's been
given.

I also fixed a race in DesktopHostLinux::Show() when running
under X window managers that don't take the _WM_S0 selection.
We now wait for notification that the host window has been
mapped before trying to focus it.

I moved the logic for choosing to create a fullscreen host
window out of DesktopHostLinux and into the browser.

Finally, I changed DesktopHostLinux::SetSize() (called by
Desktop::SetHostSize()) update the internal size and notify
the desktop immediately.

BUG=100979,100894
TEST=tests pass on ion3; fullscreen window is created on chrome os

Review URL: http://codereview.chromium.org/8374005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106989 0039d316-1c4b-4281-b951-d872f2087c98

 Made ShuttingDownWithoutCloseBrowsers a explicit flag.
 Use END_SESSION shutdown type if chrome recieves SIGTERM AND there are tabs that may
 block shutdown.
 Make sure APP_TERMINATING is sent only once.

This fixes SIGABORT crash in two shutdown scenarios:
1) powering off when chrome has beforeunload handler, or
downloads in progress.
2) singout from screen locker when chrome has beforeunload handler or downloads in progress.

 This is simple version of fix to merge to release branch. I'm working on
another CL that will (hopefully) cleanup a bit more.

BUG=chromium-os:20460
TEST=see bug for repro step


Review URL: http://codereview.chromium.org/8262009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106988 0039d316-1c4b-4281-b951-d872f2087c98

This is to help get the compositor free memory when appropritate

BUG=none
TEST=unit tests

R=vangelis@chromium.org


Review URL: http://codereview.chromium.org/8369010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106987 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106986 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo, yurys
Review URL: http://codereview.chromium.org/8387004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106985 0039d316-1c4b-4281-b951-d872f2087c98

base/base.gyp: 
  - exclude test/test_file_util_linux.cc on OpenBSD because of
    missing fdatasync()

base/base.gypi:
  - include linux_util.cc on OpenBSD too
  - exclude some linux specific files from the OpenBSD build
    because the openbsd implementation is different

base/file_util_posix.cc:
  - Use file_util::GetTempDir directly to get the shm dir
    on !linux

base/sys_info_freebsd.cc:
   - return 0 and do a NOTREACHED() in case sysctlbyname() fails

base/sys_info_openbsd.cc:
  - cleanup includes
  - use arraysize() in the sysctl() call
  - implement SysInfo::MaxSharedMemorySize()

build/common.gypi:
  - -Wno-deprecated is C++ only flag so move it to cflags_cc
  - Do not exclude linux specific files, dirs on OpenBSD since
    90% of it is sharable

base/sys_info_linux.cc:
  - DCHECK if the read string is empty
  - Use base::StringToInt64() to convert the string
    to an int64
  - DCHECK if the returned int64 is okay for a size_t
  - call NOTREACHED() and return 0 if fails

BUG=
TEST=runs on linux?


Review URL: http://codereview.chromium.org/8382001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98

Harden audio output controller making it safe to call Pause() before Play() really started. Not sure if it really fixes the crash, but crash started happening only after Play() was split into several tasks and become much slower (http://codereview.chromium.org/8229013/ change 105311).

Added unit test.

BUG=100650

Review URL: http://codereview.chromium.org/8371013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106983 0039d316-1c4b-4281-b951-d872f2087c98

In order for this to be on for real, the PNaCl toolchain still needs to
available

Since NaCl is still turned off by default on ARM, this code should be a no-op
for all other cases.

This also moves the compilation a step forward for ARM. 
 
There is a bootstrap dependency on memset on ARM - so SYSROOT on the
ChromiumOS chroot is required to gain access to libc.

R=bradnelson,robertm
BUG=http://code.google.com/p/chromium/issues/detail?id=61695
BUG=http://code.google.com/p/chromium/issues/detail?id=38909
BUG=http://code.google.com/p/nativeclient/issues/detail?id=135


Review URL: http://codereview.chromium.org/8364019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106982 0039d316-1c4b-4281-b951-d872f2087c98

Remove temporary hack necessary while webkit change was landing: https://bugs.webkit.org/show_bug.cgi?id=70076
Review URL: http://codereview.chromium.org/8365022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106981 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a bug in PluginLoaderPosix where if the last N plugins in the
canonical list crash, the callbacks are never run.

BUG=17863
TEST=On Linux, plugins work as before.


Review URL: http://codereview.chromium.org/8372015

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/8351014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106977 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8004005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106973 0039d316-1c4b-4281-b951-d872f2087c98