- 05 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8ccdc63a188..23c5b63d1c68 2020-08-04 oksamyt@google.com Merge "[trace processor] Update webview power metric slice selection conditions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0ef75c6fc0baada002d53f7c39d7171f39b2079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794859}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7176f54720e6..f8ccdc63a188 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0837eeec5e39c4499cd8a98e7cb38bba823e34dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794858}
-
Rachel Carpenter authored
This removes the feature that it was conditioned on and adds logic in extensions to remove the component and not add it again. We should be able to remove it completely in another milestone after clients have had a chance to remove it properly. Bug: b/159863346 Change-Id: Id6369e670f749b6cd532a25eac0d35c718a4f5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318889 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#794857}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac60992d41b7..d5eb7e06f156 2020-08-05 fancl@chromium.org Change Row parent to TestContainer for stats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1112373 Tbr: skyostil@google.com Change-Id: I95698bb989148e850eae5d005b7c1c59129c3bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794856}
-
Ben Pastene authored
This reverts commit 5365fbee. Reason for revert: Spec reverting for browser_test timeouts on mac eg: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2891 See crbug.com/1112796 Original change's description: > Correctly prompt users for system level location permission > > This is part of the Core Location implementation in Chrome. This change > deals with the UI element. It checks the permission from the UI side > and prompts the user accordingly > > Bug: 1051591 > Change-Id: I69b9964690f5e9f114a1502a5cc45a38d6da558c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240029 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794293} TBR=avi@chromium.org,engedy@chromium.org,reillyg@chromium.org,mattreynolds@chromium.org,jameshollyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1051591, 1112796 Change-Id: Ia18a29213a2e02acd0ef57ec416e7973cfc51a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337579Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794855}
-
Melissa Zhang authored
This CL adds proper margins for SharesheetTargetButton and updates bubble targets to have a fixed size and alignment. We also increase the size of the bubble to a fixed width. Bug: 1097623 Change-Id: I9f236a6dd73dbf1a9159d8e6a8ee38a4447c06aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336117Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794854}
-
Devlin Cronin authored
We should be using last committed URL for security checks, not visible URL. This requires updating a number of the extension API tests in order to wait for the tab to commit before attaching the debugger; also take this as an opportunity to update a few with some async helpers (like await, etc). Bug: 237908 Change-Id: Ic9fcb010e4d029204d5d2e0b8e6bbbe76738bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327462Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794853}
-
Rakina Zata Amni authored
If a page has beforeunload/unload handlers (and soon, pagehide and visibilitychange handlers too), tabs.remove might not be able to close a tab immediately. We shouldn't trigger the callback passed to tabs.remove until the tabs actually closed. This CL waits for WebContentsDestroyed to be called on all the tabs that we're removing before responding/triggering callbacks. Bug: 987409 Change-Id: Ibdf526307c8c2652bc04a7aca4c379aca6d11922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319927 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794852}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7176f54720e6..b156b016f22b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4c25126a1f963529d66ff6601d325d20b7e6419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794851}
-
Mohsen Izadi authored
This reverts commit 87c9ba45. Reason for revert: The original revert was to confirm that metrics changes were due to the original CL. Since that was the case and the changes were almost all expected we can reland the original CL. Note that we expect this CL to make both improvements and regressions in Graphics.Smoothness.PercentDroppedFrames.AllSequences metric depending on the page. UMA data from the Finch experiment, however, show that there is much more improvements in the wild than regressions. It is also expected that it will mostly regress thread_total_rendering_cpu_time_per_frame, but that's the cost we accept for better smoothness. Original change's description: > Revert "Re-add field trial testing config for DisableLatencyRecoveryDesktop" > > This reverts commit 26f4c62b. > > Reason for revert: crbug.com/1108303 regressions showing up on a large number of Graphics.Smoothness.PercentDroppedFrames graphs. We should analyze the impact and reland. > > Original change's description: > > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > > > Based on the data gathered from running the experiment on canary/dev and > > beta, it seems that the disabling latency recovery for both main and > > impl threads is an overall performance win. So, we are going to > > re-enable the (now-expired) experiment on stable and move forward with > > its gradual rollout. > > > > Bug: 993895 > > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790549} > > TBR=mohsen@chromium.org,rkaplow@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993895 > Change-Id: I0409a5a5df03b34c8e4a203482175089dac83e41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315014 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791293} TBR=mohsen@chromium.org,rkaplow@chromium.org,jonross@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993895 Change-Id: I70cc66c1202d320a227c1244293ac67e111946f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332681Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#794850}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d41280a787d1..adc250c38976 2020-08-04 jmadill@chromium.org Vulkan: Refactor ImageViewHelper serials. 2020-08-04 timvp@google.com Create empty //tools/android/md5sum/BUILD.gn 2020-08-04 ccameron@chromium.org macOS/ARM: Allow populating GPU based on AGXAccelerator 2020-08-04 syoussefi@chromium.org Vulkan: EXT_multisampled_render_to_texture2 support 2020-08-04 syoussefi@chromium.org Vulkan: Fix blit/resolve of mixed-samples framebuffers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1110408,chromium:1110421 Tbr: geofflang@google.com Test: Test: gn gen out/Android Change-Id: Ic92a8e23b00a408ee7edec7914a4847e486a3119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794849}
-
Noah Rose Ledesma authored
The webmedia player delegate will now send IPC messages informing webcontents observers of changes of audio output devices. used. Bug: 1110143 Change-Id: Iac3712ee5015f0bd00176b40e3fad60c5c9361eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321767 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#794848}
-
Tsuyoshi Horo authored
TBR=imcheng@chromium.org Bug: 879885 Change-Id: I8228e4d06404a59d32859b70de2adbaff71279c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336378Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794847}
-
Michael Crouse authored
This change updates the user blocklist on rebuffer events and updates the UKM metrics that a rebuffer event occurred. A future change will add a threshold for the number of rebuffers to be observed before stopping active throttles rather than immediately. Bug: 1097792, 1101563 Change-Id: I4e078a38102c1bc7a8bc12e76bad7edf7caceb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333741Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#794846}
-
Guido Urdaneta authored
We are seeing cases where dlerror() crashes without a known reason under MSAN in a logging statement of InitializeStubs() during PulseAudio initialization. This CL splits the logging statement that reports the library that failed to open and the call to dlerror(). This will allow us to see in the logs which library failed to load prior to the dlerror crash. Bug: 1109346 Change-Id: I3adbdf27e7207404a0c4d8a9fd472b77a8932c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332259 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#794845}
-
Andrew Grieve authored
It's redundant with is_official_build=true Bug: None Change-Id: I43ac78c75bb744c920da0e340285bc356d1316c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327144Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#794844}
-
Austin Tankiang authored
selectByEntry() is not guaranteed to finish synchronously, however, the callsite in onDirectoryChanged_() expects it to. This function became async for two reasons: 1. The directory tree always used to have one more level preloaded, just not visible. This meant that folder navigation on RHS was sync as it could only traverse one level. This had changed in crrev.com/c/2059729, and folder navigation is now async. 2. Navigations to deeply nested folders became possible using the "Go to file location" feature. Turn selectByEntry() into an async function to allow callers to await on it. This fixes the active marker in the directory tree not being updated. Also add a test to ensure the active marker updates correctly. Bug: 1086370 Change-Id: I1423710bfd989bcb512f19ebca40e8e9bf405ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331770 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#794843}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596562698-726e910d88cf0fdaea1d96e4c3f332f3c327590e.profdata to chrome-win32-master-1596571199-429c5d3274b1adcffd4054f095f3cc2a5ada36c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib1dd9193bebd523d7fa13a007772cbbdba208da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794842}
-
Tsuyoshi Horo authored
TBR=pdr@chromium.org Bug: 1113050 Change-Id: I9bf3cfcc0e25376478bbd996f98408d5b95bb96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336428Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794841}
-
Alex Gough authored
No functional changes. - Change DEPS for network sandbox specialization - _win.cc as much code is Windows only and could have distinct reviewers. - Setup OWNERS for new files to ensure review. Bug: 1111421 Change-Id: I03e5e0c4e4df87d3af9e5ce58975b3d4348ce90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332860Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794840}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: If634e36bccdaf23712ecf376a6ff315c346875e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332868Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794839}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6116bf6ce82..d24a19d42924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1099917 Tbr: horo@google.com Change-Id: Ifc0e3a8466511136e762e4c937de17249171656c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337445Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794838}
-
Olivier Yiptong authored
Adding the UX-chosen icon: go/icons#icon=font_download Used evanstade.github.io/skiafy Bug: 1112552 Change-Id: Ica80e4186f324a8c9296a702483c49e03f6f4547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337344 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#794837}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/dd5382a4449c..1b6221e157c7 $ git log dd5382a44..1b6221e15 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 nharper Don't set default encryption level to ENCRYPTION_HANDSHAKE 2020-08-04 quiche-dev Demotes noisy QUIC_LOGs to QUIC_DLOG. 2020-08-04 renjietang Use std::vector instead of QuicSmallMap in various places as map is an overkill. 2020-08-04 renjietang Consult only stream map for gQUIC in QuicSession::GetNumActiveStreams(). 2020-08-04 renjietang Remove zombie stream map in QuicSession. 2020-08-04 danzh Refactor out the logic which responds to connectivity probing and connection migration from QuicConnection::OnPacketComplete(). No behavior change, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=renjietang@chromium.org Change-Id: If011824b5eacdfe1ee6fb10d05f28e6659ca76d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337793 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#794836}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b0d8780f66..b156b016f22b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0c27fd8bda0260a976b47aa4a68e0af8eab7c4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794835}
-
Minoru Chikamune authored
We are going to remove ipc_task_queue and ipc_task_runner. The scheduling policy of ipc_task_queue is the same as the default task queue. Nowadays, we are using per-frame task queues as much as possible. And if there are no relevant per-frame task queues, then we can use the (per-isolate) default task queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: I786ca2b652dcd9c25dd0867cc30659332c01d0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331793Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#794834}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d6df76fdb45c..580a4b1d52b6 2020-08-04 jacktfranklin@chromium.org Script to re-generate all bridges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f2757b63d3f4839e5b9f7e3055e7e0337f5e188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794833}
-
Kent Tamura authored
This CL adds legend-align-expected.txt, which introduces two more PASSes and no new FAILs. Bug: 875235 Change-Id: Ied5ea8dbe44ebedc4590d6e2f7e337f6dadb144a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336313 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#794832}
-
Eugene But authored
According to Session.WebStates.NavigationItem.SerializedTitleSize histogram, stored title can be quite large, which may have negative impact on stability. Chrome for iOS does not have UI surface to display title longer than 50 characters, so truncating the title to 50 does not have any functional side effects and can improve the stability Bug: 1082279 Change-Id: I20a51fa09e748976f2b31c6c83ee642da877e791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337497Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#794831}
-
Yuke Liao authored
This CL fixes linux-lacros-compile-re mb config to attach it to chromiumos instead of linux. Bug: 1110382 Change-Id: Id4ad6f28862aa155d72fa36fc33be0c417a8168b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337386 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794830}
-
Zain Afzal authored
Due to some ux decisions the media app now needs to support a "save as" operation where the current file is saved in a new location and the app is navigated to the new file. This means that "saveCopy" is no longer an accurate name so we are renaming it to "saveAs". Additionally this CL adds some additional logic to slip the newly saved file into the navigable files list so users can navigate back to the original file or any other file in the directory. To prevent TOT being broken this CL leaves saveCopy as is for older version of the media app client code. Once the client is updated saveCopy will be deleted in a separate CL. Google3 side of this change: cl/323288209. Bug: b/161193454 Change-Id: Ic66dcfdbcefbee985a9764701cb0bcee229020aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316189 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#794829}
-
Minoru Chikamune authored
We are going to remove ipc_task_queue and ipc_task_runner. The scheduling policy of ipc_task_queue is the same as the default task queue. Nowadays, we are using per-frame task queues as much as possible. And if there are no relevant per-frame task queues, then we can use the (per-isolate) default task queues. [related design doc section] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#bookmark=id.eeuir8g768ou Bug: 1105403 Change-Id: I034961b5d320a3a43b93bcbeabbcb495e72a20e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332089Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#794828}
-
Dale Curtis authored
This adds a new vt_config_util.mm file which handles converting to and from macOS color space information into a gfx::ColorSpace. Most notably this adds support for HDR color spaces. R=ccameron, sandersd Bug: 1103432 Test: New tests. Change-Id: I17f5c93276c1cc19a1623c007370e4f480bd2e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336179 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#794827}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e289c0284053..ac60992d41b7 2020-08-04 dpranke@google.com Update OWNERS for //third_party/typ. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ie1055f8b93e22c3c7fb37bc621580cc912bbb6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794826}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/21efb7c7ddbc..10f019c5068f 2020-08-04 het@google.com [CanvasKit] Expose TypefaceFontProvider. 2020-08-04 herb@google.com remove unused scale for direct masks 2020-08-04 johnstiles@google.com Fix debug visualization for SkString. 2020-08-04 bungeman@google.com Remove use of SK_IGNORE_MAC_OPSZ_FORCE 2020-08-04 jlavrova@google.com Remove SK_PARAGRAPH_OLD_SPACE_RESOLUTION (staging changes done) 2020-08-04 brianosman@google.com Remove bits of code related to sk_Args 2020-08-04 borenet@google.com Reland "[recipes] Verify that we actually deleted the file/dir on android" 2020-08-04 adlai@google.com Remove two staging APIs post-Chrome-migration 2020-08-04 bungeman@google.com Rename kMultiMaster_FontFlag to kVariable_FontFlag 2020-08-04 mtklein@google.com try always setting fvisibility=hidden 2020-08-04 bungeman@google.com Better serialize variations, separate SkFontData. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I6892d280e25a097a8a8cbcd9efd226906202c9a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794825}
-
Owen Rodley authored
This should make it more obvious that it corresponds to an actual tree closure, and hence should be paid attention to. Bug: 1111108 Change-Id: I5db965a86f0e8399a8c2b5bd17b34d4d89a94ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336097 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#794824}
-
Dirk Pranke authored
Since jumbo builds are no longer supported, we no longer need to identify particular source files to exclude from them. Bug: 994387 Change-Id: I6f7f12e55602e3fac4b10c2f613cfa9992129871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337274Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#794823}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of content_unittests that didn't expect a change of RenderFrameHosts etc. on same-site main frame navigations. This CL does not include: - Updates for content_browsertests and non-navigation-specific tests, which are handled in crrev.com/c/2195872 and crrev.com/c/2210174. - Updates for tests under chrome/, components/ and layout tests (fixed in other CLs)) - Fix to ensure order of unload handlers on same-site cross-RFH navigations (will be fixed on a future CL) - Fix to ensure WebPreferences are carried over for cross-RFH same-site navigations (will be fixed on a future CL) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I8cddb7e5caceea380ec413dbb446142811f0f62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210035 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#794822}
-
Erik Chen authored
This CL allows extensions to be marked as available on the 'lacros' platform. This is primarily a small change to the generator python files to accept a new enum type. This CL marks enterprise.platformKeys as available on 'lacros' in order to have real code using this logic path. Change-Id: Icb593cb9fdd149154b7bd5d7206fad560ce82277 Bug: 1111879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333570 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#794821}
-
Sven Zheng authored
Bug: 1104291 Change-Id: I9e549304eefc2b511fc1b95a22e8fe9a6c099ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337105 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#794820}
-