- 01 Sep, 2018 40 commits
-
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I99dcd18546028da70850d3e953de370e645b9126 Reviewed-on: https://chromium-review.googlesource.com/1200392 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588272}
-
Lei Zhang authored
While generating the print preview, the renderer now must send the list of page numbers in the DidStartPreview message. The browser can then use the list to validate the DidPreviewPage messages. Also combine calls to PrintPreviewUI methods to encapsulate more. Change-Id: If50199d14a61fa60e5e657fab6459fa80a7f0d88 Reviewed-on: https://chromium-review.googlesource.com/1188242 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588271}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee3f5c44326d..1203870d6c79 git log ee3f5c44326d..1203870d6c79 --date=short --no-merges --format='%ad %ae %s' 2018-09-01 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-01 lannm@chromium.org Add chromite.lib.repo_manifest 2018-09-01 bhthompson@google.com Update gen_luci_scheduler with R70 branch Created with: gclient setdep -r src/third_party/chromite@1203870d6c79 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I999ec2f4d536aea4ccad09fc5f7fe601219073af Reviewed-on: https://chromium-review.googlesource.com/1200174Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588270}
-
Lei Zhang authored
Encapsulate ClearAllPreviewData() and SetPrintPreviewDataForIndex(). Change-Id: I0ad046aef0ffcf098cc783bc177a8597c1c973c5 Reviewed-on: https://chromium-review.googlesource.com/1188778 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Byoungkown authored
Using "use_jumbo_build=true" args in GN, speed up builds in components/domain_reliability. Bug: None Change-Id: Ifaf4e19ce81dbc9fe284f841db83f0b5d9e0518f Reviewed-on: https://chromium-review.googlesource.com/1193627Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#588268}
-
Sam McNally authored
Also update DriveFsHost to drop errors with an unknown type rather than requiring observers to do so. Bug: 844298 Change-Id: I6434ef5c7664f115fb260d75a89939e51b53d519 Reviewed-on: https://chromium-review.googlesource.com/1198662Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588267}
-
Byoungkown authored
Using "use_jumbo_build=true" args in GN, speed up builds in components/cast_certificate. Bug: None Change-Id: I4e8a48722dcdef687e57afd462b8394c668d5292 Reviewed-on: https://chromium-review.googlesource.com/1193626Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#588266}
-
Victor Costan authored
This CL only handles the files in //storage. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other directories. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Change-Id: I6a7cde992a658d40294ec131d58fbe06cea2d0c8 Reviewed-on: https://chromium-review.googlesource.com/1200566Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588265}
-
Tao Bai authored
Present heuristic type to Android Autofill service. Bug: 849913 Change-Id: I7e832aa157d6fe5adadc8c8edc2dcc77ecd9effa Reviewed-on: https://chromium-review.googlesource.com/1174977Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#588264}
-
Oksana Zhuravlova authored
Bug: 879803 Change-Id: Ie3db494b151b36bc73ae9f9067c0c89d4685553b TBR=twellington@chromium.org Change-Id: Ie3db494b151b36bc73ae9f9067c0c89d4685553b Reviewed-on: https://chromium-review.googlesource.com/1200172Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588263}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 27028c1e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23756 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4f4d9a7032a974853528a545956cdcdae87da477 Reviewed-on: https://chromium-review.googlesource.com/1199628 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588262}
-
Alexander Alekseev authored
This reverts commit 90766e30. Reason for revert: Cannot start session after sign-in (stuck at Sync Consent). Original change's description: > Migrate Assistant opt-in flow into CrOS OOBE > > Bug: b/78190629 > Test: Manual Test > Change-Id: I3cb433b5c688309453489df85d43657e2a19339b > Reviewed-on: https://chromium-review.googlesource.com/1195662 > Commit-Queue: Yue Li <updowndota@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588053} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org Change-Id: I05f3589c511e05067b333cb895882bfd1dd52e49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/78190629 Reviewed-on: https://chromium-review.googlesource.com/1199466Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#588261}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cb0f1f565b29..58e53ea82f25 git log cb0f1f565b29..58e53ea82f25 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 tobine@google.com Fix sign mismatch warning Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@58e53ea82f25 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id4a04cb5667b2cc3704fcda6b068142f4b34d278 Reviewed-on: https://chromium-review.googlesource.com/1199872Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588260}
-
Eric Roman authored
This adds an optional "ProxyErrorClient" client to the NetworkContext which receives notifications of errors in the PAC script, as well as notifications of failed URL loads that may have been proxy related. (Reland of d576f34a). Bug: 876568,851609,879491 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I08987d658879913d94c9b13b6fdc1de2a32a6d54 Reviewed-on: https://chromium-review.googlesource.com/1200076 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#588259}
-
Weilun Shi authored
Remove focus ring on custom background dialog's done button when it is disabled. Bug: 878709 Change-Id: I9f30a27361682a6bb91273ae43cf97e1b1030594 Reviewed-on: https://chromium-review.googlesource.com/1196165 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588258}
-
Karan Bhatia authored
This CL limits the no. of rules that an extension can provide to 30000. If an extension provides more rules than this limit, those rules will be ignored and an install warning will be surfaced to the user upon installation on the extensions page. These won't re-surface once the browser restarts for packed extensions. BUG=767977 Change-Id: I95c824f4233dd7c0b77393fa817522b9b1c70681 Reviewed-on: https://chromium-review.googlesource.com/1198010 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#588257}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4912261d75761c9b914ba8cf4952d27a0b2f42bd Reviewed-on: https://chromium-review.googlesource.com/1200586Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588256}
-
Julie Jeongeun Kim authored
This patch creates file_manager_strings.grdp as collecting file manager strings from chromeos_strings.grdp to manage independently. It also moves sha1 for file manager already added at chrome/app/chromeos_strings_grdp to chrome/app/file_manager_strings_grdp It's wrapped in <if expr="chromeos"> at generated_resources.grd. TEST=tested manually Bug: 845818 Change-Id: I3741871b2fe9e0d0aec8da10caa7f4ab3f20363a Reviewed-on: https://chromium-review.googlesource.com/1195173Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#588255}
-
Sunny Sachanandani authored
Zero-copy NV12 will have to skip VideoProcessorBlt so split it out, and cleanup some of the color space calculation logic as well. Bug: 848093 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I260d2f060a957383054b46bdffdd2105baf2a896 Reviewed-on: https://chromium-review.googlesource.com/1171842Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#588254}
-
Peter Kotwicz authored
When loading app_icon.png on Android P, upscaling doesn't occur until after the image is drawn. As a result, if we try to show a lower DPI image such as the mdpi icon, the Bitmap#getWidth/Bitmap#getHeight values will only return the original image size on Android P. What we actually want is the scaled image size. To do so we use Bitmap#getScaledWidth/Bitmap#getScaledHeight which return the scaled image size in pixels. This wasn't a problem on O and earlier since this scaling occurred when the bitmap was loaded into memory (prior to rendering). This CL is a follow up to https://chromium-review.googlesource.com/1148815 Bug: None Change-Id: Ief90e97ad9f618db3e866222dc486a468e14bdfd Reviewed-on: https://chromium-review.googlesource.com/1199494 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588253}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/253038d8d13b..88fc6da3e28c git log 253038d8d13b..88fc6da3e28c --date=short --no-merges --format='%ad %ae %s' 2018-08-31 jmadill@chromium.org Vulkan: Mega-refactor to VertexArrayVk. Created with: gclient setdep -r src/third_party/angle@88fc6da3e28c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I54a50a240f08e58f74a8b429efbdd5be20b0db50 Reviewed-on: https://chromium-review.googlesource.com/1200168Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588252}
-
Victor Costan authored
This cleanup refactors content::ParseManifest(). The main outcome is separating low-level string manipulation (previously using C-style pointers) from the higher-level logic for interpreting manifest data. The desired benefit is being able to easily reason about the (standard and proprietary) AppCache features that Chrome supports. The CL relies heavily on base::StringPiece for string parsing, which uses a (start, length) representation. Updating this requires more work than the previous (start, end) representation. The extra work should be outweighed by the performance savings of the new approach. * URLs are not re-encoded from std::wstring to UTF16. * Keywords are encoded as static base::StringPiece instances, avoiding some strlen() calls. Bug: 879224 Change-Id: Ia8ecdb9453a103b7c6bfed8bc80ecf159095afc5 Reviewed-on: https://chromium-review.googlesource.com/1192985 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#588251}
-
Xida Chen authored
This CL adds RecordHitTestData in LayoutReplacedPainter. Two layout tests are added for SVG root and HTML image element cases. Bug: 876468 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea6a2318bcd7029b252ebccc92d62d93ad0b6c23 Reviewed-on: https://chromium-review.googlesource.com/1196914 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588250}
-
Eugene Kim authored
It's much easier to write: base::Erase(container, value); base::EraseIf(container, ...); than: container.erase(std::remove(container.begin(), container.end(), value), container.end()); container.erase(std::remove_if(container.begin(), container.end(), ...), container.end()); Bug: 875665 Change-Id: Iadfcce0915d215085d515e13b6faa745462d11b8 Reviewed-on: https://chromium-review.googlesource.com/1190403 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588249}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/554ad9846a8b..6487e5ca6f10 git log 554ad9846a8b..6487e5ca6f10 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@6487e5ca6f10 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I19a7e711f429b039e23b305b1124983e626c3b36 Reviewed-on: https://chromium-review.googlesource.com/1199877Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588248}
-
Alan Cutter authored
This CL is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1195346 to clean up old "slide" names and move shared timing constants into the HostedAppButtonContainer class instead of needing them to be synchronised/passed around. Change-Id: I717e4972b47ae8d0a0336c675b8a733efa2e2a22 Reviewed-on: https://chromium-review.googlesource.com/1198707 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#588247}
-
Nicholas Verne authored
Tremplin is the new way to start the crostini container. It provides more feedback on the install progress of the container itself. The old StartContainer stage of CrostiniRestarter is now replaced by CreateLxdContainer, StartLxdContainer, SetUpLxdUserName in sequence. These calls all have to wait until the Tremplin service itself has started in a vm. As a result, StartTerminaVm now waits for Tremplin to start before calling the callback. Bug: 860094 Change-Id: If55406c2b665897aff97bebb5f3cbae2205d5550 Reviewed-on: https://chromium-review.googlesource.com/1170449Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588246}
-
Guido Urdaneta authored
Authorization via policy settings will be added in a follow-up CL before enabling by default. Bug: 860311 Change-Id: Ifadaa08b1a312f750654ebe51b862a8733b998a5 Reviewed-on: https://chromium-review.googlesource.com/1183195 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588245}
-
Lei Zhang authored
- Add a ShouldUseCompositor() helper function. - Reduce the number of GetPrintPreviewUI() calls in the non-compositing path. - Call PrintPreviewUI::ShouldCancelRequest() before compositing, to avoid doing work if the results are not useful. - Make NotifyUIPreviewPageReady() and NotifyUIPreviewDocumentReady() check the data in a consistent manner. Change-Id: Ia357e6ab1a7bf41a849445cf113aff071cae1b1c Reviewed-on: https://chromium-review.googlesource.com/1188030 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Victor Costan authored
This CL only handles the files in //content. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other directories. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Change-Id: Ib3f9965fe92b84be3db88d0143a398079b812efd Reviewed-on: https://chromium-review.googlesource.com/1200525Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588243}
-
rbpotter authored
The duplex setting is stored as bool, but the preset options are setting it as if it is an enum. Fix this mismatch. Bug: None Change-Id: Ie2624f352b9e57d7946da2d58903dd606d7266db Reviewed-on: https://chromium-review.googlesource.com/1199600 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588242}
-
Weilun Shi authored
Listen on the tile's keyup event instead of keydown event to prevent opening "Add shortcut" dialog before releasing the spacebar. Bug: 879167 Change-Id: Id7668562db1f3db47f5f484670f06b9080b34c6d Reviewed-on: https://chromium-review.googlesource.com/1200403 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4259762b3597..e323bd9d2263 git log 4259762b3597..e323bd9d2263 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 nodir@google.com [bot_update] Untie revision and repository properties Created with: gclient setdep -r src/third_party/depot_tools@e323bd9d2263 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161,chromium:694348 TBR=agable@chromium.org Change-Id: I2435f620a6af4d970ed09912de690acbafa7523a Reviewed-on: https://chromium-review.googlesource.com/1199875Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588240}
-
Dominic Farolino authored
This follows up http://crrev.com/c/927701, mentioning that not all requests have their priority pushed down to the lowest, but that there is more granularity. R=kinuko@chromium.org, tbansal@chromium.org Bug: N/A Change-Id: I6112d8fdf8948552acc0a188c75b89aa2ef8f425 Reviewed-on: https://chromium-review.googlesource.com/1200583Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Victor Miura authored
Appending entries to visible_rect_history was a hotspot in profiling. Changing to std::deque, and re-ordering the update code so the deque only grows to 2 entries rather than 3. BUG=879668 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I576ba0ae278a04a0e7336b3b1cd589fadd25b177 Reviewed-on: https://chromium-review.googlesource.com/1200466Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#588238}
-
Erik Luo authored
This makes Consoles messages focusable and navigable using: ArrowUp/Down/Left/Right, Home, End Screenshot: https://imgur.com/a/6JWY0iU Bug: 865674 Change-Id: I4166bf4d8d57856c6d1f7d51ef29e2dea0c088eb Reviewed-on: https://chromium-review.googlesource.com/1144453 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#588237}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b8e60f98418e..5167fb3f6694 git log b8e60f98418e..5167fb3f6694 --date=short --no-merges --format='%ad %ae %s' 2018-09-01 chiniforooshan@chromium.org Telemetry: latency metrics in TBMv2 Created with: gclient setdep -r src/third_party/catapult@5167fb3f6694 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553 TBR=sullivan@chromium.org Change-Id: Ifa1bc9ed82007576631a28271769ef7b3a667cf9 Reviewed-on: https://chromium-review.googlesource.com/1200169Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588236}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ca3a100e7dcf..a38996be8593 git log ca3a100e7dcf..a38996be8593 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 tsepez@chromium.org Remove avail_buf out argument from GetAvailInput() methods. Created with: gclient setdep -r src/third_party/pdfium@a38996be8593 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibf88905a34a202949c3c4035930e72224a308708 Reviewed-on: https://chromium-review.googlesource.com/1199874Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588235}
-
Weilun Shi authored
Changing the CSS setting and manually changing font family to Segoe UI on Windows instead of depending on the automatic fallback on CSS. Bug: 867778 Change-Id: I3c2fed3453639c6a8d1a4cb61cb88af3af33354b Reviewed-on: https://chromium-review.googlesource.com/1200310Reviewed-by:
-
yusukes authored
This allows chrome://settings/inputMethods to show up-to-date IME information without closing and reopening the settings window. For example, when the language X is enabled on the device and a new Chrome OS IME extension for the language X is installed, it'll instantly show up in chrome://settings/inputMethods. The same happens for Android IMEs installed via Play Store too. BUG=867795,845079 TEST=Add 'Japanese' to the language list, open chrome://settings/inputMethods, install 'SKK Japanese Input' (extension IME) from Chrome Web Store, verify the IME entry ('SKK') shows up in the settings page immediately. TEST=Go to extensions page, disable the SKK IME, verify 'SKK' disappears immediately. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I20f7586cd58e7d6c6f92f37c1f0b697d57d17d32 Reviewed-on: https://chromium-review.googlesource.com/1198106 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#588233}
-
