- 08 Oct, 2018 40 commits
-
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I5acd367734d70359367369961cf66e7945482e6f Reviewed-on: https://chromium-review.googlesource.com/c/1264583Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597510}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I26aafd6d9606d08a4052fada37728aeb7a513975 Reviewed-on: https://chromium-review.googlesource.com/c/1258907Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597509}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/passwords_private. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: Ic7e228270788db02035262b532fcc2eee8cebf0f Reviewed-on: https://chromium-review.googlesource.com/c/1258355Reviewed-by:
-
Javier Ernesto Flores Robles authored
More info: https://docs.google.com/document/d/1tTnjQIvN3gaF4iM3NI9NxHM7hBSHiVIBesssJxyq63I/edit?ts=5970bfd9# BUG: 891834 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibc84b996a5e76f5b387e98669364fbd7221e539f Reviewed-on: https://chromium-review.googlesource.com/c/1258164Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597507}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/app_list. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I8b538c62942b3e166321c62f3044d33975a1f396 Reviewed-on: https://chromium-review.googlesource.com/c/1257931Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/ash. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I924f989afa69979481c82a6b32d3b5d9dfd24b49 Reviewed-on: https://chromium-review.googlesource.com/c/1258177Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I74d020e16e7346724b5119ade16005119b1c119f Reviewed-on: https://chromium-review.googlesource.com/c/1258913Reviewed-by:
-
Anders Hartvoll Ruud authored
In CSS Typed OM, types that are not yet supported by a specialized CSSStyleValue subclass are represented by "direct" CSSStyleValue objects. These objects are only valid for their associated property. For instance, you may not get a (direct) CSSStyleValue object from 'color', and then set it on 'background-color'; the (direct) CSSStyleValue acquired from 'color' is valid for 'color' only. The same should apply for registered custom properties; a direct CSSStyleValue acquired from '--x' is only valid for '--x'. To do this, blink::CSSUnsupportedStyleValue must be aware of the custom property name. This means the AtomicString with the custom property name must be passed around to almost everything. However, if the property at hand is not a custom property, I want to avoid AtomicString-ing the name of the property. Hence there are DCHECKs to make sure this is avoided. Reminder: this CL would be much less ... grotesque and perhaps less error-prone if dynamic CSSProperties (Ribbon) were in place, but because we like pain, we decided to not give that project a very high priority. R=chrishtr@chromium.org Bug: 641877 Change-Id: I99af4745d1d33365759e9fd4acef5082ab213229 Reviewed-on: https://chromium-review.googlesource.com/c/1257916Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#597503}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/settings. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I5103cabe5c8ea6f58e9c1cd10f17e352c3f4cbe4 Reviewed-on: https://chromium-review.googlesource.com/c/1259024Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/offline_pages. This CL was uploaded by git cl split. R=dimich@chromium.org Bug: 809610 Change-Id: I8bcb6ce9389ed769c91d677c5b065866b5b1323d Reviewed-on: https://chromium-review.googlesource.com/c/1258358Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597501}
-
Sergio Villar Senin authored
It corresponds to O2TS::Observer::OnRefreshTokensLoaded(). The loading of tokens from disk should ideally be an implementation detail of identity service but as there is a non trivial amount of consumers we should add this API to ease the transition. Bug: 884205 Change-Id: Ica449d4461e16c1a2652d1acdf8fc23939eca8ad Reviewed-on: https://chromium-review.googlesource.com/c/1251264 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597500}
-
Noel Gordon authored
Add a Quick View loading test for a PDF document. For loading, wait on the <webview> |src| then detect the PDF plugin <embed> type as a proxy for "contentChanged". Note: there's no need to add any PDF scrolling / backgroundColor tests since those aspects are handled internally by Chrome's PDF viewer. Bug: 891150 Change-Id: I8d3eb438f1cca6d2d249966fd107a4075c7b67b7 Reviewed-on: https://chromium-review.googlesource.com/c/1267916Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597499}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/86b2fecee9ca..a81ac2dc02bf git log 86b2fecee9ca..a81ac2dc02bf --date=short --no-merges --format='%ad %ae %s' 2018-10-07 primiano@google.com Lower testing field id to 2**28 - 1 Created with: gclient setdep -r src/third_party/perfetto@a81ac2dc02bf The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5872cf9f52d94755b642fdd89bfbf28a180ff03f Reviewed-on: https://chromium-review.googlesource.com/c/1267955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597498}
-
Andrew MacPherson authored
Implement the IAudioClient3 interface to allow lower output latency for use in Web Audio via the latencyHint. Update AudioParameters adding HardwareCapabilities with min_ and max_frames_per_buffer representing the min and max buffer sizes supported by the audio hardware so that requested buffer sizes can be appropriately clamped in AudioLatency::GetExactBufferSize(). Bug: 316908 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibafe6d917ec4d57a16092f040b57b4ff27ed54b3 Reviewed-on: https://chromium-review.googlesource.com/c/1165236Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#597497}
-
Henrik Grunell authored
Bug: 891202 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I46c6df2e176a55a35a3afdcfec31d8652d78bb66 Reviewed-on: https://chromium-review.googlesource.com/c/1268015Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597496}
-
David Jean authored
Bug: 891291 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8e72497ea3a71a2cb2c6b8e51e4b5076b233457c Reviewed-on: https://chromium-review.googlesource.com/c/1264538Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#597495}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iee30f216608f992fb7083ece1b019426fa731da5 Reviewed-on: https://chromium-review.googlesource.com/c/1267956Reviewed-by:
-
Henrik Boström authored
It was previously a blink::RuntimeEnabledFeature (--enable-blink-feature), making it a base::Feature (--enable-feature) allows us to control it with Finch experiments. The blink feature is kept for backwards compatibility; either one of the flags can be used to enable Unified Plan by default. This also adds the flag to the chrome://flags page. Bug: 857003 Change-Id: I2fafec1a54ded69c37cc469b4f43c10e1a5f7ef3 Reviewed-on: https://chromium-review.googlesource.com/c/1264580 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#597493}
-
Victor Costan authored
Many methods in //net use the "int" return type to return either a net::Error or a number (e.g., bytes read). However, quite a few methods also use the "int" return type, even though they only return net::Errors. This CL replaces int with net::Error where applicable in //net/disk_cache/disk_cache.h, and in the classes implementing the interfaces defined in disk_cache.h. This is intended to help readers distinguish between methods that return an error code and methods that may return a number or an error code. Change-Id: I112a277700e7c636f0c9e5248d600c443f86bee4 Reviewed-on: https://chromium-review.googlesource.com/c/1263888Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597492}
-
Noel Gordon authored
Add JS content load handlers to the <file-safe-media> webview #content element: onloadeddata for <video> and <audio>, and onload for the rest which currently means <image> [1]. Call contentChanged when these load handlers fire: to confirm that the audio|image|video loaded, and send the 'webview-loaded' message to the parent <file-safe-media>. The parent <file-safe-media> responds to the message by setting the <webview> 'loaded' attribute: see CL:1256469. [1] The 'html' <file-safe-media> use-case already handles 'onload' via the HTML fetch API, and invokes contentChanged when fetch returns HTML text to render. Test: browser_tests --gtest_filter="QuickView*FilesAppBrowserTest*" Bug: 891150 Change-Id: I12d65a20be3cce570c90b5e0a8fd9e20bd77985c Reviewed-on: https://chromium-review.googlesource.com/c/1267838 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597491}
-
Dominic Mazzoni authored
Starting with revision 591483, the Chrome OS and Win archives are named chrome-chromeos.zip instead of chrome-linux.zip, and chrome-win.zip instead of chrome-win32.zip, respectively. TBR=robertocn@chromium.org Bug: 872783, 789612 Change-Id: I3bc72fa47c6e54b9a0b25306048af9942c06c1fa Reviewed-on: https://chromium-review.googlesource.com/c/1259864 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#597490}
-
Zhuoyu Qian authored
BUG=561800 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2316e2f8929888f965ffd02b59bcd5107c2b703c Reviewed-on: https://chromium-review.googlesource.com/c/1248068 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/957ac4e54f2c..9b74746414c7 Created with: gclient setdep -r src-internal@9b74746414c7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5bd770c3868f33731c0a96c7d37ee280bfa6973d Reviewed-on: https://chromium-review.googlesource.com/c/1267680Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597488}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d527bd95..edb48955 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb77572e857aae9503c93be43aa56496cb2c5dfd Reviewed-on: https://chromium-review.googlesource.com/c/1267819Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/19b51d298334..6d765b07f86f git log 19b51d298334..6d765b07f86f --date=short --no-merges --format='%ad %ae %s' 2018-10-08 jiajia.qin@intel.com ES31: Fix some bugs in ShaderStorageBlockOutputHLSL Created with: gclient setdep -r src/third_party/angle@6d765b07f86f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I4ea5489b822815b86f6ed4d1dbaefb2f82b334e6 Reviewed-on: https://chromium-review.googlesource.com/c/1267679Reviewed-by:
-
Leo Zhang authored
1, Move the rulebased logic to public cpp. 2, Rename the cpp header caused by folder changes. 3, Rename controller to engine and fix deps Bug: 837156 Change-Id: Id0d09e86494ef0c2346a324fcef247ff14604740 Reviewed-on: https://chromium-review.googlesource.com/c/1256322 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597485}
-
Richard Li authored
The ultimate target of this work is moving fetch_api_request.mojom into third_party/blink/public/mojom/fetch/ folder. To accomplish the goal, the whole work is seperated into six parts. 1. Remove content::RequestContextType. Use blink.mojom.RequestContextType instead. --------- CL:1229704 2. Remove content::ServiceWorkerFetchRequest. Use blink.mojom.FetchAPIRequest instead. 3. Remove blink::WebURLRequest::RequestContext. Use blink.mojom.RequestContextType instead. --------- This CL 4. Remove blink::WebServiceWorkerRequest. Use blink.mojom.FetchAPIRequest instead. 5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy instead. --------- CL:1212345 6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer instead. Once all the above tasks get done, fetch_api_request.mojom can be moved into that folder. Change-Id: I8aaed1713d5fd1522049139313260cf221be3dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1242301 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#597484}
-
Tommy Steimel authored
This CL updates the media controls on desktop to have the standard play button in the bottom left corner instead of the overlay play button in the center. As part of this change, the play button is given a disabled state when appropriate, which also applies to the audio player. This fixes a separate issue where the audio player wasn't giving proper feedback with a broken source. Bug: 890078, 839101 Change-Id: Ifbc8b3c216d3537c657b04ff6fc53506b886c48f Reviewed-on: https://chromium-review.googlesource.com/c/1252846Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2a4f9d5ceeb..957ac4e54f2c Created with: gclient setdep -r src-internal@957ac4e54f2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6d88a596b7e02738b69255cbaf68342b111fcb92 Reviewed-on: https://chromium-review.googlesource.com/c/1267677Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Adds the concept of an "active adapter". BluetoothSystem will use the "active adapter" to perform all its operations. If the adapter gets removed, BluetoothSystem will pick another adapter as the "active adapter". If there are no adapters, the state changes to Unavailable. Bug: 870192 Change-Id: Ice2cfc555d2b2c40d99d382db63b7794aaff60e3 Reviewed-on: https://chromium-review.googlesource.com/c/1256395 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597481}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/450bf36f7918..19b51d298334 git log 450bf36f7918..19b51d298334 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 jiawei.shao@intel.com ES31: Support textureGather[Offset] on shadow samplers Created with: gclient setdep -r src/third_party/angle@19b51d298334 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I7456b73d4b5f6d5ca117076de9ff38f87f8abb82 Reviewed-on: https://chromium-review.googlesource.com/c/1267675Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I34edff14dd05d1cc2ff4b0086a94f4d793c25c6f Reviewed-on: https://chromium-review.googlesource.com/c/1267678Reviewed-by:
-
Giovanni Ortuño Urquidi authored
TBR=boliu@chromium.org Bug: 892004 Change-Id: I5d65e66001e164b5b079927a2c62bb1fa3cc8d29 Reviewed-on: https://chromium-review.googlesource.com/c/1267835Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#597478}
-
John Abd-El-Malek authored
Although all callsites that lead to construction of AppCacheURLLoaderJob provide a NavigationLoaderInterceptor::LoaderCallback, some use weak pointers to bind it. So it's possible that in between the time that AppCacheURLLoaderJob grabs the response info from storage that the callback is now empty, which leads to client_ not being initialized. Bug: 882538 Change-Id: Idf234ee6b7c926b36bf199fbfbe0fe655fdf2180 Reviewed-on: https://chromium-review.googlesource.com/c/1267236 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#597477}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9db8376b5d86779ee9fdd5705bfd9496d1829c39 Reviewed-on: https://chromium-review.googlesource.com/c/1267557Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#597476}
-
Giovanni Ortuño Urquidi authored
TBR=vasilii@chromium.org Bug: 893008, 849582 Change-Id: Id88b5b61e0b25528ac94951ee5aa3ac13b021eff Reviewed-on: https://chromium-review.googlesource.com/c/1267756Reviewed-by:
-
Darren Shen authored
The "component_id" is unused, so we remove it. Change-Id: I7e3eca372e4bec90b70e4c38cfa50302107e2602 Reviewed-on: https://chromium-review.googlesource.com/c/1257465Reviewed-by:
-
Giovanni Ortuño Urquidi authored
TBR=dmazzoni@chromium.org Bug: 892960 Change-Id: I240cab39158f9b56cfb5f8ba25d2cb66f93a42f9 Reviewed-on: https://chromium-review.googlesource.com/c/1267635Reviewed-by:
-
Alexey Baskakov authored
Tests still flaky: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29417 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933354636347205216/+/steps/single_process_mash_browser_tests/0/logs/ConsumerDeviceStatusCollectorTimeLimitEnabledTest.ReportingActivityTimesSleepTransistions/0 TBR=poromov@chromium.org Bug: 891573 Change-Id: I9fd2b8b70d5d2483df3ed97d7d657e8cdc43ba3d Reviewed-on: https://chromium-review.googlesource.com/c/1267717Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This is a reland of 6d46cb28 The original patch got reverted because its parent was reverted. There are no changes from the original CL. Original change's description: > bluetooth: Finish implementing GetState() > > Use Adapter's power state for GetState(). > > Bug: 870192 > Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637 > Reviewed-on: https://chromium-review.googlesource.com/c/1250581 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596532} TBR=reillyg@chromium.org Bug: 870192 Change-Id: If4aa220d2c6799ef955a3568f1a32c8eac57b2ba Reviewed-on: https://chromium-review.googlesource.com/c/1264099Reviewed-by:
-
