GitLab

Cr-Commit-Position: refs/heads/master@{#468476}

Before the change, an update check error would terminate the update but leave the
components unhandled. Therefore, for an external observer, it would appear that the
components were stuck on checking for updates.

BUG=687231

Review-Url: https://codereview.chromium.org/2853903002
Cr-Commit-Position: refs/heads/master@{#468475}

BUG=690179

Review-Url: https://codereview.chromium.org/2843383004
Cr-Commit-Position: refs/heads/master@{#468474}

If the Smart Select classifier suggests shortening the selection, we discard the
suggestion. This makes it so Smart Select can only extend a selection and thus
fixes the issue where sometimes it would shorten a SelectAll selection.

BUG=714106

Review-Url: https://codereview.chromium.org/2847133004
Cr-Commit-Position: refs/heads/master@{#468473}

Make file names more consistent in cc/surfaces.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2852163002
Cr-Commit-Position: refs/heads/master@{#468472}

This CL adds CSS for .separator which is a grey separator line
between controls on a row (e.g. settings-box). The intent is to replace
.secondary-action (a TODO has been added to that effect). This initial
CL changes the separator lines seen in the basic main page of MD
settings.

(a step to fix, but not complete fix).
BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2847583002
Cr-Commit-Position: refs/heads/master@{#468471}

Additionally this resolves an incoming margin strut once we know the inline node
isn't empty. In this respect we treat it like a zero-height div.

This regresses some tests that were using the existing LayoutBlockFlow layout.
I.e. when we are inside a LayoutTableCell.

BUG=635619

Review-Url: https://codereview.chromium.org/2851983002
Cr-Commit-Position: refs/heads/master@{#468470}

This is because launcher closes after voice queries.

Also fixing a bug where a voice query was treated as a non-voice query for some short period of time. This happened because while "is voice query" flag was cleared, the query text remained non-empty. This caused, in particular, unnecessary answer server queries after the voice query is over. Stack example (with "is voice" already cleared, and query text is still non-empty):

0  app_list::SearchAnswerWebContentsDelegate::Update (this=0x48a03b686e0, is_voice_query=<optimized out>) at ../../chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc:93
1  0x000064441d08df8a in AppListViewDelegate::OnTemplateURLServiceChanged (this=0x48a046fa000) at ../../chrome/browser/ui/app_list/app_list_view_delegate.cc:534
2  0x000064441c687230 in TemplateURLService::NotifyObservers (this=<optimized out>) at ../../components/search_engines/template_url_service.cc:2124
3  0x000064441c68ec06 in Update (this=0x48a0265a340, existing_turl=0x48a0350d600, new_values=...) at ../../components/search_engines/template_url_service.cc:1713
4  TemplateURLService::UpdateTemplateURLVisitTime (this=0x48a0265a340, url=0x48a0350d600) at ../../components/search_engines/template_url_service.cc:1787
5  0x000064441c689375 in TemplateURLService::UpdateKeywordSearchTermsForURL (this=0x48a0265a340, details=...) at ../../components/search_engines/template_url_service.cc:1781
6  0x000064441af6bb4f in non-virtual thunk to ChromeTemplateURLServiceClient::OnURLVisited(history::HistoryService*, ui::PageTransition, history::URLRow const&, std::vector<GURL, std::allocator<GURL> > const&, base::Time) ()
    at ../../chrome/browser/search_engines/chrome_template_url_service_client.cc:85
7  0x000064441c62bf32 in history::HistoryService::NotifyURLVisited (this=0x48a027df500, transition=805306373, row=..., redirects=std::vector of length 0, capacity 0, visit_time=...) at ../../components/history/core/browser/history_service.cc:1092
......

Some frames may be optimized away due to inlining.

Also other optimizations and cleanups; as a result, we now have exactly as many expensive requests (such as server queries) as necessary.

Bug=712331

Review-Url: https://codereview.chromium.org/2846733004
Cr-Commit-Position: refs/heads/master@{#468469}

BUG=663085

Review-Url: https://codereview.chromium.org/2856653002
Cr-Commit-Position: refs/heads/master@{#468468}

This verifies that one request per page has pid= and that 5 consecutive
page loads generates 5 unique IDs.

BUG=709516

Review-Url: https://codereview.chromium.org/2845803002
Cr-Commit-Position: refs/heads/master@{#468467}

getLocationInWindow adjusts for the Android nav bar, while the
positioning of the parent is exclusive of the nav bar.  This causes
the suggestions be too bar left aligned and cut off.

Only visible if you have the nav bar aligned with the start of
the text (i.e. on the left with LTR text).

BUG=669150

Review-Url: https://codereview.chromium.org/2849283002
Cr-Commit-Position: refs/heads/master@{#468466}

BUG=687231

Review-Url: https://codereview.chromium.org/2856573003
Cr-Commit-Position: refs/heads/master@{#468465}

I believe we aren't always getting the begin main frame signal leading
to an increase in hung renderers when rAF mouse aligned input is
enabled. Test my theory by adding a timer that fires after a
significantly long time (5s) if we are waiting for a signal but
haven't received it.

BUG=703344

Review-Url: https://codereview.chromium.org/2846333002
Cr-Commit-Position: refs/heads/master@{#468464}

https://skia.googlesource.com/skia.git/+log/d170c0fb48aa..5664e65eb168

$ git log d170c0fb4..5664e65eb --date=short --no-merges --format='%ad %ae %s'
2017-05-01 mtklein finish up constants
2017-05-01 mtklein refactor hsl_to_rgb a touch
2017-05-01 benjaminwagner Update Nexus6p to Android O developer release.
2017-05-01 mtklein fix t / t2 confusion in hsl_to_rgb
2017-05-01 mtklein getting close on float constants
2017-05-01 bungeman SkFontMgr::matchFamily should not crash on nullptr.
2017-05-01 mtklein some float constants
2017-05-01 scroggo Blacklist SkImage_makeTextureImage on NVIDIA Win10 Vulkan
2017-05-01 egdaniel Fix Creation of GrBackendRenderTarget from GrBackendRenderTargetDesc in GL

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I6a61e519ac953988db16f774779576650a855c8e
Reviewed-on: https://chromium-review.googlesource.com/492090Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468463}

BUG=684839

Review-Url: https://codereview.chromium.org/2847823004
Cr-Commit-Position: refs/heads/master@{#468462}

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837023004
Cr-Commit-Position: refs/heads/master@{#468461}

Revert of [Android] Keep extracted secondary dex files when clearing data in tests. (patchset #2 id:20001 of https://codereview.chromium.org/2854503002/ )

Reason for revert:
primary suspect for crbug.com/717267

Original issue's description:
> [Android] Keep extracted secondary dex files when clearing data in tests.
>
> BUG=716029
>
> Review-Url: https://codereview.chromium.org/2854503002
> Cr-Commit-Position: refs/heads/master@{#468356}
> Committed: https://chromium.googlesource.com/chromium/src/+/039ec1ad2eaec6f13bfdda8cb3ac5e5d8cdc32b3

TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=716029

Review-Url: https://codereview.chromium.org/2849323002
Cr-Commit-Position: refs/heads/master@{#468460}

Review-Url: https://codereview.chromium.org/2846333003
Cr-Commit-Position: refs/heads/master@{#468459}

- Adds new shared pref key and values for search engine promo state
- Exposes prevous promo type features in ChromeFeatureList to java

BUG=712833, 712836

Review-Url: https://codereview.chromium.org/2848333002
Cr-Commit-Position: refs/heads/master@{#468458}

On Windows, we can use GPU IO thread to filter some messages for GPUVEA.
In that case, while GpuVideoEncodeAccelerator::OnWillDestroyStub() is running
on main thread, GpuVideoEncodeAccelerator::OnEncodeFrameCreated() can run
on IO thread. If |encoder_| is reset on main thread and accessed on IO
thread, we see the crashes listed on the bug.
This CL solves the issue by:
- Checking |filter_removed_| which is signaled on IO thread before deciding
to continue with encode GpuVideoEncodeAccelerator::OnEncodeFrameCreated() on
IO thread.
- Making sure that |encoder_worker_thread_| tasks are completed before reset.

BUG=715759
TEST=Tested AppRTC loopback with H264.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849443003
Cr-Commit-Position: refs/heads/master@{#468457}

This patch switches UsbServiceLinux to being initialized with a
SequencedTaskRunner that puts it on its own non-shutdown-blocking
sequence. Individual device connections are also put on their own
sequences because there is no dependency between them and the global
service.

As DeviceMonitorLinux is global and owned by the FILE thread a new
UdevWatcher class has been added which can be owned by each service
that needs to monitor udev and lives on its own sequence.

This should resolve issue 694496 by allowing Chrome to exit even if a
faulty driver or device has locked up the USB service.

BUG=694496

Review-Url: https://codereview.chromium.org/2849953003
Cr-Commit-Position: refs/heads/master@{#468456}

Previously, WMPI used kNoSurfaceID to indicate both that a surface
shouldn't be used for overlays on Android, and that no surface has
been provided yet by the SurfaceManager.  This could lead to a
deadlock if the SurfaceManager actually does return kNoSurfaceID,
and we're on pre-M Android.

This CL represents the surfac ID as a base::Optional, with the
unset state indicating that a call to SurfaceManager is pending.

BUG=

Review-Url: https://codereview.chromium.org/2856643002
Cr-Commit-Position: refs/heads/master@{#468455}

After the direct share icon is clicked, the dialog of context menu
does not dissmiss. This is because onClick event of the direct share
icon does not call dialog to dismiss. To fix the problem, add an
delegate interface for direct share action and implement it in the
TabularContextMenuUi.

BUG=None

Review-Url: https://codereview.chromium.org/2853483003
Cr-Commit-Position: refs/heads/master@{#468454}

BUG=707642

Review-Url: https://codereview.chromium.org/2847203002
Cr-Commit-Position: refs/heads/master@{#468453}

The SAMLPolicyTest.TransferCookiesUnaffiliated test and its PRE-test
were timing out in Debug builds.

There is nothing obvious that can be improved in the test. Also the
timeout times agree to some degree with the slowdown of the Debug mode
measured locally.

Therefore disabling this test in Debug builds.

BUG=683161,714167

Review-Url: https://codereview.chromium.org/2845393002
Cr-Commit-Position: refs/heads/master@{#468452}

PluginPlaceholders are RenderFrameObservers, and render_frames can
go away before the object is actually destructed (during shutdown).

This CL adds the missing null checks needed to prevent trying to use
null pointers.

BUG=693120
R=raymes@chromium.org

Review-Url: https://codereview.chromium.org/2845413002 .
Cr-Commit-Position: refs/heads/master@{#468451}

https://pdfium.googlesource.com/pdfium.git/+log/b8e00f247803..a0a69233cafa

$ git log b8e00f247..a0a69233c --date=short --no-merges --format='%ad %ae %s'
2017-05-01 tsepez Remove more |new|s, part 5

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If0b0a847696fdb7d64b8ebf186af9e0db4a5652f
Reviewed-on: https://chromium-review.googlesource.com/491929
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468450}

BUG=707642

Review-Url: https://codereview.chromium.org/2846283002
Cr-Commit-Position: refs/heads/master@{#468449}

changes:
(1) When entering the tablet mode, the status area tray will always show the rotation lock auto or locked.
(2) For system tray menu, the locked state is divided into two states: landscape and portrait.

crbug.com/704923 #9 shows the UI implementation.

BUG=704923
TEST=tested on device

Review-Url: https://codereview.chromium.org/2846883006
Cr-Commit-Position: refs/heads/master@{#468448}

Also removed some delegate-to-superclass-only
DeprecatedInvalidationPaint() because there is no more naming
conflict with the new version.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2851453005
Cr-Commit-Position: refs/heads/master@{#468447}

A series of tests are flaking right now due to SessionController.cc issue.

This disables those tests while I work on a fix.

TBR=sky@chromium.org
TEST=mash_browser_tests
BUG=717176

Review-Url: https://codereview.chromium.org/2852963003
Cr-Commit-Position: refs/heads/master@{#468446}

I was unable to completely switch over to const ModelTypeSet& usage in
the syncer, as during a NormalSyncShare we modify the ModelTypeSet*
during GetUpdates, so when we Commit we have a reduced set of types.

BUG=

Review-Url: https://codereview.chromium.org/2850213002
Cr-Commit-Position: refs/heads/master@{#468445}

This line was mistakenly added in:

https://codereview.chromium.org/2839183002/

BUG=717099

Review-Url: https://codereview.chromium.org/2853013003
Cr-Commit-Position: refs/heads/master@{#468444}

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2850633003
Cr-Commit-Position: refs/heads/master@{#468443}

BUG=176436

Review-Url: https://codereview.chromium.org/2843213002
Cr-Commit-Position: refs/heads/master@{#468442}

Caused by https://codereview.chromium.org/2836293003. Instead detect
when margin has moved a float completely out of its former position
and mark any affected siblings for layout.

BUG=716385

Review-Url: https://codereview.chromium.org/2846923003
Cr-Commit-Position: refs/heads/master@{#468441}

These tests are still flaky when virtualized GL contexts are used in
the command buffer. So far no luck reproducing these failures locally.

BUG=694359
TBR=zmo@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2853133002
Cr-Commit-Position: refs/heads/master@{#468440}

For now start with content_browsertsts with network service enabled.

(chromium repo change)

BUG=713857

Review-Url: https://codereview.chromium.org/2848013002
Cr-Commit-Position: refs/heads/master@{#468439}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2b7090e93566..9300a23423c0

$ git log 2b7090e93..9300a2342 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 eakuefner [Dashboard] Implement add_histograms_queue
2017-05-01 simonhatch Dashboard - Fix email_summary for internal_only.

Created with:
  roll-dep src/third_party/catapult
BUG=716025


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I8ff3ac7ca1fea1f131d1bb0cc5c166dd6f44d103
Reviewed-on: https://chromium-review.googlesource.com/491907
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468438}

BUG=717201

Review-Url: https://codereview.chromium.org/2853013004
Cr-Commit-Position: refs/heads/master@{#468437}