- 08 Mar, 2018 6 commits
-
-
David Benjamin authored
Also use base::StringPiece rather than a std::string reference. It avoids some unnecessary copies in the substrings. Bug: 814591 Change-Id: I7a1a0387b09038f7e084b2baf7b67716c729710a Reviewed-on: https://chromium-review.googlesource.com/953744Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#541652}
-
Jao-ke Chin-Lee authored
Migrated builders being removed from console: * GPU Linux Builder * Cast Linux * Linux Builder * Linux Builder (dbg) * Linux Tests * Linux Tests (dbg)(1) * Mac10.13 Tests (dbg) Bug: 790061, 790118, 790133, 790138, 790143, 790140, 818393 Change-Id: I77a097b28129870a19c5d21c6fbf99b9c67dde8e Reviewed-on: https://chromium-review.googlesource.com/954284Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#541651}
-
Dave Schuyler authored
This CL suggests that the words "test" and "example" be treated as QUERY regardless of whether whitespace is present (e.g. "test "). Without this CL something like "test " (with a trailing space) will be UNKNOWN, which may be treated as a URL or QUERY (it's not explicit -- this CL makes it explicit). Bug: 818137 Change-Id: Iedaa4e3c06782a9d9131d3e91d3cee87c1dee7ab Reviewed-on: https://chromium-review.googlesource.com/950235 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541650}
-
Lukasz Anforowicz authored
This CL tries to remove test expectations from LayoutTests/FlagExpectations/site-per-process if they are already covered by expectations in LayoutTests/TestExpectations Bug: 477150, 711468, 788390 Change-Id: I89b0838d7fc3dbdbb536d542baf2d3e5e31b6faf Reviewed-on: https://chromium-review.googlesource.com/953222 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541649}
-
Raymond Toy authored
Implements the core of the tail processing algorithm for AudioNodes, but doesn't actually enable it. Enabling will fill be in a follow-up CL. Keep nodes alive when there are no input connections so that the node has time to flush out any internal memory. When the output of the node is going to be disabled (because there are no inputs), place the node on a list, without disabling the output. The list is processed every rendering quantum to see if the tail time of node has passed. If the tail time has not passed, nothing is done; otherwise, the output is disabled, and the node is removed from the list. This allows the node to be collected, if possible. Bug: 357843 Test: AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html Change-Id: I895255f856c079dbeed872120ab5c0cb36b8bdb3 Reviewed-on: https://chromium-review.googlesource.com/949762Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541648}
-
Darren Shen authored
In ash/accelerators/accelerator_controller, we need to query / set the caps lock state. This is currently done through InputMethodManager. Under mash, InputMethodManager will not be available from accelerator_controller, so we'll need to query / set the caps lock state via Mojo. We use the existing ImeController::IsCapsLockEnabled() and ImeController::SetCapsLockFromTray (renamed to SetCapsLockEnabled) methods. Bug: 819081 Change-Id: Id4b4337f6cb9268116b4c6bb034ad4004a3a7705 Reviewed-on: https://chromium-review.googlesource.com/950503Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#541647}
-
- 07 Mar, 2018 34 commits
-
-
inglorion authored
crbug.com/818086 shows that using control flow guard, ThinLTO, and RTTI together results in broken binaries. This change disables CFG when ThinLTO and RTTI are enabled to allow builds to succeed while a fix for the problem is developed. R=dpranke,thakis Bug: 818086 Change-Id: Ia926350dc4193f3a1c87a45b36a8d5dc1dd97c08 Reviewed-on: https://chromium-review.googlesource.com/952666Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541646}
-
yiyix authored
RenderFrameMetadataProvider(RFMP) is not available until calling RWHI::RequestCompositorFrameSink, that is no observer can be added before that point, which may not be convenient for all observers. In this patch, RenderFrameMetadataProvider will be created in RenderWidgetHostImpl constructor and the ready to receive and send information after calling RequestCompositorFrameSink. For Example: RenderWidgetHostViewAura is created and start to observe changes in RFM before calling RWHI::RequestCompositorFrameSink. Bug: 716911 Change-Id: Icac9d5ff44a24b2a828bb7946202917f79c93147 Reviewed-on: https://chromium-review.googlesource.com/952200 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#541645}
-
https://webrtc.googlesource.com/src.git/+log/12edf4ce344d..98bb968f7bed $ git log 12edf4ce3..98bb968f7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b15c8329fb0542de893ca6a6efb78f623d50581 Reviewed-on: https://chromium-review.googlesource.com/953650Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541644}
-
Adam Langley authored
https://boringssl.googlesource.com/boringssl/+log/f8058d41147543d6ad9a5ae5d70e7d19198bbe33..a6bfc45b6286e358ba83f7daa769e1e9012cc7bb BUG=none Change-Id: I21c45bdad92ecbe9879be5a414c336d490146b9f Reviewed-on: https://chromium-review.googlesource.com/953649Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541643}
-
erikchen authored
In my recent change to this file: https://chromium-review.googlesource.com/c/chromium/src/+/951745/5/remoting/host/current_process_stats_agent.cc#35, I accidentally called the set_working_set_size setter with the PagefileUsage metric. This CL fixes it to use the set_pagefile_size setter. Bug: 819289 Change-Id: I3670f955bb484c1eb27d067c72d17a4d745a2446 TBR: sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/953764Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541642}
-
https://chromium.googlesource.com/angle/angle.git/+log/e4c5a23b1148..40dba69082bd $ git log e4c5a23b1..40dba6908 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 jmadill Update copyright notice in the style guide. 2018-03-05 brandon1.jones Add NPOT validation to copyTextureCHROMIUM Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I9c329b16a07a26ac9942446f53357722d18c26ef Reviewed-on: https://chromium-review.googlesource.com/953653Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541641}
-
Becky Zhou authored
+ Fix keyboard not showing when interacting between url bar and prompt javascript dialog + Fix keyboard not being hidden when entering tab switcher + Add accessibility description when opening tab modal dialogs Bug: 798893, 812443 Change-Id: I162b4dface23c5af142ffc2054aaf489dcc53647 Reviewed-on: https://chromium-review.googlesource.com/897989 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541640}
-
Ted Choc authored
BUG=819730 Change-Id: I772f0a960ecc79cc43d0f924448b2c7823755fb6 Reviewed-on: https://chromium-review.googlesource.com/953659Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541639}
-
Chong Zhang authored
Removed 2 tests from the filter: -RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler * Fixed by adding |ScopedIPCSupport| after |InitializeMojo()|. -RenderThreadImplBrowserTest.ResourceDispatchIPCTasksGoThroughScheduler * This test no longer exists. -- Note: the first test used to crash with log: [91028:91028:0307/112240.705814:2593896751430:FATAL:scoped_refptr.h(219)] Check failed: ptr_. #0 0x7f69ce3986ad base::debug::StackTrace::StackTrace() #1 0x7f69ce396b9c base::debug::StackTrace::StackTrace() #2 0x7f69ce41ebca logging::LogMessage::~LogMessage() #3 0x7f69d0131b42 scoped_refptr<>::operator->() #4 0x7f69d016d49b mojo::edk::NodeController::SendBrokerClientInvitation() #5 0x7f69d013becf mojo::edk::Core::SendBrokerClientInvitation() #6 0x7f69d01c06ea mojo::edk::OutgoingBrokerClientInvitation::Send() #7 0x7f69c9cb0df8 content::internal::ChildProcessLauncherHelper::PostLaunchOnLauncherThread() #8 0x7f69c9cb08cd content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I18d85b91b5db78087c7e507df3d38da767327e1b Reviewed-on: https://chromium-review.googlesource.com/953248Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541638}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. (GetProcAddress() returns FARPROC, a function pointer type.) Bug: 550065 Change-Id: Ia96aaa2ef58a434ef61e7d8d0c6df9b632d6b1c2 Reviewed-on: https://chromium-review.googlesource.com/953743Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541637}
-
Sergey Berezin authored
BUG=813163 TBR=jochen@chromium.org Change-Id: I1fb5565b978fb38b39fb2ddf9f726f9a3c5bd794 Reviewed-on: https://chromium-review.googlesource.com/953591Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541636}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ic2218d2ce520b53b6da32947d4def70a72f69c27 Reviewed-on: https://chromium-review.googlesource.com/952707Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541635}
-
Yuly Novikov authored
BUG=810917 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5370ff9d3a8cc943e511f8cc5da272d07d47406d Reviewed-on: https://chromium-review.googlesource.com/953325Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541634}
-
Kenneth Russell authored
BUG=chromium:811811 BUG=chromium:811905 BUG=chromium:811815 BUG=chromium:811796 BUG=chromium:811831 BUG=chromium:811789 BUG=chromium:811809 BUG=chromium:811821 BUG=chromium:811869 BUG=chromium:811866 BUG=chromium:811781 BUG=chromium:811799 BUG=chromium:811814 BUG=chromium:811864 BUG=chromium:811835 BUG=chromium:811834 Change-Id: I6019014dd1032a0553f520b1127a2e5041a425e3 Reviewed-on: https://chromium-review.googlesource.com/953256Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541633}
-
Robert Liao authored
This allows browser_action_test_util_views_mac.mm to be used in the future for shared code between Mac Views and Aura Views. BUG=818397 Change-Id: I3c0937216233ffbbe1933ad3cbb423da1010feb2 Reviewed-on: https://chromium-review.googlesource.com/953245Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#541632}
-
Menglu Huang authored
iOS swarming arguments doesn't contain isolate args, which are separated by '--' from the swarming trigger arguments. Remove the '--' assert in the script which blocks iOS tasks to use the custom swarming trigger logic. Other platforms: <args to swarming.py trigger> -- <args to bot running isolate> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I49bb5a1c0abf78a5aa775d139f9dc60c60adeb09 Reviewed-on: https://chromium-review.googlesource.com/953251Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#541631}
-
Kenneth Russell authored
This is temporary, in order to be able to continue running the GLES1 and GLES2 conformance tests on these bots. The tests need to be migrated to other machines. Bug: 819751 Change-Id: Idfb9c70fd81cb7891bbc597e541a9bb64f686511 Reviewed-on: https://chromium-review.googlesource.com/953825Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541630}
-
David Tseng authored
This reverts commit d6d6b05f. Reason for revert: <INSERT REASONING HERE> Original change's description: > Better support crosh > > - value change events often fire on richly editable text fields. We do not really use this in the state machine for rich text, so ignore it. It often causes poor state transitions e.g. speaking "deleted" in crosh when typing. > - use the AutomationRichEditableText class in more cases. This acknowledges the usage in the wild where a page author can set role textbox on any node. When they do this it is assumed they manage a DOM selection unless they set the role on either an input or textarea where the browser does this on their behalf. > > Test: chromevox_tests --gtest_filter=Editing*.*. Manually on crosh, by typing into the text field. > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8a9cf31e8834434ade0960d5e0b3045a664bc7ca > Reviewed-on: https://chromium-review.googlesource.com/952193 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541378} TBR=dmazzoni@chromium.org,dtseng@chromium.org Change-Id: I3a3d196e9dfefdaed96fb098c6ecaf8cc5643d82 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/954042Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541629}
-
Wenzhao Zang authored
It should be fine to remove the entire code path within |focusInput| with |opt_ensureFocus| == true, since the original bug crbug.com/725622 was fixed by reverting another CL. However to be safe, this CL only affects user pods without password input field. The cause of the bug might be: when clicking the pod that requires online sign-in (ie. the pod that does not display a password field), the focus immediately goes to the GAIA sign-in page, so the pod never gets the chance to remove the focus listener. When the GAIA page is closed, the pod is still trying to steal focus. It's observed that the issue doesn't exist if the GAIA page is not opened. Bug: 778371 Change-Id: Ib4f39798fa60bc0cf72bbfd67c7fe8e997f7eedb Reviewed-on: https://chromium-review.googlesource.com/950475Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541628}
-
Achuith Bhandarkar authored
BUG=chromium:819050 TEST=None Change-Id: I821bd35f6a0ce3129f3753b282e120003f5b90a6 Reviewed-on: https://chromium-review.googlesource.com/953826Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#541627}
-
Yixin Wang authored
|retransmittable_on_wire_timeout_| is set and there are active requests. If retransmittable_on_wire_timeout_ is explicitly set, then the following behavior is enabled: If an ACK is received such that there are no more unacked packets, a short delay timer will start if the connection has active requests (to expire retransmittable_on_wire_timeout_ from the now). When the timer expires, a PING frame will be sent. If a retransmittable packet is sent while the timer is active, the timer is cancelled. This is intended to only be enabled for Cronet for connection migration. Merges internal change 187955841 Change-Id: I0517e2768ccdd785f05de484dc2fe77eaaa32ea0 Reviewed-on: https://chromium-review.googlesource.com/953340Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#541626}
-
Simeon Anfinrud authored
I need a page I can point to when people have questions about the framework, or just a reference for myself and others who want to look at examples of how to use the framework. Bug: Internal b/74206681 Test: preview page in markdown renderer Change-Id: I2ab3f5d92dbe103c8f4929a79758272e61c44e75 Reviewed-on: https://chromium-review.googlesource.com/950137 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#541625}
-
Xiaocheng Hu authored
Mojo doesn't allow an unrun callback to be removed before the message pipe is closed. However, Mac spellchecker manages RequestTextCheckCallbacks as (indirectly) owned by a completion barrier in SpellingRequest, which lives independently with the message pipe. Hence, in some shutdown orders, the callback can be cleared while the message pipe is still open. This patch fixes the issue by making SpellCheckHost own all pending SpellingRequests, and SpellingRequest own RequestTextCheckCallback. Note: this patch serves as a quick fix to the regressed test cases. A follow-up patch will clean up the code. Bug: 814845 Change-Id: I22a08cdce2744b50fe23c0ff48c10d5207fa5f8b Reviewed-on: https://chromium-review.googlesource.com/946848 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541624}
-
Eugene But authored
Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia98dcc56f5681e033d0ec02dd9714d16ca6f40a6 Reviewed-on: https://chromium-review.googlesource.com/947093 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541623}
-
Wenzhao Zang authored
BUG: 819326 Change-Id: I0afe3443fb1560baf0149e00ce0044a36fc525a3 Reviewed-on: https://chromium-review.googlesource.com/951861Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541622}
-
Dan Harrington authored
OfflinePageMetadataStore was only referenced in the unittest, now it has been removed. A few methods/types were migrated to OfflinePageMetadataStoreSQL, others were removed because the were no longer in use. I removed some tests that only tested the removed methods. Other methods that were used to test the database and were moved to the test file, like GetOfflinePages and AddOfflinePage. offline_page_metadata_store_unittest.cc will be renamed offline_page_metadata_store_sql_unittest.cc in a follow-up. Bug: 778813 Change-Id: I6315cd5fb43b8a56b84dcede8c388286dd96e39c Reviewed-on: https://chromium-review.googlesource.com/949502Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#541621}
-
Weidong Guo authored
When the folder is created, the folder item view's origin is initiated with (0, 0). So after dragging the folder item view will be animated to where it is supposed to be, which cause the weird movement. The same thing happens when the last item is moved outside the folder. Changes: Use the original view's bounds to set the newly created view's bounds before the deletion of the original view. BUG=819664 Change-Id: Id0066b27a0bd30f04e5b62c6b782178fbf84d48c Reviewed-on: https://chromium-review.googlesource.com/953204Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541620}
-
https://skia.googlesource.com/skia.git/+log/461ef7af88cc..88df8d2e5a87 $ git log 461ef7af8..88df8d2e5 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 stephana Test SKQP on Firebase Testlab and Upload 2018-03-07 csmartdalton ccpr: Combine GS triangle hulls and edges into a single draw 2018-03-07 bsalomon Make Vulkan testing-only backend textures have optimal layout 2018-03-07 bsalomon Rename wrap backend tex/rt methods on GrProxyProvider 2018-03-07 robertphillips Have GrGlyphCache and GrAtlasManager compute the atlas limits independently 2018-03-07 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 7618eaf9a..2202680c6 (4 commits) 2018-03-07 csmartdalton ccpr: Fix very small edges 2018-03-07 reed Revert "Revert "add tiler for SkDraw"" 2018-03-07 robertphillips Revise Text & Small Path Atlas so instantiation failure is handled at flush time 2018-03-07 reed chop down huge rects before hairlining 2018-03-07 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 8a7ec86c0..da8c41528 (1 commit) 2018-03-07 bsalomon Initial texture data is never flipped when uploaded. 2018-03-07 herb Revert "Remove attach and detach glyph cache." 2018-03-07 bsalomon Remove abandon param from GrGpu::deleteTestingOnlyBackendTexture. 2018-02-27 mtklein Reland "Reland "make SkJumper stages normal Skia code"" 2018-03-07 mtklein Revert "Reland "make SkJumper stages normal Skia code"" 2018-03-05 herb Remove attach and detach glyph cache. 2018-02-27 mtklein Reland "make SkJumper stages normal Skia code" 2018-03-07 bungeman Remove dm excludes from public.bzl. 2018-03-07 mtklein Revert "make SkJumper stages normal Skia code" 2018-02-27 mtklein make SkJumper stages normal Skia code 2018-03-07 bsalomon Prefer kMixedSamples MSFBOType to multisampled-render-to-texture variants Created with: roll-dep src/third_party/skia BUG=757974 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I69907ba55222be9cd5691d6e009cc45cb259bbd3 Reviewed-on: https://chromium-review.googlesource.com/953170Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541619}
-
Luciano Pacheco authored
CL #4 out of 5. Converted the following directories: - third_party/WebKit/Source/platform/audio - third_party/WebKit/Source/platform/exported - third_party/WebKit/Source/platform/graphics When the ctor is private replaced to base::WrapUnique, otherwise used std::make_unique. Removed include of wtf/PtrUtil.h. Fixed missing includes pointed by git cl lint. Bug: 781645 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia41caa048f5c9cfea1ed95b8052bf23fd5ff6c2b Reviewed-on: https://chromium-review.googlesource.com/950486Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#541618}
-
Katie D authored
If the Accessibility node becomes undefined during reading, the default behavior is to stop reading immediately. This allows STS to continue reading hen nodes are undefined. Advanced users may want more control over text, while novice users may be surprised when text continues after windows are closed (and there's no visual indicator that speech is still in prgoress). An open question is whether this should also apply to nodes that disappear from the screen after their window is closed or minimized, or if they are scrolled off screen. Right now, that behavior is read and is unchanged by this patch. Adds this behind the --enable-experimental-accessibility-features flag in Chrome OS. Bug: 818835 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib063d6ac5071f35a5d4e0a90cd472bb0ffc165f9 Reviewed-on: https://chromium-review.googlesource.com/949776 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541617}
-
Noel Gordon authored
Patch to prepare to for the removal of [iterations] option, so we can replace it with a rate-based bench marker tool similar to zlib_bench. First step: remove the [packetSize] option. Bug: 601198 Change-Id: If5fabb8597209dac88b134a71d648a950910c86d Reviewed-on: https://chromium-review.googlesource.com/952603Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#541616}
-
Jinsuk Kim authored
This CL fixes a bug that removes tab strip upon opening a new tab while text selection is made on tablets. Made sure the action mode toolbar gets animated out (if present) before new tab gets opened. Bug: 807712 Change-Id: Icba04263d836733595696f12063c3b47afd314f0 Reviewed-on: https://chromium-review.googlesource.com/952602 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#541615}
-
James Cook authored
ChromeVoxPanel depends on knowledge of fullscreen state and docked magnifier state in order to compute its bounds. In addition it can update the window manager's work area. Under go/mustash this knowledge lives in the ash process, not in the browser. Therefore move the bounds and work area management into ash. Next steps include introducing a mojo interface for setting the ChromeVox panel's fullscreen state and moving AccessibilityObserver support to ash::AccessibilityController from the system tray code. Bug: 628655, 819351 Test: added to ash_unittests Change-Id: Ibb27a0b8ab6b998ecd305b7e7bfbad8b35853613 Reviewed-on: https://chromium-review.googlesource.com/952263 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541614}
-
Amirhossein Simjour authored
Backplane of the hosted dialogs are moved to align with main content. As a result the dialog itself will be in the center of the web content. BUG=808560 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6addedbfef905c51e11d5a6a5c95f889775a2078 Reviewed-on: https://chromium-review.googlesource.com/953247Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#541613}
-