GitLab

These tests are flaky on all platforms.

BUG=chromium:340354
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/1026673002

Cr-Commit-Position: refs/heads/master@{#321535}

BUG=466631

Review URL: https://codereview.chromium.org/1011553003

Cr-Commit-Position: refs/heads/master@{#321534}

Review URL: https://codereview.chromium.org/1002623005

Cr-Commit-Position: refs/heads/master@{#321533}

The following CL replaces the existing code with the new class.

BUG=469039
TEST=JobEventRouterTest

Review URL: https://codereview.chromium.org/1023923002

Cr-Commit-Position: refs/heads/master@{#321532}

Ensures that we can figure out how often zero suggest is triggered in a
session.

BUG=

Review URL: https://codereview.chromium.org/1002263006

Cr-Commit-Position: refs/heads/master@{#321531}

Cr-Commit-Position: refs/heads/master@{#321530}

supported 32K using finch experiment.

BUG=464063

Review URL: https://codereview.chromium.org/1016563005

Cr-Commit-Position: refs/heads/master@{#321529}

BUG=

Review URL: https://codereview.chromium.org/1012333004

Cr-Commit-Position: refs/heads/master@{#321528}

Revert of Disabling failing tests in WebRtcApprtcBrowserTest (patchset #2 id:20001 of https://codereview.chromium.org/1016693002/)

Reason for revert:
We have landed an update to the AppRTC app in https://codereview.chromium.org/1023683002/ now, so these tests should now work.

Original issue's description:
> Disabling failing tests in WebRtcApprtcBrowserTest.
>
> These tests will be enabled again once the AppRTC app is working again which we expect will happen rather soon.
>
> TBR=phoglund
> BUG=467471
>
> Committed: https://crrev.com/15103a5ff0f262c85309d4b6af957d7c089aab3d
> Cr-Commit-Position: refs/heads/master@{#320883}

TBR=phoglund@chromium.org,henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467471

Review URL: https://codereview.chromium.org/1027673002

Cr-Commit-Position: refs/heads/master@{#321527}

R=agoode@chromium.org,wolenetz@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1023893002

Cr-Commit-Position: refs/heads/master@{#321526}

BUG=465971

Review URL: https://codereview.chromium.org/1011813006

Cr-Commit-Position: refs/heads/master@{#321525}

Visual studio uses rip-relative addressing (rra) extensively in 64 bit binaries. ParseRel32RelocsFromSection does not find these addresses, which causes courgette to miss a lot of rva pointers, and thus missing a lot of compresssion opportunities.

This patch makes the ParseRel32RelocsFromSection find rip relative call/jmp/lea. It also finds mov's that load from memory using rra's.

Based on CL by niels.werensteijn.teamspeak@gmail.com in crrev.com/212563003

This change gives a noticeable improvement on 64-bit binaries. Against test binaries (64-bit chrome.dll 40.0.2214.115->43.0.2317.0) the patch sizes were:

Uncompressed:
before: 10,948,152
after: 9,948,442 (9.1% reduction)

Compressed (7z ultra):
before: 6,084,670
after: 5,581,502 (8.3% reduction)

BUG=459064
TEST=courgette_unittests

Review URL: https://codereview.chromium.org/878043002

Cr-Commit-Position: refs/heads/master@{#321524}

As the TODO in cast_config.h bu miu@, remove rtcp_interval, since it is
always be kDefaultRtcpIntervalMs.

BUG=
R=miu@chromium.org

Review URL: https://codereview.chromium.org/1012573002

Cr-Commit-Position: refs/heads/master@{#321523}

and share it with both the QuicClientSession and QuicSimpleClient.

BUG=

Review URL: https://codereview.chromium.org/1009803003

Cr-Commit-Position: refs/heads/master@{#321522}

The low battery notification is a TrayNotificationView. This CL makes it
into a message center notification instead, giving it updated icons.

This fixes issues caused by using the outdated tray notification style.

A new BatteryNotification class is added to show, hide and update
the MessageCenter Notification. TrayPower::PowerNotificationView is
removed. PowerStatusView and PowerStatusViewTest are simplified.

BUG=163120,371364
R=skuhne@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/1014753003

Cr-Commit-Position: refs/heads/master@{#321521}

BUG=468085

Review URL: https://codereview.chromium.org/999643003

Cr-Commit-Position: refs/heads/master@{#321520}

properties.
With this patch we benchmark both of these upload techniques.

When using glTexSubImage2D the texture storage is specified with
glTexStorage2D when available, or glTexImage2D passing an empty pointer as data.

Trying to re-land this patch after it broke the perfbots (crbug.com/468748).

BUG=468748

Review URL: https://codereview.chromium.org/1027623002

Cr-Commit-Position: refs/heads/master@{#321519}

BUG=84250
TBR=aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/1021963002

Cr-Commit-Position: refs/heads/master@{#321518}

This change was automatically generated by running:
  update_use_counter_feature_enum.py

BUG=428806

Review URL: https://codereview.chromium.org/1024763002

Cr-Commit-Position: refs/heads/master@{#321517}

currently behavior of alt+Left arrow key and Left Arrow key are same.
Check added so that when user select alt+Left arrow key then it will
be handled by default behavior.

BUG=468605

Review URL: https://codereview.chromium.org/1019193002

Cr-Commit-Position: refs/heads/master@{#321516}

BUG=450630
TEST=None

Review URL: https://codereview.chromium.org/1018853005

Cr-Commit-Position: refs/heads/master@{#321515}

In Compositor Frame Time counter the text "time(ms)" gets chopped from right side.
Also in FPS Display "GPU raster" status get chopped from right side.

This is caused due to width constraint.
Rearranging the Display items to display all items properly

BUG=445877

Review URL: https://codereview.chromium.org/1001123003

Cr-Commit-Position: refs/heads/master@{#321514}

This CL makes the ContentsView's API state-keyed rather than page index
keyed. This removes cruft from callers of SetActivePage and will
support further refactors.

BUG=455059
TBR=jamescook@chromium.org, benwells@chromium.org

Review URL: https://codereview.chromium.org/947903002

Cr-Commit-Position: refs/heads/master@{#321513}

Add capability for having a "Report abuse" checkbox on the extension uninstall
dialog. Currently, don't show this until we have the field trial specifications
worked out.

BUG=441377

Review URL: https://codereview.chromium.org/1010953002

Cr-Commit-Position: refs/heads/master@{#321512}

This pulls in the following Native Client changes:

4db937c: (jfb@chromium.org) Update revision for PNaCl
db53905: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
04b09f1: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
924decd: (hidehiko@chromium.org) Non-SFI mode: Enable C++11 features on gyp build.
7fe2747: (jfb@chromium.org) Overflow test: improve testing of signed values around 0
d632af2: (jfb@chromium.org) Update revision for PNaCl
cc78fa0: (sbc@chromium.org) Update sysroot creator scripts toolchain.

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/f418b37b22393d82c08d28ce1c151bed933d2c9b..cc78fa093218f9a9a5e576002e197e17da379023

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1022923004

Cr-Commit-Position: refs/heads/master@{#321511}

In commit 3576d464 the conversion of
the selected directory to an absolute path was moved from
FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread to
FilesSelected. As the latter runs on the UI thread this violated I/O
restrictions and results in a DCHECK. This was not caught by tests
because in the test environment I/O appears to be allowed on the main
thread.

This change splits the call to IsUnderNonNativeLocalPath from the
conversion to an absolute path.

BUG=457841

Review URL: https://codereview.chromium.org/1023793002

Cr-Commit-Position: refs/heads/master@{#321510}

BUG=None
TEST=None
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/1021103002

Cr-Commit-Position: refs/heads/master@{#321509}

BUG=446700

Review URL: https://codereview.chromium.org/997713004

Cr-Commit-Position: refs/heads/master@{#321508}

RenderText previously only had a SetText to alter the text.  Calling SetText would reset the text styling already setup.

It can be more efficient in some cases to preserve the existing font styling and when only adding text to the end of the RenderText.

This patch adds AppendText that allows adding to an exiting RenderText without disturbing the existing styling.

This change is related to (and used by) CL 795933009.

BUG=

Review URL: https://codereview.chromium.org/1014163002

Cr-Commit-Position: refs/heads/master@{#321507}

Required wiring up the options handler for now, but that can all go
away once settingsPrivate is ready.

BUG=

Review URL: https://codereview.chromium.org/1019403002

Cr-Commit-Position: refs/heads/master@{#321506}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d800d87..adf9990

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1021023003

Cr-Commit-Position: refs/heads/master@{#321505}

Synthetic gestures rely on a flush signal from the InputRouter to
indicate when a particular gesture has finished. Currently, this fails
to capture fling animations, as they are hosted in the renderer.

Wire up the fling end notification to the InputRouter, allowing it to
gate flush signalling based on fling animation existence. This will
allow proper execution of synthetic fling gestures with telemetry.

BUG=321141

Review URL: https://codereview.chromium.org/1003023002

Cr-Commit-Position: refs/heads/master@{#321504}

Disabled TabCaptureApiTest.CaptureInSplitIncognitoMode everywhere.
Disabled MultiProfileFileManagerBrowserTest.BasicDownloads and
CopyBetweenWindows/FileManagerBrowserTest under MSan.

TBR=mtomasz@chromium.org, miu@chromium.org
BUG=468980,468982,468608

Review URL: https://codereview.chromium.org/1027583002

Cr-Commit-Position: refs/heads/master@{#321503}

After this cl, the last remaining reference to remoting.AppMode in AppRemoting is in app_remoting.js. That will be addressed in a followup cl.

Move the following out of remoting.js and into app-specific locations:
* remoting.signOut (into crd_event_handlers.js)
* remoting.showErrorMessage (into desktop_remoting.js)
* isWindowed_ (into desktop_remoting.js)
* remoting.promptClose (into desktop_remoting.js)
* remoting.isMe2MeInstallable (into local_host_section.js)

Rename Delegate.signInFailed -> Delegate.handleAuthError
Add Application.onAuthError to call Delegate.handleAuthError

Change references to global remoting.showErrorMessage to remoting.app.onAuthError

BUG=

Review URL: https://codereview.chromium.org/1020743002

Cr-Commit-Position: refs/heads/master@{#321502}

Makes the primary buttons first in tab order.

BUG=466390

Review URL: https://codereview.chromium.org/1011283003

Cr-Commit-Position: refs/heads/master@{#321501}

BUG=451526

Review URL: https://codereview.chromium.org/1012173002

Cr-Commit-Position: refs/heads/master@{#321500}

"Verifying card" status overlay is displayed while the dialog is waiting
for card verification. Once the card has been verified "Your card is
verified" is displayed for one second and then the dialog closes.
If the card was successfully verified then the card data on the form
will be filled.

This CL is not pixel-perfect with the UI mocks. That will come in a
later CL.

No error messages are displayed on card verification failure. Coming
soon in another CL.

Video attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c11

BUG=448572

Review URL: https://codereview.chromium.org/1014683007

Cr-Commit-Position: refs/heads/master@{#321499}

by disabling the selectedAttribute as a workaround. See
https://github.com/Polymer/polymer/issues/946.

R=michaelpg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1010363003

Cr-Commit-Position: refs/heads/master@{#321498}

We use std::unique to remove duplicate entries from the fallback list.

BUG=467459

Review URL: https://codereview.chromium.org/1019743004

Cr-Commit-Position: refs/heads/master@{#321497}

This makes sure we don't break crbug.com/417479.

BUG=

Review URL: https://codereview.chromium.org/1002013003

Cr-Commit-Position: refs/heads/master@{#321496}