- 08 Mar, 2018 40 commits
-
-
Misha Efimov authored
Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ife4a40e651a08827a0dfe5c500b80a685ff29359 Reviewed-on: https://chromium-review.googlesource.com/946408Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#541782}
-
Jamie Madill authored
This reverts commit d52a1146. Reason for revert: The Vulkan roll has landed in Chrome. Original change's description: > Temporarily disable angle_vulkan_deqp_tests. > > Unblocks the Vulkan roll (issues with http://crbug.com/643346). > > Bug: angleproject:2393 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Tbr: kbr@chromium.org > No-Try: True > Change-Id: Icd41d0ba9abbbdd5a8d52e9f391716dbef674a34 > Reviewed-on: https://chromium-review.googlesource.com/951648 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541458} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: Iadbb548ed09d8a19cf2f13302c3c790dcec911eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2393 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955542Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#541781}
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ia026d7497a2a901d231973a03effad0868f547d1 Reviewed-on: https://chromium-review.googlesource.com/953742Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541780}
-
Yuki Shiino authored
Deletes |WrapPersistent| for wrapper-tracing version of callback interfaces after https://crrev.com/c/951163 . Bug: 778580 Change-Id: I16e8c19d1c01f74bc841aa3bcc1f6dacdc2563f8 Reviewed-on: https://chromium-review.googlesource.com/954864Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#541779}
-
Jochen Eisinger authored
Otherwise, we might crash flakily on windows, as we might tear down the Shell (WebContentsDelegate) before the callback to select a filename has returned. BUG=819739 R=battre@chromium.org Change-Id: I09348f556ee10a9efae738b0ee2721c23641590a Reviewed-on: https://chromium-review.googlesource.com/954944 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#541778}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Iae8c931231d6516cb64abe6386b4c3e343b9870c Reviewed-on: https://chromium-review.googlesource.com/952329Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541777}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. (GetProcAddress() returns FARPROC, a function pointer type.) Merges one line from upstream 5d0574bf6473130d25dd296ad30206ccd148590b Bug: 550065 Change-Id: I54080e807e2106ff084adc6e0f7954a72bdf467f Reviewed-on: https://chromium-review.googlesource.com/953722Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541776}
-
Ulan Degenbaev authored
This relands commit d690c638. This time the new test is marked as timeout in MSAN expectation. Original change's description: > [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot. > > Each DOM node has a corresponding JS wrapper node. In heap snapshot > they appear as duplicates. > > Example retaining path with duplicates: > - [1] in InternalNode @2041178784 > - [1] in HTMLDivElement @2041079168 // DOM node > - [3] in HTMLDivElement @2231// JS wrapper > - retainer in Window / @2105 > > The heap snapshot generator now can merge an embedder node with a node > returned by EmbedderGraph::Node::WrapperNode() function. > > This patch implements the WrapperNode() function for each DOM node. > > Bug: chromium:811925 > Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019 > Reviewed-on: https://chromium-review.googlesource.com/928503 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539132} Change-Id: I0523477d562c68512a2a92902022826df8a32820 Reviewed-on: https://chromium-review.googlesource.com/955243Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541775}
-
Chris Nardi authored
Remove already existing duplicate tests, and upstream a unified version of currently existing an + b selector parsing tests. Bug: 818475 Change-Id: Id889175e0d4df27037ee335d23020c213c148b44 Reviewed-on: https://chromium-review.googlesource.com/952078Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541774}
-
Boris Sazonov authored
This CL fixes the string resource id used for the negative button in AccountSigninView. https://crrev.com/c/880861 introduced updateConsentText() that has been unconditionally using fre_skip_text for the negative button. In reality, the text for this button should change depending on the access point used to initiate sign-in. It was the last usage of IDS_FRE_SKIP_TEXT (Java method uses IDS_NO_THANKS instead), so this CL removes it. Bug: 818590 Change-Id: I00222b3648b82918b0bf262d28acece089604f91 Reviewed-on: https://chromium-review.googlesource.com/953423Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541773}
-
Chandan Padhi authored
InputDeviceInfo extends MediaDeviceInfo and represents audio and video input devices. These objects are the result of calling MediaDevices.enumerateDevices(). This interface gives access to the capabilities of the input device it represents via getCapabilities() method which will be implemented in asubsequent CL. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78 Bug: 817769 Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3 Reviewed-on: https://chromium-review.googlesource.com/942961 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541772}
-
Fredrik Söderquist authored
This CL replaces the use of SVGElementProxy in ReferenceClipPathOperation with SVGResource. The main change between the two is when the element reference is resolved ("when used" versus "when computed".) This also, by extension, adds infrastructure for invalidation and other things required to make SVGResource work. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia43f76256a251a15c4dc100461cff9bf728eb188 Reviewed-on: https://chromium-review.googlesource.com/951613 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541771}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1666d944..16d3f07a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6343cb86d6cefa9339a456183da919f392a04bda Reviewed-on: https://chromium-review.googlesource.com/955042Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#541770}
-
Andy Paicu authored
PR: https://github.com/w3c/webappsec-csp/pull/290 Bug: 805886 Change-Id: I5bdda65c7e70e729b33a3647135fee6453e97e66 Reviewed-on: https://chromium-review.googlesource.com/934181 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#541769}
-
Christian Dullweber authored
When Chrome is restarted, tabs are initially in a frozen state and have no WebContents. History deletions need to clean up this frozen state to correctly remove navigation entries. Add integration tests for deletion of navigation entries from regular and frozen tabs. Bug: 407074 Change-Id: Id69ffcf05622f8e02eace0036e6787cea0b4dfab Reviewed-on: https://chromium-review.googlesource.com/949323 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541768}
-
Morten Stenshorne authored
Removed redundant parameter from CalculateBorderScrollbarPadding() and ConstrainColumnBlockSize(). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If828121f1ab3582d2c97d9ea1d85ca0b51ed10c9 Reviewed-on: https://chromium-review.googlesource.com/946096Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#541767}
-
Jochen Eisinger authored
Also move bauerb@ to general owners for better coverage in EMEA R=dtrainor@chromium.org,tedchoc@chromium.org,twellington@chromium.org,yusufo@chromium.org,bauerb@chromium.org Change-Id: Id3b097ef8df4f76cc5abdcbfa69fecc610d68519 Reviewed-on: https://chromium-review.googlesource.com/940128Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541766}
-
Sylvain Defresne authored
Add GetToolbarVoiceSearchButtonImages(bool) to BrandedImageProvider to allow eventually remove GetToolbarVoiceSearchButtonImageId(int*) and to allow make provider use simpler (no need to check the return value). Bug: none Change-Id: Ibd25cb14018debe6b87fdc8a4c7af3c92a21a6c5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951691 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#541765}
-
Sylvain Defresne authored
Use GetToolbarSearchButtonImage(SearchEngineIcon) overload and remove the deprecated old overload of the method (unused and downstream fixed to not override it already). Bug: none Change-Id: I5b115b5df55e7a81333903b0cc788c673e148053 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951735 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#541764}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4de0dd39. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" af1c15b1 "bluetooth: Use DeviceUUID in FakeBluetooth" 5dc0cbee "[css-typed-om] Clean up parsing tests." a9a7e883 "Move core CORB logic into //services/network." 5e638c8e "Upstream some CSSOM tests" 300cd0df "Moved XR getViewport, removed XRDevice.external" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13462 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bsittler@chromium.org, pwnall@chromium.org: external/wpt/cookie-store domenic@chromium.org, ricea@chromium.org: external/wpt/streams jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/IndexedDB external/wpt/storage jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI kpaulhamus@chromium.org: external/wpt/webauthn yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: Iaf6b4b3ef0e660eeb63f85e60b03c0a2a9237be1 Reviewed-on: https://chromium-review.googlesource.com/954924 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541763}
-
Michael Lippautz authored
Reflects the change that there marking is actually implemented in the marking visitors and the adjust traits are only used for getting the proper descriptions. Bug: chromium:802273 Change-Id: Ib5df76a4689696b766c657fc7676780c694760f0 Reviewed-on: https://chromium-review.googlesource.com/948742 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541762}
-
Harald Alvestrand authored
Bug: chromium:804275 Change-Id: Id76cce71074ddde14b7e5179d1e536d0658154a1 Reviewed-on: https://chromium-review.googlesource.com/951785 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#541761}
-
George Joseph authored
A video tag should not highlight the play button and slider thumb when preload is disabled and no source is present BUG=665149 Change-Id: I2ee71d95f7c1cf289c2e7892b30845c77bc1bd1f Reviewed-on: https://chromium-review.googlesource.com/905643 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#541760}
-
Colin Blundell authored
Cf. https://docs.google.com/document/d/1Zati5ZohwjUM0vz5qj6sWg5r-_I0iisUoSoAMNdd7C8/edit#heading=h.xo57d5v7zhrp. This CL just updates docs. Movement of existing services in //components will follow. Change-Id: I9fceb075f66eadfd9e2ceb6ae55d927affbdf8a0 Reviewed-on: https://chromium-review.googlesource.com/948851Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#541759}
-
Mohamed Amir Yosef authored
This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/951245 That renames couple of other occurrences of SharedModelTypeProcessor Change-Id: I55657cc2b0e98c8a0b7dacf2c4be97ee770f51ef Reviewed-on: https://chromium-review.googlesource.com/953542Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#541758}
-
Koji Ishii authored
Following bot results are included. 4108 4111 4112 4117 4119 4120 4122 4126 4129 2 lines were removed and 6 lines were deflaked by consecutive results since 4065. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I899bb826d5a55529cc73e698880e7cbb13461cc1 Reviewed-on: https://chromium-review.googlesource.com/952112 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#541757}
-
Kenichi Ishibashi authored
When we observe high memory usage in renderer process, |binding_| could be already bound when StartMonitoringIfNeeded() is called. Check if it is already bound in StartMonitoringIfNeeded(). Bug: 817873 Change-Id: I4c75b48471a7de839fd2a159edf5f87db89c8c1d Reviewed-on: https://chromium-review.googlesource.com/954892Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541756}
-
Ramin Halavati authored
A script is added to check network traffic annotation tests. Common parts of this script and the former annotation checker are separated as annotation_tools.py. Bug: 690323 Change-Id: If712cca4359a98549318fafe80d64b651765d800 Reviewed-on: https://chromium-review.googlesource.com/951255 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#541755}
-
https://skia.googlesource.com/skia.git/+log/df04ce29490a..fa303398d503 $ git log df04ce294..fa303398d --date=short --no-merges --format='%ad %ae %s' 2018-03-08 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2202680c6..ed8b49195 (5 commits) 2018-03-07 csmartdalton ccpr: Simplify triangle corners Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ia6de38042177eb3dce9ec853f19fd02db0ba9c67 Reviewed-on: https://chromium-review.googlesource.com/954990Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541754}
-
Hitoshi Yoshida authored
interface mixin is a new IDL feature, and has a new grammar definition. This CL updates IDL parser to accept it. https://heycam.github.io/webidl/#idl-interface-mixins Bug: 781257 Change-Id: Ibb771007c9147cf868995c80db8afc4ca43b9a74 Reviewed-on: https://chromium-review.googlesource.com/954763 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541753}
-
Mikel Astiz authored
Various unused or redundant APIs are removed trivially. Bug: 681921 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6e5b85b69a002b1037e1ee4f778f29af31af1525 Reviewed-on: https://chromium-review.googlesource.com/952922Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541752}
-
Ramin Halavati authored
Network traffic annotation is added to two requests in: components/invalidation/impl/p2p_invalidator.cc components/invalidation/impl/push_client_channel.cc Bug: 656607 Change-Id: I34b9dbc22b8d4035270f66225d2424c624bb6217 Reviewed-on: https://chromium-review.googlesource.com/926008 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#541751}
-
Eric Willigers authored
Since M60, vibrate always requires user gesture. Remove the feature flag and M59's deprecation message. BUG=704650 Change-Id: Ifd1bda521e320fb7c0e8b3378117553e18cad833 Reviewed-on: https://chromium-review.googlesource.com/892581Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#541750}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: Ibae58c9e8c7ca4f8135de38786c051e42d210d05 Reviewed-on: https://chromium-review.googlesource.com/954844 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#541749}
-
Dominic Mazzoni authored
When an Android accessibility service sends us a CLICK or FOCUS action on a specific node in a WebView, we should first focus the WebView itself. Otherwise clicking on a text field using an accessibility service doesn't actually move input focus there and pop up the virtual keyboard. Bug: 819669 Change-Id: I8e4069324e45516fbc1621723885ad8448fdc862 Reviewed-on: https://chromium-review.googlesource.com/953322Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541748}
-
Ramin Halavati authored
Local annotation is added to SpdySession::TryCreatePushStream. Bug: 656607 Change-Id: I164d9d6df34b9f38e6077c5746a04f2e53a7061d Reviewed-on: https://chromium-review.googlesource.com/951728 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#541747}
-
Xiaohan Wang authored
This reverts commit 7a87490b. Reason for revert: Crash. See crbug.com/819916 Original change's description: > Add a SubresourceLoadInfo struct to content/ > > This data type is useful for sending stats from the renderer to the > browser, in SubresourceResponseStarted methods. Currently there are six > fields that are passed around, but soon there may be more in order to > get PageLoadMetrics working with the Network Service. > > BUG=816684 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I26a62ebb5aa82f225a70fe54098433c5c3342941 > Reviewed-on: https://chromium-review.googlesource.com/947582 > Commit-Queue: Conley Owens <cco3@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541550} TBR=dcheng@chromium.org,jcivelli@chromium.org,jam@chromium.org,cco3@chromium.org Change-Id: I48effa0d5a7407dfbbaf41d5d1708a1491f31639 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816684,819916 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/954588Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541746}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I74ff926d9dd9173fc2e8abbe800700631873629a Reviewed-on: https://chromium-review.googlesource.com/954984 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541745}
-
Matt Falkenhagen authored
This has been enabled on Android since Chrome 62 by server-side field trial configuation, and since Chrome 64 by the client code. As part of the launch process for issue 733466, we received approval to enable it on all platforms after Android 62 rolled out widely, which is definitely true now. This CL still keeps the feature flag, but it should be removed completely later. Bug: 733466, 819476 Change-Id: Idcd85b1afb3e7724a1ff6a3b9cd8e1db6ec23788 Reviewed-on: https://chromium-review.googlesource.com/952955Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541744}
-
Manuel Rego Casasnovas authored
The ImeTextSpanThickness enum has 3 values: * kNone: When you don't want to paint the underline (this was done with transparent color before). * kThin: For regular ImeTextSpan. * kThick: For thick ones. With the enum the API calls are much clearer than using a boolean. BUG=554893 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I813716c08d73fc962080952c9729d3167fc12c0e Reviewed-on: https://chromium-review.googlesource.com/919494Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#541743}
-