GitLab

It's been said before and will be said again: keyboard event handling in
Chrome is a monster. Several things came together to make this happen:

First, in most Mac apps, cmd+w closes the dictionary popover if it's
visible. This specifically happens through the `performClose:` action
sent by the main menu. But, in Chrome, cmd+w closes the tab and not the
window, so cmd+w sends a different action. This meant that cmd+w
originally closed the tab and left the dictionary popover floating. This
was fixed many years ago (see r118131 and r322075) by making
`-[AppController menuNeedsUpdate:]` check the current target of
`performClose:` and only map cmd+w to "close tab" when the target is a
browser window.

This would work but for another layer of keyboard shortcut handling
trickery. For a number of reasons (see comment beginning "If this
keyEquivalent" added in r565490), Chrome doesn't actually let
`NSMenuItem`s send their own actions. Instead,
ChromeCommandDispatcherDelegate determines which menu item *would* have
been targeted by a given event, then handles the event itself.

The end result is that, when the dictionary popover is visible, the menu
items are successfully remapped so that cmd+w means "Close Window". But,
any actual cmd+w event is grabbed by ChromeCommandDispatcherDelegate and
sent directly to Chrome's own keyboard shortcut handling… so the browser
window closes.

This change adds a check that was proposed back in r322075, and makes
ChromeCommandDispatcherDelegate only grab the event when the found menu
item's action would be sent to its own window.

Bug: 947752
Change-Id: Ib32988d5fb69c79f899069feb02f7529ea05225f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849431
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705275}

This makes it so various inputs (e.g. file input, submit button) have
the correct labels.

Change-Id: I5d49dc5d2d71a92fedfd0a6748ad142454e0e55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856845Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705274}

After feedback from leberly@ that the significance of the dashed focus
rings used by Switch Access is unclear, we are changing that behavior.

Per a discussion with lpalmaro@ and jasonwan@, the new behavior is to
show a dashed focus ring around the "next" focus when selecting the
element has a primary effect of changing the focus (i.e. selecting the
back button or entering a group), and no dashed ring otherwise.

The previous behavior was to always show the dashed ring as the current
group's location.

Bug: 996392
Change-Id: I5f13df27f7a57818cd0cca9f118fe46581009071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848352
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705273}

If FidoCableDiscovery was only provided with v2 pairing information then
it wouldn't send any advertisements, but also wouldn't signal that it
was ready.

BUG=1002262

Change-Id: I0e15d0017ec97891316c0fe1ea83761384676e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857298Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705272}

Bug: None
Change-Id: I6110495e02aca81c2f9fead9037fcc1be0352255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855219Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705271}

Realized it was easier to read this in reverse that what was
happening previously. Probably just as a result of it being moved
away from NGPaintFragment at some point.

Change-Id: I0bc29a0b6868c8c47a69bfdc82cbc8a8c9017eab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856723
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705270}

Replace the std::unique_ptr<base::Value> parameter to base::Value.

Bug: 1012811
Change-Id: Id63d78a0ce54a381822b911ce67caf5afe38b3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848857Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705269}

This cl reads supported delegations of an installable payment app from
its web app manifest for just in time installation. With this change an
installable payment app can specify whether or not they will provide
shipping address and/or payer's contact information in their app manifest.

Change-Id: I278bf5484bb52f5f02e3d66193e6f705b5313ab3
Bug: 984694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834421Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705268}

One of the shards times out when running w/ just 2 shards.

Bug: 1011494
Change-Id: Ie1764870e928373e0fee97db957ebc60cc501019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856844
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705267}

Using wpt-import in Chromium c3fdfcff.
With Chromium commits locally applied on WPT:
23748e60 "Change text directive to text="
2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests."
d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests."
6386d9d8 "Update service_worker_unregister_and_register()"
1644eff7 "Update scroll to text feature detectability API"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mlamouri@chromium.org:
  external/wpt/mediasession

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I36aa5e20ad2e4f6e9d89043096273da706ccf2e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855381Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705266}

Also removed ShellObserver from LockLayoutManager

Bug: 833348
Change-Id: Ic4e899145eb7751ff5c089193e7733017383ff03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855939Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705265}

This CL is based on
https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3

It is the fourth patch of splitting the bigger one
https://chromium-review.googlesource.com/c/chromium/src/+/1797069

It also unifies the record of the 'Android.OmniboxFocusReason' metrics.

Screenshot:
https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing

Bug: 982018, 1012275
Change-Id: I16d045777164d49d72356af474e5c186c8318370
Binary-Size: crbug.com/998206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705264}

Chrome's translation system only supports translating no (Norwegian),
not nb (Norwegian Bokmal). To alias the language codes, there's a map in
language_util.cc that converts between the UI language and the
translation language. This works fine for Filipino, where there is a
1-to-1 mapping between UI language code to translate code.

However, Chrome technically supports both variations of Norwegian as UI
languages. When trying to add no, the mapping kicks in and instead adds
nb to the language list.

Rather than mapping both ways, we should map nb to no for translate, but
retain no for the UI language.

Test: Open chrome://settings/languages, and attempt to add Norwegian to
the languages list. You should see Norwegian listed - without this fix,
Norwegian Bokmal is added instead.

Bug: 842126
Change-Id: Ib564602e52a70589a5e0fa6a7a4aac813f9207e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834577Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Justin Gallagher <jugallag@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705263}

::GetThreadPriority() sometimes returns -3 or -6 on bots.

-3
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8900924268806719008/+/steps/base_unittests/0/logs/PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess/0

-6
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8900658140238913376/+/steps/browser_tests__with_patch__on_Windows-10-15063/0/logs/Flaky_failure:_BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalSmallerThanActualSize__status_FAILURE_SUCCESS_/0

Handling these values is a prerequisite to enable
THREAD_MODE_BACKGROUND_* by default.

Bug: 931720, 919466
Change-Id: Ib109a06bf95907a2988427158ea233b8395bf1f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829570
Commit-Queue: François Doray <fdoray@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705262}

QR codes for caBLE v2 pairing are only valid for a limited time period.
Some devices cannot scan and advertise within a two-second window thus
this change increases the window to four seconds. It also includes
extra debugging to help identify if this increase is insufficient.

BUG=1002262

Change-Id: I0f201a08fd6ac5003411472a51831c9b90beb0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856683
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#705261}

This switches Network Service to a simpler service model which does not
involve the Service Manager. Instead, the browser directly controls a
singleton Network Service process or in-process instance.

This should not change existing Network Service lifetime or behavior; it
only gives the browser direct control of process lifetime instead of
relying on the Service Manager to do that work.

Bug: 977637
Change-Id: I626ec8bec935e02f7c0d66a3c379a5fc0c547a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673442
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705260}

https://chromium.googlesource.com/angle/angle.git/+log/741c0aa6f5a1..bbf0ce28f06a

git log 741c0aa6f5a1..bbf0ce28f06a --date=short --no-merges --format='%ad %ae %s'
2019-10-11 tobine@google.com Vulkan:Add support to stage D or S textures

Created with:
  gclient setdep -r src/third_party/angle@bbf0ce28f06a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: If3d70582f2101a4b2c94cf5676e1f1f5460050b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705259}

This feature has already been removed from the code base.

Bug: 73098
Change-Id: Ic6b5fc5660000f75a5f8bb474af1e5ba760bc6fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853948Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705258}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4d4275fc6a5d..ec08b81b4fde

git log 4d4275fc6a5d..ec08b81b4fde --date=short --no-merges --format='%ad %ae %s'
2019-10-11 manojgupta@google.com cros_fuzz: Install 'virtual/implicit-system'

Created with:
  gclient setdep -r src/third_party/chromite@ec08b81b4fde

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Idbfce4859639091fd955d9521325810c5f270c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857198Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705257}

Bug: 985589
Change-Id: Iab4c0a05ddaac3f26f4fa39b88efca55072bd5f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846321Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#705256}

The code tries to avoid logging caBLE devices multiple times by
recording already-logged information. This works when the device
advertises a constant set of UUIDs but |emplace| doesn't overwrite
existing elements in a map so fails when the device changes its
configuration.

This change fixes that.

Change-Id: I15788f54c62d4ae5e0d0cd98563c41cc66be7077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856682
Commit-Queue: Adam Langley <agl@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#705255}

Per Xcode release notes, setting FramebufferServerRendererPolicy to 'none'
will allow CoreSimulator to skip compositing operations in the virtual
frame buffer.  This may improve test performance.

To avoid any unexpected complications, first delete this value before and
after each test run.  In a followup CL, this value can be set to 'none'
without potentially breaking other bots.

Bug: 989674
Change-Id: I90319a86364ee727bc751cb27ac9404f989deb69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854266Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705254}

Overlay resizer can be displayed when there are no scrollbars or the existing
scrollbars are an overlay.

We can't paint it in background phase because it can be obscured by the content
of the resizable container or a positive child paint layer.

With this change, overlay resizer will be painted(like overlay scrollbars) in
kOverlayOverflowControls(renamed from kOverlayScrollbars) phase.

In the follow up CLs, some clean up will be made to:
1. The logic that can use the new added function: HasNonOverlayOverflowControls.
2. Namings of the variable or method related to the original kOverlayScrollbars
   paint phase.

This is 1/3 of a series of patches:
  1. This patch.
  2. https://crrev.com/c/1817874
  3. https://crrev.com/c/1831917

Bug: 1006173
Change-Id: I5cb295d539b925ac1a6d7299798ccfcf4a59abf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816486
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705253}

The test sporadically fails on the bot. Also rename the test name from
"All" to "Drawer" to avoid potential confusion with other tests.

Bug: 1013656
Change-Id: Ie6314b8c039f7e58796ad36a7f930729ffdb31f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856721
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705252}

This was broken by recent refactor:
e7e326d5

Change-Id: I4603d1163acad3b7a4340a0330a79fcc71f1a31e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856842
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705251}

https://pdfium.googlesource.com/pdfium.git/+log/9fa72471b87d..1f088ab877cb

git log 9fa72471b87d..1f088ab877cb --date=short --no-merges --format='%ad %ae %s'
2019-10-11 thestig@chromium.org Avoid an assertion failure in CPDF_DIBBase::StartLoadMask().
2019-10-10 thestig@chromium.org Simplify MonthFromTime().

Created with:
  gclient setdep -r src/third_party/pdfium@1f088ab877cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:1013066
Change-Id: I7a10f6292c4bd378f59bdd190fd82593c4dfcd5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705250}

Change-Id: Ie245e371cabeaba50213e92b9d4d54c65c072412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856361Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#705249}

I'm the only person in the list, and given that I'm not actively working
on apps APIs, it's probably not worth having me as an owner for all api
implementations any longer. (Lately, I've been just redirecting all review
requests).

Change-Id: Ib3f09a12ae2cfde6004e657368229fb2be662165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856840
Auto-Submit: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705248}

Change-Id: Iccb810706ba94f91e0da42c259c917bf95d444a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856630Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#705247}

This reverts commit 68ddeefb.

Reason for revert: crbug.com/901501 has been merged to crbug.com/986211, which is fixed.

Original change's description:
> Add instrumentation to investigate a possible UAF.
>
> Bug: 901501
> Change-Id: Ic778c96c1bb10a9f4bb2f8f3efd883e452bc9742
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606770
> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
> Commit-Queue: Ryan Hamilton <rch@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658861}

TBR=rch@chromium.org,zhongyi@chromium.org

Bug: 901501
Change-Id: I84096ef16edfd37210a7c02f4c1c523dd5d76c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856724Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705246}

This CL introduces a fuzzer for the ELF disassemblers in Zucchini. I
have already uploaded some corpus files to the clusterfuzz-corpus
Google Storage bucket.

Achieves ~700 exec/s locally. This is on-par with the DEX and Win32
disassemblers as it requires a largish representative file to serve
as a test. (Recommendation is ~1000 exec/s).

Brings up coverage of ELF related code from 0-30% to 80-100%

I expect this will find quite a few crashes early on but should
stabilize within a couple of weeks; est. 1-2 bugfixes per day
based on how DEX and Win32 went. Mostly checked_casts and bounds
issues.

Bug: 1013641
Change-Id: I205135547cad2a95e59f99d7f040c13d72c45b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856624
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705245}

This updates the tab freezing entry in chrome://flags to facilitate
testing the two configs that are candidate to ship in M79.

Bug: 980533
Change-Id: I1b5b671b90b8f76b03d842750673e504b894d279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856801
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705244}

Add a browser test for the logic that triggers the system slot
initialization whenever the TPM goes into the "ready" state as
notified by cryptohomed (added in r698007).

The test exercises the following codepath (this description
skips some intermediate callers for the sake of brevity):
1. SystemTokenCertDBInitializer is notified by the
   chromeos::[Fake]CryptohomeClient that TpmInitStatusUpdated
   with |ready|==true;
2. chromeos::TPMTokenLoader::EnsureStarted() gets called;
3. crypto::InitializeTPMTokenAndSystemSlot() gets called.

This is verified by the test by opening a web page in the
Chrome OS Login screen that uses client cert authentication.
If the codepath mentioned above wouldn't work, the test would
fail due to ClientCertFilterChromeOS waiting infinitely for
the result from crypto::GetSystemNSSKeySlot().

Bug: 725500
Change-Id: I17e0fa42d3fda7d0deed5f86a2ab99b079865b36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815857
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705243}

A previous change added error handling for when prefs serialization
fails.  The check call will result in a crash so I am updating the
comment above it to reflect that and remove the unreachable code
below it.

Change-Id: If16aff75e100c3a92e27344203ccad6d292caf5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856878
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705242}

https://android.googlesource.com/platform/external/perfetto.git/+log/dbcebd185da3..666b243afa28

git log dbcebd185da3..666b243afa28 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 treehugger-gerrit@google.com Merge "processor: Add a DLOG for unexpected metadata to json export"
2019-10-11 treehugger-gerrit@google.com Merge "Correctly handle multiple mappings for symbols"
2019-10-11 treehugger-gerrit@google.com Merge "ELOG in Client API OnDisconnect."

Created with:
  gclient setdep -r src/third_party/perfetto@666b243afa28

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I8c86e09a633079709ddb73ff2fda16604c218080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856588Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705241}

The WidgetInputHandlerImpl always checks that the RenderWidget is not
undead before calling into it, so these methods always have a WebWidget
present. The context menu method is an IPC handler which is only
received when not undead or provisional, so it always has a WebWidget
present.

SimulateImeFinishComposingText() is never called.

ImeCommitTextOnMainThread() is called from RunOnMainThread() which
only executes the callback when the RenderWidget is not undead, so
a WebWidget is always present.

R=avi@chromium.org

Bug: 419087
Change-Id: I1b29030638f9e31f6c5646c5e6894f07a1e9b860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856718Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705240}

- The entire favicon container, including the loading spinners, should be
hidden when TabRendererData has show_icon set to false (ex: New Tab Page).
- The favicon itself should be hidden whenever a tab is still waiting.
- The favicon itself should be hidden whenever a tab is still loading
and the favicon is the default favicon (the globe icon).

This is an effort to mimic the behavior of the existing tab strip.

Bug: 1004985
Change-Id: Ide7f2daa2c72bfed2a072c40ea1eac00f894ab31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853848
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705239}

This will record if USB devices are attached before sign-in, after sign-in,
or at the lock screen, along with the device class.

Bug: 1011122
Change-Id: I83ad38b3d1fcb8e805de4014e81dda8c603d2d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838526Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Allen Webb <allenwebb@google.com>
Cr-Commit-Position: refs/heads/master@{#705238}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d99c8fdb68b..0912f5e649f3


Created with:
  gclient setdep -r src-internal@0912f5e649f3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I4ce7df6ed436e56168c4797dd71a7f8a5ac882eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856589Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705237}

Whatever comes before the start of the column (due to negative margins)
shouldn't affect the block-size of balanced columns, since it won't
take up any space in them.

This fixes two tests, although that means that they'll now crash, :-P
because of incomplete fragment painting support. When loaded manually,
the tests pass, but when run by the test runner, they crash, presumably
due to differences in how the layout tree is treated after the page has
loaded and displayed, or because we're using a different allocator?
There's a pointer to a dead object in there; see crbug.com/994172

Bug: 829028
Change-Id: Ida3a5269f93672e01c3a7572fc919af0b8fede84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855739Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705236}